@sun-asterisk/sungen 2.1.1 → 2.2.1

package/src/generators/test-generator/code-generator.ts

@@ -179,6 +179,24 @@ export class CodeGenerator {
     fs.writeFileSync(generatedTest.filePath, generatedTest.code, 'utf-8');
   }
 
+  /**
+   * Ensure specs/base.ts exists in the output directory
+   */
+  ensureBaseFile(outputDir: string): void {
+    const basePath = path.join(outputDir, 'base.ts');
+    if (fs.existsSync(basePath)) return;
+
+    const templatePath = path.join(__dirname, '..', '..', '..', 'orchestrator', 'templates', 'specs-base.ts');
+    if (fs.existsSync(templatePath)) {
+      const baseDir = path.dirname(basePath);
+      if (!fs.existsSync(baseDir)) {
+        fs.mkdirSync(baseDir, { recursive: true });
+      }
+      fs.copyFileSync(templatePath, basePath);
+      console.log('✓ Created: specs/base.ts');
+    }
+  }
+
   private async generateTestCode(feature: ParsedFeature): Promise<string> {
     // Extract feature name from source file if available, otherwise derive from feature name
     let featureName: string;
@@ -415,6 +433,9 @@ export class CodeGenerator {
     const { GherkinParser } = require('../gherkin-parser');
     const parser = new GherkinParser();
 
+    // Ensure specs/base.ts exists
+    this.ensureBaseFile(outputDir);
+
     // Parse all features first
     const features: ParsedFeature[] = [];
     const parseErrors: Array<{ file: string; error: any }> = [];

package/src/generators/test-generator/patterns/navigation-patterns.ts

@@ -9,7 +9,7 @@ export const navigationPatterns: StepPattern[] = [
   {
     name: 'open-page-type',
     matcher: (step: ParsedStep) =>
-      (step.text.includes('open') || step.text.includes('opens') || step.text.includes('is on')) &&
+      (step.text.includes('open') || step.text.includes('opens') || step.text.includes('is on') || step.text.includes('navigate to')) &&
       step.elementType === 'page',
     resolver: (step, context) => {
       let path = context.featurePath || '/';
@@ -64,7 +64,7 @@ export const navigationPatterns: StepPattern[] = [
   {
     name: 'navigate-to-route',
     matcher: (step: ParsedStep) =>
-      (step.text.includes('navigates to') || step.text.includes('is on')) &&
+      (step.text.includes('navigate to') || step.text.includes('navigates to') || step.text.includes('is on')) &&
       !!(step.selectorRef || step.dataRef),
     resolver: (step, context) => {
       const route = step.selectorRef || step.dataRef;

package/src/generators/test-generator/utils/selector-resolver.ts

@@ -3,191 +3,6 @@ import * as path from 'path';
 import yaml from 'yaml';
 import { readYaml, readYamlIfExists } from '../../../utils/yaml-io';
 
-/**
- * Remove Vietnamese diacritics (accents) from text
- * Example: "Thời gian" → "Thoi gian", "Địa điểm" → "Dia diem"
- */
-function removeVietnameseTones(text: string): string {
-  const vietnameseTones: { [key: string]: string } = {
-    'à': 'a', 'á': 'a', 'ả': 'a', 'ã': 'a', 'ạ': 'a',
-    'ă': 'a', 'ằ': 'a', 'ắ': 'a', 'ẳ': 'a', 'ẵ': 'a', 'ặ': 'a',
-    'â': 'a', 'ầ': 'a', 'ấ': 'a', 'ẩ': 'a', 'ẫ': 'a', 'ậ': 'a',
-    'đ': 'd',
-    'è': 'e', 'é': 'e', 'ẻ': 'e', 'ẽ': 'e', 'ẹ': 'e',
-    'ê': 'e', 'ề': 'e', 'ế': 'e', 'ể': 'e', 'ễ': 'e', 'ệ': 'e',
-    'ì': 'i', 'í': 'i', 'ỉ': 'i', 'ĩ': 'i', 'ị': 'i',
-    'ò': 'o', 'ó': 'o', 'ỏ': 'o', 'õ': 'o', 'ọ': 'o',
-    'ô': 'o', 'ồ': 'o', 'ố': 'o', 'ổ': 'o', 'ỗ': 'o', 'ộ': 'o',
-    'ơ': 'o', 'ờ': 'o', 'ớ': 'o', 'ở': 'o', 'ỡ': 'o', 'ợ': 'o',
-    'ù': 'u', 'ú': 'u', 'ủ': 'u', 'ũ': 'u', 'ụ': 'u',
-    'ư': 'u', 'ừ': 'u', 'ứ': 'u', 'ử': 'u', 'ữ': 'u', 'ự': 'u',
-    'ỳ': 'y', 'ý': 'y', 'ỷ': 'y', 'ỹ': 'y', 'ỵ': 'y',
-    // Uppercase
-    'À': 'A', 'Á': 'A', 'Ả': 'A', 'Ã': 'A', 'Ạ': 'A',
-    'Ă': 'A', 'Ằ': 'A', 'Ắ': 'A', 'Ẳ': 'A', 'Ẵ': 'A', 'Ặ': 'A',
-    'Â': 'A', 'Ầ': 'A', 'Ấ': 'A', 'Ẩ': 'A', 'Ẫ': 'A', 'Ậ': 'A',
-    'Đ': 'D',
-    'È': 'E', 'É': 'E', 'Ẻ': 'E', 'Ẽ': 'E', 'Ẹ': 'E',
-    'Ê': 'E', 'Ề': 'E', 'Ế': 'E', 'Ể': 'E', 'Ễ': 'E', 'Ệ': 'E',
-    'Ì': 'I', 'Í': 'I', 'Ỉ': 'I', 'Ĩ': 'I', 'Ị': 'I',
-    'Ò': 'O', 'Ó': 'O', 'Ỏ': 'O', 'Õ': 'O', 'Ọ': 'O',
-    'Ô': 'O', 'Ồ': 'O', 'Ố': 'O', 'Ổ': 'O', 'Ỗ': 'O', 'Ộ': 'O',
-    'Ơ': 'O', 'Ờ': 'O', 'Ớ': 'O', 'Ở': 'O', 'Ỡ': 'O', 'Ợ': 'O',
-    'Ù': 'U', 'Ú': 'U', 'Ủ': 'U', 'Ũ': 'U', 'Ụ': 'U',
-    'Ư': 'U', 'Ừ': 'U', 'Ứ': 'U', 'Ử': 'U', 'Ữ': 'U', 'Ự': 'U',
-    'Ỳ': 'Y', 'Ý': 'Y', 'Ỷ': 'Y', 'Ỹ': 'Y', 'Ỵ': 'Y',
-  };
-
-  return text.split('').map(char => vietnameseTones[char] || char).join('');
-}
-
-/**
- * Convert Japanese Hiragana and Katakana to Romaji
- * Example: "ひらがな" → "hiragana", "カタカナ" → "katakana"
- */
-function convertJapaneseToRomaji(text: string): string {
-  // Hiragana to Romaji mapping
-  const hiraganaMap: { [key: string]: string } = {
-    // Basic vowels
-    'あ': 'a', 'い': 'i', 'う': 'u', 'え': 'e', 'お': 'o',
-    // K-row
-    'か': 'ka', 'き': 'ki', 'く': 'ku', 'け': 'ke', 'こ': 'ko',
-    'きゃ': 'kya', 'きゅ': 'kyu', 'きょ': 'kyo',
-    // G-row
-    'が': 'ga', 'ぎ': 'gi', 'ぐ': 'gu', 'げ': 'ge', 'ご': 'go',
-    'ぎゃ': 'gya', 'ぎゅ': 'gyu', 'ぎょ': 'gyo',
-    // S-row
-    'さ': 'sa', 'し': 'shi', 'す': 'su', 'せ': 'se', 'そ': 'so',
-    'しゃ': 'sha', 'しゅ': 'shu', 'しょ': 'sho',
-    // Z-row
-    'ざ': 'za', 'じ': 'ji', 'ず': 'zu', 'ぜ': 'ze', 'ぞ': 'zo',
-    'じゃ': 'ja', 'じゅ': 'ju', 'じょ': 'jo',
-    // T-row
-    'た': 'ta', 'ち': 'chi', 'つ': 'tsu', 'て': 'te', 'と': 'to',
-    'ちゃ': 'cha', 'ちゅ': 'chu', 'ちょ': 'cho',
-    // D-row
-    'だ': 'da', 'ぢ': 'ji', 'づ': 'zu', 'で': 'de', 'ど': 'do',
-    // N-row
-    'な': 'na', 'に': 'ni', 'ぬ': 'nu', 'ね': 'ne', 'の': 'no',
-    'にゃ': 'nya', 'にゅ': 'nyu', 'にょ': 'nyo',
-    // H-row
-    'は': 'ha', 'ひ': 'hi', 'ふ': 'fu', 'へ': 'he', 'ほ': 'ho',
-    'ひゃ': 'hya', 'ひゅ': 'hyu', 'ひょ': 'hyo',
-    // B-row
-    'ば': 'ba', 'び': 'bi', 'ぶ': 'bu', 'べ': 'be', 'ぼ': 'bo',
-    'びゃ': 'bya', 'びゅ': 'byu', 'びょ': 'byo',
-    // P-row
-    'ぱ': 'pa', 'ぴ': 'pi', 'ぷ': 'pu', 'ぺ': 'pe', 'ぽ': 'po',
-    'ぴゃ': 'pya', 'ぴゅ': 'pyu', 'ぴょ': 'pyo',
-    // M-row
-    'ま': 'ma', 'み': 'mi', 'む': 'mu', 'め': 'me', 'も': 'mo',
-    'みゃ': 'mya', 'みゅ': 'myu', 'みょ': 'myo',
-    // Y-row
-    'や': 'ya', 'ゆ': 'yu', 'よ': 'yo',
-    // R-row
-    'ら': 'ra', 'り': 'ri', 'る': 'ru', 'れ': 're', 'ろ': 'ro',
-    'りゃ': 'rya', 'りゅ': 'ryu', 'りょ': 'ryo',
-    // W-row
-    'わ': 'wa', 'ゐ': 'wi', 'ゑ': 'we', 'を': 'wo', 'ん': 'n',
-    // Small tsu (doubles next consonant)
-    'っ': '',
-  };
-
-  // Katakana to Romaji mapping
-  const katakanaMap: { [key: string]: string } = {
-    // Basic vowels
-    'ア': 'a', 'イ': 'i', 'ウ': 'u', 'エ': 'e', 'オ': 'o',
-    // K-row
-    'カ': 'ka', 'キ': 'ki', 'ク': 'ku', 'ケ': 'ke', 'コ': 'ko',
-    'キャ': 'kya', 'キュ': 'kyu', 'キョ': 'kyo',
-    // G-row
-    'ガ': 'ga', 'ギ': 'gi', 'グ': 'gu', 'ゲ': 'ge', 'ゴ': 'go',
-    'ギャ': 'gya', 'ギュ': 'gyu', 'ギョ': 'gyo',
-    // S-row
-    'サ': 'sa', 'シ': 'shi', 'ス': 'su', 'セ': 'se', 'ソ': 'so',
-    'シャ': 'sha', 'シュ': 'shu', 'ショ': 'sho',
-    // Z-row
-    'ザ': 'za', 'ジ': 'ji', 'ズ': 'zu', 'ゼ': 'ze', 'ゾ': 'zo',
-    'ジャ': 'ja', 'ジュ': 'ju', 'ジョ': 'jo',
-    // T-row
-    'タ': 'ta', 'チ': 'chi', 'ツ': 'tsu', 'テ': 'te', 'ト': 'to',
-    'チャ': 'cha', 'チュ': 'chu', 'チョ': 'cho',
-    // D-row
-    'ダ': 'da', 'ヂ': 'ji', 'ヅ': 'zu', 'デ': 'de', 'ド': 'do',
-    // N-row
-    'ナ': 'na', 'ニ': 'ni', 'ヌ': 'nu', 'ネ': 'ne', 'ノ': 'no',
-    'ニャ': 'nya', 'ニュ': 'nyu', 'ニョ': 'nyo',
-    // H-row
-    'ハ': 'ha', 'ヒ': 'hi', 'フ': 'fu', 'ヘ': 'he', 'ホ': 'ho',
-    'ヒャ': 'hya', 'ヒュ': 'hyu', 'ヒョ': 'hyo',
-    // B-row
-    'バ': 'ba', 'ビ': 'bi', 'ブ': 'bu', 'ベ': 'be', 'ボ': 'bo',
-    'ビャ': 'bya', 'ビュ': 'byu', 'ビョ': 'byo',
-    // P-row
-    'パ': 'pa', 'ピ': 'pi', 'プ': 'pu', 'ペ': 'pe', 'ポ': 'po',
-    'ピャ': 'pya', 'ピュ': 'pyu', 'ピョ': 'pyo',
-    // M-row
-    'マ': 'ma', 'ミ': 'mi', 'ム': 'mu', 'メ': 'me', 'モ': 'mo',
-    'ミャ': 'mya', 'ミュ': 'myu', 'ミョ': 'myo',
-    // Y-row
-    'ヤ': 'ya', 'ユ': 'yu', 'ヨ': 'yo',
-    // R-row
-    'ラ': 'ra', 'リ': 'ri', 'ル': 'ru', 'レ': 're', 'ロ': 'ro',
-    'リャ': 'rya', 'リュ': 'ryu', 'リョ': 'ryo',
-    // W-row
-    'ワ': 'wa', 'ヰ': 'wi', 'ヱ': 'we', 'ヲ': 'wo', 'ン': 'n',
-    // Small tsu (doubles next consonant)
-    'ッ': '',
-    // Extended katakana for foreign words
-    'ヴ': 'vu',
-    'ファ': 'fa', 'フィ': 'fi', 'フェ': 'fe', 'フォ': 'fo',
-    'ウィ': 'wi', 'ウェ': 'we', 'ウォ': 'wo',
-    'ティ': 'ti', 'ディ': 'di',
-    'トゥ': 'tu', 'ドゥ': 'du',
-  };
-
-  const allMaps = { ...hiraganaMap, ...katakanaMap };
-
-  let result = '';
-  let i = 0;
-
-  while (i < text.length) {
-    // Try to match 2-character combinations first (like きゃ, シャ)
-    if (i < text.length - 1) {
-      const twoChar = text.substring(i, i + 2);
-      if (allMaps[twoChar]) {
-        result += allMaps[twoChar];
-        i += 2;
-        continue;
-      }
-    }
-
-    // Then try single character
-    const oneChar = text[i];
-    if (allMaps[oneChar]) {
-      // Handle small tsu (っ/ッ) - double next consonant
-      if (oneChar === 'っ' || oneChar === 'ッ') {
-        if (i < text.length - 1) {
-          const nextChar = text[i + 1];
-          const nextRomaji = allMaps[nextChar];
-          if (nextRomaji && nextRomaji.length > 0) {
-            result += nextRomaji[0]; // Add first letter of next romaji
-          }
-        }
-      } else {
-        result += allMaps[oneChar];
-      }
-      i++;
-    } else {
-      // Not Japanese character, keep as is
-      result += oneChar;
-      i++;
-    }
-  }
-
-  return result;
-}
-
 import { SelectorType } from '../../../utils/selector-types';
 
 // Structured selector format v2
@@ -288,23 +103,31 @@ export class SelectorResolver {
   }
 
   /**
-   * Generate selector key from natural language label
-   * "Email Address" → "email.address"
-   * "Submit Button" → "submit.button"
-   * "User's Profile" → "users.profile"
-   * "Thời gian" → "thoi.gian"
-   * "Địa điểm" → "dia.diem"
-   * "ログイン" → "roguin"
-   * "パスワード" → "pasuwaado"
+   * Generate selector key from natural language label using Unicode NFC normalization.
+   * Preserves all Unicode characters (Vietnamese, Japanese, etc.) as-is.
+   *
+   * "Email Address"  → "email address"
+   * "Submit Button"  → "submit button"
+   * "User's Profile" → "user's profile"
+   * "Giới thiệu"    → "giới thiệu"
+   * "Thời gian"      → "thời gian"
+   * "ログイン"        → "ログイン"
+   * "書類一覧"        → "書類一覧"
    */
   static generateKey(label: string): string {
-    return convertJapaneseToRomaji(removeVietnameseTones(label))  // Convert Japanese and Vietnamese first
-      .toLowerCase()
-      .replace(/['\u2019]s/g, 's')     // Apostrophe s to just s ("User's" → "users")
-      .replace(/['\u2019]/g, '')        // Remove remaining apostrophes
-      .replace(/[^a-z0-9\s]/g, '')     // Remove special chars except spaces
-      .trim()
-      .replace(/\s+/g, '.');            // Spaces to dots
+    return label.normalize('NFC').toLowerCase().trim().replace(/\s+/g, ' ');
+  }
+
+  /**
+   * Normalize all keys in a SelectorFile through generateKey()
+   * so that YAML keys are case-insensitive and Unicode-normalized on lookup.
+   */
+  private static normalizeKeys(file: SelectorFile): SelectorFile {
+    const normalized: SelectorFile = {};
+    for (const [key, value] of Object.entries(file)) {
+      normalized[SelectorResolver.generateKey(key)] = value;
+    }
+    return normalized;
   }
 
   /**
@@ -742,7 +565,7 @@ export class SelectorResolver {
       if (basePath) {
         const baseSelectors = readYamlIfExists<SelectorFile>(basePath);
         if (baseSelectors) {
-          Object.assign(selectors, baseSelectors);
+          Object.assign(selectors, SelectorResolver.normalizeKeys(baseSelectors));
         }
       }
 
@@ -751,7 +574,7 @@ export class SelectorResolver {
       if (baseOverridePath) {
         const overrideSelectors = readYamlIfExists<SelectorFile>(baseOverridePath);
         if (overrideSelectors) {
-          Object.assign(selectors, overrideSelectors);
+          Object.assign(selectors, SelectorResolver.normalizeKeys(overrideSelectors));
         }
       }
     }
@@ -769,7 +592,7 @@ export class SelectorResolver {
     } else {
       const featureSelectors = readYamlIfExists<SelectorFile>(featurePath);
       if (featureSelectors) {
-        Object.assign(selectors, featureSelectors);
+        Object.assign(selectors, SelectorResolver.normalizeKeys(featureSelectors));
       }
     }
 
@@ -778,7 +601,7 @@ export class SelectorResolver {
     if (featureOverridePath) {
       const overrideSelectors = readYamlIfExists<SelectorFile>(featureOverridePath);
       if (overrideSelectors) {
-        Object.assign(selectors, overrideSelectors);
+        Object.assign(selectors, SelectorResolver.normalizeKeys(overrideSelectors));
       }
     }
 

package/src/orchestrator/project-initializer.ts

@@ -44,6 +44,9 @@ export class ProjectInitializer {
     // Create playwright config if doesn't exist
     this.createPlaywrightConfig();
 
+    // Create specs/base.ts for shared context
+    this.createSpecsBase();
+
     // Create/update .gitignore
     this.updateGitignore();
 
@@ -53,6 +56,9 @@ export class ProjectInitializer {
     // Create AI rules files
     this.createAIRules();
 
+    // Create VS Code settings for Copilot auto-attach
+    this.createVSCodeSettings();
+
     // Display summary
     this.displaySummary(normalizedProjectName);
   }
@@ -159,6 +165,54 @@ export class ProjectInitializer {
     this.createdItems.push('README.md');
   }
 
+  /**
+   * Create VS Code settings for Copilot auto-attach
+   */
+  private createVSCodeSettings(): void {
+    const settingsPath = path.join(this.cwd, '.vscode', 'settings.json');
+
+    if (fs.existsSync(settingsPath)) {
+      this.skippedItems.push('.vscode/settings.json');
+      return;
+    }
+
+    const settingsDir = path.dirname(settingsPath);
+    if (!fs.existsSync(settingsDir)) {
+      fs.mkdirSync(settingsDir, { recursive: true });
+    }
+
+    const settings = {
+      'github.copilot.chat.agent.runTasks': true,
+      'chat.tools.terminal.autoApprove': {
+        sungen: true,
+        'npx playwright': true,
+      },
+    };
+
+    fs.writeFileSync(settingsPath, JSON.stringify(settings, null, 2) + '\n', 'utf-8');
+    this.createdItems.push('.vscode/settings.json');
+
+    // Create MCP config for Playwright browser tools
+    const mcpPath = path.join(this.cwd, '.vscode', 'mcp.json');
+
+    if (fs.existsSync(mcpPath)) {
+      this.skippedItems.push('.vscode/mcp.json');
+      return;
+    }
+
+    const mcpConfig = {
+      servers: {
+        playwright: {
+          command: 'npx',
+          args: ['@playwright/mcp@latest'],
+        },
+      },
+    };
+
+    fs.writeFileSync(mcpPath, JSON.stringify(mcpConfig, null, 2) + '\n', 'utf-8');
+    this.createdItems.push('.vscode/mcp.json');
+  }
+
   /**
    * Display initialization summary
    */
@@ -216,11 +270,15 @@ export class ProjectInitializer {
       ['claude-skill-gherkin-syntax.md', '.claude/skills/sungen-gherkin-syntax/SKILL.md'],
       ['claude-skill-selector-keys.md', '.claude/skills/sungen-selector-keys/SKILL.md'],
       ['claude-skill-error-mapping.md', '.claude/skills/sungen-error-mapping/SKILL.md'],
-
-      // Skills — GitHub Copilot
-      ['copilot-skill-gherkin-syntax.md', '.github/prompts/sungen-gherkin-syntax.prompt.md'],
-      ['copilot-skill-selector-keys.md', '.github/prompts/sungen-selector-keys.prompt.md'],
-      ['copilot-skill-error-mapping.md', '.github/prompts/sungen-error-mapping.prompt.md'],
+      ['claude-skill-tc-generation.md', '.claude/skills/sungen-tc-generation/SKILL.md'],
+      ['claude-skill-selector-fix.md', '.claude/skills/sungen-selector-fix/SKILL.md'],
+
+      // Skills — GitHub Copilot (separate copies with Copilot-friendly descriptions)
+      ['github-skill-sungen-gherkin-syntax.md', '.github/skills/sungen-gherkin-syntax/SKILL.md'],
+      ['github-skill-sungen-selector-keys.md', '.github/skills/sungen-selector-keys/SKILL.md'],
+      ['github-skill-sungen-error-mapping.md', '.github/skills/sungen-error-mapping/SKILL.md'],
+      ['github-skill-sungen-tc-generation.md', '.github/skills/sungen-tc-generation/SKILL.md'],
+      ['github-skill-sungen-selector-fix.md', '.github/skills/sungen-selector-fix/SKILL.md'],
     ];
 
     for (const [templateFile, outputRelPath] of fileMapping) {
@@ -244,6 +302,27 @@ export class ProjectInitializer {
 
   }
 
+  /**
+   * Create specs/base.ts for shared browser context
+   */
+  private createSpecsBase(): void {
+    const basePath = path.join(this.cwd, 'specs', 'generated', 'base.ts');
+
+    if (fs.existsSync(basePath)) {
+      this.skippedItems.push('specs/generated/base.ts');
+      return;
+    }
+
+    const baseDir = path.dirname(basePath);
+    if (!fs.existsSync(baseDir)) {
+      fs.mkdirSync(baseDir, { recursive: true });
+    }
+
+    const content = this.readTemplate('specs-base.ts');
+    fs.writeFileSync(basePath, content, 'utf-8');
+    this.createdItems.push('specs/generated/base.ts');
+  }
+
   /**
    * Read a template file from the templates directory
    */

package/src/orchestrator/templates/ai-instructions/claude-cmd-add-screen.md

@@ -2,7 +2,7 @@
 name: add-screen
 description: 'Add a new Sungen screen — scaffolds directories and delegates to make-tc for test case creation'
 argument-hint: [screen-name] [url-path]
-allowed-tools: Read, Grep, Bash, Glob
+allowed-tools: Read, Grep, Bash, Glob, AskUserQuestion
 ---
 
 You are adding a new Sungen screen for test generation.
@@ -37,6 +37,7 @@ If yes, delegate to `/sungen:make-tc <screen>` to handle:
 ### 3. Confirm
 
 Tell the user what was created and next steps:
-- If the page requires authentication before exploring via browser, read `baseURL` from `playwright.config.ts` and tell the user to manually run: `sungen makeauth <role> --url <baseURL>` (e.g., `sungen makeauth admin --url http://localhost:3000`). **Do NOT execute this command yourself.**
+- If the page requires authentication, the user will be asked to log in via the MCP browser during `/sungen:make-tc`
 - Edit the generated files as needed
-- Run `sungen generate --screen <screen>` to compile to Playwright `.spec.ts`
+- Run `/sungen:make-tc <screen>` to create test cases
+- Run `/sungen:make-test <screen>` to generate selectors, compile, and run tests

package/src/orchestrator/templates/ai-instructions/claude-cmd-make-tc.md

@@ -1,60 +1,25 @@
 ---
 name: make-tc
-description: 'Create test cases for a Sungen screen — gathers viewpoints, explores live page or static designs, generates feature/selectors/test-data files'
+description: 'Create or update test cases for a Sungen screen — generates feature + test-data files (20+ scenarios per viewpoint)'
 argument-hint: [screen-name]
-allowed-tools: Read, Grep, Bash, Glob
+allowed-tools: Read, Grep, Bash, Glob, AskUserQuestion
 ---
 
 ## Role
 
-You are a **Senior QA Engineer** specialized in test case design. You structure test cases by viewpoint categories and translate UI into Gherkin test cases following the `sungen-gherkin-syntax` and `sungen-selector-keys` skills.
+You are a **Senior QA Engineer** specialized in exhaustive test case design. You structure test cases by viewpoint categories and translate UI into comprehensive Gherkin test cases following the `sungen-gherkin-syntax` and `sungen-tc-generation` skills. Your focus is on **Gherkin scenarios and test data only** — selectors are handled later during `/sungen:make-test`.
 
 ## Parameters
 
-Parse from `$ARGUMENTS`:
-- **screen** — screen name (e.g., `login`, `dashboard`)
-
-If missing, ask the user.
+Parse **screen** from `$ARGUMENTS`. If missing, ask the user.
 
 ## Steps
 
-### 1. Verify screen exists
-
-Check `qa/screens/<screen>/` exists. If not, tell user to run `/sungen:add-screen` first.
-
-### 2. Determine source mode
-
-Ask: "Do you have a **live page** or **static designs** (screenshots, Figma, images)?"
-
-**Live page →** explore via browser (see CLAUDE.md for Playwright MCP rules). If auth needed, check `specs/.auth/<role>.json` exists — if not, read `baseURL` from `playwright.config.ts` and tell the user to manually run: `sungen makeauth <role> --url <baseURL>` (e.g., `sungen makeauth admin --url http://localhost:3000`). **Do NOT execute `sungen makeauth` yourself.** Wait for the user to confirm auth is ready before proceeding.
-
-**Static designs →** ask user to provide screenshot paths, Figma exports, or UI descriptions. Note: selectors will be best-guess until live page is available.
-
-Present discovered elements to user, then proceed.
-
-### 3. Gather test viewpoints
-
-| VP Category | Description |
-|---|---|
-| **UI/UX** | Default screen appearance, static elements, default states |
-| **Validation** | Field/form validation, error messages |
-| **Logic** | Business logic, happy paths, redirects |
-| **Security** | Auth guards, permission checks |
-
-For each viewpoint, gather: **UI Target**, **Test Viewpoint**, **Expected Result**.
-
-User can provide all at once as a table:
-```
-| VP Category | UI Target | Test Viewpoint | Expected Result |
-```
-
-### 4. Generate files
-
-Generate the 3 files following `sungen-gherkin-syntax` and `sungen-selector-keys` skill rules:
-- `qa/screens/<screen>/features/<screen>.feature` — one Scenario per viewpoint
-- `qa/screens/<screen>/selectors/<screen>.yaml`
-- `qa/screens/<screen>/test-data/<screen>.yaml`
-
-### 5. Confirm
+1. Verify `qa/screens/<screen>/` exists. If not → `/sungen:add-screen` first.
+2. Check if `.feature` file already has scenarios. If yes → use `AskUserQuestion` to ask the update mode (see `sungen-tc-generation` skill for details). If no → fresh creation.
+3. Use `AskUserQuestion` to ask: **Live page** (explore via Playwright MCP) or **Static designs** (screenshots, Figma)? Explore accordingly (see CLAUDE.md for MCP rules).
+4. Follow the `sungen-tc-generation` skill for section identification, viewpoint generation, and output format.
+5. Generate or update `.feature` + `test-data.yaml` following `sungen-gherkin-syntax` and `sungen-tc-generation` skills.
+6. Show summary → next: `/sungen:make-test <screen>`
 
-Show what was generated. Next: `sungen generate --screen <screen>`
+**No selectors.yaml** — selectors are generated during `/sungen:make-test`.

package/src/orchestrator/templates/ai-instructions/claude-cmd-make-test.md

@@ -1,59 +1,24 @@
 ---
 name: make-test
-description: 'Compile and run Playwright tests for a Sungen screen — auto-fixes selectors on failure, falls back to AI .spec.ts fix after 5 attempts'
+description: 'Generate selectors, compile, and run Playwright tests — auto-fixes selectors on failure'
 argument-hint: [screen-name]
-allowed-tools: Read, Grep, Bash, Glob, Edit
+allowed-tools: Read, Grep, Bash, Glob, Edit, AskUserQuestion
 ---
 
 ## Role
 
-You are a **Senior Developer** specialized in Playwright test debugging. You diagnose test failures, fix selectors/test-data, and patch `.spec.ts` when needed. Use the `sungen-error-mapping` and `sungen-selector-keys` skills for error diagnosis and key fixes.
+You are a **Senior Developer** specialized in Playwright test debugging. You generate selectors from live pages, diagnose test failures, and fix selectors/test-data using the `sungen-selector-fix`, `sungen-selector-keys`, and `sungen-error-mapping` skills.
 
 ## Parameters
 
-Parse from `$ARGUMENTS`:
-- **screen** — screen name (e.g., `login`, `dashboard`)
-
-If missing, ask the user.
+Parse **screen** from `$ARGUMENTS`. If missing, ask the user.
 
 ## Steps
 
-### 1. Verify screen exists
-
-Check `qa/screens/<screen>/` has all 3 source files. If not, tell user to run `/sungen:add-screen` and `/sungen:make-tc` first.
-
-### 2. Compile
-
-```bash
-sungen generate --screen <screen>
-```
-
-If fails, fix source files per `sungen-error-mapping` skill and retry.
-
-### 3. Run tests
-
-```bash
-npx playwright test specs/screens/<screen>/<screen>.spec.ts
-```
-
-If pass → Step 5. If fail → Step 4.
-
-### 4. Fix and retry (max 5 attempts)
-
-Per attempt:
-1. Read Playwright error output
-2. Map error to fix using `sungen-error-mapping` skill
-3. Fix `selectors.yaml` or `test-data.yaml`
-4. Recompile: `sungen generate --screen <screen>`
-5. Retest
-
-### 5. Fallback — AI fix .spec.ts
-
-After 5 failed attempts, ask user:
-> Tests still failing. Would you like me to directly fix the `.spec.ts` file?
-
-If yes: read `.spec.ts`, fix locators/assertions, mark with `// AI-fixed: <reason>`
-
-### 6. Confirm
-
-Show: pass/fail, attempt count, files changed.
+1. Verify `qa/screens/<screen>/` has `.feature` + `test-data.yaml`. If not → `/sungen:make-tc` first.
+2. Generate `selectors.yaml` from live page using `sungen-selector-fix` and `sungen-selector-keys` skills.
+3. Compile: `sungen generate --screen <screen>`
+4. Run: `npx playwright test specs/screens/<screen>/<screen>.spec.ts`
+5. If fail → fix selectors/test-data per `sungen-selector-fix` + `sungen-error-mapping` skills, retry (max 5).
+6. After 5 fails → ask user about direct `.spec.ts` fix.
+7. Show: pass/fail, attempt count, files changed.

package/src/orchestrator/templates/ai-instructions/claude-config.md

@@ -12,7 +12,7 @@ Given a login page, here are the 3 files you generate:
 
 **qa/screens/login/features/login.feature**
 ```gherkin
-@auth:admin
+@no-auth
 Feature: Login Screen
 
   Scenario: Successful login
@@ -73,12 +73,14 @@ When exploring a page to generate test files:
 Only use: `browser_navigate`, `browser_snapshot`, `browser_click`, `browser_fill_form`, `browser_evaluate`.
 
 To browse authenticated pages via MCP:
-1. Check if `specs/.auth/<role>.json` exists
-2. If not, read `baseURL` from `playwright.config.ts` and tell the user to manually run: `sungen makeauth <role> --url <baseURL>`. **Do NOT execute `sungen makeauth` yourself.** Wait for user confirmation.
-3. Read `specs/.auth/<role>.json`
-4. `browser_navigate` to the page
-5. `browser_evaluate` to inject localStorage and cookies from the JSON
-6. `browser_navigate` again to reload with auth
+1. `browser_navigate` to `baseURL`
+2. If redirected to login, ask the user to log in manually:
+   > "This page requires login. Please log in using the browser. Confirm when you're done."
+3. Once confirmed, `browser_navigate` to the target page and take `browser_snapshot`
+
+**Never use `sungen makeauth`.** Always let the user log in manually via the MCP browser.
+**NEVER use `browser_evaluate` to inject cookies or localStorage.** It causes size limit issues and server 500 errors.
+**Minimize navigations** — take one snapshot per page, do not navigate repeatedly.
 
 ## Commands
 
@@ -86,5 +88,4 @@ To browse authenticated pages via MCP:
 sungen add --screen <name> --path <url-path>  # Create screen
 sungen generate --screen <name>                # Compile to .spec.ts
 sungen generate --all                          # Compile all
-sungen makeauth <role>                         # Capture auth state
 ```