@sun-asterisk/impact-analyzer 1.0.1 → 1.0.3

package/README.md

@@ -163,9 +163,9 @@ jobs:
   analyze:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
-          fetch-depth: 0
+          fetch-depth: 0  # Fetch full history
 
       - uses: actions/setup-node@v3
         with:
@@ -176,7 +176,6 @@ jobs:
           npx @sun-asterisk/impact-analyzer \
             --input=src \
             --base=origin/${{ github.base_ref }} \
-            --head=${{ github.sha }} \
             --output=impact-report.md \
             --json=impact-report.json
 
@@ -200,11 +199,12 @@ jobs:
 impact-analysis:
   stage: test
   image: node:18
+  variables:
+    GIT_DEPTH: 0  # Fetch full history
   script:
     - npx @sun-asterisk/impact-analyzer
         --input=src
         --base=origin/$CI_MERGE_REQUEST_TARGET_BRANCH_NAME
-        --head=$CI_COMMIT_SHA
         --output=impact-report.md
         --json=impact-report.json
   artifacts:

package/config/default-config.js

@@ -15,7 +15,7 @@ export function loadConfig(cli) {
 
     // Git references
     baseRef: cli.getArg('base', 'origin/main'),
-    headRef: cli.getArg('head', 'HEAD'),
+    headRef: cli.getArg('head', ''),  // Empty means current working directory
 
     // Analysis options
     maxDepth: parseInt(cli.getArg('max-depth', '3')),
@@ -38,9 +38,11 @@ function validateConfig(config) {
     throw new Error('Source directory (--input) is required');
   }
 
-  if (!config.baseRef || !config.headRef) {
-    throw new Error('Git references (--base and --head) are required');
+  if (!config.baseRef) {
+    throw new Error('Base git reference (--base) is required');
   }
+  
+  // headRef is optional, defaults to working directory comparison
 }
 
 export const DEFAULT_CONFIG = {

package/modules/utils/git-utils.js

@@ -11,7 +11,7 @@ export class GitUtils {
   /**
    * Get list of changed files between two refs
    * @param {string} baseRef - Base git reference
-   * @param {string} headRef - Head git reference
+   * @param {string} headRef - Head git reference (empty = working directory)
    * @param {string} workDir - Working directory (optional, defaults to cwd)
    */
   static getChangedFiles(baseRef, headRef, workDir = null) {
@@ -23,10 +23,14 @@ export class GitUtils {
         throw new Error(`Directory does not exist: ${cwd}`);
       }
 
-      const diffCommand = `git diff --name-status ${baseRef}...${headRef}`;
+      // If headRef is empty, compare baseRef with working directory
+      const diffCommand = headRef 
+        ? `git diff --name-status ${baseRef}...${headRef}`
+        : `git diff --name-status ${baseRef}`;
+        
       const diffOutput = execSync(diffCommand, {
         encoding: 'utf-8',
-        cwd: cwd  // FIXED: Execute git command in the source directory
+        cwd: cwd
       });
 
       const changedFiles = [];
@@ -48,7 +52,7 @@ export class GitUtils {
       console.error('Error getting changed files:', error.message);
       console.error('  Working directory:', workDir || process.cwd());
       console.error('  Base ref:', baseRef);
-      console.error('  Head ref:', headRef);
+      console.error('  Head ref:', headRef || '(working directory)');
       return [];
     }
   }
@@ -77,7 +81,7 @@ export class GitUtils {
    * Get diff between two versions of a file
    * @param {string} filePath - File path relative to git root (e.g., 'src/modules/file.ts')
    * @param {string} baseRef - Base git reference
-   * @param {string} headRef - Head git reference  
+   * @param {string} headRef - Head git reference (empty = working directory)
    * @param {string} workDir - Working directory to run git from (optional)
    */
   static getFileDiff(filePath, baseRef, headRef, workDir = null) {
@@ -93,9 +97,10 @@ export class GitUtils {
         return '';
       }
 
-      // filePath is already relative to git root (from git diff --name-status)
-      // Execute git diff from git root
-      const diffCommand = `git diff ${baseRef}...${headRef} -- ${filePath}`;
+      // If headRef is empty, compare with working directory
+      const diffCommand = headRef
+        ? `git diff ${baseRef}...${headRef} -- ${filePath}`
+        : `git diff ${baseRef} -- ${filePath}`;
       
       const result = execSync(diffCommand, {
         encoding: 'utf-8',
@@ -108,7 +113,7 @@ export class GitUtils {
       console.error('Error getting file diff:', error.message);
       console.error('  File:', filePath);
       console.error('  Base:', baseRef);
-      console.error('  Head:', headRef);
+      console.error('  Head:', headRef || '(working directory)');
       console.error('  Working dir:', workDir);
       return '';
     }

package/modules/utils/method-call-graph.js

@@ -448,89 +448,64 @@ export class MethodCallGraph {
 
   /**
    * Get changed methods from git diff
-   * Detects both:
-   * 1. Methods that contain changed lines
-   * 2. Method calls that were added/removed
+   * Uses ts-morph AST to detect which specific methods contain changes
    */
   getChangedMethods(diff, filePath) {
-    const changedMethods = new Set();
-    const changedMethodCalls = new Set();
-    
     if (!diff || !filePath) return [];
 
     const sourceFile = this.project.getSourceFile(filePath);
     if (!sourceFile) return [];
 
-    const classes = sourceFile.getClasses();
-    if (classes.length === 0) return [];
-
-    // Parse diff to extract changed line numbers
+    // Extract changed line numbers from diff
     const changedLines = this.extractChangedLineNumbers(diff);
-    
     if (changedLines.length === 0) return [];
 
-    // 1. Find methods that contain the changed lines
+    const changedMethods = [];
+    
+    // Get all classes in the file
+    const classes = sourceFile.getClasses();
+    
     for (const classDecl of classes) {
       const className = classDecl.getName();
+      if (!className) continue;
+      
       const methods = classDecl.getMethods();
-
+      
       for (const method of methods) {
         const methodName = method.getName();
-        const startLine = method.getStartLineNumber();
-        const endLine = method.getEndLineNumber();
-
-        // Check if any changed line falls within this method's range
-        const hasChangedLine = changedLines.some(
-          lineNum => lineNum >= startLine && lineNum <= endLine
-        );
-
-        if (hasChangedLine) {
-          const fullName = `${className}.${methodName}`;
-          changedMethods.add(fullName);
-        }
-      }
-    }
-
-    // 2. Detect method calls that were modified in the diff
-    const diffLines = diff.split('\n');
-    
-    for (const line of diffLines) {
-      // Only look at added/removed lines
-      if (!line.startsWith('+') && !line.startsWith('-')) continue;
-      
-      const codeLine = line.substring(1).trim();
-      
-      // Pattern: object.methodName(...) or await object.methodName(...)
-      const methodCallPattern = /(?:await\s+)?(\w+)\.(\w+)\s*\(/g;
-      let match;
-      
-      while ((match = methodCallPattern.exec(codeLine)) !== null) {
-        const objectName = match[1];
-        const methodName = match[2];
         
-        // Try to resolve the type of the object
-        const resolvedType = this.resolveObjectType(objectName, sourceFile, classes);
-        
-        if (resolvedType) {
-          const fullName = `${resolvedType}.${methodName}`;
-          changedMethodCalls.add(fullName);
+        // Check if this specific method contains changes
+        if (this.methodContainsChanges(method, changedLines)) {
+          changedMethods.push({
+            className: className,
+            methodName: methodName,
+            file: filePath,
+            fullName: `${className}.${methodName}`
+          });
         }
       }
     }
-
-    // Combine both: methods containing changes + method calls that changed
-    const allChangedMethods = [...changedMethods, ...changedMethodCalls];
     
-    // Convert to objects with metadata
-    return [...new Set(allChangedMethods)].map(fullName => {
-      const parts = fullName.split('.');
-      return {
-        className: parts[0],
-        methodName: parts[1],
-        file: filePath,
-        fullName: fullName
-      };
-    });
+    return changedMethods;
+  }
+
+  /**
+   * Check if a method contains actual code changes using ts-morph AST
+   */
+  methodContainsChanges(method, changedLines) {
+    const body = method.getBody();
+    if (!body) return false;
+
+    // Get the method body block (excluding signature and decorators)
+    const bodyStartLine = body.getStartLineNumber();
+    const bodyEndLine = body.getEndLineNumber();
+
+    // Check if any changed line is within the method body
+    const hasChangesInBody = changedLines.some(
+      line => line >= bodyStartLine && line <= bodyEndLine
+    );
+
+    return hasChangesInBody;
   }
 
   /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sun-asterisk/impact-analyzer",
-  "version": "1.0.1",
+  "version": "1.0.3",
   "description": "Automated impact analysis for TypeScript/JavaScript projects",
   "main": "index.js",
   "type": "module",