@sumaris-net/ngx-components 1.23.4 → 1.23.7

package/fesm2015/sumaris-net.ngx-components.js

@@ -17509,6 +17509,7 @@ class AppForm {
         this._subscription = new Subscription();
         this._enable = false;
         this.i18nFieldPrefix = null;
+        this.destroySubject = new Subject();
         this.readySubject = new BehaviorSubject(false);
         this.loadingSubject = new BehaviorSubject(true);
         this.errorSubject = new BehaviorSubject(undefined);
@@ -17630,6 +17631,8 @@ class AppForm {
         this.errorSubject.unsubscribe();
         this.onCancel.unsubscribe();
         this.onSubmit.unsubscribe();
+        this.destroySubject.next();
+        this.destroySubject.unsubscribe();
     }
     cancel() {
         return __awaiter(this, void 0, void 0, function* () {
@@ -22596,13 +22599,13 @@ class EntitiesTableDataSource extends TableDataSource {
                 // Call service deletion
                 yield this.dataService.deleteAll(data, this.serviceOptions);
                 // Workaround, to be sure all rows have been deleted
-                // Sometimes, the service miss deletion, or GrapQHl cache remove failed.
+                // Sometime, the service miss deletion, or GraphQl cache remove failed.
                 // In this case, apply missing deletion using the super.delete() function
-                const rowNotDeleted = this.getRows().filter(rows.includes);
+                const rowNotDeleted = this.getRows().filter(row => rows.includes(row));
                 if (isNotEmptyArray(rowNotDeleted)) {
-                    console.warn(`[table-datasource] Force deletion of ${rowNotDeleted.length} rows (Is service update the cache ?)`);
+                    console.warn(`[table-datasource] Force deletion of ${rowNotDeleted.length} rows! Please check that data service update the cache, after deletion`);
                     rowNotDeleted
-                        // Start from the end
+                        // Start at the end
                         .sort((a, b) => a.id > b.id ? -1 : 1)
                         .forEach(r => _super.delete.call(this, r.id));
                 }
@@ -22729,8 +22732,8 @@ class AppTable {
         this._subscription = new Subscription();
         this._cellValueChangesDefs = {};
         this._enabled = true;
-        this._destroy$ = new Subject();
         this.allowRowDetail = true;
+        this.destroySubject = new Subject();
         this.excludesColumns = [];
         this.totalRowCount = null;
         this.readySubject = new BehaviorSubject(false);
@@ -23025,7 +23028,7 @@ class AppTable {
         // Stop if next another row, or destroying
         combineLatest([
             this.onStartEditingRow,
-            this._destroy$
+            this.destroySubject
         ])
         // DEBUG
         //.pipe(
@@ -23122,8 +23125,8 @@ class AppTable {
         this.onSort.unsubscribe();
         this.onDirty.unsubscribe();
         this.onError.unsubscribe();
-        this._destroy$.next();
-        this._destroy$.unsubscribe();
+        this.destroySubject.next();
+        this.destroySubject.unsubscribe();
         (_a = this._dataSource) === null || _a === void 0 ? void 0 : _a.ngOnDestroy();
     }
     updateView(res, opts) {
@@ -23259,7 +23262,6 @@ class AppTable {
         // Stop event
         event === null || event === void 0 ? void 0 : event.stopPropagation();
         // Confirmation edition or creation
-        //const confirmed = this.dataSource.confirmEditCreate(row);
         const confirmed = row.confirmEditCreate();
         if (confirmed) {
             // If edit finished, forget edited row
@@ -23484,18 +23486,22 @@ class AppTable {
             // Reverse row order (on a copy)
             // This is a workaround, need because row.delete() has async execution
             // and index cache is updated with a delay
-            rows = rows.slice()
+            let tempRows = rows.slice()
                 .sort((a, b) => a.id > b.id ? -1 : 1);
+            let deletedRows = [];
             // If data need to be saved first
             if (this.saveBeforeDelete) {
                 // Exclude invalid rows (because of save() will fail, when exists some invalid rows)
-                rows = rows.filter(row => {
+                tempRows = tempRows.filter(row => {
                     // Delete the row, if newly created row (id = -1), or if invalid and not editing (= not cancellable)
                     if (row.id === -1 || (!row.valid && !row.editing)) {
+                        if (this.debug)
+                            console.debug(`[table] Delete row #${row.id}`);
                         row.delete();
                         this.visibleRowCount--;
                         this.totalRowCount--;
-                        return false;
+                        deletedRows.push(row);
+                        return false; // Exclude from the list to delete using the service
                     }
                     // Cancel the row (and mark as pristine), when not valid but in edition
                     else if (!row.valid && row.editing) {
@@ -23508,7 +23514,7 @@ class AppTable {
                 });
                 // Apply save, only if there is still some rows to delete
                 // WARN: If no more rows (e.g. because all has been cancelled) then continue anyway to clear editedRow and selection (issue IMAGINE-669)
-                if (isNotEmptyArray(rows)) {
+                if (deletedRows.length || tempRows.length) {
                     // Save data (e.g. when using memory service)
                     const saved = yield this.saveBeforeAction('delete');
                     if (!saved) {
@@ -23518,13 +23524,12 @@ class AppTable {
                 }
             }
             try {
-                const deleteCount = rows.length;
                 // Apply deletion on datasource
                 // If no more rows to delete, continue anyway to clear editedRow and selection (issue IMAGINE-669)
-                if (deleteCount) {
+                if (tempRows.length) {
                     if (this.debug)
-                        console.debug('[table] Delete selected rows...');
-                    yield this._dataSource.deleteAll(rows);
+                        console.debug(`[table] Delete ${tempRows.length} rows...`);
+                    yield this._dataSource.deleteAll(tempRows);
                 }
                 // DO not update manually, because watchALl().subscribe() will update this count
                 //this.totalRowCount -= deleteCount;
@@ -23533,9 +23538,8 @@ class AppTable {
                 this.editedRow = undefined;
                 this.markAsDirty({ emitEvent: false /*markForCheck() is called just after*/ });
                 this.markForCheck();
-                if (deleteCount)
-                    this.onAfterDeletedRows.next(rows);
-                return deleteCount;
+                this.onAfterDeletedRows.next(rows);
+                return rows.length;
             }
             catch (err) {
                 this.setError(err && err.message || err);
@@ -24342,6 +24346,7 @@ class AppEditor {
         this._subscription = new Subscription();
         this._enabled = false;
         this._dirty = false;
+        this.destroySubject = new Subject();
         this.readySubject = new BehaviorSubject(false);
         this.loadingSubject = new BehaviorSubject(true);
         this.errorSubject = new BehaviorSubject(undefined);
@@ -24426,13 +24431,15 @@ class AppEditor {
         }
     }
     ngAfterViewInit() {
-        // Can be override by subclasses
+        // Can be overridden by subclasses
     }
     ngOnDestroy() {
         this._subscription.unsubscribe();
         this.readySubject.unsubscribe();
         this.loadingSubject.unsubscribe();
         this.errorSubject.unsubscribe();
+        this.destroySubject.next();
+        this.destroySubject.unsubscribe();
     }
     addChildForm(form) {
         if (!form)