@sulhadin/orchestrator 1.7.1 → 1.8.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/package.json
CHANGED
|
@@ -85,11 +85,11 @@ PM discusses feature with user
|
|
|
85
85
|
→ PM plans scope, phases, acceptance criteria
|
|
86
86
|
→ [USER APPROVAL GATE: Milestone creation]
|
|
87
87
|
→ PM creates milestone (status: planning)
|
|
88
|
-
→
|
|
88
|
+
→ Worker activates #architect: writes RFC + validates grooming
|
|
89
89
|
→ [USER APPROVAL GATE: RFC + grooming validation → Implementation]
|
|
90
|
-
→
|
|
91
|
-
→
|
|
92
|
-
→
|
|
90
|
+
→ Worker executes backend phases (sequential, each → commit)
|
|
91
|
+
→ Worker executes frontend phases (sequential, each → commit)
|
|
92
|
+
→ Worker activates #reviewer (reviews unpushed commits)
|
|
93
93
|
→ FIX cycle if changes-requested (one round, no re-review)
|
|
94
94
|
→ [USER APPROVAL GATE: Push to origin]
|
|
95
95
|
→ PM pushes, verifies acceptance criteria, closes milestone
|
|
@@ -158,6 +158,7 @@ Rules:
|
|
|
158
158
|
- Breaking changes add `!` after type
|
|
159
159
|
- Body explains WHY, not WHAT
|
|
160
160
|
- Subject line ≤ 72 characters
|
|
161
|
+
- **No `Co-Authored-By` trailers** — never add co-author lines to commit messages
|
|
161
162
|
|
|
162
163
|
---
|
|
163
164
|
|
|
@@ -177,7 +178,7 @@ All other transitions are automatic.
|
|
|
177
178
|
Reviewer no longer needs task files. Review is based on **unpushed commits**.
|
|
178
179
|
|
|
179
180
|
```
|
|
180
|
-
|
|
181
|
+
Worker activates #reviewer
|
|
181
182
|
→ Reviewer runs: git log origin/{branch}..HEAD
|
|
182
183
|
→ Reviewer runs: git diff origin/{branch}...HEAD
|
|
183
184
|
→ Reviewer applies full checklist (backend or frontend mode)
|
|
@@ -186,7 +187,7 @@ PM dispatches #reviewer via worker agent
|
|
|
186
187
|
|
|
187
188
|
**If approved** → PM proceeds to push gate.
|
|
188
189
|
|
|
189
|
-
**If changes-requested** →
|
|
190
|
+
**If changes-requested** → Worker switches to the relevant role, fixes
|
|
190
191
|
and commits. Pipeline proceeds — **no re-review** (single review round).
|
|
191
192
|
|
|
192
193
|
---
|
|
@@ -47,11 +47,13 @@ For each milestone (in order: in-progress first, then planning):
|
|
|
47
47
|
⚙️ #backend ✅ phase-1 done (feat(db): add auth tables)
|
|
48
48
|
|
|
49
49
|
⚙️ #backend ▶ phase-2: API endpoints + tests...
|
|
50
|
-
|
|
50
|
+
Read phase-2.md, implement, test, commit
|
|
51
|
+
Update phase-2.md result + context.md
|
|
51
52
|
⚙️ #backend ✅ phase-2 done (feat(auth): add login endpoint)
|
|
52
53
|
|
|
53
54
|
🎨 #frontend ▶ phase-3: Login UI...
|
|
54
|
-
|
|
55
|
+
Read phase-3.md, implement, test, commit
|
|
56
|
+
Update phase-3.md result + context.md
|
|
55
57
|
🎨 #frontend ✅ phase-3 done (feat(auth): add login page)
|
|
56
58
|
|
|
57
59
|
🔍 #reviewer ▶ reviewing unpushed commits...
|
|
@@ -76,9 +78,20 @@ For each milestone (in order: in-progress first, then planning):
|
|
|
76
78
|
✅ All milestones complete. Waiting for new work from PM.
|
|
77
79
|
```
|
|
78
80
|
|
|
79
|
-
## Role Switching
|
|
81
|
+
## Role Switching — Automatic, Based on Phase File
|
|
80
82
|
|
|
81
|
-
|
|
83
|
+
You switch roles **automatically** based on the `role:` field in each phase file.
|
|
84
|
+
Nobody tells you which role to use — you read it from the phase file and activate
|
|
85
|
+
the corresponding role, its rules, its ownership scope, and its engineering principles.
|
|
86
|
+
|
|
87
|
+
```
|
|
88
|
+
phase-1.md → role: backend-engineer → you become #backend
|
|
89
|
+
phase-2.md → role: backend-engineer → you stay #backend
|
|
90
|
+
phase-3.md → role: frontend-engineer → you switch to #frontend
|
|
91
|
+
review → always #reviewer
|
|
92
|
+
```
|
|
93
|
+
|
|
94
|
+
Role mapping:
|
|
82
95
|
|
|
83
96
|
| Role prefix | Role | Icon |
|
|
84
97
|
|-------------|------|------|
|
|
@@ -158,9 +171,9 @@ When `#start` is called and a milestone has `status: in-progress`:
|
|
|
158
171
|
|
|
159
172
|
For each phase:
|
|
160
173
|
|
|
161
|
-
1. **
|
|
162
|
-
2. **
|
|
163
|
-
3. **
|
|
174
|
+
1. **Read the phase file** — check `role:` field, objective, scope, acceptance criteria
|
|
175
|
+
2. **Activate the role from `role:` field** — read the corresponding role file in `.orchestra/roles/`, follow its rules, principles, ownership scope
|
|
176
|
+
3. **Print start status** — `{icon} #role ▶ phase-N: description...`
|
|
164
177
|
4. **Implement** — write code, tests, following the role's engineering standards
|
|
165
178
|
5. **Verify** — `npx tsc --noEmit`, run tests (if applicable)
|
|
166
179
|
6. **Commit** — one conventional commit per phase on current branch
|
|
@@ -25,7 +25,7 @@ When the user says "You are the code-reviewer", do the following:
|
|
|
25
25
|
1. Read this file completely.
|
|
26
26
|
2. Read `.orchestra/README.md` for orchestration rules.
|
|
27
27
|
3. Determine activation mode:
|
|
28
|
-
- **Autonomous mode:**
|
|
28
|
+
- **Autonomous mode (#start):** Worker activates you automatically after all phases complete. Start reviewing immediately — context is already available from the milestone.
|
|
29
29
|
- **Manual mode:** Check if there are unpushed commits on the current branch using `git log origin/{branch}..HEAD`. If commits exist, review them. If no unpushed commits, report: "No unpushed commits to review. Ready for instructions."
|
|
30
30
|
4. Read the milestone's RFC for context on what was intended.
|
|
31
31
|
5. Start reviewing immediately without asking for confirmation.
|
|
@@ -117,7 +117,7 @@ Fix: Reviewer → changes-requested → Engineer fixes → proceed (no re-r
|
|
|
117
117
|
- Current library versions only
|
|
118
118
|
- No workarounds, no unused code, no `any` types
|
|
119
119
|
- SOLID, KISS, YAGNI, DRY — enforced by reviewer
|
|
120
|
-
-
|
|
120
|
+
- Worker (#start) reads milestones, switches roles automatically per phase
|
|
121
121
|
- Each phase → one commit, milestone done → push to origin
|
|
122
122
|
|
|
123
123
|
### Commands
|