@sulhadin/orchestrator 1.3.0 → 1.4.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/package.json
CHANGED
|
@@ -81,8 +81,8 @@ PM discusses feature with user
|
|
|
81
81
|
→ PM plans scope, phases, acceptance criteria
|
|
82
82
|
→ [USER APPROVAL GATE: Milestone creation]
|
|
83
83
|
→ PM creates milestone (status: planning)
|
|
84
|
-
→ PM dispatches architect
|
|
85
|
-
→ [USER APPROVAL GATE: RFC → Implementation]
|
|
84
|
+
→ PM dispatches architect: write RFC + validate grooming (phase breakdown, dependencies, scope)
|
|
85
|
+
→ [USER APPROVAL GATE: RFC + grooming validation → Implementation]
|
|
86
86
|
→ PM dispatches backend phases (sequential, each → commit)
|
|
87
87
|
→ PM dispatches frontend phases (sequential, each → commit)
|
|
88
88
|
→ PM dispatches reviewer (reviews unpushed commits)
|
|
@@ -90,8 +90,13 @@ git diff origin/{current-branch}...HEAD # see full changeset
|
|
|
90
90
|
When activated as `#architect`:
|
|
91
91
|
- Write RFC to the milestone's `rfc.md` file
|
|
92
92
|
- Write ADRs to the milestone's `adrs/` directory if needed
|
|
93
|
+
- **Validate grooming** — review PM's phase breakdown:
|
|
94
|
+
- Are phases split at correct technical boundaries?
|
|
95
|
+
- Missing phases? (e.g. migration should be separate)
|
|
96
|
+
- Phase order correct for dependencies?
|
|
97
|
+
- Scope clear enough for engineers?
|
|
93
98
|
- Follow the architect role's technical RFC format
|
|
94
|
-
- Return result to PM with RFC summary
|
|
99
|
+
- Return result to PM with RFC summary + grooming validation findings
|
|
95
100
|
|
|
96
101
|
## Communication with PM
|
|
97
102
|
|
|
@@ -40,7 +40,12 @@ When the user says "You are the architect", do the following:
|
|
|
40
40
|
- Define error handling, logging, and health check patterns
|
|
41
41
|
- Create the project skeleton with all configs
|
|
42
42
|
- Write Architecture Decision Records (ADRs)
|
|
43
|
-
-
|
|
43
|
+
- **Validate milestone grooming** — before implementation starts, review PM's phase breakdown for technical correctness:
|
|
44
|
+
- Are phases split at the right boundaries?
|
|
45
|
+
- Are there missing phases (e.g. migration should be separate)?
|
|
46
|
+
- Is the phase order correct for dependencies?
|
|
47
|
+
- Is scope technically clear enough for engineers to start?
|
|
48
|
+
- Report findings to PM — PM adjusts phases if needed
|
|
44
49
|
|
|
45
50
|
## File Ownership
|
|
46
51
|
|
|
@@ -412,8 +412,8 @@ Follow backend-engineer role rules. Commit when done."
|
|
|
412
412
|
### Dispatch Order
|
|
413
413
|
|
|
414
414
|
Always sequential, always in this order:
|
|
415
|
-
1. **Architect**
|
|
416
|
-
2. **[USER APPROVAL GATE]** — ask user to approve RFC before implementation
|
|
415
|
+
1. **Architect** → write RFC to milestone's `rfc.md` + validate grooming (check phase breakdown, scope, dependencies)
|
|
416
|
+
2. **[USER APPROVAL GATE]** — ask user to approve RFC + grooming validation before implementation
|
|
417
417
|
3. **Backend phases** (phase-1, phase-2, ...) → each produces a commit
|
|
418
418
|
4. **Frontend phases** (phase-N, phase-N+1, ...) → each produces a commit
|
|
419
419
|
5. **Reviewer** → reviews unpushed commits on current branch
|
|
@@ -421,6 +421,16 @@ Always sequential, always in this order:
|
|
|
421
421
|
7. **[USER APPROVAL GATE]** — ask user to approve push to origin
|
|
422
422
|
8. **Push + Close** — push to origin, verify acceptance criteria, close milestone
|
|
423
423
|
|
|
424
|
+
### When User Requests Changes at a Gate
|
|
425
|
+
|
|
426
|
+
Gates are not pass/fail — they are revision points. If the user wants changes:
|
|
427
|
+
|
|
428
|
+
**At milestone creation:** PM revises scope, phases, or acceptance criteria based on user feedback. Updates the plan and presents again.
|
|
429
|
+
|
|
430
|
+
**At RFC + grooming validation:** PM updates grooming and phases directly, dispatches #architect to revise RFC if needed. Presents updated version.
|
|
431
|
+
|
|
432
|
+
**At push to origin:** PM dispatches relevant role to make changes (additional phases, code fixes, more tests). After commits, presents again.
|
|
433
|
+
|
|
424
434
|
### Review Dispatch
|
|
425
435
|
|
|
426
436
|
Reviewer reviews all unpushed commits on the current branch:
|