@suilend/sdk 9.0.0-next.ge1ea2dc → 10.0.0-next.g5c83439

package/client.d.ts

@@ -1,11 +1,12 @@
 import { SuiClientTypes } from "@mysten/sui/client";
 import { SuiGrpcClient } from "@mysten/sui/grpc";
 import { Transaction, TransactionObjectArgument, TransactionObjectInput } from "@mysten/sui/transactions";
-import { SuiPriceServiceConnection, SuiPythClient } from "@pythnetwork/pyth-sui-js";
+import { SuiPythClient } from "@pythnetwork/pyth-sui-js";
 import { LendingMarket, ObligationOwnerCap } from "./_generated/suilend/lending-market/structs";
 import { Obligation } from "./_generated/suilend/obligation/structs";
 import { NewConfigArgs as CreateRateLimiterConfigArgs } from "./_generated/suilend/rate-limiter/functions";
 import { CreateReserveConfigArgs } from "./_generated/suilend/reserve-config/functions";
+import { type PriceUpdateDataSource } from "./lib/pyth";
 import { Side } from "./lib/types";
 export declare const ADMIN_ADDRESS: string;
 export declare const LENDING_MARKET_REGISTRY_ID: string;
@@ -43,7 +44,18 @@ export declare class SuilendClient {
     lendingMarket: LendingMarket<string>;
     suiGrpcClient: SuiGrpcClient;
     pythClient: SuiPythClient;
-    pythConnection: SuiPriceServiceConnection;
+    /**
+     * The source of the signed update this client puts ON-CHAIN.
+     *
+     * Typed as the one-method `PriceUpdateDataSource` rather than the concrete
+     * `SuiPriceServiceConnection` it used to be: a real connection still satisfies
+     * it structurally, and the narrower type is what lets a caller inject an
+     * authenticated or proxied source without reimplementing a pyth client. It
+     * stays a public, reassignable field because consumers already assign it
+     * directly — the indexer to reach its failover connection, the admin dialogs
+     * to read update data for a reserve change.
+     */
+    pythConnection: PriceUpdateDataSource;
     constructor(lendingMarket: LendingMarket<string>, suiGrpcClient: SuiGrpcClient);
     static initialize(lendingMarketId: string, lendingMarketType: string, suiGrpcClient: SuiGrpcClient, logPackageId?: boolean): Promise<SuilendClient>;
     /**

package/client.js

@@ -1,5 +1,5 @@
 import { SUI_CLOCK_OBJECT_ID, SUI_SYSTEM_STATE_OBJECT_ID, normalizeStructTag, normalizeSuiObjectId, toHex, } from "@mysten/sui/utils";
-import { SuiPriceServiceConnection, SuiPythClient, } from "@pythnetwork/pyth-sui-js";
+import { SuiPythClient } from "@pythnetwork/pyth-sui-js";
 import { extractCTokenCoinType, getAllCoins, getSpendableCoin, } from "@suilend/sui-core";
 import { phantom } from "./_generated/_framework/reified.js";
 import { PKG_V10, setPublishedAt } from "./_generated/suilend/index.js";
@@ -11,7 +11,7 @@ import { Obligation } from "./_generated/suilend/obligation/structs.js";
 import { newConfig as createRateLimiterConfig, } from "./_generated/suilend/rate-limiter/functions.js";
 import { createReserveConfig, } from "./_generated/suilend/reserve-config/functions.js";
 import { addReserveProCompatible, addReserveV2ProCompatible, changeReservePriceFeedProCompatible, priceInfoPublishTime, refreshReservePriceProCompatible, } from "./lib/proCompatible.js";
-import { PRIMARY_PYTH_ENDPOINT } from "./lib/pyth.js";
+import { resolvePriceUpdateDataSource, } from "./lib/pyth.js";
 import { Side } from "./lib/types.js";
 import { chunkedMultiGet } from "./utils/obligation.js";
 const SUI_COINTYPE = "0x2::sui::SUI";
@@ -144,6 +144,17 @@ export class SuilendClient {
     lendingMarket;
     suiGrpcClient;
     pythClient;
+    /**
+     * The source of the signed update this client puts ON-CHAIN.
+     *
+     * Typed as the one-method `PriceUpdateDataSource` rather than the concrete
+     * `SuiPriceServiceConnection` it used to be: a real connection still satisfies
+     * it structurally, and the narrower type is what lets a caller inject an
+     * authenticated or proxied source without reimplementing a pyth client. It
+     * stays a public, reassignable field because consumers already assign it
+     * directly — the indexer to reach its failover connection, the admin dialogs
+     * to read update data for a reserve change.
+     */
     pythConnection;
     constructor(lendingMarket, suiGrpcClient) {
         this.lendingMarket = lendingMarket;
@@ -161,10 +172,13 @@ export class SuilendClient {
         // deposit/withdraw/borrow/repay, and nothing read-only touches it, so a
         // typecheck and every page-load check stay green while writes are broken.
         this.pythClient = new SuiPythClient(suiGrpcClient, PYTH_STATE_ID, WORMHOLE_STATE_ID);
-        const pythEndpoint = PRIMARY_PYTH_ENDPOINT; // TODO: Use getWorkingPythEndpoint
-        this.pythConnection = new SuiPriceServiceConnection(pythEndpoint, {
-            timeout: 30 * 1000,
-        });
+        // Deliberately NOT a public-Hermes connection, which is what stood here.
+        // `WORMHOLE_STATE_ID` above is unconditionally the pro-compatible
+        // deployment, and public Hermes signs with a guardian set that deployment
+        // does not hold — so that default could not produce a usable update for any
+        // feed, and only looked harmless because `refreshAll` skips the update
+        // entirely while a feed is fresh. See `resolvePriceUpdateDataSource`.
+        this.pythConnection = resolvePriceUpdateDataSource();
     }
     static async initialize(lendingMarketId, lendingMarketType, suiGrpcClient, logPackageId) {
         const lendingMarket = await LendingMarket.fetch(suiGrpcClient, phantom(lendingMarketType), lendingMarketId);
@@ -488,8 +502,10 @@ export class SuilendClient {
             });
             const publishTime = priceInfoPublishTime(object.json, priceInfoObjectId);
             const stalenessSeconds = Date.now() / 1000 - Number(publishTime);
+            // 20s, not MAX_STALENESS_SECONDS (60): the update has to leave the
+            // object fresh enough to still satisfy `refresh_reserve_price` after
+            // the transaction lands, not merely fresh at the moment it is read.
             if (stalenessSeconds > 20) {
-                const reserve = this.lendingMarket.reserves[Number(reserveArrayIndexes[+i])];
                 stalePriceIdentifiers.push(priceIdentifiers[+i]);
             }
         })()));

package/lib/pyth.d.ts

@@ -106,3 +106,64 @@ export declare const hermesConnectionConfig: (hermesConfig?: HermesClientConfig)
  * works without an injected connection.
  */
 export declare const resolvePythConnection: (pythConnectionOverride?: PriceFeedSource, fallbackPythEndpoint?: string, hermesConfig?: HermesClientConfig) => Promise<PriceFeedSource>;
+/**
+ * Where `SuilendClient` gets the signed price update it puts ON-CHAIN.
+ *
+ * Not the same thing as `PriceFeedSource`, and the distinction is the whole
+ * point of this type existing. `PriceFeedSource` answers "what is this feed
+ * worth" and is read off-chain; the answer is a number and any Hermes can
+ * produce it. This answers "give me a VAA the Pyth deployment our contracts
+ * link will verify" — a signed blob that a *specific* deployment's guardian set
+ * has to have signed. Injecting one has never affected the other, which is how
+ * an app could believe it had moved to Pyth Pro while every transaction it built
+ * still carried a public-Hermes VAA.
+ *
+ * One method, because that is all `SuilendClient` ever calls on the field.
+ */
+export interface PriceUpdateDataSource {
+    getPriceFeedsUpdateData(priceIds: string[]): Promise<Buffer[]>;
+}
+/**
+ * Register the process-wide source for on-chain price updates. Call at startup;
+ * clients constructed BEFORE the call still pick it up, because the SDK default
+ * resolves late (see `deferredPriceUpdateDataSource`).
+ *
+ * Process-wide rather than a constructor argument on purpose: consumers build a
+ * `SuilendClient` in many places (perpetual-ui alone has 17 `initialize` call
+ * sites across four apps), and a per-site argument means the site somebody adds
+ * next silently reverts to the broken path. One registration covers every
+ * instance, including ones constructed by code the caller does not own.
+ *
+ * Resolution order, most specific first:
+ *   1. `client.pythConnection = …` — a per-instance assignment always wins, and
+ *      is how the indexer injects its authenticated failover connection.
+ *   2. whatever was registered here.
+ *   3. the SDK default.
+ *
+ * That order is load-bearing for the planned change to have the SDK resolve its
+ * own default endpoint: adding a real default at (3) cannot fight a consumer
+ * that registered at (2), so registrations made now become redundant rather
+ * than wrong.
+ */
+export declare function setPriceUpdateDataSource(source: PriceUpdateDataSource): void;
+/**
+ * Test-only. The registration is process-wide by design, so without this one
+ * test's source would leak into the next.
+ */
+export declare function clearPriceUpdateDataSource(): void;
+/**
+ * The source a newly-constructed `SuilendClient` should start with: ALWAYS the
+ * late-resolving wrapper, never the registered source directly.
+ *
+ * Returning the registered source when one happened to exist made resolution
+ * depend on construction order after all — a client built before registration
+ * followed the registry, one built after snapshotted it. So a re-registration (a
+ * provider re-running on hot reload, a refreshed credential behind the source)
+ * left every already-built client calling the source it replaced, which is the
+ * same silent-divergence failure this seam exists to prevent, reached through
+ * timing instead of a missed call site.
+ *
+ * Per-instance assignment still wins, because the field stays public and
+ * reassignable; this only decides what a client starts with.
+ */
+export declare function resolvePriceUpdateDataSource(): PriceUpdateDataSource;

package/lib/pyth.js

@@ -180,3 +180,86 @@ export const resolvePythConnection = async (pythConnectionOverride, fallbackPyth
     const pythEndpoint = await getWorkingPythEndpoint(fallbackPythEndpoint);
     return createHermesPriceFeedSource(new HermesClient(pythEndpoint, hermesConnectionConfig(hermesConfig)));
 };
+/**
+ * The SDK's default: it resolves the registered source LATE, and fails only if
+ * there still isn't one.
+ *
+ * Late resolution is the point. A client reads this default at construction, so
+ * a default that captured "nothing registered" would leave every client built
+ * before startup finished permanently broken — and consumers construct clients
+ * inside React hooks and module initialisers, where ordering against an app's
+ * own bootstrap is not something the SDK can dictate. Deferring to call time
+ * means registration order simply does not matter.
+ *
+ * When there genuinely is no source, it names the problem rather than returning
+ * something unusable. There is no default that could work: `WORMHOLE_STATE_ID`
+ * is unconditionally the pro-compatible deployment, whose vendored wormhole
+ * holds a single guardian set, so a public-Hermes VAA carries the Wormhole
+ * network's set 7 and aborts in `dynamic_field::borrow_child_object` as the
+ * first command of the user's transaction. Shipping public Hermes here — which
+ * is what this SDK did — was not a lenient default but a guaranteed on-chain
+ * abort, deferred until a feed drifted past the staleness gate.
+ */
+const deferredPriceUpdateDataSource = {
+    getPriceFeedsUpdateData: (priceIds) => {
+        if (registeredPriceUpdateDataSource) {
+            return registeredPriceUpdateDataSource.getPriceFeedsUpdateData(priceIds);
+        }
+        return Promise.reject(new Error("@suilend/sdk: no price-update source is registered, so an on-chain " +
+            "price update cannot be built. Call setPriceUpdateDataSource() at " +
+            "startup with a source backed by the pro-compatible Pyth deployment " +
+            "(public Hermes cannot be used: its VAAs are signed by a guardian set " +
+            "the linked wormhole instance does not hold, and verification aborts)."));
+    },
+};
+let registeredPriceUpdateDataSource;
+/**
+ * Register the process-wide source for on-chain price updates. Call at startup;
+ * clients constructed BEFORE the call still pick it up, because the SDK default
+ * resolves late (see `deferredPriceUpdateDataSource`).
+ *
+ * Process-wide rather than a constructor argument on purpose: consumers build a
+ * `SuilendClient` in many places (perpetual-ui alone has 17 `initialize` call
+ * sites across four apps), and a per-site argument means the site somebody adds
+ * next silently reverts to the broken path. One registration covers every
+ * instance, including ones constructed by code the caller does not own.
+ *
+ * Resolution order, most specific first:
+ *   1. `client.pythConnection = …` — a per-instance assignment always wins, and
+ *      is how the indexer injects its authenticated failover connection.
+ *   2. whatever was registered here.
+ *   3. the SDK default.
+ *
+ * That order is load-bearing for the planned change to have the SDK resolve its
+ * own default endpoint: adding a real default at (3) cannot fight a consumer
+ * that registered at (2), so registrations made now become redundant rather
+ * than wrong.
+ */
+export function setPriceUpdateDataSource(source) {
+    registeredPriceUpdateDataSource = source;
+}
+/**
+ * Test-only. The registration is process-wide by design, so without this one
+ * test's source would leak into the next.
+ */
+export function clearPriceUpdateDataSource() {
+    registeredPriceUpdateDataSource = undefined;
+}
+/**
+ * The source a newly-constructed `SuilendClient` should start with: ALWAYS the
+ * late-resolving wrapper, never the registered source directly.
+ *
+ * Returning the registered source when one happened to exist made resolution
+ * depend on construction order after all — a client built before registration
+ * followed the registry, one built after snapshotted it. So a re-registration (a
+ * provider re-running on hot reload, a refreshed credential behind the source)
+ * left every already-built client calling the source it replaced, which is the
+ * same silent-divergence failure this seam exists to prevent, reached through
+ * timing instead of a missed call site.
+ *
+ * Per-instance assignment still wins, because the field stays public and
+ * reassignable; this only decides what a client starts with.
+ */
+export function resolvePriceUpdateDataSource() {
+    return deferredPriceUpdateDataSource;
+}

package/package.json

@@ -1 +1 @@
-{"name":"@suilend/sdk","version":"9.0.0-next.ge1ea2dc","private":false,"description":"A TypeScript SDK for interacting with the Suilend program","author":"Suilend","license":"MIT","main":"./index.js","exports":{".":"./index.js","./client":"./client.js","./mmt":"./mmt.js","./strategies":"./strategies.js","./api/events":"./api/events.js","./api":"./api/index.js","./lib/constants":"./lib/constants.js","./lib":"./lib/index.js","./lib/initialize":"./lib/initialize.js","./lib/liquidityMining":"./lib/liquidityMining.js","./lib/proCompatible":"./lib/proCompatible.js","./lib/pyth":"./lib/pyth.js","./lib/strategyOwnerCap":"./lib/strategyOwnerCap.js","./lib/transactions":"./lib/transactions.js","./lib/types":"./lib/types.js","./margin":"./margin/index.js","./parsers/apiReserveAssetDataEvent":"./parsers/apiReserveAssetDataEvent.js","./parsers":"./parsers/index.js","./parsers/lendingMarket":"./parsers/lendingMarket.js","./parsers/obligation":"./parsers/obligation.js","./parsers/rateLimiter":"./parsers/rateLimiter.js","./parsers/reserve":"./parsers/reserve.js","./swap":"./swap/index.js","./swap/quote":"./swap/quote.js","./swap/transaction":"./swap/transaction.js","./utils/events":"./utils/events.js","./utils/feedId":"./utils/feedId.js","./utils":"./utils/index.js","./utils/obligation":"./utils/obligation.js","./utils/simulate":"./utils/simulate.js","./_generated/_framework/reified":"./_generated/_framework/reified.js","./_generated/_framework/util":"./_generated/_framework/util.js","./_generated/_framework/vector":"./_generated/_framework/vector.js","./_generated/suilend":"./_generated/suilend/index.js","./margin/margin/admin_cap":"./margin/margin/admin_cap.js","./margin/margin/market":"./margin/margin/market.js","./margin/margin/permissions":"./margin/margin/permissions.js","./margin/margin/position":"./margin/margin/position.js","./margin/margin/router":"./margin/margin/router.js","./margin/margin/version":"./margin/margin/version.js","./margin/utils":"./margin/utils/index.js","./_generated/suilend/cell/structs":"./_generated/suilend/cell/structs.js","./_generated/suilend/decimal/structs":"./_generated/suilend/decimal/structs.js","./_generated/suilend/lending-market/functions":"./_generated/suilend/lending-market/functions.js","./_generated/suilend/lending-market/structs":"./_generated/suilend/lending-market/structs.js","./_generated/suilend/lending-market-registry/functions":"./_generated/suilend/lending-market-registry/functions.js","./_generated/suilend/liquidity-mining/structs":"./_generated/suilend/liquidity-mining/structs.js","./_generated/suilend/obligation/structs":"./_generated/suilend/obligation/structs.js","./_generated/suilend/rate-limiter/functions":"./_generated/suilend/rate-limiter/functions.js","./_generated/suilend/rate-limiter/structs":"./_generated/suilend/rate-limiter/structs.js","./_generated/suilend/reserve/structs":"./_generated/suilend/reserve/structs.js","./_generated/suilend/reserve-config/functions":"./_generated/suilend/reserve-config/functions.js","./_generated/suilend/reserve-config/structs":"./_generated/suilend/reserve-config/structs.js","./_generated/_dependencies/source/0x1":"./_generated/_dependencies/source/0x1/index.js","./_generated/_dependencies/source/0x2":"./_generated/_dependencies/source/0x2/index.js","./_generated/_dependencies/source/0x8d97f1cd6ac663735be08d1d2b6d02a159e711586461306ce60a2b7a6a565a9e":"./_generated/_dependencies/source/0x8d97f1cd6ac663735be08d1d2b6d02a159e711586461306ce60a2b7a6a565a9e/index.js","./margin/margin/deps/std/type_name":"./margin/margin/deps/std/type_name.js","./margin/margin/deps/sui/vec_set":"./margin/margin/deps/sui/vec_set.js","./margin/margin/deps/suilend/lending_market":"./margin/margin/deps/suilend/lending_market.js","./_generated/_dependencies/source/0x1/ascii/structs":"./_generated/_dependencies/source/0x1/ascii/structs.js","./_generated/_dependencies/source/0x1/option/structs":"./_generated/_dependencies/source/0x1/option/structs.js","./_generated/_dependencies/source/0x1/type-name/structs":"./_generated/_dependencies/source/0x1/type-name/structs.js","./_generated/_dependencies/source/0x2/bag/structs":"./_generated/_dependencies/source/0x2/bag/structs.js","./_generated/_dependencies/source/0x2/balance/structs":"./_generated/_dependencies/source/0x2/balance/structs.js","./_generated/_dependencies/source/0x2/object/structs":"./_generated/_dependencies/source/0x2/object/structs.js","./_generated/_dependencies/source/0x2/object-table/structs":"./_generated/_dependencies/source/0x2/object-table/structs.js","./_generated/_dependencies/source/0x8d97f1cd6ac663735be08d1d2b6d02a159e711586461306ce60a2b7a6a565a9e/price-identifier/structs":"./_generated/_dependencies/source/0x8d97f1cd6ac663735be08d1d2b6d02a159e711586461306ce60a2b7a6a565a9e/price-identifier/structs.js"},"types":"./index.d.ts","scripts":{"build":"rm -rf ./dist && tsc && node ./fix-esm-imports.js","typecheck":"tsc --noEmit && tsc --noEmit -p tsconfig.test.json","test":"vitest run","lint:ci":"yarn run typecheck","prettier":"prettier --write src/ tests/","release":"yarn run build && node ./release.js && cd ./dist && npm publish --access public"},"repository":{"type":"git","url":"git+https://github.com/fireflyprotocol/lending-mono.git","directory":"ts/sdks/sdk"},"dependencies":{"@bluefin-exchange/bluefin7k-aggregator-sdk":"^7.5.0","@cetusprotocol/aggregator-sdk":"^1.5.7","@flowx-finance/sdk":"^2.1.0","@pythnetwork/hermes-client":"3.1.0","@pythnetwork/pyth-sui-js":"4.0.0","@suilend/springsui-sdk":"^4.0.0","bignumber.js":"^11.1.5","bn.js":"^5.2.2","crypto-js":"^4.2.0","lodash":"^4.17.21","p-limit":"7.3.1","uuid":"^14.0.1"},"devDependencies":{"@mysten/bcs":"^2.0.5","@mysten/sui":"2.23.2","@suilend/sui-core":"^1.0.0","@tsconfig/recommended":"^1.0.8","@types/bn.js":"^5.2.0","@types/lodash":"^4.17.25","@types/node":"^26.1.2","fast-check":"^4.9.0","prettier":"^3.3.3","ts-node":"^10.9.2","typescript":"^6.0.3","vitest":"4.1.10"},"peerDependencies":{"@mysten/bcs":"^2.0.5","@mysten/sui":">=2.22.1 <3","@suilend/sui-core":"^1.0.0"},"type":"module"}
+{"name":"@suilend/sdk","version":"10.0.0-next.g5c83439","private":false,"description":"A TypeScript SDK for interacting with the Suilend program","author":"Suilend","license":"MIT","main":"./index.js","exports":{".":"./index.js","./client":"./client.js","./mmt":"./mmt.js","./strategies":"./strategies.js","./api/events":"./api/events.js","./api":"./api/index.js","./lib/constants":"./lib/constants.js","./lib":"./lib/index.js","./lib/initialize":"./lib/initialize.js","./lib/liquidityMining":"./lib/liquidityMining.js","./lib/proCompatible":"./lib/proCompatible.js","./lib/pyth":"./lib/pyth.js","./lib/strategyOwnerCap":"./lib/strategyOwnerCap.js","./lib/transactions":"./lib/transactions.js","./lib/types":"./lib/types.js","./margin":"./margin/index.js","./parsers/apiReserveAssetDataEvent":"./parsers/apiReserveAssetDataEvent.js","./parsers":"./parsers/index.js","./parsers/lendingMarket":"./parsers/lendingMarket.js","./parsers/obligation":"./parsers/obligation.js","./parsers/rateLimiter":"./parsers/rateLimiter.js","./parsers/reserve":"./parsers/reserve.js","./swap":"./swap/index.js","./swap/quote":"./swap/quote.js","./swap/transaction":"./swap/transaction.js","./utils/events":"./utils/events.js","./utils/feedId":"./utils/feedId.js","./utils":"./utils/index.js","./utils/obligation":"./utils/obligation.js","./utils/simulate":"./utils/simulate.js","./_generated/_framework/reified":"./_generated/_framework/reified.js","./_generated/_framework/util":"./_generated/_framework/util.js","./_generated/_framework/vector":"./_generated/_framework/vector.js","./_generated/suilend":"./_generated/suilend/index.js","./margin/margin/admin_cap":"./margin/margin/admin_cap.js","./margin/margin/market":"./margin/margin/market.js","./margin/margin/permissions":"./margin/margin/permissions.js","./margin/margin/position":"./margin/margin/position.js","./margin/margin/router":"./margin/margin/router.js","./margin/margin/version":"./margin/margin/version.js","./margin/utils":"./margin/utils/index.js","./_generated/suilend/cell/structs":"./_generated/suilend/cell/structs.js","./_generated/suilend/decimal/structs":"./_generated/suilend/decimal/structs.js","./_generated/suilend/lending-market/functions":"./_generated/suilend/lending-market/functions.js","./_generated/suilend/lending-market/structs":"./_generated/suilend/lending-market/structs.js","./_generated/suilend/lending-market-registry/functions":"./_generated/suilend/lending-market-registry/functions.js","./_generated/suilend/liquidity-mining/structs":"./_generated/suilend/liquidity-mining/structs.js","./_generated/suilend/obligation/structs":"./_generated/suilend/obligation/structs.js","./_generated/suilend/rate-limiter/functions":"./_generated/suilend/rate-limiter/functions.js","./_generated/suilend/rate-limiter/structs":"./_generated/suilend/rate-limiter/structs.js","./_generated/suilend/reserve/structs":"./_generated/suilend/reserve/structs.js","./_generated/suilend/reserve-config/functions":"./_generated/suilend/reserve-config/functions.js","./_generated/suilend/reserve-config/structs":"./_generated/suilend/reserve-config/structs.js","./_generated/_dependencies/source/0x1":"./_generated/_dependencies/source/0x1/index.js","./_generated/_dependencies/source/0x2":"./_generated/_dependencies/source/0x2/index.js","./_generated/_dependencies/source/0x8d97f1cd6ac663735be08d1d2b6d02a159e711586461306ce60a2b7a6a565a9e":"./_generated/_dependencies/source/0x8d97f1cd6ac663735be08d1d2b6d02a159e711586461306ce60a2b7a6a565a9e/index.js","./margin/margin/deps/std/type_name":"./margin/margin/deps/std/type_name.js","./margin/margin/deps/sui/vec_set":"./margin/margin/deps/sui/vec_set.js","./margin/margin/deps/suilend/lending_market":"./margin/margin/deps/suilend/lending_market.js","./_generated/_dependencies/source/0x1/ascii/structs":"./_generated/_dependencies/source/0x1/ascii/structs.js","./_generated/_dependencies/source/0x1/option/structs":"./_generated/_dependencies/source/0x1/option/structs.js","./_generated/_dependencies/source/0x1/type-name/structs":"./_generated/_dependencies/source/0x1/type-name/structs.js","./_generated/_dependencies/source/0x2/bag/structs":"./_generated/_dependencies/source/0x2/bag/structs.js","./_generated/_dependencies/source/0x2/balance/structs":"./_generated/_dependencies/source/0x2/balance/structs.js","./_generated/_dependencies/source/0x2/object/structs":"./_generated/_dependencies/source/0x2/object/structs.js","./_generated/_dependencies/source/0x2/object-table/structs":"./_generated/_dependencies/source/0x2/object-table/structs.js","./_generated/_dependencies/source/0x8d97f1cd6ac663735be08d1d2b6d02a159e711586461306ce60a2b7a6a565a9e/price-identifier/structs":"./_generated/_dependencies/source/0x8d97f1cd6ac663735be08d1d2b6d02a159e711586461306ce60a2b7a6a565a9e/price-identifier/structs.js"},"types":"./index.d.ts","scripts":{"build":"rm -rf ./dist && tsc && node ./fix-esm-imports.js","typecheck":"tsc --noEmit && tsc --noEmit -p tsconfig.test.json","test":"vitest run","lint:ci":"yarn run typecheck","prettier":"prettier --write src/ tests/","release":"yarn run build && node ./release.js && cd ./dist && npm publish --access public"},"repository":{"type":"git","url":"git+https://github.com/fireflyprotocol/lending-mono.git","directory":"ts/sdks/sdk"},"dependencies":{"@bluefin-exchange/bluefin7k-aggregator-sdk":"^7.5.0","@cetusprotocol/aggregator-sdk":"^1.5.7","@flowx-finance/sdk":"^2.1.0","@pythnetwork/hermes-client":"3.1.0","@pythnetwork/pyth-sui-js":"4.0.0","@suilend/springsui-sdk":"^4.0.0","bignumber.js":"^11.1.5","bn.js":"^5.2.2","crypto-js":"^4.2.0","lodash":"^4.17.21","p-limit":"7.3.1","uuid":"^14.0.1"},"devDependencies":{"@mysten/bcs":"^2.0.5","@mysten/sui":"2.23.2","@suilend/sui-core":"^1.0.0","@tsconfig/recommended":"^1.0.8","@types/bn.js":"^5.2.0","@types/lodash":"^4.17.25","@types/node":"^26.1.2","fast-check":"^4.9.0","prettier":"^3.3.3","ts-node":"^10.9.2","typescript":"^6.0.3","vitest":"4.1.10"},"peerDependencies":{"@mysten/bcs":"^2.0.5","@mysten/sui":">=2.22.1 <3","@suilend/sui-core":"^1.0.0"},"type":"module"}

package/strategies.js

@@ -1145,6 +1145,11 @@ transaction, dryRunTransaction) => {
     const fullyRepayBorrowsUsingLst = async (maxWithdrawRemainingLstAndRedepositAsBase) => {
         if (depositReserves.lst === undefined)
             throw new Error("LST reserve not found");
+        // Everything below is appended to `transaction` while only the repay is dry-run,
+        // so a failure has to undo the whole handler — otherwise an aborting command stays
+        // in the transaction the user is asked to sign.
+        const transactionBeforeFullRepay = Transaction.from(transaction);
+        const depositsBeforeFullRepay = cloneDeep(deposits);
         const borrowedAmountUsd = borrowedAmount.times(borrowReserve.price);
         const fullRepaymentAmount = (borrowedAmountUsd.lt(0.1)
             ? new BigNumber(0.1).div(borrowReserve.price) // $0.1 in borrow coinType
@@ -1203,14 +1208,18 @@ transaction, dryRunTransaction) => {
             txCopy.transferObjects([fullRepaymentCoin], _address); // Transfer remaining SUI to user
             await dryRunTransaction(txCopy); // Throws error if fails
             transaction = txCopy;
+            // 2.3) Update state
+            borrowedAmount = BigNumber.max(borrowedAmount.minus(repaidAmount), new BigNumber(0));
         }
         catch (err) {
-            // Don't block user if fails
+            // Undo the handler rather than carrying a command that aborts, and leave
+            // `borrowedAmount` alone — nothing was repaid, so the caller must still see the
+            // debt as outstanding.
             console.error(err);
-            transaction.transferObjects([fullRepaymentCoin], _address); // Transfer SUI to user
+            transaction = transactionBeforeFullRepay;
+            deposits = depositsBeforeFullRepay;
+            return;
         }
-        // 2.3) Update state
-        borrowedAmount = BigNumber.max(borrowedAmount.minus(repaidAmount), new BigNumber(0));
         console.log(`[unloopStrategyToExposure.fullyRepayBorrowsUsingLst] repay_borrows.update_state |`, JSON.stringify({
             deposits: deposits.map((d) => ({
                 coinType: d.coinType,
@@ -1288,6 +1297,11 @@ transaction, dryRunTransaction) => {
     const fullyRepayBorrowsUsingBase = async () => {
         if (depositReserves.base === undefined)
             throw new Error("Base reserve not found");
+        // Everything below is appended to `transaction` while only the repay is dry-run,
+        // so a failure has to undo the whole handler — otherwise an aborting command stays
+        // in the transaction the user is asked to sign.
+        const transactionBeforeFullRepay = Transaction.from(transaction);
+        const depositsBeforeFullRepay = cloneDeep(deposits);
         const borrowedAmountUsd = borrowedAmount.times(borrowReserve.price);
         const fullRepaymentAmount = (borrowedAmountUsd.lt(0.1)
             ? new BigNumber(0.1).div(borrowReserve.price) // $0.1 in borrow coinType
@@ -1401,14 +1415,18 @@ transaction, dryRunTransaction) => {
             txCopy.transferObjects([swapCoin], _address); // Transfer remaining to user
             await dryRunTransaction(txCopy); // Throws error if fails
             transaction = txCopy;
+            // 4.2) Update state
+            borrowedAmount = BigNumber.max(borrowedAmount.minus(repaidAmount), new BigNumber(0));
         }
         catch (err) {
-            // Don't block user if fails
+            // Undo the handler rather than carrying a command that aborts, and leave
+            // `borrowedAmount` alone — nothing was repaid, so the caller must still see the
+            // debt as outstanding.
             console.error(err);
-            transaction.transferObjects([swapCoin], _address); // Transfer to user
+            transaction = transactionBeforeFullRepay;
+            deposits = depositsBeforeFullRepay;
+            return;
         }
-        // 4.2) Update state
-        borrowedAmount = BigNumber.max(borrowedAmount.minus(repaidAmount), new BigNumber(0));
         console.log(`[unloopStrategyToExposure.fullyRepayBorrowsUsingBase] repay_borrows.update_state |`, JSON.stringify({
             deposits: deposits.map((d) => ({
                 coinType: d.coinType,
@@ -1490,6 +1508,15 @@ transaction, dryRunTransaction) => {
                 stepMaxRepaidAmount: stepMaxRepaidAmount.toFixed(20),
             }, null, 2));
             // 1.2) Withdraw
+            // Once this step's ceiling can cover everything still owed, it is the last one
+            // — see the base branch for why looping again aborts with `EBorrowNotFound`.
+            // Unlike that branch this needs no margin on top of `pendingBorrowedAmount`:
+            // there is no swap, the redeem rate is deterministic, and every estimate here
+            // errs the same way. `stepWithdrawnAmount` and `stepRepaidAmount` both round
+            // down, and `lstToSuiExchangeRate` is a cached floor that only grows as staking
+            // rewards accrue, so the SUI actually redeemed is at or above the estimate and
+            // the tracked debt already sits at or above the real one.
+            const isFinalStep = pendingBorrowedAmount.lte(stepMaxRepaidAmount);
             const stepWithdrawnAmount = BigNumber.min(pendingBorrowedAmount, stepMaxRepaidAmount)
                 .times(1 - +(lst?.redeemFeePercent ?? 0) / 100) // Potential rounding issue (max 1 MIST)
                 .div(lst?.lstToSuiExchangeRate ?? 1)
@@ -1499,6 +1526,13 @@ transaction, dryRunTransaction) => {
                 stepWithdrawnAmount: stepWithdrawnAmount.toFixed(20),
                 isMaxWithdraw,
             }, null, 2));
+            // The withdraw, redeem and swap below go straight onto `transaction`, but only
+            // the repay is dry-run. When that dry run fails, the step's commands are already
+            // in the transaction, so every later dry run fails on that same command and the
+            // user ends up signing a transaction already known to fail. Snapshot the
+            // pre-step state so a failed step can be rolled back whole.
+            const transactionBeforeStep = Transaction.from(transaction);
+            const depositsBeforeStep = cloneDeep(deposits);
             const [stepWithdrawnCoin] = strategyWithdraw(strategyType, loopingDepositReserve.coinType, strategyOwnerCapId, suilendClient.findReserveArrayIndex(loopingDepositReserve.coinType), BigInt(new BigNumber(stepWithdrawnAmount
                 .times(10 ** loopingDepositReserve.token.decimals)
                 .integerValue(BigNumber.ROUND_DOWN)
@@ -1528,27 +1562,46 @@ transaction, dryRunTransaction) => {
                 stepRepaidAmount: stepRepaidAmount.toFixed(20),
                 isMaxRepay,
             }, null, 2));
+            let stepClearedDebt = false;
             try {
                 const txCopy = Transaction.from(transaction);
                 suilendClient.repay(obligationId, borrowReserve.coinType, stepSuiCoin, txCopy);
                 txCopy.transferObjects([stepSuiCoin], _address);
                 await dryRunTransaction(txCopy); // Throws error if fails
                 transaction = txCopy;
+                // 3.2) Update state
+                // A final step covers everything owed and `obligation::repay` clamps to the
+                // real debt, so the target is reached exactly rather than by subtracting a
+                // figure the rounding has already made fictional.
+                borrowedAmount = isFinalStep
+                    ? targetBorrowedAmount
+                    : borrowedAmount.minus(stepRepaidAmount);
+                stepClearedDebt = isFinalStep;
             }
             catch (err) {
-                // Don't block user if fails
+                // The step cannot land — the redeem aborted, or the borrow is already gone
+                // (`EBorrowNotFound`). Roll the whole step back either way: keeping it would
+                // leave an aborting command in the transaction, so every later dry run would
+                // fail on that same command and the user would be asked to sign a transaction
+                // known to fail.
                 console.error(err);
-                transaction.transferObjects([stepSuiCoin], _address);
+                transaction = transactionBeforeStep;
+                deposits = depositsBeforeStep;
+                break;
             }
-            // 3.2) Update state
-            borrowedAmount = borrowedAmount.minus(stepRepaidAmount);
             console.log(`[unloopStrategyToExposure] ${i} repay_sui.update_state |`, JSON.stringify({
                 deposits: deposits.map((d) => ({
                     coinType: d.coinType,
                     depositedAmount: d.depositedAmount.toFixed(20),
                 })),
                 borrowedAmount: borrowedAmount.toFixed(20),
+                stepClearedDebt,
             }, null, 2));
+            // Nothing is owed above target any more. Returning here rather than looping
+            // again also skips `fullyRepayBorrowsUsingLst`, which would repay a borrow that
+            // no longer exists.
+            if (stepClearedDebt)
+                break;
         }
         // Base only
         else if (loopingDepositReserve.coinType === depositReserves.base?.coinType) {
@@ -1591,8 +1644,24 @@ transaction, dryRunTransaction) => {
                 stepMaxWithdrawnAmount: stepMaxWithdrawnAmount.toFixed(20),
                 stepMaxRepaidAmount: stepMaxRepaidAmount.toFixed(20),
             }, null, 2));
+            const slippagePercent = 1;
             // 1.2) Withdraw
-            const stepWithdrawnAmount = BigNumber.min(pendingBorrowedAmount, stepMaxRepaidAmount)
+            // Once this step's ceiling can cover everything still owed, it is the last
+            // one — so size it to clear the debt outright rather than to the exact tracked
+            // figure. The swap may fill up to `slippagePercent`% below its quote, so scale
+            // by that to stay covered at the worst fill. Overshooting is free:
+            // `obligation::repay` clamps to what is actually owed
+            // (`min(max_repay_amount, borrowed_amount)`) and the surplus is transferred
+            // back to the user below.
+            //
+            // Sizing to the tracked figure instead leaves the loop believing a residual is
+            // still owed, because that figure is deliberately held above the real debt (see
+            // the repay step). The next iteration then aborts with `EBorrowNotFound` — a
+            // fully repaid borrow is removed from the obligation, so there is nothing left
+            // to repay against.
+            const stepTargetRepaidAmount = pendingBorrowedAmount.div(1 - slippagePercent / 100);
+            const isFinalStep = stepTargetRepaidAmount.lte(stepMaxRepaidAmount);
+            const stepWithdrawnAmount = BigNumber.min(stepTargetRepaidAmount, stepMaxRepaidAmount)
                 .div(baseToBorrowExchangeRate)
                 .decimalPlaces(loopingDepositReserve.token.decimals, BigNumber.ROUND_DOWN);
             const isMaxWithdraw = stepWithdrawnAmount.eq(stepMaxWithdrawnAmount);
@@ -1606,6 +1675,14 @@ transaction, dryRunTransaction) => {
             // zero-amount quote — there's nothing meaningful left to unloop, so stop.
             if (stepWithdrawnAmount.lte(0))
                 break;
+            // The withdraw and the swap below go straight onto `transaction`, but only the
+            // repay is dry-run. When that dry run fails, the step's commands are already in
+            // the transaction — and the swap is usually what aborts — so every later dry run
+            // fails on that same command and the user ends up signing a transaction already
+            // known to fail. Snapshot the pre-step state so a failed step can be rolled back
+            // whole.
+            const transactionBeforeStep = Transaction.from(transaction);
+            const depositsBeforeStep = cloneDeep(deposits);
             const [stepWithdrawnCoin] = strategyWithdraw(strategyType, loopingDepositReserve.coinType, strategyOwnerCapId, suilendClient.findReserveArrayIndex(loopingDepositReserve.coinType), BigInt(new BigNumber(stepWithdrawnAmount
                 .times(10 ** loopingDepositReserve.token.decimals)
                 .integerValue(BigNumber.ROUND_DOWN)
@@ -1638,7 +1715,6 @@ transaction, dryRunTransaction) => {
             });
             if (!routers)
                 throw new Error("No swap quote found");
-            const slippagePercent = 1;
             let stepBorrowCoin;
             try {
                 stepBorrowCoin = (await cetusSdk.fixableRouterSwapV3({
@@ -1676,27 +1752,46 @@ transaction, dryRunTransaction) => {
                 stepRepaidAmount: stepRepaidAmount.toFixed(20),
                 isMaxRepay,
             }, null, 2));
+            let stepClearedDebt = false;
             try {
                 const txCopy = Transaction.from(transaction);
                 suilendClient.repay(obligationId, borrowReserve.coinType, stepBorrowCoin, txCopy);
                 txCopy.transferObjects([stepBorrowCoin], _address);
                 await dryRunTransaction(txCopy); // Throws error if fails
                 transaction = txCopy;
+                // 3.2) Update state
+                // A final step was sized to clear the debt even at the worst fill, and the
+                // repay clamps, so the target is reached exactly rather than by subtracting a
+                // figure the haircut has already made fictional.
+                borrowedAmount = isFinalStep
+                    ? targetBorrowedAmount
+                    : borrowedAmount.minus(stepRepaidAmount);
+                stepClearedDebt = isFinalStep;
             }
             catch (err) {
-                // Don't block user if fails
+                // The step cannot land — the swap's slippage check aborted, or the borrow is
+                // already gone (`EBorrowNotFound`). Roll the whole step back either way:
+                // keeping it would leave an aborting command in the transaction, so every
+                // later dry run would fail on that same command and the user would be asked
+                // to sign a transaction known to fail.
                 console.error(err);
-                transaction.transferObjects([stepBorrowCoin], _address);
+                transaction = transactionBeforeStep;
+                deposits = depositsBeforeStep;
+                break;
             }
-            // 3.2) Update state
-            borrowedAmount = borrowedAmount.minus(stepRepaidAmount);
             console.log(`[unloopStrategyToExposure] ${i} repay_borrows.update_state |`, JSON.stringify({
                 deposits: deposits.map((d) => ({
                     coinType: d.coinType,
                     depositedAmount: d.depositedAmount.toFixed(20),
                 })),
                 borrowedAmount: borrowedAmount.toFixed(20),
+                stepClearedDebt,
             }, null, 2));
+            // Nothing is owed above target any more. Returning here rather than looping
+            // again also skips `fullyRepayBorrowsUsingBase`, which would repay a borrow
+            // that no longer exists.
+            if (stepClearedDebt)
+                break;
         }
         else {
             throw new Error("No LST or base reserve found"); // Should not happen
@@ -1963,7 +2058,22 @@ lstMap, strategyType, suiGrpcClient, suilendClient, cetusSdk, cetusPartnerId, _a
     }
     // 2) Withdraw base or LST
     // 2.1) Withdraw
-    const [withdrawnCoin] = strategyWithdraw(strategyType, depositReserve.coinType, strategyOwnerCapId, suilendClient.findReserveArrayIndex(depositReserve.coinType), BigInt(new BigNumber(withdrawnAmount
+    // `withdrawnAmount` is priced off the pre-unloop position, but the unloop spends
+    // collateral to repay borrows and each step only counts `slippagePercent`% less
+    // than its quote towards the debt. The tracked debt therefore lags the real one,
+    // the loop unwinds further than it needs to, and what is left can be less than
+    // the amount the user asked for. Withdrawing the unclamped amount underflows
+    // `obligation::withdraw_unchecked` on-chain and fails the whole transaction, so
+    // clamp to what the position still holds.
+    const remainingDepositedAmount = deposits.find((d) => d.coinType === depositReserve.coinType)
+        ?.depositedAmount ?? new BigNumber(0);
+    const finalWithdrawnAmount = BigNumber.max(new BigNumber(0), BigNumber.min(withdrawnAmount, remainingDepositedAmount)).decimalPlaces(depositReserve.token.decimals, BigNumber.ROUND_DOWN);
+    console.log(`[withdraw] withdraw.clamp |`, JSON.stringify({
+        withdrawnAmount: withdrawnAmount.toFixed(20),
+        remainingDepositedAmount: remainingDepositedAmount.toFixed(20),
+        finalWithdrawnAmount: finalWithdrawnAmount.toFixed(20),
+    }, null, 2));
+    const [withdrawnCoin] = strategyWithdraw(strategyType, depositReserve.coinType, strategyOwnerCapId, suilendClient.findReserveArrayIndex(depositReserve.coinType), BigInt(new BigNumber(finalWithdrawnAmount
         .times(10 ** depositReserve.token.decimals)
         .integerValue(BigNumber.ROUND_DOWN)
         .toString())
@@ -1973,7 +2083,7 @@ lstMap, strategyType, suiGrpcClient, suilendClient, cetusSdk, cetusPartnerId, _a
     // 2.2) Update state
     deposits = addOrInsertStrategyDeposit(deposits, {
         coinType: depositReserve.coinType,
-        depositedAmount: withdrawnAmount.times(-1),
+        depositedAmount: finalWithdrawnAmount.times(-1),
     });
     const newExposure = getStrategyExposure(reserveMap, lstMap, strategyType, getStrategySimulatedObligation(reserveMap, lstMap, strategyType, deposits, borrowedAmount));
     const newTvlAmountUsd = getStrategyTvlAmount(reserveMap, lstMap, strategyType, getStrategySimulatedObligation(reserveMap, lstMap, strategyType, deposits, borrowedAmount)).times(defaultCurrencyReserve.price);
@@ -1998,7 +2108,7 @@ lstMap, strategyType, suiGrpcClient, suilendClient, cetusSdk, cetusPartnerId, _a
                 const routers = await cetusSdk.findRouters({
                     from: depositReserve.coinType,
                     target: withdraw.coinType,
-                    amount: new BN(withdrawnAmount
+                    amount: new BN(finalWithdrawnAmount
                         .times(10 ** depositReserve.token.decimals)
                         .integerValue(BigNumber.ROUND_DOWN)
                         .toString()),
@@ -2089,6 +2199,12 @@ lstMap, strategyType, suiGrpcClient, suilendClient, cetusSdk, cetusPartnerId, _a
         }, null, 2));
     }
     // 2) MAX withdraw base or LST
+    // The withdraw below takes every deposit, which the obligation only permits once
+    // the borrows are gone. The unloop stops early if a step cannot land, so check
+    // rather than build a transaction that is certain to abort on the health check —
+    // the caller can surface this instead of asking the user to sign it.
+    if (borrowedAmount.gt(STRATEGY_E))
+        throw new Error("Failed to repay borrows before withdrawing");
     const estimatedWithdrawnAmount = deposits.find((d) => d.coinType === depositReserve.coinType)
         ?.depositedAmount ?? new BigNumber(0);
     const [withdrawnCoin] = strategyWithdraw(strategyType, depositReserve.coinType, strategyOwnerCapId, suilendClient.findReserveArrayIndex(depositReserve.coinType), BigInt(MAX_U64.toString()), transaction);
@@ -2150,6 +2266,10 @@ lstMap, strategyType, suiGrpcClient, suilendClient, cetusSdk, cetusPartnerId, _a
     }
     // 4) Claim rewards and transfer to user
     if (hasClaimableRewards) {
+        // Claiming is a bonus, so a failure must not block the withdraw — but the calls
+        // are appended as they are built, so a throw part-way leaves half a claim behind
+        // that can abort the whole transaction. Roll back to before the claim instead.
+        const transactionBeforeClaim = Transaction.from(transaction);
         try {
             const mergedCoinsMap = strategyClaimRewardsAndMergeCoins(strategyType, rewardsMap, strategyOwnerCapId, transaction);
             for (const coin of Object.values(mergedCoinsMap)) {
@@ -2157,8 +2277,8 @@ lstMap, strategyType, suiGrpcClient, suilendClient, cetusSdk, cetusPartnerId, _a
             }
         }
         catch (err) {
-            // Don't block user if fails
             console.error(err);
+            transaction = transactionBeforeClaim;
         }
     }
     return { deposits, borrowedAmount, transaction };