@suffolklitlab/alkiln 5.12.0-delete6 → 5.13.0-logs1

package/lib/run_cucumber.js

@@ -1,9 +1,10 @@
 #!/usr/bin/env node
 
 const fs = require('fs');
+const path = require(`path`);
 const cucumber_api = require('@cucumber/cucumber/api');
 
-const log = require('./utils/log');  // These always log in the console
+const Log = require('./utils/log');
 const session_vars = require('./utils/session_vars');
 
 const SUMMARY_FILENAME = `cucumber-report.txt`;
@@ -53,11 +54,14 @@ function build_config( command_args ) {
 };  // Ends build_config()
 
 
-(async function main() {
+async function main() {
   /** Create the cucumber config, run the tests, create and
   *   manipluate the output. */
+
   const environment = { cwd: process.cwd() };
-  log.info({ type: `run`, code: `ALK0049`, pre: `environment`, data: environment });
+  log.info({ code: `ALK0049`, context: `pre_run environment` },
+    environment
+  );
 
   // We'll use the user info to construct the possible paths to /sources
   let id = session_vars.get_user_id();
@@ -65,8 +69,9 @@ function build_config( command_args ) {
   let project = session_vars.get_user_project_name();
 
   // process.argv is a list of strings of commands and args.
-  // If using `npm run cucumber`, use `--` before `--sources=./foo`
-  let argv = require(`minimist`)( process.argv.slice(2), {
+  // If using `npm run cucumber` (as opposed to the bin commands),
+  // use `--` before `--sources=./foo`
+  const argv = require(`minimist`)( process.argv.slice(2), {
     default: {
       sources: [
         `./docassemble/*/data/sources`,  // In GitHub folder
@@ -85,35 +90,45 @@ function build_config( command_args ) {
   let one_dir_exists = session_vars.set_sources_paths( sources_list );
   if ( !one_dir_exists ) {
     // If we don't throw, it'll be more confusing when no tests run
-    let msg = `ALKiln can't find your "sources" folder(s). See above for details.`;
-    let code = `ALK0050`
-    log.error({ type: `run`, code: code, pre: msg });
-    throw new ReferenceError(`🤕 ${ code } run ERROR: ${ msg }`);
+    log.throw({ code: `ALK0050`, context: `pre_run`,
+      error: new ReferenceError(
+        `ALKiln can't find your "sources" folder(s). See above for details.`
+      ),
+    });
   }
   
   const { runConfiguration } = await cucumber_api.loadConfiguration({
     provided: build_config( argv ),
   }, environment);
-
-  log.info({ type: `run`, code: `ALK0051`, pre: `runConfiguration`, data: runConfiguration });
-
-  var path = require(`path`);
-  var codeDir = path.dirname(require.main.filename);
-  log.info({ type: `run`, code: `ALK0052`, pre: `working directory`, data: codeDir });
+  log.info({ code: `ALK0051`, context: `pre_run config`, },
+    runConfiguration
+  );
+
+  const codeDir = path.dirname(require.main.filename);
+  log.info({ code: `ALK0052`, context: `pre_run directory`, },
+    codeDir, `\n\n`
+  );
   const support = await cucumber_api.loadSupport({ support: {
     requireModules: [ `${ codeDir }/index.js` ],
     requirePaths: [ `${ codeDir }/index.js` ],
     importPaths: [],
   }, sources: {paths: []}}, environment);
 
-  log.info({ type: `run`, code: `ALK0053`, pre: `working directory`, data: codeDir });
-  log.info({ type: `plain`, pre: `\n\n` });
-
+  // ====================
+  // Run
+  // ====================
   const { success } = await cucumber_api.runCucumber({...runConfiguration, support});
+  // ====================
+
   if ( success ) {
-    log.success({ type: `run`, code: `ALK0054`, pre: `Tests succeeded!` });
+    log.success({ code: `ALK0054`, context: `post_run`, },
+      `Tests succeeded!`
+    );
   } else {
-    log.error({ type: `run`, code: `ALK0055`, pre: `The test run ran into something unexpected. Look above for more details.` });
+    // Don't want to throw error here, so don't pass error object
+    log.warn({ code: `ALK0055`, context: `post_run`, },
+      `The tests ran into something unexpected. Look above for more details.`
+    );
   }
   // Custom exit code. May overlap with other systems.
   // Best info I've found via stack overflow: https://tldp.org/LDP/abs/html/exitcodes.html
@@ -123,31 +138,64 @@ function build_config( command_args ) {
   // This is hardcoded information from `provide_config` above.
   // This code isn't used for anything other than detecting and removing color codes.
   let summary_file_name = SUMMARY_FILENAME;
-  fs.readFile(summary_file_name, 'utf8', (err, text) => {
-    if (err) {
+  fs.readFile(summary_file_name, 'utf8', (read_error, text) => {
+    if ( read_error ) {
       // Something else will probably show an error that's more relevant
-      log.info({ type: `run`, code: `ALK0056`, pre: `Failed to read cucumber report`, data: err });
+      log.warn({ code: `ALK0056`, context: `post_run error`, },
+        `Failed to read cucumber report`, read_error
+      );
       return;
     }
 
     // Replace terminal color codes, if present
     // https://gist.github.com/fnky/458719343aabd01cfb17a3a4f7296797#colors--graphics-mode
     text = text.replace(/\x1b\[[0-9][0-9]?[0-9]?m/g, '');
-
-    // Put it in the correct file in the correct folder
-    let artifacts_path = session_vars.get_artifacts_path_name();
+    // Add to the debug file
     try {
-      fs.appendFileSync( `${ artifacts_path }/${ log.debug_log_file }`, `\n\n${text}`);
+      // fs.appendFileSync( `${ artifacts_path }/${ log.debug_log_file }`, `\n\n${text}`);
+      log.debug({ code: `ALK0216`, context: `post_run`, },
+        `\n\n`, text
+      );
     } catch ( error ) {
-      log.info({ type: `run`, code: `ALK0182`, pre: `Something probably went wrong earlier. Look above for more details, but here is more information just in case: ALKiln was unable to write to ${ artifacts_path }/${ log.debug_log_file }.`, data: error });
+      log.warn({ code: `ALK0182`, context: `post_run error`, },
+        `Something probably went wrong earlier. Look above for more details. Problem when writing to ${ log.path }/${ log.debug_log_filename }.`,
+        error
+      );
     }
+
+    // Add to the non-passed test output file
     try {
-      // Add to a unexpected results file when tests themselves fail
+      // Save only non-passing test output to cut out cruft.
+      // cucumber only outputs non-success details anyway.
+      // Our reports only non-passing tests to this file.
       if ( exitCode === 50 ) {
-        fs.appendFileSync( `${ artifacts_path }/${ log.unexpected_filename }`, `\n\n${ text }` );
+        // fs.appendFileSync( `${ log.path }/${ Log.unexpected_filename }`, `\n\n${ text }` );
+        log.unexpected({ text });
       }
-    } catch ( error ) {
-      log.info({ type: `run`, code: `ALK0181`, pre: `Something probably went wrong earlier. Look above for more details, but here is more information just in case: ALKiln was unable to write to ${ artifacts_path }/${ log.unexpected_filename }.`, data: error });
+    } catch ( unexpected_file_error ) {
+      console.warn(
+        `🔎 ALK0181 internal WARNING: Something probably went wrong earlier. Problem when writing to ${ log.path }/${ log.unexpected_filename }`,
+        unexpected_file_error
+      );
     }
+
+    return;
   });
-})();
+}
+
+
+// 1. session_vars - make sure all the required env vars exist
+session_vars.validateEnvironment();
+
+// 2. Prepare logs
+// process.argv is a list of strings of commands and args.
+// If using `npm run cucumber` (as opposed to the bin commands),
+// use `--` before `--sources=./foo`
+const argv = require(`minimist`)( process.argv.slice(2) );
+// The artifacts folder might be getting created for the first
+// time right here. The tests themselves should avoid creating
+// their own file.
+const log = new Log({ path: argv.path, context: `run` });
+
+// 3. run
+main();

package/lib/scope.js

@@ -13,14 +13,13 @@ const pdf_reader = require('./utils/pdf_reader');
 const session_vars = require('./utils/session_vars');
 const get_base_interview_url = require(`./docassemble/get_base_interview_url`);
 const time = require('./utils/time');
-const log = require('./utils/log');
+// const log = require('./utils/log');
 const { waitForTimeout } = require('./utils/time');
 const files = require('./utils/files' );
 const da_api = require('./docassemble/docassemble_api_interface');
 const wrapPromiseWithTimeout = require('./cucumber_8_shim');
 const reports = require(`./utils/reports`);
 
-
 let ordinal_to_integer = {
   only: 0, first: 0, second: 1, third: 2, fourth: 3, fifth: 4,
   sixth: 5, seventh: 6, eighth: 7, ninth: 8, tenth: 9,
@@ -84,10 +83,16 @@ let toBase64 = function ( utf8_str, exclude_padding=true) {
 
 let proxies_regex = /(\bx\.)|(\bx\[)|(\[[ijklmn]\])/g;
 let da_base64_regex = /^[A-Za-z0-9+/]+$/;
+let log = null;
 
 module.exports = {
   trigger_not_needed_flag: `ALKiln: no trigger variable needed`,
 
+
+  set_log: function ({ log_obj }) {
+    log = log_obj;
+  },
+
   getSafeScenarioBaseFilename: async function( scope, { scenario }) {
     /** Return a string that's safe to be a filename. Include the Scenario
     *    description and tags.
@@ -171,7 +176,7 @@ module.exports = {
     // If something might be hidden or shown, wait extra time to let it hide or show
     // I think `.$()` does not use a timeout
     let showif = await scope.page.$('.dashowif');
-    if ( showif ) { await scope.page.waitForTimeout( scope.showif_timeout ); }
+    if ( showif ) { await time.waitForTimeout( scope.showif_timeout ); }
   },
 
   waitForTab: async function waitForTab(scope, { tab_id }) {
@@ -288,9 +293,7 @@ module.exports = {
     /** Tap a given element, detect navigation, and do appropriate related things.
     *  `click_promise can be any kind of Promise, including a Promise.all()
     */
-    let msg = `Cannot find the element to tap.`;
-    if ( !elem ) { reports.addToReport(scope, { type: `error`, code: `ALK0102`, value: msg }); }
-    expect( elem, msg ).to.exist;
+    await scope.guard_against_missing_tap_element(scope, { elem });
 
     // Get the text on the button or link for a potential error message later
     let tapperText = await (await elem.getProperty('textContent')).jsonValue();
@@ -326,6 +329,14 @@ module.exports = {
     }  // ends try/catch
   },  // Ends scope.tapElementAndStayOnPage()
 
+  guard_against_missing_tap_element: async function(scope, { elem }) {
+    /** Handle the error message for a missing tap element, if it's missing. */
+    let msg = `Cannot find the element to tap.`;
+    if ( !elem ) { reports.addToReport(scope, { type: `error`, code: `ALK0102`, value: msg }); }
+    expect( elem, msg ).to.exist;
+    return elem;
+  },
+
   // Handle server reload errors
   server_statuses: [],
   server_check_interval_ms: 1 * 1000,
@@ -501,7 +512,7 @@ module.exports = {
     if ( diff <= 0 ) { return false; }
 
     // If time hasn't expired, wait and then check again
-    await scope.page.waitForTimeout( 100 );
+    await time.waitForTimeout( 100 );
     await scope.detectDownloadComplete(scope, endTime);
 
     return false;
@@ -686,7 +697,7 @@ module.exports = {
       });
       expect( load_result.error ).to.equal( '' );
     } else {
-      reports.addToReport(scope, { type: `row info`, code: `ALK0117`, value: `Successfully found the interview at "${ interview_url }"` });
+      reports.addToReport(scope, { type: `row info`, code: `ALK0117`, value: `Successfully found the interview` });
     }
 
     return scope.page;
@@ -705,19 +716,19 @@ module.exports = {
       if ( !scenario.interviews ) { scenario.interviews = {}; }
       if ( !scenario.interviews[ vars.uid ] ) {
         scenario.interviews[ vars.uid ] = vars;
-        log.debug({
-          code: `ALK0185`, type: `info`,
-          pre: `Saved new interview data. File path: ${ vars.i }. Session id: ${ vars.uid }.`
-        });
+        log.debug({ code: `ALK0185`, context: `session_id_etc` },
+          `Saved new interview data. File path: ${ vars.i }. Session id: ${ vars.uid }.`
+        );
       } else {
-        log.debug({
-          code: `ALK0186`, type: `info`,
-          pre: `Interview data already existed. File path: ${ vars.i }. Session id: ${ vars.uid }.`
-        });
+        log.debug({ code: `ALK0186`, context: `session_id_etc` },
+          `Interview data already existed. File path: ${ vars.i }. Session id: ${ vars.uid }.`
+        );
       }
       return vars;
     } else {
-      log.debug({ code: `ALK0187`, type: `info`, pre: `Found no interview data.` });
+      log.debug({ code: `ALK0187`, context: `session_id_etc` },
+        `Found no interview data.`
+      );
       return null;
     }
   },  // Ends scope.set_interview_session_data()
@@ -864,11 +875,9 @@ module.exports = {
       supported_table.push( result );
     }  // ends for every row
 
-    log.debug({
-      code: `ALK0122`,
-      type: `info`,
-      pre: `scope.normalizedTable():\n ${JSON.stringify( supported_table )}`
-    });
+    log.debug({ code: `ALK0122`, context: `table`, },
+      `scope.normalizedTable():`, supported_table
+    );
 
     return supported_table;
   },  // Ends scope.normalizeTable()
@@ -1018,11 +1027,9 @@ module.exports = {
       fields.push( field_data );
     }  // ends for every node
 
-    log.debug({
-      code: `ALK0124`,
-      type: `info`,
-      pre: `page fields:\n${ JSON.stringify( fields )}`
-    });
+    log.debug({ code: `ALK0124`, context: `page fields`, },
+      fields
+    );
     return fields;
   },  // Ends scope.getAllFields()
 
@@ -1072,11 +1079,9 @@ module.exports = {
     /* Return variable names and values combined in ways that can
     * try to match table rows. Tables can have two properties:
     * variable name and value. */
-    log.debug({
-      code: `ALK0126`,
-      type: `info`,
-      pre: `scope.getPossibleTableRowMatchers() var_names: ${JSON.stringify(var_names)} values: ${JSON.stringify(values)}`
-    });
+    log.debug({ code: `ALK0126`, context: `matching`, },
+      `scope.getPossibleTableRowMatchers() var_names:`, var_names, `values:`, values
+    );
     let possible_table_rows = [];
     for ( let var_name of var_names ) {
       // Inputs like textareas don't have values
@@ -1551,17 +1556,13 @@ module.exports = {
       reports.addToReport(scope, { type: `warning`, code: `ALK0130`, value: multiple_matches_msg });
     }
 
-    log.debug({
-      code: `ALK0131`,
-      type: `info`,
-      pre: `final_matching_rows:\n${JSON.stringify( final_matching_rows )}`
-    });
+    log.debug({ code: `ALK0131`, context: `matching`, },
+      `final_matching_rows:`, final_matching_rows
+    );
     if ( final_matching_rows.length == 0) {
-      log.debug({
-        code: `ALK0132`,
-        type: `info`,
-        pre: `field:\n${JSON.stringify( field )}`
-      });
+      log.debug({ code: `ALK0132`, context: `matching`, },
+        `0 matching rows. Field:`, field
+      );
     }
 
     return final_matching_rows;
@@ -1627,7 +1628,7 @@ module.exports = {
         catch(err){ elem.style.background = 'Khaki'; }
         return elem.getAttribute('for') || elem.getAttribute('name'); 
       });
-      await scope.page.waitForTimeout( 400 );
+      await time.waitForTimeout( 400 );
     }
 
     // We use the last match. We wrote a warning for the user if there were
@@ -1647,11 +1648,9 @@ module.exports = {
 
   get_handle_from_field: async function ( scope, { field }) {
     /** Get the element's puppeteer handle using the field's selector. */
-    log.debug({
-      code: `ALK0133`,
-      type: `info`,
-      pre: `scope.get_handle_from_field() field.selector: ${JSON.stringify(field.selector)}`
-    });
+    log.debug({ code: `ALK0133`, },
+      `scope.get_handle_from_field() field.selector:`, field.selector
+    );
     let handle = await scope.page.evaluateHandle(( selector ) => {
       let elem = document.querySelector( selector );
       // If the element has a sibling that's a label, we need to
@@ -1850,7 +1849,7 @@ module.exports = {
       });
       if ( type === `radio` || type === `checkbox` ) {
 
-        let [label] = await handle.$x(`following-sibling::label`);
+        let [label] = await handle.$$(`xpath/.//following-sibling::label`);
         
         if ( session_vars.get_debug() ) {
           if ( answer.toLowerCase() === 'false' ) { await label.evaluate( elem => { elem.style.background = 'tomato'; }); }
@@ -2163,7 +2162,9 @@ module.exports = {
     * @param ensure_all_vars_used {bool} [false] = Default false. If true, errors if any
     *     object in var_data is not used during running of this function.
     */
-    log.debug({ type: `plain`, pre: `~~~~~~~~~~~~~~ scope.setFields() ~~~~~~~~~~~~~~` });
+    log.debug({ code: `ALK0221`, before: `~~~~~~~~~~~~~~\n`, },
+      `scope.setFields()`
+    );
 
     // Only record the page id once for each page to which we navigate
     let { id } = await scope.examinePageID( scope, 'none to match' );
@@ -2207,13 +2208,12 @@ module.exports = {
           // Accumulate number of times this row was used. Esp important for `.target_number`
           await scope.increment_row_use( scope, { row: row_used });
 
-          process.stdout.write(`\x1b[36m${ '*' }\x1b[0m`);  // assumes var was set if no error occurred
-
+          log.stdout({}, `\x1b[36m${ '*' }\x1b[0m`);  // assumes var was set if no error occurred
         }
       }  // ends for every non-submit-button field on the page
     }  // ends while fields are still being set
 
-    if ( session_vars.get_debug() ) { await scope.page.waitForTimeout(2000); }
+    if ( session_vars.get_debug() ) { await time.waitForTimeout(2000); }
 
     // Press a continue button with a story table variable name if it exists
     let did_navigate = false;
@@ -2253,7 +2253,7 @@ module.exports = {
           // }
 
           did_navigate = true;
-          process.stdout.write(`\x1b[36m${ 'v' }\x1b[0m`);  // pressed button successfully
+          log.stdout({}, `\x1b[36m${ 'v' }\x1b[0m`);  // pressed button successfully
           break;
 
         }  // ends if row_used
@@ -2300,7 +2300,7 @@ module.exports = {
       // }
 
       did_navigate = true;
-      process.stdout.write(`\x1b[36m${ '>' }\x1b[0m`);  // continued successfully
+      log.stdout({}, `\x1b[36m${ '>' }\x1b[0m`);  // continued successfully
     }  // ends if !did_navigate && ensure_navigation
 
     if ( did_navigate && scope.check_all_for_a11y ) {
@@ -2561,7 +2561,7 @@ module.exports = {
 
     // Attempt to solve weird race condition issues where page has not properly continued
     while ( curr_url === prev_url && !error.was_found && !timedOut ) {
-      await scope.page.waitForTimeout( 50 );
+      await time.waitForTimeout( 50 );
       curr_url = await scope.page.url();
       error = await scope.checkForError( scope );
     }
@@ -2582,10 +2582,10 @@ module.exports = {
 
     // All results are lists to match `$x`
     let possible_errors = {
-      complex_user_error: await scope.page.$$('.alert-danger'),
+      complex_user_error: await scope.page.$$(`.alert-danger`),
       // The below does not work if there's not a space between ':' and 'none'
-      simple_user_error: await scope.page.$x(`//*[contains(@class, "da-has-error")][not(contains(@style,"display: none"))]`),
-      system_error: await scope.page.$x( '//meta[@content="docassemble: Error"]' ),
+      simple_user_error: await scope.page.$$(`xpath/.//*[contains(@class, "da-has-error")][not(contains(@style,"display: none"))]`),
+      system_error: await scope.page.$$(`xpath/.//meta[@content="docassemble: Error"]` ),
     };
 
     let error_handlers = {};
@@ -2597,7 +2597,7 @@ module.exports = {
         // Also, if you're debugging and you close the window early, the process will still
         // take this long to exit after the tests finish. Not sure how to account for that.
         if ( session_vars.get_debug() ) {
-          await scope.page.waitForTimeout( ( scope.timeout - (1 * 1000)) );
+          await time.waitForTimeout( ( scope.timeout - (1 * 1000)) );
         }
         was_found = true;
         error_handlers[ error_key ] = possible_errors[ error_key ][0];
@@ -2702,7 +2702,7 @@ module.exports = {
     },  // Ends scope.steps.add_json_vars_to_report()
 
     link_works: async ( scope, linkText ) => {
-      let [link] = await scope.page.$x(`//a[contains(text(), "${ linkText }")]`);
+      let [link] = await scope.page.$$(`xpath/.//a[contains(text(), "${ linkText }")]`);
       let prop_obj = await link.getProperty( 'href' );
       let actual_url = await prop_obj.jsonValue();
 
@@ -2760,13 +2760,13 @@ module.exports = {
       /** Tap a link that doesn't navigate. Depends on the language of the text.
        *  TODO: This may be broken at this point.
        * */
-      const [link] = await scope.page.$x(`//a[contains(text(), "${phrase}")]`);
+      const [link] = await scope.page.$$(`xpath/.//a[contains(text(), "${phrase}")]`);
 
       let msg = `The term "${ phrase }" seems to be missing.`;
       if ( !link ) { reports.addToReport(scope, { type: `error`, code: `ALK0151`, value: msg }); }
       expect( link, msg ).to.exist;
       await scope.tapElementAndStayOnPage(scope, { elem: link });
-      await scope.page.waitForTimeout(10000);
+      await time.waitForTimeout(10000);
     },  // Ends scope.steps.tap_term()
 
     sign: async ( scope, name ) => {
@@ -2785,7 +2785,7 @@ module.exports = {
       * TODO: Properly wait for download to complete. See notes in
       * scope.js scope.detectDownloadComplete()
       */
-      let [elem] = await scope.page.$x(`//a[contains(@href, "${ filename }")]`);
+      let [elem] = await scope.page.$$(`xpath/.//a[contains(@href, "${ filename }")]`);
 
       let msg = `"${ filename }" seems to be missing. Cannot find a link to that document.`;
       if ( !elem ) { reports.addToReport(scope, { type: `error`, code: `ALK0152`, value: msg }); }
@@ -3017,20 +3017,94 @@ module.exports = {
       expect( email, email_msg ).to.not.equal( undefined );
       expect( password, password_msg ).to.not.equal( undefined );
 
-      // Try to log in
+      // Try to enter the information
       await scope.page.type( `#email`, email );
       await scope.page.type( `#password`, password );
-      let elem = await scope.page.$( `button[name="submit"]` );
-      await scope.tapElementAndNavigate( scope, { elem });
+      let elem = await scope.page.$( `button[type="submit"]` );
+      await scope.guard_against_missing_tap_element(scope, { elem });
 
-      reports.addToReport( scope, {
-        type: `row info`,
-        code: `ALK0163`,
-        value: `Signed into ${ session_vars.get_da_server_url() }/user/sign-in successfully.`
+      // Submit and see what happens
+      let winner = await scope.steps.race_sign_in_navigation( scope, { elem });
+      // Add the result to the report and possibly throw errors
+      if ( winner[0] === `success` ) {
+        reports.addToReport( scope, {
+          type: `row info`, code: `ALK0163`,
+          value: `Successfully signed into ${ login_url }`
+        });
+        await scope.afterStep(scope, {waitForShowIf: false});
+      } else if ( winner[0] === `failure` ) {
+        let error_msg = reports.addToReport( scope, {
+          type: `error`, code: `ALK0209`,
+          value: `Failed to sign into ${ login_url }. Make sure you followed the instructions at https://assemblyline.suffolklitlab.org/docs/alkiln/writing/#sign-in.`
+        });
+        throw new Error( error_msg );
+      } else if ( winner[0] === `error` ) {
+        let error_msg = reports.addToReport( scope, {
+          type: `error`, code: `ALK0210`,
+          value: `Error on sign in page at ${ login_url }. Try this by hand and then run the test again.`
+        });
+        throw new Error( error_msg );
+      }
+    },  // Ends scope.steps.sign_in()
+
+    race_sign_in_navigation: async function ( scope, { elem }) {
+      /** Wait for sign in navigation success or failure, or system error. */
+
+      // After everything, clean up incomplete promises
+      const controller = new AbortController;
+
+      // Redirect
+      let redirect_promise = scope.page.waitForResponse(function ( response ) {
+        return response.status() === 302;
+      }, { signal: controller.signal })
+      .catch(( catch_info ) => {
+        log.debug({ code: `ALK0204`, context: `nav`, },
+          `302 sign-in wait catch error:`, catch_info.name, catch_info,
+        );
       });
 
-      await scope.afterStep(scope, {waitForShowIf: false});
-    },  // Ends scope.steps.sign_in()
+      // Invalid credentials, no navigation, no sign in
+      let wrong_sign_in_promise = scope.page.waitForResponse(function ( response ) {
+        return response.status() >= 200 && response.status() < 300 && response.url().includes(`/sign-in`);
+      }, { signal: controller.signal })
+      .catch(( catch_info ) => {
+        log.debug({ code: `ALK0205`, context: `nav`, },
+          `200s sign-in wait catch error:`, catch_info.name, catch_info,
+        );
+      });
+
+      // System error
+      let error_promise = scope.page.waitForResponse(function ( response ) {
+        return response.status() >= 500 && response.status() < 600;
+      }, { signal: controller.signal })
+      .catch(( catch_info ) => {
+        log.debug({ code: `ALK0206`, context: `nav`, },
+          `500s sign-in wait catch error:`, catch_info.name, catch_info,
+        );
+      });
+
+      let click_promise = elem.click();  // MUST complete
+      const winner = await Promise.race([
+        Promise.all([ `success`, click_promise, redirect_promise ]),
+        Promise.all([ `failure`, click_promise, wrong_sign_in_promise ]),
+        Promise.all([ `error`, click_promise, error_promise ]),
+      ]).catch(function ( error ) {
+        let error_msg = reports.addToReport( scope, {
+          type: `error`, code: `ALK0207`,
+          value: `Unknown error waiting for results during sign in at ${ login_url }.`
+        });
+        throw new Error( error );
+      });
+
+      // Clean up unresolved promises
+      controller.abort();
+
+      log.debug({ code: `ALK0208`, context: `nav` },
+        `Sign-in winner:`, winner
+      );
+
+      return winner;
+    },
 
     set_random_page_vars: async ( scope ) => {
       /** Answer inputs randomly. */
@@ -3050,7 +3124,7 @@ module.exports = {
         } else {
           // Try to give a random answer for that element tag
           await scope.set_random_input_for[ field.tag ]( scope, { field: field });
-          process.stdout.write(`\x1b[36m${ '*' }\x1b[0m`);  // assumes var was set if no error occurred
+          log.stdout({}, `\x1b[36m${ '*' }\x1b[0m`);  // assumes var was set if no error occurred
         }
 
       }  // End for all page fields
@@ -3086,11 +3160,10 @@ module.exports = {
       }
       if (field == null) {
         // Just skip it? Shouldn't happen but has before. Dig in more
-        log.debug({
-          code: `ALK0164`,
-          type: `info`,
-          pre: `A random button field choice was null. These were the fields to choose from:\n${ JSON.stringify(fields, null, 2) }`,
-        });
+        log.debug({ code: `ALK0164`, context: `random`, },
+          `A random button field choice was null. These were the fields to choose from:`,
+          fields
+        );
         return;
       }
       let handle = await scope.get_handle_from_field( scope, { field: field });