@suffolklitlab/alkiln 5.10.1 → 5.10.3

package/CHANGELOG.md

@@ -45,6 +45,22 @@ Format:
 
 <!-- ## [Unreleased] -->
 
+## [5.10.3] - 2024-03-23
+
+### Fixed
+
+- Fixes undefined var name when setting long text or ajax combobox value
+
+### Internal
+
+- Removes test for text on error pages. That keeps changing every now and then. It would be nice to test that we're catching some text, which we can't do right now. Maybe we should be broader with where we get the text since authors can also change the DOM. At least there are screenshots when possible.
+
+## [5.10.2] - 2024-02-29
+
+### Fixed
+
+- Fixed dates only being part-way filled.
+
 ## [5.10.1] - 2024-02-23
 
 ### Changed

package/lib/scope.js

@@ -1796,6 +1796,7 @@ module.exports = {
         await scope.setText( scope, { handle, answer: answer_date });
         await handle.press(`Tab`);
         await scope.afterStep(scope, { waitForShowIf: true });
+        
       } else if (type == `time`) {
         // Authors should enter the time like 12:34 PM, but we shouldn't type ":", space, or M.
         let answer_time = answer.replace(":", "").replace(" ", "").replace("M", "");
@@ -1864,7 +1865,6 @@ module.exports = {
                      valid_date.getDate().toString().padStart(2, 0) + '/' +
                      valid_date.getFullYear().toString());
     }
-
     return valid_date;
   },  // Ends scope.today_to_date()
 
@@ -1975,17 +1975,34 @@ module.exports = {
   },  // Ends scope.setCheckbox()
 
   setText: async function ( scope, { handle, answer }) {
-    // Set text in some kind of field (input text, input date, textarea, etc.)
-    // First set the value to part of the string
-    const to_set = answer.slice(0, -3);
-    const to_type = answer.slice(-3);
-    await handle.evaluate(( elem, text ) => {
-      elem.value = text;
-    }, to_set );
-    // Then type the last three characters of the string with a
-    // good pause to let the field register the interaction
+    /** Set text in some kind of field (input text, input date, textarea, etc.) */
+    const typing_cutoff = 300;
+    const slice_value = -3;
+
+    let is_ajax = await handle.evaluate(( elem, text, typing_cutoff, slice_value ) => {
+      // For long strings or ajax comboboxes, set the value of the field to
+      // most of the text. This will be faster in those cases.
+      is_ajax = elem.className.includes(`da-ajax-combobox`);
+
+      if ( is_ajax || text.length > typing_cutoff ) {
+        elem.value = text.slice(0, slice_value);  // .slice(0, -3)
+      }
+
+      return is_ajax;
+    }, answer, typing_cutoff, slice_value );
+
+    // Interact like a "human" in all cases.
     await handle.focus();
-    await handle.type( to_type, { delay: 100 });
+
+    // For long strings or ajax comboboxes, where we have set most of the text
+    // already, add a good pause for the field to detect the interaction.
+    if ( is_ajax || answer.length > typing_cutoff ) {
+      const to_type = answer.slice( slice_value );  // .slice(-3)
+      await handle.type( to_type, { delay: 100 });
+    } else {
+      // Otherwise type the whole string with 0 delay
+      await handle.type( answer );
+    }
   },
 
   draw_signature: async function ( scope, name ) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@suffolklitlab/alkiln",
-  "version": "5.10.1",
+  "version": "5.10.3",
   "description": "Integrated automated end-to-end testing with docassemble, puppeteer, and cucumber.",
   "main": "lib/index.js",
   "scripts": {