@suffolklitlab/alkiln 5.0.2 → 5.1.0

package/CHANGELOG.md

@@ -37,9 +37,19 @@ Format:
 
 ### Security
 - 
+
+### Internal
+- 
 -->
 <!-- ## [Unreleased] -->
 
+## [5.1.0] - 2023-08-12
+### Added
+- Comboboxes - can now fill in comboboxes on the latest Docassemble.
+
+### Fixed
+- Filling out a hidden field right after a date field triggered the date's calendar popup, which I believe ate the input for the next visible field.
+
 ## [5.0.2] - 2023-07-20
 ### Fixed
 - Accept `SERVER_RELOAD_TIMEOUT_SECONDS` as an env var input in GitHub.
@@ -89,6 +99,10 @@ Format:
     server
 - Update dependencies. See [#727](https://github.com/SuffolkLITLab/ALKiln/pull/727).
 
+### Internal
+- added a test for multiline json values (only ones set by code not by user input)
+- added an internal section to the change log
+
 ## [4.11.1] - 2023-03-21
 ### Changed
 - Get error data from server errors

package/action.yml

@@ -5,15 +5,6 @@ inputs:
   SERVER_URL:
     description: 'The url of your docassemble server. This should be in your GitHub SECRETS or the SECRETS of your org.'
     required: true
-  PLAYGROUND_EMAIL:
-    description: 'The email of your docassemble testing account. This should be in your GitHub SECRETS or the SECRETS of your org.'
-    required: true
-  PLAYGROUND_PASSWORD:
-    description: 'The password of your docassemble testing account. This should be in your GitHub SECRETS or the SECRETS of your org.'
-    required: true
-  PLAYGROUND_ID:
-    description: 'The id of your docassemble testing account. This should be in your GitHub SECRETS or the SECRETS of your org.'
-    required: true
   DOCASSEMBLE_DEVELOPER_API_KEY:
     description: 'API key of the testing account with developer permissions on your docassemble server.'
     required: true
@@ -45,9 +36,6 @@ runs:
         echo "REPO_URL=${{ github.server_url }}/${{ github.repository }}" >> $GITHUB_ENV
         echo "BRANCH_PATH=${{ github.ref }}" >> $GITHUB_ENV
         echo "BASE_URL=${{ inputs.SERVER_URL }}" >> $GITHUB_ENV
-        echo "PLAYGROUND_EMAIL=${{ inputs.PLAYGROUND_EMAIL }}" >> $GITHUB_ENV
-        echo "PLAYGROUND_PASSWORD=${{ inputs.PLAYGROUND_PASSWORD }}" >> $GITHUB_ENV
-        echo "PLAYGROUND_ID=${{ inputs.PLAYGROUND_ID }}" >> $GITHUB_ENV
         echo "DOCASSEMBLE_DEVELOPER_API_KEY=${{ inputs.DOCASSEMBLE_DEVELOPER_API_KEY }}" >> $GITHUB_ENV
         echo "ALKILN_VERSION=${{ inputs.ALKILN_VERSION }}" >> $GITHUB_ENV
         echo "MAX_SECONDS_FOR_SETUP=${{ inputs.MAX_SECONDS_FOR_SETUP }}" >> $GITHUB_ENV

package/lib/scope.js

@@ -998,6 +998,11 @@ module.exports = {
         }
       }
 
+      if ( !encoded_name ) {
+        // Some fields, like comboboxes, have a weird var name setup
+        encoded_name = $node.attr( `id` );
+      }
+
       // ====================
       // Table rows
       // ====================
@@ -1472,6 +1477,11 @@ module.exports = {
    */
     let row_used = null;
 
+    // Skip hidden fields right away. When a date field was above a combobox,
+    // interacting with the hidden field caused the date field to open its
+    // calendar which blocked input to the combobox
+    if ( field.type === `hidden` ) { return row_used; }
+
     let matching_input_rows = await scope.getMatchingRows( scope, { var_data, field });
 
     // Nothing to set if there are no matching table rows
@@ -1486,6 +1496,8 @@ module.exports = {
 
     let handle = await scope.get_handle_from_field( scope, { field: field });
 
+    // After each previous input, figure out if this input is (now/still) disabled
+    // TODO: Consider testing for disabled this before we get the matching row
     let disabled = await handle.evaluate(( elem )=> {
       // da's header covers the top of the section containing the fields which means
       // sometimes it blocks nodes from clicks. Scroll item to the bottom instead.
@@ -1888,8 +1900,6 @@ module.exports = {
     await handle.evaluate( el => { el.value = '' });
     await handle.focus();
     await handle.type( answer );
-    setTimeout(async () => {
-    }, 500)
   },
 
   draw_signature: async function ( scope, name ) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@suffolklitlab/alkiln",
-  "version": "5.0.2",
+  "version": "5.1.0",
   "description": "Integrated automated end-to-end testing with docassemble, puppeteer, and cucumber.",
   "main": "lib/index.js",
   "scripts": {