@suffolklitlab/alkiln 4.6.1 → 4.7.1

package/tests/features/random_input.feature

@@ -0,0 +1,31 @@
+@random_input
+Feature: Assembly Line package-specific Steps
+
+# In tag names, 'ri' is for 'random input'
+
+@fast @ri1 @random
+Scenario: I fill in random input till the end
+  Given I start the interview at "test_random_input"
+  And I answer randomly for at most 20 pages
+  Then the question id should be "end"
+
+@fast @ri2 @random
+Scenario: I fill in random input for 1 page
+  Given I start the interview at "test_random_input"
+  And I answer randomly for at most 1 page
+
+# Should create two unique folders for random step screenshots which
+# must be checked manually
+@fast @ri3 @random
+Scenario: I answer randomly till the end twice
+  Given I start the interview at "test_random_input"
+  And I answer randomly for at most 50 pages
+  Given I start the interview at "test_random_input"
+  And I answer randomly for at most 50 pages
+
+@fast @ri4 @random @error
+Scenario: Fail with error page from random input
+  Given the final Scenario status should be "failed"
+  Given I start the interview at "test_missing_var_error_screen"
+  And the max seconds for each step in this scenario is 10
+  And I answer randomly for at most 3 pages

package/tests/features/story_table_formats.feature

@@ -3,7 +3,6 @@ Feature: Supported story table formats
 
 NOTE:
     Unsupported formats:
-    - Arrays (see https://github.com/plocket/docassemble-cucumber/issues/257)
     - Format 1 and 2 tables (permanent) (see https://github.com/plocket/docassemble-cucumber/issues/264)
 
 NOTE:
@@ -75,3 +74,52 @@ Scenario: Table MISSING trigger column
     | single_quote_dict['single_quote_key']['sq_two'] | true |
     | text_input | Regular text input field value |
     | textarea | Multiline text\narea value |
+
+@fast @stf5
+Scenario: Table has no header row, has trigger column
+  Given I start the interview at "all_tests"
+  And I get to "showifs" with this data:
+    | double_quote_dict["double_quote_key"]['dq_two'] | true |  |
+    | checkboxes_other['checkbox_other_opt_1'] | true |  |
+    | checkboxes_other['checkbox_other_opt_2'] | true |  |
+    | checkboxes_other['checkbox_other_opt_3'] | false |  |
+    | checkboxes_yesno | True |  |
+    | dropdown_test | dropdown_opt_2 |  |
+    | radio_other | radio_other_opt_3 |  |
+    | radio_yesno | False |  |
+    | single_quote_dict['single_quote_key']['sq_two'] | true |  |
+    | text_input | Regular text input field value |  |
+    | textarea | Multiline text\narea value |  |
+
+@fast @stf6
+Scenario: Table has no header row, MISSING trigger column
+  Given I start the interview at "all_tests"
+  And I get to "showifs" with this data:
+    | double_quote_dict["double_quote_key"]['dq_two'] | true |
+    | checkboxes_other['checkbox_other_opt_2'] | true |
+    | checkboxes_yesno | True |
+    | dropdown_test | dropdown_opt_2 |
+    | radio_other | radio_other_opt_3 |
+    | radio_yesno | False |
+    | single_quote_dict['single_quote_key']['sq_two'] | true |
+    | text_input | Regular text input field value |
+    | textarea | Multiline text\narea value |
+
+@fast @stf7
+Scenario: Fails when table has no header row and rows have only one column
+  Given the final Scenario status should be "failed"
+  And the Scenario report should include:
+  """
+  Your Story Table definition needs to be changed.
+  """
+  Given I start the interview at "all_tests"
+  And I get to "showifs" with this data:
+    | double_quote_dict["double_quote_key"]['dq_two'] |
+    | checkboxes_other['checkbox_other_opt_2'] |
+    | checkboxes_yesno |
+    | dropdown_test |
+    | radio_other |
+    | radio_yesno |
+    | single_quote_dict['single_quote_key']['sq_two'] |
+    | text_input |
+    | textarea |

package/tests/unit_tests/getSafeScenarioBaseFilename.fixtures.js

@@ -1,8 +1,6 @@
 let names = {};
 
 names.with_spaces = `a tests description`;
-names.tag1 = `tag1`;
-names.tag2 = `tag2`;
 
 names.non_english_chars = `是汉字`;
 

package/tests/unit_tests/getSafeScenarioBaseFilename.test.js

@@ -6,14 +6,11 @@ const scope = require(`../../lib/scope.js`);
 const getSafeScenarioBaseFilename = scope.getSafeScenarioBaseFilename;
 
 
-let mock_scenario = function ( description, tag_names=[] ) {
+let mock_scenario = function ( description ) {
   /** Mock the complex structure of a Scenario object */
   let scenario = {
-    pickle: { name: description, tags: [], }
+    pickle: { name: description }
   };
-  for ( let tag of tag_names ) {
-    scenario.pickle.tags.push({ name: tag });
-  }
   return scenario;
 };  // Ends mock_scenario();
 
@@ -23,39 +20,31 @@ describe(`When I use scope.getSafeScenarioBaseFilename()`, function() {
     scope.language = undefined;
   });
 
-  // No language, no tags
+  // No language
   it(`preserves spaces`, async function() {
-    let scenario = mock_scenario( names.with_spaces, [] );
+    let scenario = mock_scenario( names.with_spaces );
     let result = await getSafeScenarioBaseFilename( scope, { scenario });
     expect( result ).to.equal( names.with_spaces );
   });
 
   it(`preserves non-english characters`, async function() {
-    let scenario = mock_scenario( names.non_english_chars, [] );
+    let scenario = mock_scenario( names.non_english_chars );
     let result = await getSafeScenarioBaseFilename( scope, { scenario });
     expect( result ).to.equal( names.non_english_chars );
   });
 
   it(`replaces invalid characters with "_"`, async function() {
-    let scenario = mock_scenario( names.colon_input, [] );
+    let scenario = mock_scenario( names.colon_input );
     let result = await getSafeScenarioBaseFilename( scope, { scenario });
     expect( result ).to.equal( names.colon_output );
   });
 
-  // language, 1 tag
-  it(`adds a language and 1 tag correctly, preserving numbers`, async function() {
+  // language
+  it(`adds a language correctly to a description`, async function() {
     scope.language = names.non_english_chars;
-    let scenario = mock_scenario( names.with_spaces, [ names.tag1 ] );
+    let scenario = mock_scenario( names.with_spaces );
     let result = await getSafeScenarioBaseFilename( scope, { scenario });
-    let expected = `${ names.non_english_chars }-${ names.with_spaces }-${ names.tag1 }`;
-    expect( result ).to.equal( expected );
-  });
-
-  // 2 tags
-  it(`adds 2 tags correctly, preserving numbers`, async function() {
-    let scenario = mock_scenario( names.with_spaces, [ names.tag1, names.tag2 ] );
-    let result = await getSafeScenarioBaseFilename( scope, { scenario });
-    let expected = `${ names.with_spaces }-${ names.tag1 }-${ names.tag2 }`;
+    let expected = `${ names.non_english_chars }-${ names.with_spaces }`;
     expect( result ).to.equal( expected );
   });
 

package/tests/unit_tests/getSafeScenarioFilename.test.js

@@ -8,9 +8,12 @@
  
  
 let test_filename = function ( expected_prefix, result ) {
-   /* Test a name to see if it's valid output with a language defined. */
-  let expected_name_regex_str = `^${ expected_prefix }\\d{13}-${ names.base_filename }$`;
-   let regex = new RegExp( expected_name_regex_str );
+  /* Test a name to see if it's valid output with a language defined. */
+  let expected_name_regex_str = `^${ expected_prefix }-${ names.base_filename }-\.{37}$`;
+  if ( expected_prefix == `` ) {
+   expected_name_regex_str = `^${ names.base_filename }-\.{37}$`;
+  }
+  let regex = new RegExp( expected_name_regex_str );
  
   // Log more info if it failed
   let found_match = regex.test( result );

package/tests/unit_tests/names.fixtures.js

@@ -3,16 +3,16 @@ let names = {};
 names.base_filename = `a_safe_id`;
 
 names.chinese_input = `是汉字`;
-names.chinese_output = `是汉字_`;
+names.chinese_output = `是汉字`;
 
 names.no_underscore_input = `ends_in_no_underscore`;
-names.no_underscore_output = `ends_in_no_underscore_`;
+names.no_underscore_output = `ends_in_no_underscore`;
 
 names.one_underscore_input = `ends_in_one_underscore_`;
-names.one_underscore_output = `ends_in_one_underscore__`;
+names.one_underscore_output = `ends_in_one_underscore_`;
 
 names.two_underscores_input = `ends_in_two_underscores__`;
-names.two_underscores_output = `ends_in_two_underscores___`;
+names.two_underscores_output = `ends_in_two_underscores__`;
 
 names.empty_string_input = ``;
 names.empty_string_output = ``;
@@ -21,15 +21,15 @@ names.undefined_input;
 names.undefined_output = ``;
 
 names.colon_input = `invalid:colon`;
-names.colon_output = `invalid_colon_`;
+names.colon_output = `invalid_colon`;
 
 names.slash_input = `invalid/slash`;
-names.slash_output = `invalid_slash_`;
+names.slash_output = `invalid_slash`;
 
 names.two_consecutive_invalid_input = `two_consecutive//invalid`;
-names.two_consecutive_invalid_output = `two_consecutive__invalid_`;
+names.two_consecutive_invalid_output = `two_consecutive__invalid`;
 
 names.numerical_input = `scenario_w1th_number00`;
-names.numerical_output = `scenario_w1th_number00_`;
+names.numerical_output = `scenario_w1th_number00`;
 
 module.exports = names;