@suffolklitlab/alkiln 4.5.1 → 4.5.2

package/CHANGELOG.md

@@ -40,6 +40,12 @@ Format:
 -->
 <!-- ## [Unreleased] -->
 
+## [4.5.2] - 2022-06-10
+### Fixed
+- (internal) Expected in report is reset properly
+  - if a test used "the Scenario report should include ...", then all tests that were
+    run after that would pass even if the test itself failed but wasn't expected to fail
+
 ## [4.5.1] - 2022-06-10
 ### Fixed
 - Corrected some schema errors in the `action.yml` (the `run` key was specified twice, should only have been once, and `required: False` is needed

package/lib/steps.js

@@ -73,6 +73,8 @@ BeforeAll(async () => {
 
 Before(async (scenario) => {
   scope.scenario_id = uuidv4();
+  scope.expected_status = null;
+  scope.expected_in_report = null;
 
   await scope.addReportHeading(scope, {scenario});
   scope.base_filename = await scope.getSafeScenarioBaseFilename(scope, {scenario});
@@ -930,11 +932,10 @@ After(async function(scenario) {
     scope.expected_status = null;  // reset for next Scenario
     expect( scenario.result.status ).to.equal( expected );
   }
-  if ( scope.expected_in_report ) {
+  if ( scope.expected_in_report && scope.expected_in_report.length > 0) {
     let expected = scope.expected_in_report;
     // Reset report values no matter what so they don't mess up future scenarios
-    // Maybe this should be in `Before`, but it would be so out of context there...
-    scope.expected_in_report = [];
+    scope.expected_in_report = null;
     let all_were_included = await scope.reportIncludesAllExpected( scope, { expected });
     if ( all_were_included ) { scenario.result.status = `PASSED`; }
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@suffolklitlab/alkiln",
-  "version": "4.5.1",
+  "version": "4.5.2",
   "description": "Integrated automated end-to-end testing with docassemble, puppeteer, and cucumber.",
   "main": "lib/index.js",
   "scripts": {

package/tests/features/interactive_steps.feature

@@ -41,6 +41,11 @@ Scenario: I set text-type values
   And I set the var "showif_dropdown" to "showif_dropdown_1"
   When I tap to continue
   # Next page
+  Then the question id should be "object checkboxes"
+  And I set the var "object_checkboxes_test['obj_chkbx_opt_1']" to "true" 
+  And I set the var "object_dropdown" to "obj_opt_2"
+  When I tap to continue
+  # Next page
   Then the question id should be "buttons yesnomaybe"
   When I set the var "buttons_yesnomaybe" to "None"
   # Next page
@@ -114,7 +119,7 @@ Scenario: tap elements
   And I tap the "#special_event" element and wait 1 second
   Then I see the phrase "Portishead"
 
-@i4 @tap-elements @tabs
+@i4 @tap-elements @tabs @error
 Scenario: tap element with an error
   Given the final Scenario status should be "failed"
   And the Scenario report should include:

package/tests/features/observation_steps.feature

@@ -46,6 +46,8 @@ Scenario: I check navigation
   Then I arrive at the next page
   Then I get to "screen features" with this data:
     | var | value | trigger |
+    | object_checkboxes_test["obj_chkbx_opt_1"] | True | |
+    | object_dropdown | obj_opt_2 | |
     | button_continue | True |  |
     | buttons_other | button_2 |  |
     | buttons_yesnomaybe | True |  |

package/tests/features/reports.feature

@@ -160,6 +160,8 @@ Scenario: Fail with link with given text does not lead to correct url
   Then I arrive at the next page
   Then I get to "screen features" with this data:
     | var | value | trigger |
+    | object_checkboxes_test["obj_chkbx_opt_1"] | true | |
+    | object_dropdown | obj_opt_2 | |
     | button_continue | True |  |
     | buttons_other | button_2 |  |
     | buttons_yesnomaybe | True |  |
@@ -188,6 +190,8 @@ Scenario: Fail with link unexpectedly opens in same window
   Then I arrive at the next page
   Then I get to "screen features" with this data:
     | var | value | trigger |
+    | object_checkboxes_test["obj_chkbx_opt_1"] | true | |
+    | object_dropdown | obj_opt_2 | |
     | button_continue | True |  |
     | buttons_other | button_2 |  |
     | buttons_yesnomaybe | True |  |
@@ -216,6 +220,8 @@ Scenario: Fail with link unexpectedly opens in a new window
   Then I arrive at the next page
   Then I get to "screen features" with this data:
     | var | value | trigger |
+    | object_checkboxes_test["obj_chkbx_opt_1"] | true | |
+    | object_dropdown | obj_opt_2 | |
     | button_continue | True |  |
     | buttons_other | button_2 |  |
     | buttons_yesnomaybe | True |  |
@@ -472,6 +478,11 @@ Scenario: Report still shows page id when I tap to continue without setting any
   # Next page
   Then the question id should be "showifs"
   When I tap to continue
+  # Next page
+  Then the question id should be "object checkboxes"
+  And I set the var "object_checkboxes_test['obj_chkbx_opt_1']" to "true" 
+  And I set the var "object_dropdown" to "obj_opt_2"
+  When I tap to continue
   # Next page (showifs ID SHOULD BE SHOWN IN REPORT)
   Then the question id should be "buttons yesnomaybe"
 
@@ -517,6 +528,8 @@ Scenario: Report lists unused table rows
     | extra_5 | extra 5 |  |
   Then I get to "screen features" with this data:
     | var | value | trigger |
+    | object_checkboxes_test["obj_chkbx_opt_1"] | true | |
+    | object_dropdown | obj_opt_2 | |
     | extra_6 | extra 6 |  |
     | extra_7 | extra 7 |  |
     | button_continue | True |  |

package/tests/features/story_tables.feature

@@ -47,6 +47,8 @@ Covers story table tests for:
     | checkboxes_yesno | True |  |
     | direct_standard_fields | True |  |
     | dropdown_test | dropdown_opt_2 |  |
+    | object_checkboxes_test["obj_chkbx_opt_1"] | true | |
+    | object_dropdown | obj_opt_2 | |
     | radio_other | radio_other_opt_3 |  |
     | radio_yesno | False |  |
     | screen_features | True |  |