@suffolklitlab/alkiln 4.2.1-custom-setup-timeout.2 → 4.3.1

package/CHANGELOG.md

@@ -38,9 +38,11 @@ Format:
 ### Security
 - 
 -->
-## [Unreleased]
+<!-- ## [Unreleased] -->
+
+## [4.3.0] - 2022-04-07
 ### Added
-- GitHub environment variable MAX_SECONDS_FOR_SETUP to set a custom maximum time for setup and takedown for packages that take a long time to load.
+- GitHub environment variable `MAX_SECONDS_FOR_SETUP` to set a custom maximum time for setup and takedown for packages that take a long time to load.
 
 ## [4.2.0] - 2022-04-05
 ### Changed

package/action.yml

@@ -29,7 +29,7 @@ inputs:
     required: false
     default: '^4.0.0'
   MAX_SECONDS_FOR_SETUP:
-    description: 'Amount of time to give the Project to upload your package's GitHub code.'
+    description: "Amount of time to give the Project to upload your package's GitHub code."
     required: false
     default: '120'
 

package/lib/docassemble/docassemble_api_interface.js

@@ -181,10 +181,9 @@ da_i.loop_to_create_project = async function( creation_options ) {
 
   // Defaults
   creation_options = creation_options || {};
-  let default_opts = { timeout: DEFAULT_MAX_REQUEST_MS, max_tries: 15, wait_seconds: 5 };
-  let timeout = creation_options.timeout || default_opts.timeout;
-  let max_tries = creation_options.max_tries || default_opts.max_tries;
-  let wait_seconds = creation_options.wait_seconds || default_opts.wait_seconds;
+  let timeout = creation_options.timeout || DEFAULT_MAX_REQUEST_MS;
+  let max_tries = creation_options.max_tries || 15;
+  let wait_seconds = creation_options.wait_seconds || 5;
 
   let project_name = null;
   let name_incrementor = 0;
@@ -353,8 +352,7 @@ da_i.wait_for_server_to_restart = async ( task_id, options ) => {
   // Base default
   options = options || {};
   // Default timeout
-  let default_timeout = DEFAULT_MAX_REQUEST_MS;
-  let timeout = options.timeout || default_timeout;
+  let timeout = options.timeout || DEFAULT_MAX_REQUEST_MS;
   // Other defaults
   let default_wait_between_loops = 4 * 1000;
   let default_wait_for_response = 1 * 1000;
@@ -363,7 +361,6 @@ da_i.wait_for_server_to_restart = async ( task_id, options ) => {
   let wait_between_loops = options.wait_between_loops || default_wait_between_loops;
   let wait_for_response = options.wait_for_response || default_wait_for_response;
   let max_loops = options.max_loops || default_max_loops;
-  let total_wait = wait_between_loops + wait_for_response;
 
   // Flags for stopping the `while` loop
   let num_tries = 0;
@@ -425,8 +422,6 @@ da_i.delete_project = async function ( delete_options ) {
     log.info({ pre: `Deleted Project "${ project_name }"` });
 
   } catch ( error ) {
-    // TODO: Add more useful error messages, like project doesn't exist. The devs
-    // shouldn't be deleting projects by hand, but it's still very possible they would
     // Status 400
     log.error({ pre: `Ran into an error when deleting Project "${ project_name }"` });
     log.debug({ pre: `See https://docassemble.org/docs/api.html#playground_delete_project.` });

package/lib/utils/session_vars.js

@@ -20,7 +20,7 @@ const session_vars = {};
 
 module.exports = session_vars;
 
-// Default to null
+// These default to null
 session_vars.get_debug = function () { return process.env.DEBUG || null; };
 session_vars.get_dev_api_key = function () { return process.env.DOCASSEMBLE_DEVELOPER_API_KEY || null; };
 session_vars.get_repo_url = function () { return process.env.REPO_URL || null; };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@suffolklitlab/alkiln",
-  "version": "4.2.1-custom-setup-timeout.2",
+  "version": "4.3.1",
   "description": "Integrated automated end-to-end testing with docassemble, puppeteer, and cucumber.",
   "main": "lib/index.js",
   "scripts": {