@suffolklitlab/alkiln 4.10.3-feat-story-pics → 4.10.3-feat-debug-cache

package/CHANGELOG.md

@@ -40,8 +40,9 @@ Format:
 -->
 ## [Unreleased]
 ## Added
-- Contribution docs
-- Story table can take screenshots after each visited page
+- Contribution docs.
+- Story table can take screenshots after each visited page.
+- Projects created in da each have a unique name. We assume for now this will not build up test packages in the server.
 
 ## [4.10.3] - 2023-01-11
 ### Removed

package/lib/docassemble/docassemble_api_interface.js

@@ -204,16 +204,16 @@ da_i.loop_to_create_project = async function( creation_options ) {
   let wait_seconds = creation_options.wait_seconds || 5;
 
   let project_name = null;
-  let name_incrementor = 0;
+  let num_tries = 0;
 
   // Try to create a project. If the project name is already taken, increment and loop again.
-  while ( name_incrementor <= max_tries ) {
-    name_incrementor++;
+  while ( num_tries <= max_tries ) {
+    num_tries++;
     try {
 
-      // Try next name that could be unique. Must remove all non-valid characters
+      // Try adding a new timestamp to the name. Must remove all non-valid characters
       // TODO: This sanitization is already done in session_vars, so remove it from here
-      project_name = session_vars.get_project_base_name().replace(/[^A-Za-z0-9]/g, '') + name_incrementor;
+      project_name = session_vars.get_project_base_name().replace(/[^A-Za-z0-9]/g, '') + `${Date.now()}`;
       log.info({ pre: `Trying to create a docassemble Project with the name ${ project_name }` });
       let response = await _da_REST.create_project( project_name, timeout );
       log.info({ pre: `The docassemble server is ready. Created a Project named ${ project_name }` });
@@ -226,7 +226,7 @@ da_i.loop_to_create_project = async function( creation_options ) {
 
       if ( response && response.data ) {
         if ( response.data.includes( `Invalid project` ) ) {
-          if ( name_incrementor < max_tries ) {
+          if ( num_tries < max_tries ) {
             // A non-unique project name. Try the next project name.
             continue;
 
@@ -256,11 +256,11 @@ da_i.loop_to_create_project = async function( creation_options ) {
 
         // If it's a timeout error, server is busy. Try again after waiting.
         // Why are we using `max_tries` for timeout error as well?
-        if ( is_timeout_error( error ) && name_incrementor < max_tries ) {
+        if ( is_timeout_error( error ) && num_tries < max_tries ) {
           log.info({ pre: `The docassemble server was busy when we tried to `
-            + `create the Project. Attempt ${ name_incrementor } of `
+            + `create the Project. Attempt ${ num_tries } of `
             + `${ max_tries }. Will try again in ${ wait_seconds } seconds.` });
-          name_incrementor--;  // Try this name again next time
+          num_tries--;  // Try this name again next time
           await time.waitForTimeout( wait_seconds * 1000 );
           continue;
 
@@ -272,6 +272,8 @@ da_i.loop_to_create_project = async function( creation_options ) {
         }  // ends type of non-response error
       }  // ends type of response error
     }  // ends try
+
+    // TODO: Add a message that we're done trying to create a project, successful or not
   }  // ends while
 };  // Ends da_i.loop_to_create_project()
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@suffolklitlab/alkiln",
-  "version": "4.10.3-feat-story-pics",
+  "version": "4.10.3-feat-debug-cache",
   "description": "Integrated automated end-to-end testing with docassemble, puppeteer, and cucumber.",
   "main": "lib/index.js",
   "scripts": {