@substrate-ai/factory 0.19.54

package/dist/convergence/__tests__/dual-signal.test.js

@@ -0,0 +1,123 @@
+/**
+ * Unit tests for dual-signal coordinator (story 46-5).
+ *
+ * Covers all ACs:
+ *   AC1 — both signals pass → AGREE
+ *   AC2 — code review passes, scenario fails → DISAGREE
+ *   AC3 — code review fails, scenario passes → DISAGREE
+ *   AC4 — code review is always authoritative decision
+ *   AC5 — coordinator emits scenario:score-computed with full payload
+ *   AC6 — LGTM_WITH_NOTES treated as code review pass
+ *   AC7 — both signals fail → AGREE
+ */
+import { describe, it, expect, vi } from 'vitest';
+import { evaluateDualSignal, createDualSignalCoordinator, } from '../dual-signal.js';
+// ---------------------------------------------------------------------------
+// Pure function tests — evaluateDualSignal
+// ---------------------------------------------------------------------------
+describe('evaluateDualSignal', () => {
+    it('AC1 — SHIP_IT + score above threshold → AGREE both passed', () => {
+        const result = evaluateDualSignal('SHIP_IT', 0.9, 0.8);
+        expect(result.codeReviewPassed).toBe(true);
+        expect(result.scenarioPassed).toBe(true);
+        expect(result.agreement).toBe('AGREE');
+        expect(result.authoritativeDecision).toBe('SHIP_IT');
+        expect(result.score).toBe(0.9);
+        expect(result.threshold).toBe(0.8);
+    });
+    it('AC7 — NEEDS_MAJOR_REWORK + score below threshold → AGREE both failed', () => {
+        const result = evaluateDualSignal('NEEDS_MAJOR_REWORK', 0.5, 0.8);
+        expect(result.codeReviewPassed).toBe(false);
+        expect(result.scenarioPassed).toBe(false);
+        expect(result.agreement).toBe('AGREE');
+        expect(result.authoritativeDecision).toBe('NEEDS_MAJOR_REWORK');
+    });
+    it('AC2 — SHIP_IT + score below threshold → DISAGREE, code review passed, scenario failed', () => {
+        const result = evaluateDualSignal('SHIP_IT', 0.6, 0.8);
+        expect(result.agreement).toBe('DISAGREE');
+        expect(result.codeReviewPassed).toBe(true);
+        expect(result.scenarioPassed).toBe(false);
+        expect(result.authoritativeDecision).toBe('SHIP_IT');
+    });
+    it('AC3 — NEEDS_MINOR_FIXES + score above threshold → DISAGREE, code review failed, scenario passed', () => {
+        const result = evaluateDualSignal('NEEDS_MINOR_FIXES', 0.9, 0.8);
+        expect(result.agreement).toBe('DISAGREE');
+        expect(result.codeReviewPassed).toBe(false);
+        expect(result.scenarioPassed).toBe(true);
+        expect(result.authoritativeDecision).toBe('NEEDS_MINOR_FIXES');
+    });
+    it('AC4 — SHIP_IT is authoritative even when scenario fails badly', () => {
+        const result = evaluateDualSignal('SHIP_IT', 0.3, 0.8);
+        expect(result.authoritativeDecision).toBe('SHIP_IT');
+    });
+    it('AC6 — LGTM_WITH_NOTES treated as code review pass', () => {
+        const result = evaluateDualSignal('LGTM_WITH_NOTES', 0.7, 0.8);
+        expect(result.codeReviewPassed).toBe(true);
+        expect(result.scenarioPassed).toBe(false);
+        expect(result.agreement).toBe('DISAGREE');
+    });
+    it('threshold boundary — score exactly at threshold → scenarioPassed true', () => {
+        const result = evaluateDualSignal('SHIP_IT', 0.8, 0.8);
+        expect(result.scenarioPassed).toBe(true);
+        expect(result.agreement).toBe('AGREE');
+    });
+    it('NEEDS_MAJOR_REWORK authoritative even when scenario passes', () => {
+        const result = evaluateDualSignal('NEEDS_MAJOR_REWORK', 0.95, 0.8);
+        expect(result.authoritativeDecision).toBe('NEEDS_MAJOR_REWORK');
+        expect(result.codeReviewPassed).toBe(false);
+        expect(result.scenarioPassed).toBe(true);
+        expect(result.agreement).toBe('DISAGREE');
+    });
+    it('NEEDS_MINOR_FIXES is not a passing verdict', () => {
+        const result = evaluateDualSignal('NEEDS_MINOR_FIXES', 0.5, 0.8);
+        expect(result.codeReviewPassed).toBe(false);
+        expect(result.agreement).toBe('AGREE');
+    });
+});
+// ---------------------------------------------------------------------------
+// Coordinator tests — createDualSignalCoordinator
+// ---------------------------------------------------------------------------
+describe('createDualSignalCoordinator', () => {
+    function makeMockBus() {
+        return { emit: vi.fn() };
+    }
+    it('AC5 — emits scenario:score-computed with full payload', () => {
+        const mockBus = makeMockBus();
+        const coordinator = createDualSignalCoordinator({ eventBus: mockBus, threshold: 0.8 });
+        coordinator.evaluate('SHIP_IT', 0.6, 'run-1');
+        expect(mockBus.emit).toHaveBeenCalledWith('scenario:score-computed', {
+            runId: 'run-1',
+            score: 0.6,
+            threshold: 0.8,
+            passes: false,
+            agreement: 'DISAGREE',
+            codeReviewPassed: true,
+            scenarioPassed: false,
+            authoritativeDecision: 'SHIP_IT',
+        });
+    });
+    it('emits exactly once per call', () => {
+        const mockBus = makeMockBus();
+        const coordinator = createDualSignalCoordinator({ eventBus: mockBus, threshold: 0.8 });
+        coordinator.evaluate('SHIP_IT', 0.9, 'run-1');
+        expect(mockBus.emit).toHaveBeenCalledTimes(1);
+    });
+    it('returns the DualSignalResult matching the emitted payload', () => {
+        const mockBus = makeMockBus();
+        const coordinator = createDualSignalCoordinator({ eventBus: mockBus, threshold: 0.8 });
+        const result = coordinator.evaluate('SHIP_IT', 0.85, 'run-1');
+        expect(result.codeReviewPassed).toBe(true);
+        expect(result.scenarioPassed).toBe(true);
+        expect(result.agreement).toBe('AGREE');
+        expect(result.authoritativeDecision).toBe('SHIP_IT');
+        expect(result.score).toBe(0.85);
+        expect(result.threshold).toBe(0.8);
+    });
+    it('passes runId correctly into emitted event payload', () => {
+        const mockBus = makeMockBus();
+        const coordinator = createDualSignalCoordinator({ eventBus: mockBus, threshold: 0.8 });
+        coordinator.evaluate('NEEDS_MINOR_FIXES', 0.5, 'run-42');
+        expect(mockBus.emit).toHaveBeenCalledWith('scenario:score-computed', expect.objectContaining({ runId: 'run-42' }));
+    });
+});
+//# sourceMappingURL=dual-signal.test.js.map

package/dist/convergence/__tests__/dual-signal.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"dual-signal.test.js","sourceRoot":"","sources":["../../../src/convergence/__tests__/dual-signal.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;GAWG;AAEH,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAA;AAGjD,OAAO,EACL,kBAAkB,EAClB,2BAA2B,GAC5B,MAAM,mBAAmB,CAAA;AAG1B,8EAA8E;AAC9E,2CAA2C;AAC3C,8EAA8E;AAE9E,QAAQ,CAAC,oBAAoB,EAAE,GAAG,EAAE;IAClC,EAAE,CAAC,2DAA2D,EAAE,GAAG,EAAE;QACnE,MAAM,MAAM,GAAG,kBAAkB,CAAC,SAAS,EAAE,GAAG,EAAE,GAAG,CAAC,CAAA;QACtD,MAAM,CAAC,MAAM,CAAC,gBAAgB,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QAC1C,MAAM,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QACxC,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAA;QACtC,MAAM,CAAC,MAAM,CAAC,qBAAqB,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAA;QACpD,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,CAAA;QAC9B,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,CAAA;IACpC,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,sEAAsE,EAAE,GAAG,EAAE;QAC9E,MAAM,MAAM,GAAG,kBAAkB,CAAC,oBAAoB,EAAE,GAAG,EAAE,GAAG,CAAC,CAAA;QACjE,MAAM,CAAC,MAAM,CAAC,gBAAgB,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;QAC3C,MAAM,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;QACzC,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAA;QACtC,MAAM,CAAC,MAAM,CAAC,qBAAqB,CAAC,CAAC,IAAI,CAAC,oBAAoB,CAAC,CAAA;IACjE,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,uFAAuF,EAAE,GAAG,EAAE;QAC/F,MAAM,MAAM,GAAG,kBAAkB,CAAC,SAAS,EAAE,GAAG,EAAE,GAAG,CAAC,CAAA;QACtD,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAA;QACzC,MAAM,CAAC,MAAM,CAAC,gBAAgB,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QAC1C,MAAM,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;QACzC,MAAM,CAAC,MAAM,CAAC,qBAAqB,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAA;IACtD,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,iGAAiG,EAAE,GAAG,EAAE;QACzG,MAAM,MAAM,GAAG,kBAAkB,CAAC,mBAAmB,EAAE,GAAG,EAAE,GAAG,CAAC,CAAA;QAChE,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAA;QACzC,MAAM,CAAC,MAAM,CAAC,gBAAgB,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;QAC3C,MAAM,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QACxC,MAAM,CAAC,MAAM,CAAC,qBAAqB,CAAC,CAAC,IAAI,CAAC,mBAAmB,CAAC,CAAA;IAChE,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,+DAA+D,EAAE,GAAG,EAAE;QACvE,MAAM,MAAM,GAAG,kBAAkB,CAAC,SAAS,EAAE,GAAG,EAAE,GAAG,CAAC,CAAA;QACtD,MAAM,CAAC,MAAM,CAAC,qBAAqB,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAA;IACtD,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,mDAAmD,EAAE,GAAG,EAAE;QAC3D,MAAM,MAAM,GAAG,kBAAkB,CAAC,iBAAiB,EAAE,GAAG,EAAE,GAAG,CAAC,CAAA;QAC9D,MAAM,CAAC,MAAM,CAAC,gBAAgB,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QAC1C,MAAM,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;QACzC,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAA;IAC3C,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,uEAAuE,EAAE,GAAG,EAAE;QAC/E,MAAM,MAAM,GAAG,kBAAkB,CAAC,SAAS,EAAE,GAAG,EAAE,GAAG,CAAC,CAAA;QACtD,MAAM,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QACxC,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAA;IACxC,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,4DAA4D,EAAE,GAAG,EAAE;QACpE,MAAM,MAAM,GAAG,kBAAkB,CAAC,oBAAoB,EAAE,IAAI,EAAE,GAAG,CAAC,CAAA;QAClE,MAAM,CAAC,MAAM,CAAC,qBAAqB,CAAC,CAAC,IAAI,CAAC,oBAAoB,CAAC,CAAA;QAC/D,MAAM,CAAC,MAAM,CAAC,gBAAgB,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;QAC3C,MAAM,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QACxC,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAA;IAC3C,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,4CAA4C,EAAE,GAAG,EAAE;QACpD,MAAM,MAAM,GAAG,kBAAkB,CAAC,mBAAmB,EAAE,GAAG,EAAE,GAAG,CAAC,CAAA;QAChE,MAAM,CAAC,MAAM,CAAC,gBAAgB,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;QAC3C,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAA;IACxC,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA;AAEF,8EAA8E;AAC9E,kDAAkD;AAClD,8EAA8E;AAE9E,QAAQ,CAAC,6BAA6B,EAAE,GAAG,EAAE;IAC3C,SAAS,WAAW;QAClB,OAAO,EAAE,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE,EAA6C,CAAA;IACrE,CAAC;IAED,EAAE,CAAC,uDAAuD,EAAE,GAAG,EAAE;QAC/D,MAAM,OAAO,GAAG,WAAW,EAAE,CAAA;QAC7B,MAAM,WAAW,GAAG,2BAA2B,CAAC,EAAE,QAAQ,EAAE,OAAO,EAAE,SAAS,EAAE,GAAG,EAAE,CAAC,CAAA;QAEtF,WAAW,CAAC,QAAQ,CAAC,SAAS,EAAE,GAAG,EAAE,OAAO,CAAC,CAAA;QAE7C,MAAM,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,oBAAoB,CAAC,yBAAyB,EAAE;YACnE,KAAK,EAAE,OAAO;YACd,KAAK,EAAE,GAAG;YACV,SAAS,EAAE,GAAG;YACd,MAAM,EAAE,KAAK;YACb,SAAS,EAAE,UAAU;YACrB,gBAAgB,EAAE,IAAI;YACtB,cAAc,EAAE,KAAK;YACrB,qBAAqB,EAAE,SAAS;SACjC,CAAC,CAAA;IACJ,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,6BAA6B,EAAE,GAAG,EAAE;QACrC,MAAM,OAAO,GAAG,WAAW,EAAE,CAAA;QAC7B,MAAM,WAAW,GAAG,2BAA2B,CAAC,EAAE,QAAQ,EAAE,OAAO,EAAE,SAAS,EAAE,GAAG,EAAE,CAAC,CAAA;QAEtF,WAAW,CAAC,QAAQ,CAAC,SAAS,EAAE,GAAG,EAAE,OAAO,CAAC,CAAA;QAE7C,MAAM,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAA;IAC/C,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,2DAA2D,EAAE,GAAG,EAAE;QACnE,MAAM,OAAO,GAAG,WAAW,EAAE,CAAA;QAC7B,MAAM,WAAW,GAAG,2BAA2B,CAAC,EAAE,QAAQ,EAAE,OAAO,EAAE,SAAS,EAAE,GAAG,EAAE,CAAC,CAAA;QAEtF,MAAM,MAAM,GAAG,WAAW,CAAC,QAAQ,CAAC,SAAS,EAAE,IAAI,EAAE,OAAO,CAAC,CAAA;QAE7D,MAAM,CAAC,MAAM,CAAC,gBAAgB,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QAC1C,MAAM,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QACxC,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAA;QACtC,MAAM,CAAC,MAAM,CAAC,qBAAqB,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAA;QACpD,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QAC/B,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,CAAA;IACpC,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,mDAAmD,EAAE,GAAG,EAAE;QAC3D,MAAM,OAAO,GAAG,WAAW,EAAE,CAAA;QAC7B,MAAM,WAAW,GAAG,2BAA2B,CAAC,EAAE,QAAQ,EAAE,OAAO,EAAE,SAAS,EAAE,GAAG,EAAE,CAAC,CAAA;QAEtF,WAAW,CAAC,QAAQ,CAAC,mBAAmB,EAAE,GAAG,EAAE,QAAQ,CAAC,CAAA;QAExD,MAAM,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,oBAAoB,CACvC,yBAAyB,EACzB,MAAM,CAAC,gBAAgB,CAAC,EAAE,KAAK,EAAE,QAAQ,EAAE,CAAC,CAC7C,CAAA;IACH,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA"}

package/dist/convergence/__tests__/epic46-integration.test.d.ts

@@ -0,0 +1,15 @@
+/**
+ * epic46-integration.test.ts
+ *
+ * End-to-end integration tests for Epic 46 Satisfaction Scoring:
+ * - Dual-signal Phase 2 agreement tracking (AC2)
+ * - Scenario-primary mode advisory events (AC3)
+ * - Score persistence roundtrip (AC4)
+ * - Multi-iteration score history (AC5)
+ * - Factory run listing and upsert semantics (AC6)
+ * - Combined end-to-end flow (AC1–AC6)
+ *
+ * Story 46-8.
+ */
+export {};
+//# sourceMappingURL=epic46-integration.test.d.ts.map

package/dist/convergence/__tests__/epic46-integration.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"epic46-integration.test.d.ts","sourceRoot":"","sources":["../../../src/convergence/__tests__/epic46-integration.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;GAYG"}