@subshell-ai/plugin-codex 0.1.1 → 0.2.0

package/dist/index.d.ts

@@ -1,4 +1,4 @@
-//#region ../../plugin-api/dist/types-CSNepTNr.d.ts
+//#region ../../plugin-api/dist/types-B_wiApwK.d.ts
 //#region src/types.d.ts
 /**
  * The contract a Subshell plugin implements.
@@ -27,9 +27,9 @@ type PluginType = "agent-harness" | "terminal";
  * branches on {@link PluginType}.
  */
 type PluginCapability = "mcp" | "resume" | "attention" | "settings";
-/** A harness profile as defined by the user (decoded JSON blobs). */
-interface ProfileDefinition {
-  /** Human-friendly profile name */
+/** A harness preset as defined by the user (decoded JSON blobs). */
+interface PresetDefinition {
+  /** Human-friendly preset name */
   name: string;
   /** Optional longer description */
   description?: string | null;
@@ -39,21 +39,21 @@ interface ProfileDefinition {
   flags: string[];
   /** Settings blob passed to the harness (e.g. claude --settings JSON) */
   settings: Record<string, unknown> | null;
-  /** If true, only this profile's config sources apply (isolation) */
+  /** If true, only this preset's config sources apply (isolation) */
   configIsolation: boolean;
-  /** If true, new subshells from this profile auto-restart on exit */
+  /** If true, new subshells from this preset auto-restart on exit */
   restartOnExit?: boolean;
 }
-/** Snapshot of a single field-level validation error on a profile. */
-interface ProfileValidationIssue {
+/** Snapshot of a single field-level validation error on a preset. */
+interface PresetValidationIssue {
   /** Field name (e.g. "name", "env", "settings") */
   field: string;
   /** Human-readable problem description */
   message: string;
 }
-interface ProfileValidationResult {
+interface PresetValidationResult {
   valid: boolean;
-  issues: ProfileValidationIssue[];
+  issues: PresetValidationIssue[];
 }
 /** Everything a plugin needs to build a launch command. */
 interface BuildCommandInput {
@@ -61,8 +61,8 @@ interface BuildCommandInput {
   binary: string;
   /** Working directory the harness runs in */
   cwd: string;
-  /** The validated profile being used */
-  profile: ProfileDefinition;
+  /** The validated preset being used */
+  preset: PresetDefinition;
   /** Subshell display name ("" = let the harness pick a default) */
   subshellName: string;
   /** Any additional CLI flags from route/request context */
@@ -169,12 +169,12 @@ interface McpRegistration {
   args?: string[];
   /**
    * Extra pane env the harness needs to discover the file (e.g. OPENCODE_CONFIG).
-   * Consumed by the HOST, which bakes it into the pane env ahead of profile env;
+   * Consumed by the HOST, which bakes it into the pane env ahead of preset env;
    * plugins never read it back.
    */
   env?: Record<string, string>;
 }
-/** One copy-paste line shown in the profile editor for manual-setup harnesses. */
+/** One copy-paste line shown in the preset editor for manual-setup harnesses. */
 interface McpSetupStep {
   /** What the user should do, and where the text goes */
   label: string;
@@ -259,8 +259,8 @@ interface PluginHost {
 interface SubshellPlugin {
   /** Builds the argv (no shell) used to launch a subshell. */
   buildCommand(input: BuildCommandInput): string[];
-  /** Validates a profile definition before saving. */
-  validateProfile(profile: ProfileDefinition): ProfileValidationResult;
+  /** Validates a preset definition before saving. */
+  validatePreset(preset: PresetDefinition): PresetValidationResult;
   /** Which optional members below are meaningful on this plugin. */
   capabilities(): PluginCapability[];
   /** Maps a harness exit code to a human label (null = unknown). */
@@ -292,14 +292,14 @@ interface SubshellPlugin {
   mcpRegistration?(launch: McpLaunchSpec, configPath: string): McpRegistration;
   /** How users obtain the subshell MCP tools here. Declare the `mcp` capability with it. */
   mcpSetup?(launch: McpLaunchSpec): McpSetupInfo;
-  /** Settings rendered in the PROFILE editor and stored on the profile. */
-  profileSettings?(): SettingsField[];
-  /** Known extra env var suggestions for the profile editor. */
+  /** Settings rendered in the PRESET editor and stored on the preset. */
+  presetSettings?(): SettingsField[];
+  /** Known extra env var suggestions for the preset editor. */
   suggestedEnv?(): {
     key: string;
     description: string;
   }[];
-  /** Known CLI flag suggestions for the profile editor. */
+  /** Known CLI flag suggestions for the preset editor. */
   suggestedFlags?(): {
     flag: string;
     description: string;
@@ -337,7 +337,11 @@ interface SubshellManifest {
   name: string;
   /** One-line description shown in the UI */
   description: string;
-  /** Optional emoji/glyph */
+  /**
+   * Relative path to this plugin's icon file, e.g. `icon.svg`. Served by
+   * the control plane at `/api/plugins/<id>/icon`; absent means the UI
+   * renders a monogram instead.
+   */
   icon?: string;
   /** Module to import, relative to the package directory */
   entry: string;
@@ -366,7 +370,7 @@ declare const manifest: SubshellManifest;
  *
  * Launch shape:
  *   codex [-m <model>] [-s <sandbox>] [-a <approval>] [mcp -c pairs]
- *         [profile flags] [extra flags]
+ *         [preset flags] [extra flags]
  * A bare launch (no subcommand, no prompt) opens the interactive TUI. Codex
  * has no create-time flag for naming its own session and no way to pin a
  * conversation id, so neither the subshell name nor a resume capability is
@@ -374,7 +378,7 @@ declare const manifest: SubshellManifest;
  * The pane's
  * cwd is already the working directory, so `-C/--cd` is never passed, and
  * `--dangerously-bypass-approvals-and-sandbox` is NEVER baked into a launch
- * (a user may put it in their own profile flags — that is their call).
+ * (a user may put it in their own preset flags — that is their call).
  *
  * subshell MCP is wired automatically WITHOUT touching user state: every
  * launch carries `-c mcp_servers.subshell.command=… -c mcp_servers.subshell.args=…`

package/dist/index.js

@@ -1,4 +1,4 @@
-//#region ../../plugin-api/dist/manifest-UFScnYqn.js
+//#region ../../plugin-api/dist/manifest-Czd9ea1g.js
 /** Every {@link PluginType}, for anything that has to iterate or validate them. */
 const PLUGIN_TYPES = ["agent-harness", "terminal"];
 /**
@@ -9,6 +9,17 @@ const PLUGIN_TYPES = ["agent-harness", "terminal"];
 */
 const MCP_SERVER_NAME = "subshell";
 /**
+* Image formats a plugin icon may be. The server maps these to a Content-Type
+* from a fixed table rather than sniffing the file, so this list and that
+* table are one decision: adding a format here without adding it there leaves
+* an icon that parses and then 500s when something asks for it.
+*/
+const ICON_EXTENSIONS = [
+	".svg",
+	".png",
+	".webp"
+];
+/**
 * Ids become directory names under `<dataDir>/plugins/`, so they are path
 * segments and nothing else: no separators, no traversal, no surprises from a
 * case-insensitive filesystem.
@@ -31,13 +42,18 @@ function parseManifest(pkgJson) {
 	const block = pkgJson.subshell;
 	if (!isRecord(block)) return { error: "package.json has no `subshell` block, so it is not a Subshell plugin" };
 	if (typeof block.apiVersion !== "number" || !Number.isInteger(block.apiVersion)) return { error: "`subshell.apiVersion` must be an integer" };
-	if (block.apiVersion < 1) return { error: `this plugin declares plugin-api ${block.apiVersion}, which is not a version; the lowest is 1 and this host implements 1` };
-	if (block.apiVersion > 1) return { error: `this plugin needs plugin-api ${block.apiVersion}, but this host implements 1; upgrade the agent` };
+	if (block.apiVersion < 1) return { error: `this plugin declares plugin-api ${block.apiVersion}, which is not a version; the lowest is 1 and this host implements 2` };
+	if (block.apiVersion > 2) return { error: `this plugin needs plugin-api ${block.apiVersion}, but this host implements 2; upgrade the agent` };
 	if (typeof block.id !== "string" || !ID_RE.test(block.id)) return { error: "`subshell.id` must be lowercase letters, digits and hyphens, starting alphanumeric (it becomes a directory name)" };
 	if (typeof block.type !== "string" || !PLUGIN_TYPES.includes(block.type)) return { error: `\`subshell.type\` must be one of: ${PLUGIN_TYPES.join(", ")}` };
 	if (typeof block.name !== "string" || block.name.trim() === "") return { error: "`subshell.name` must be a non-empty string" };
 	if (typeof block.description !== "string") return { error: "`subshell.description` must be a string" };
-	if (block.icon !== void 0 && typeof block.icon !== "string") return { error: "`subshell.icon` must be a string" };
+	if (block.icon !== void 0) {
+		if (typeof block.icon !== "string" || block.icon.trim() === "") return { error: "`subshell.icon` must be a non-empty relative path to an image in the package" };
+		if (block.icon.startsWith("/") || block.icon.split("/").includes("..")) return { error: "`subshell.icon` must stay inside the package (no leading `/` and no `..` segment)" };
+		const icon = block.icon;
+		if (!ICON_EXTENSIONS.some((ext) => icon.endsWith(ext))) return { error: `\`subshell.icon\` must end in one of: ${ICON_EXTENSIONS.join(", ")}` };
+	}
 	if (typeof block.entry !== "string" || block.entry.trim() === "") return { error: "`subshell.entry` must be a non-empty relative path" };
 	if (block.entry.startsWith("/") || block.entry.split("/").includes("..")) return { error: "`subshell.entry` must stay inside the package (no leading `/` and no `..` segment)" };
 	let detect;
@@ -80,23 +96,23 @@ function parseManifest(pkgJson) {
 //#endregion
 //#region ../../plugin-api/dist/index.js
 /**
-* The profile checks every built-in harness performs unchanged: a non-empty
+* The preset checks every built-in harness performs unchanged: a non-empty
 * name, string env values, and flags that look like flags. Harnesses with
 * extra rules run their own checks on top of these.
-* @param profile - The decoded profile definition to check
+* @param preset - The decoded preset definition to check
 * @returns Issues per field; `valid` is true when no issues were found
 */
-function validateGenericProfile(profile) {
+function validateGenericPreset(preset) {
 	const issues = [];
-	if (!profile.name || profile.name.trim().length === 0) issues.push({
+	if (!preset.name || preset.name.trim().length === 0) issues.push({
 		field: "name",
-		message: "Profile name is required."
+		message: "Preset name is required."
 	});
-	for (const [key, value] of Object.entries(profile.env)) if (typeof value !== "string") issues.push({
+	for (const [key, value] of Object.entries(preset.env)) if (typeof value !== "string") issues.push({
 		field: "env",
 		message: `Env var "${key}" must be a string.`
 	});
-	for (const flag of profile.flags) if (!flag.startsWith("-")) issues.push({
+	for (const flag of preset.flags) if (!flag.startsWith("-")) issues.push({
 		field: "flags",
 		message: `Flag "${flag}" must start with "-".`
 	});
@@ -118,7 +134,7 @@ function validateGenericProfile(profile) {
 const parsed = parseManifest({
 	name: "@subshell-ai/plugin-codex",
 	description: "Codex harness plugin for Subshell",
-	version: "0.1.1",
+	version: "0.2.0",
 	license: "Apache-2.0",
 	type: "module",
 	main: "dist/index.js",
@@ -152,15 +168,15 @@ const parsed = parseManifest({
 		"tsdown": "0.22.14",
 		"typescript": "7.0.2"
 	},
-	files: ["dist"],
+	files: ["dist", "icon.svg"],
 	publishConfig: { "access": "public" },
 	subshell: {
-		"apiVersion": 1,
+		"apiVersion": 2,
 		"id": "codex",
 		"type": "agent-harness",
 		"name": "Codex",
 		"description": "OpenAI's agentic coding CLI (interactive TUI)",
-		"icon": "📖",
+		"icon": "icon.svg",
 		"entry": "dist/index.js",
 		"detect": {
 			"binaryName": "codex",
@@ -239,7 +255,7 @@ function tomlStringArray(values) {
 *
 * Launch shape:
 *   codex [-m <model>] [-s <sandbox>] [-a <approval>] [mcp -c pairs]
-*         [profile flags] [extra flags]
+*         [preset flags] [extra flags]
 * A bare launch (no subcommand, no prompt) opens the interactive TUI. Codex
 * has no create-time flag for naming its own session and no way to pin a
 * conversation id, so neither the subshell name nor a resume capability is
@@ -247,7 +263,7 @@ function tomlStringArray(values) {
 * The pane's
 * cwd is already the working directory, so `-C/--cd` is never passed, and
 * `--dangerously-bypass-approvals-and-sandbox` is NEVER baked into a launch
-* (a user may put it in their own profile flags — that is their call).
+* (a user may put it in their own preset flags — that is their call).
 *
 * subshell MCP is wired automatically WITHOUT touching user state: every
 * launch carries `-c mcp_servers.subshell.command=… -c mcp_servers.subshell.args=…`
@@ -268,14 +284,14 @@ function tomlStringArray(values) {
 const createPlugin = (_host) => ({
 	capabilities: () => ["mcp", "settings"],
 	buildCommand(input) {
-		const { binary, profile, extraFlags, mcp } = input;
+		const { binary, preset, extraFlags, mcp } = input;
 		const args = [binary];
-		const s = profile.settings ?? {};
+		const s = preset.settings ?? {};
 		if (typeof s.model === "string" && s.model) args.push("-m", s.model);
 		if (typeof s.sandbox === "string" && s.sandbox) args.push("-s", s.sandbox);
 		if (typeof s.askForApproval === "string" && s.askForApproval) args.push("-a", s.askForApproval);
 		if (mcp?.args) args.push(...mcp.args);
-		for (const flag of profile.flags) args.push(flag);
+		for (const flag of preset.flags) args.push(flag);
 		if (extraFlags) args.push(...extraFlags);
 		return args;
 	},
@@ -317,10 +333,10 @@ const createPlugin = (_host) => ({
 			summary: "Subshell registers itself with every Codex subshell automatically (per-invocation -c mcp_servers.subshell.* overrides; your ~/.codex config is never modified)."
 		};
 	},
-	validateProfile(profile) {
-		return validateGenericProfile(profile);
+	validatePreset(preset) {
+		return validateGenericPreset(preset);
 	},
-	profileSettings() {
+	presetSettings() {
 		return CODEX_SETTINGS_FIELDS;
 	},
 	suggestedEnv() {

package/icon.svg

@@ -0,0 +1,4 @@
+<svg viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg"><title>Codex</title>
+<circle cx="12" cy="12" r="12" fill="#0080F7"/>
+<path d="M9.94494 9.59163V8.13227C9.94494 8.00935 9.99105 7.91713 10.0985 7.85575L13.0327 6.16599C13.4321 5.93558 13.9083 5.8281 14.3998 5.8281C16.2432 5.8281 17.4108 7.25677 17.4108 8.77751C17.4108 8.885 17.4108 9.00792 17.3953 9.13083L14.3537 7.34884C14.1694 7.24135 13.985 7.24135 13.8007 7.34884L9.94494 9.59163ZM16.7963 15.2755V11.7883C16.7963 11.5732 16.704 11.4196 16.5197 11.3121L12.664 9.0693L13.9236 8.34725C14.0311 8.28587 14.1234 8.28587 14.2308 8.34725L17.165 10.037C18.0099 10.5287 18.5782 11.5732 18.5782 12.587C18.5782 13.7544 17.887 14.8298 16.7963 15.2753V15.2755ZM9.03861 12.2031L7.77896 11.4658C7.67146 11.4045 7.62535 11.3122 7.62535 11.1893V7.8098C7.62535 6.16613 8.88501 4.92176 10.5902 4.92176C11.2354 4.92176 11.8344 5.13689 12.3415 5.52089L9.31526 7.27218C9.13097 7.37968 9.03875 7.53328 9.03875 7.74841V12.2033L9.03861 12.2031ZM11.75 13.77L9.94494 12.7562V10.6056L11.75 9.59178L13.5549 10.6056V12.7562L11.75 13.77ZM12.9098 18.44C12.2645 18.44 11.6655 18.2249 11.1585 17.8409L14.1847 16.0896C14.369 15.9821 14.4612 15.8285 14.4612 15.6134V11.1585L15.7363 11.8958C15.8438 11.9572 15.8899 12.0494 15.8899 12.1723V15.5519C15.8899 17.1955 14.6148 18.44 12.9098 18.44ZM9.26901 15.0144L6.33486 13.3246C5.4899 12.833 4.92161 11.7885 4.92161 10.7746C4.92161 9.59177 5.62824 8.53183 6.71886 8.0863V11.5887C6.71886 11.8039 6.81109 11.9575 6.99538 12.065L10.8359 14.2923L9.57621 15.0144C9.46872 15.0758 9.37649 15.0758 9.26901 15.0144ZM9.10013 17.5337C7.36426 17.5337 6.08919 16.2279 6.08919 14.6149C6.08919 14.492 6.1046 14.3691 6.11988 14.2462L9.1461 15.9975C9.33039 16.105 9.51483 16.105 9.69912 15.9975L13.5549 13.7702V15.2295C13.5549 15.3524 13.5088 15.4446 13.4013 15.506L10.4671 17.1958C10.0677 17.4262 9.59148 17.5337 9.09999 17.5337H9.10013ZM12.9098 19.3616C14.7685 19.3616 16.32 18.0406 16.6735 16.2893C18.3939 15.8438 19.5 14.2308 19.5 12.5872C19.5 11.5118 19.0391 10.4673 18.2096 9.71454C18.2864 9.39192 18.3326 9.0693 18.3326 8.74682C18.3326 6.55014 16.5505 4.90634 14.4921 4.90634C14.0774 4.90634 13.6779 4.96772 13.2785 5.10605C12.5872 4.43011 11.6347 4 10.5902 4C8.7314 4 7.17996 5.32103 6.8265 7.07232C5.10605 7.51786 4 9.13083 4 10.7745C4 11.8498 4.4608 12.8944 5.29035 13.6471C5.21354 13.9697 5.16743 14.2923 5.16743 14.6148C5.16743 16.8114 6.94941 18.4552 9.00792 18.4552C9.42261 18.4552 9.82204 18.3939 10.2215 18.2556C10.9127 18.9315 11.8651 19.3616 12.9098 19.3616Z" fill="white"/>
+</svg>

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@subshell-ai/plugin-codex",
   "description": "Codex harness plugin for Subshell",
-  "version": "0.1.1",
+  "version": "0.2.0",
   "license": "Apache-2.0",
   "type": "module",
   "main": "dist/index.js",
@@ -39,19 +39,17 @@
     "tsdown": "0.22.14",
     "typescript": "7.0.2"
   },
-  "files": [
-    "dist"
-  ],
+  "files": ["dist", "icon.svg"],
   "publishConfig": {
     "access": "public"
   },
   "subshell": {
-    "apiVersion": 1,
+    "apiVersion": 2,
     "id": "codex",
     "type": "agent-harness",
     "name": "Codex",
     "description": "OpenAI's agentic coding CLI (interactive TUI)",
-    "icon": "📖",
+    "icon": "icon.svg",
     "entry": "dist/index.js",
     "detect": {
       "binaryName": "codex",