@sublang/playbook 13.3.0 → 14.0.0

package/slc/workflow-contracts.json

@@ -0,0 +1,371 @@
+{
+  "schema": "sublang.playbook.workflow-contracts.v1",
+  "package": "@sublang/playbook",
+  "artifactSchema": 3,
+  "runtimeAbi": 1,
+  "description": "Public output interfaces for the packaged builtin workflows. The selected pipeline declares literalTargetBindings as its default nested-target namespace; explicit Source or compiler-dependency bindings override defaults and require their own interfaces. Hosts must honor the compiled bindings. Child output fields retain child-owned authority, while the shared envelope and terminal kind govern transport and authored failure; a local basename alone establishes no binding.",
+  "$defs": {
+    "compactError": {
+      "type": "object",
+      "properties": {
+        "name": {
+          "type": "string"
+        },
+        "message": {
+          "type": "string"
+        }
+      },
+      "required": ["name", "message"],
+      "additionalProperties": false
+    },
+    "json": {
+      "anyOf": [
+        {
+          "type": "null"
+        },
+        {
+          "type": "boolean"
+        },
+        {
+          "type": "number"
+        },
+        {
+          "type": "string"
+        },
+        {
+          "type": "array",
+          "items": {
+            "$ref": "#/$defs/json"
+          }
+        },
+        {
+          "type": "object",
+          "additionalProperties": {
+            "$ref": "#/$defs/json"
+          }
+        }
+      ]
+    },
+    "completedCodeResult": {
+      "anyOf": [
+        {
+          "type": "object",
+          "properties": {
+            "playbookId": {
+              "const": "code"
+            },
+            "status": {
+              "const": "ok"
+            },
+            "output": {
+              "$ref": "#/$defs/json"
+            }
+          },
+          "required": ["playbookId", "status"],
+          "additionalProperties": false
+        },
+        {
+          "type": "object",
+          "properties": {
+            "playbookId": {
+              "const": "code"
+            },
+            "status": {
+              "enum": ["aborted", "error"]
+            },
+            "error": {
+              "$ref": "#/$defs/compactError"
+            }
+          },
+          "required": ["playbookId", "status", "error"],
+          "additionalProperties": false
+        }
+      ]
+    }
+  },
+  "workflows": {
+    "review": {
+      "callInput": "text",
+      "output": {
+        "type": "object",
+        "properties": {
+          "noUnsettledFindings": {
+            "const": true
+          },
+          "evaluatedRevision": {
+            "type": "string",
+            "description": "Exact receipt-observed repository revision evaluated by the final clean review round; it can include REVIEW-owned fixes after the caller's original commit."
+          }
+        },
+        "required": ["noUnsettledFindings", "evaluatedRevision"],
+        "additionalProperties": false
+      }
+    },
+    "decide": {
+      "callInput": "text",
+      "output": {
+        "anyOf": [
+          {
+            "type": "object",
+            "properties": {
+              "decideCommit": {
+                "type": "string",
+                "description": "Exact DECIDE-owned commit."
+              },
+              "evaluatedRevision": {
+                "type": "string",
+                "description": "Exact repository revision evaluated by the final passing review."
+              },
+              "noUnsettledFindings": {
+                "const": true
+              }
+            },
+            "required": [
+              "decideCommit",
+              "evaluatedRevision",
+              "noUnsettledFindings"
+            ],
+            "additionalProperties": false
+          },
+          {
+            "type": "object",
+            "properties": {
+              "lastDecideCommit": {
+                "type": "string",
+                "description": "Exact last DECIDE-owned commit."
+              },
+              "noUnsettledFindings": {
+                "const": false
+              },
+              "reviewStatus": {
+                "enum": ["aborted", "error"]
+              },
+              "error": {
+                "$ref": "#/$defs/compactError"
+              }
+            },
+            "required": [
+              "lastDecideCommit",
+              "noUnsettledFindings",
+              "reviewStatus"
+            ],
+            "additionalProperties": false
+          }
+        ]
+      }
+    },
+    "code": {
+      "callInput": "text",
+      "output": {
+        "anyOf": [
+          {
+            "type": "object",
+            "properties": {
+              "status": {
+                "const": "complete"
+              },
+              "lastCodeCommit": {
+                "type": "string",
+                "description": "Exact last CODE-owned commit; excludes REVIEW-owned fix commits."
+              },
+              "finalEvaluatedRevision": {
+                "type": "string",
+                "description": "Exact repository revision evaluated by the final passing review; it may differ from lastCodeCommit."
+              },
+              "allReviewsPassed": {
+                "const": true
+              }
+            },
+            "required": [
+              "status",
+              "lastCodeCommit",
+              "finalEvaluatedRevision",
+              "allReviewsPassed"
+            ],
+            "additionalProperties": false
+          },
+          {
+            "type": "object",
+            "properties": {
+              "status": {
+                "const": "review-failed"
+              },
+              "lastCodeCommit": {
+                "type": "string",
+                "description": "Exact last CODE-owned commit."
+              },
+              "error": {
+                "$ref": "#/$defs/compactError"
+              }
+            },
+            "required": ["status", "lastCodeCommit", "error"],
+            "additionalProperties": false
+          }
+        ]
+      }
+    },
+    "branch": {
+      "callInput": "text",
+      "output": {
+        "anyOf": [
+          {
+            "type": "object",
+            "properties": {
+              "status": {
+                "const": "branched"
+              },
+              "branch": {
+                "type": "string",
+                "description": "Exact new branch name."
+              },
+              "baseRevision": {
+                "type": "string",
+                "description": "Exact receipt-observed repository revision the branch was created from."
+              },
+              "issueSummary": {
+                "type": "string",
+                "description": "Concise issue-and-comments or request summary."
+              }
+            },
+            "required": ["status", "branch", "baseRevision", "issueSummary"],
+            "additionalProperties": false
+          },
+          {
+            "type": "object",
+            "properties": {
+              "status": {
+                "const": "refused"
+              },
+              "coderOutput": {
+                "type": "string",
+                "description": "Complete refusal report."
+              }
+            },
+            "required": ["status", "coderOutput"],
+            "additionalProperties": false
+          }
+        ]
+      }
+    },
+    "pr": {
+      "callInput": "text",
+      "output": {
+        "anyOf": [
+          {
+            "type": "object",
+            "properties": {
+              "status": {
+                "const": "merged"
+              },
+              "pullRequest": {
+                "type": "string",
+                "description": "Exact pull request number as reported."
+              },
+              "pullRequestUrl": {
+                "type": "string",
+                "description": "Exact pull request URL as reported."
+              },
+              "localDefaultUpdated": {
+                "type": "boolean"
+              }
+            },
+            "required": [
+              "status",
+              "pullRequest",
+              "pullRequestUrl",
+              "localDefaultUpdated"
+            ],
+            "additionalProperties": false
+          },
+          {
+            "type": "object",
+            "properties": {
+              "status": {
+                "const": "not-merged"
+              },
+              "reason": {
+                "const": "not-published"
+              },
+              "coderOutput": {
+                "type": "string",
+                "description": "Complete report explaining why publication did not occur."
+              }
+            },
+            "required": ["status", "reason", "coderOutput"],
+            "additionalProperties": false
+          },
+          {
+            "type": "object",
+            "properties": {
+              "status": {
+                "const": "not-merged"
+              },
+              "reason": {
+                "const": "fix-failed"
+              },
+              "pullRequest": {
+                "type": "string"
+              },
+              "pullRequestUrl": {
+                "type": "string"
+              },
+              "childResult": {
+                "$ref": "#/$defs/completedCodeResult"
+              }
+            },
+            "required": [
+              "status",
+              "reason",
+              "pullRequest",
+              "pullRequestUrl",
+              "childResult"
+            ],
+            "additionalProperties": false
+          },
+          {
+            "type": "object",
+            "properties": {
+              "status": {
+                "const": "not-merged"
+              },
+              "reason": {
+                "enum": ["fix-not-published", "checks-failed"]
+              },
+              "pullRequest": {
+                "type": "string"
+              },
+              "pullRequestUrl": {
+                "type": "string"
+              }
+            },
+            "required": ["status", "reason", "pullRequest", "pullRequestUrl"],
+            "additionalProperties": false
+          },
+          {
+            "type": "object",
+            "properties": {
+              "status": {
+                "const": "merge-unconfirmed"
+              },
+              "pullRequest": {
+                "type": "string"
+              },
+              "pullRequestUrl": {
+                "type": "string"
+              }
+            },
+            "required": ["status", "pullRequest", "pullRequestUrl"],
+            "additionalProperties": false
+          }
+        ]
+      }
+    }
+  },
+  "literalTargetBindings": {
+    "review": "review",
+    "decide": "decide",
+    "code": "code",
+    "branch": "branch",
+    "pr": "pr"
+  }
+}

package/src/xstate-playbook-runtime.js

@@ -2455,6 +2455,39 @@ export function createXStatePlaybookRuntime(machine, spec) {
                 throw new Error(`createPlaybookRuntime.${method}: deferred settlement recovery is required`, { cause: deferredSettlementClosure });
             }
         }
+        function pendingHasExactUnchangedOrigin(pending) {
+            // The outcome menu is not the selected outcome: a source-authored
+            // unchanged question may share its state with needsBossReply: deferred.
+            // An open operation nevertheless always retains its checkpoint and
+            // cumulative receipt authority, even if a later boundary looks alike.
+            if (runtimeLogicalOperations().some((operation) => operation.logicalReceipt === undefined)) {
+                return false;
+            }
+            const latest = effectLedgerMirror.boundaries
+                .filter(runtimeBoundaryIsOwned)
+                .at(-1);
+            if (latest === undefined ||
+                latest.sourceStateId !== pending.resumeStateId ||
+                pending.asker.kind !== 'role' ||
+                latest.roleId !== pending.asker.roleId ||
+                latest.logicalOperationId !== undefined ||
+                latest.physicalReceipt?.classification !== 'unchanged') {
+                return false;
+            }
+            // Reuse the persisted authority/receipt check rather than infer an arm
+            // from question prose or search older evidence for a convenient match.
+            const persisted = persistedBoundaryReconciliation(latest, effectLedgerMirror);
+            if (persisted === undefined ||
+                persisted.historicalDeferred ||
+                persisted.reconciliation.status !== 'resolved') {
+                return false;
+            }
+            const output = persisted.reconciliation.output;
+            const declaration = outcomeAuthority.governedPlayerStates[latest.sourceStateId]?.[output.guard];
+            return (declaration?.repositoryDisposition === 'unchanged' &&
+                typeof output.question === 'string' &&
+                output.question === pending.question);
+        }
         function currentBoundDeferredOperation(pending) {
             const projected = {
                 questionId: pending.questionId,
@@ -5779,7 +5812,8 @@ export function createXStatePlaybookRuntime(machine, spec) {
                             deferredPending = pendingBossQuestionForState(normalizePlaybookSnapshot(snapshot), snapshotContext);
                             pendingRequiresDeferredBinding =
                                 deferredPending !== undefined &&
-                                    outcomeAuthority?.governedPlayerStates[deferredPending.resumeStateId]?.needsBossReply?.repositoryDisposition === 'deferred';
+                                    outcomeAuthority?.governedPlayerStates[deferredPending.resumeStateId]?.needsBossReply?.repositoryDisposition === 'deferred' &&
+                                    !pendingHasExactUnchangedOrigin(deferredPending);
                             deferredOperation =
                                 !pendingRequiresDeferredBinding
                                     ? undefined

package/src/xstate-playbook-runtime.ts

@@ -3987,6 +3987,58 @@ export function createXStatePlaybookRuntime<
       }
     }
 
+    function pendingHasExactUnchangedOrigin(
+      pending: PlaybookPendingBossQuestionContext,
+    ): boolean {
+      // The outcome menu is not the selected outcome: a source-authored
+      // unchanged question may share its state with needsBossReply: deferred.
+      // An open operation nevertheless always retains its checkpoint and
+      // cumulative receipt authority, even if a later boundary looks alike.
+      if (
+        runtimeLogicalOperations().some(
+          (operation) => operation.logicalReceipt === undefined,
+        )
+      ) {
+        return false;
+      }
+      const latest = effectLedgerMirror.boundaries
+        .filter(runtimeBoundaryIsOwned)
+        .at(-1);
+      if (
+        latest === undefined ||
+        latest.sourceStateId !== pending.resumeStateId ||
+        pending.asker.kind !== 'role' ||
+        latest.roleId !== pending.asker.roleId ||
+        latest.logicalOperationId !== undefined ||
+        latest.physicalReceipt?.classification !== 'unchanged'
+      ) {
+        return false;
+      }
+      // Reuse the persisted authority/receipt check rather than infer an arm
+      // from question prose or search older evidence for a convenient match.
+      const persisted = persistedBoundaryReconciliation(
+        latest,
+        effectLedgerMirror,
+      );
+      if (
+        persisted === undefined ||
+        persisted.historicalDeferred ||
+        persisted.reconciliation.status !== 'resolved'
+      ) {
+        return false;
+      }
+      const output = persisted.reconciliation.output;
+      const declaration =
+        outcomeAuthority.governedPlayerStates[latest.sourceStateId]?.[
+          output.guard
+        ];
+      return (
+        declaration?.repositoryDisposition === 'unchanged' &&
+        typeof output.question === 'string' &&
+        output.question === pending.question
+      );
+    }
+
     function currentBoundDeferredOperation(
       pending: PlaybookPendingBossQuestionContext,
     ): PlaybookEffectLogicalOperation | undefined {
@@ -8313,7 +8365,8 @@ export function createXStatePlaybookRuntime<
                 deferredPending !== undefined &&
                 outcomeAuthority?.governedPlayerStates[
                   deferredPending.resumeStateId
-                ]?.needsBossReply?.repositoryDisposition === 'deferred';
+                ]?.needsBossReply?.repositoryDisposition === 'deferred' &&
+                !pendingHasExactUnchangedOrigin(deferredPending);
               deferredOperation =
                 !pendingRequiresDeferredBinding
                   ? undefined