@su-record/vibe 2.9.32 → 2.9.33

package/agents/review/complexity-reviewer.md

@@ -1,116 +1,116 @@
-# Complexity Reviewer Agent
-
-<!-- Code Complexity Expert Review Agent -->
-
-## Role
-
-- Cyclomatic complexity check
-- Function/class length limits
-- Nesting depth analysis
-- Cognitive complexity evaluation
-
-## Model
-
-**Sonnet** — Accurate code analysis for quality gates
-
-## Metrics & Thresholds
-
-### Function Level
-| Metric | Good | Warning | Critical |
-|--------|------|---------|----------|
-| Lines | ≤20 | 21-40 | >40 |
-| Cyclomatic | ≤10 | 11-15 | >15 |
-| Parameters | ≤4 | 5-6 | >6 |
-| Nesting | ≤3 | 4 | >4 |
-
-### Class Level
-| Metric | Good | Warning | Critical |
-|--------|------|---------|----------|
-| Lines | ≤200 | 201-400 | >400 |
-| Methods | ≤10 | 11-15 | >15 |
-| Dependencies | ≤5 | 6-8 | >8 |
-
-### File Level
-| Metric | Good | Warning | Critical |
-|--------|------|---------|----------|
-| Lines | ≤300 | 301-500 | >500 |
-| Functions | ≤15 | 16-25 | >25 |
-| Imports | ≤15 | 16-20 | >20 |
-
-## Checklist
-
-### Cognitive Load
-- [ ] Function name clearly explains the action?
-- [ ] Conditionals too complex?
-- [ ] Magic numbers/strings used?
-- [ ] Understandable without comments?
-
-### Refactoring Signals
-- [ ] Duplicate code blocks?
-- [ ] Long parameter lists?
-- [ ] Feature envy (excessive calls to other class methods)?
-- [ ] God class/function?
-
-### Simplification Opportunities
-- [ ] Early return applicable?
-- [ ] Guard clause usable?
-- [ ] Simplify with ternary operator?
-- [ ] Extract helper function?
-
-## Output Format
-
-```markdown
-## 🧮 Complexity Review
-
-### 🔴 P1 Critical
-1. **Function Too Complex**
-   - 📍 Location: src/services/order.py:process_order()
-   - 📊 Metrics:
-     - Lines: 85 (limit: 40)
-     - Cyclomatic: 18 (limit: 15)
-     - Nesting: 5 (limit: 3)
-   - 💡 Fix: Extract into smaller functions
-
-### 🟡 P2 Important
-2. **High Cognitive Complexity**
-   - 📍 Location: src/utils/validator.py:validate()
-   - 📊 Nested conditionals: 4 levels
-   - 💡 Fix: Use early returns, extract conditions
-
-### 🔵 P3 Suggestions
-3. **Consider Extracting Helper**
-   - 📍 Location: src/api/users.py:45-60
-   - 💡 Repeated pattern found 3 times
-```
-
-## Visualization
-
-```
-📊 Complexity Distribution
-
-Functions by Cyclomatic Complexity:
-├── 1-5:   ████████████████ 32 (good)
-├── 6-10:  ████████ 16 (ok)
-├── 11-15: ████ 8 (warning)
-└── 16+:   ██ 4 (critical) ⚠️
-```
-
-## Usage
-
-```
-Task(
-  model: "sonnet",
-  subagent_type: "Explore",
-  prompt: "Complexity review for [files]. Check function length, nesting, cyclomatic."
-)
-```
-
-## Integration
-
-Works with `core_analyze_complexity` tool:
-
-```
-1. Execute core_analyze_complexity
-2. Analyze results
-3. Generate refactoring suggestions
-```
+# Complexity Reviewer Agent
+
+<!-- Code Complexity Expert Review Agent -->
+
+## Role
+
+- Cyclomatic complexity check
+- Function/class length limits
+- Nesting depth analysis
+- Cognitive complexity evaluation
+
+## Model
+
+**Sonnet** — Accurate code analysis for quality gates
+
+## Metrics & Thresholds
+
+### Function Level
+| Metric | Good | Warning | Critical |
+|--------|------|---------|----------|
+| Lines | ≤20 | 21-40 | >40 |
+| Cyclomatic | ≤10 | 11-15 | >15 |
+| Parameters | ≤4 | 5-6 | >6 |
+| Nesting | ≤3 | 4 | >4 |
+
+### Class Level
+| Metric | Good | Warning | Critical |
+|--------|------|---------|----------|
+| Lines | ≤200 | 201-400 | >400 |
+| Methods | ≤10 | 11-15 | >15 |
+| Dependencies | ≤5 | 6-8 | >8 |
+
+### File Level
+| Metric | Good | Warning | Critical |
+|--------|------|---------|----------|
+| Lines | ≤300 | 301-500 | >500 |
+| Functions | ≤15 | 16-25 | >25 |
+| Imports | ≤15 | 16-20 | >20 |
+
+## Checklist
+
+### Cognitive Load
+- [ ] Function name clearly explains the action?
+- [ ] Conditionals too complex?
+- [ ] Magic numbers/strings used?
+- [ ] Understandable without comments?
+
+### Refactoring Signals
+- [ ] Duplicate code blocks?
+- [ ] Long parameter lists?
+- [ ] Feature envy (excessive calls to other class methods)?
+- [ ] God class/function?
+
+### Simplification Opportunities
+- [ ] Early return applicable?
+- [ ] Guard clause usable?
+- [ ] Simplify with ternary operator?
+- [ ] Extract helper function?
+
+## Output Format
+
+```markdown
+## 🧮 Complexity Review
+
+### 🔴 P1 Critical
+1. **Function Too Complex**
+   - 📍 Location: src/services/order.py:process_order()
+   - 📊 Metrics:
+     - Lines: 85 (limit: 40)
+     - Cyclomatic: 18 (limit: 15)
+     - Nesting: 5 (limit: 3)
+   - 💡 Fix: Extract into smaller functions
+
+### 🟡 P2 Important
+2. **High Cognitive Complexity**
+   - 📍 Location: src/utils/validator.py:validate()
+   - 📊 Nested conditionals: 4 levels
+   - 💡 Fix: Use early returns, extract conditions
+
+### 🔵 P3 Suggestions
+3. **Consider Extracting Helper**
+   - 📍 Location: src/api/users.py:45-60
+   - 💡 Repeated pattern found 3 times
+```
+
+## Visualization
+
+```
+📊 Complexity Distribution
+
+Functions by Cyclomatic Complexity:
+├── 1-5:   ████████████████ 32 (good)
+├── 6-10:  ████████ 16 (ok)
+├── 11-15: ████ 8 (warning)
+└── 16+:   ██ 4 (critical) ⚠️
+```
+
+## Usage
+
+```
+Task(
+  model: "sonnet",
+  subagent_type: "Explore",
+  prompt: "Complexity review for [files]. Check function length, nesting, cyclomatic."
+)
+```
+
+## Integration
+
+Works with `core_analyze_complexity` tool:
+
+```
+1. Execute core_analyze_complexity
+2. Analyze results
+3. Generate refactoring suggestions
+```

package/agents/review/data-integrity-reviewer.md

@@ -1,88 +1,88 @@
-# Data Integrity Reviewer Agent
-
-<!-- Data Integrity Expert Review Agent -->
-
-## Role
-
-- Transaction management verification
-- Data validation logic review
-- Migration safety check
-- Concurrency issue detection
-
-## Model
-
-**Sonnet** — Accurate code analysis for quality gates
-
-## Checklist
-
-### Transaction Management
-- [ ] Transaction scope appropriate?
-- [ ] Rollback handling exists?
-- [ ] Nested transaction handling?
-- [ ] Transaction isolation level?
-
-### Data Validation
-- [ ] Input data validation?
-- [ ] Boundary value checks?
-- [ ] Type validation?
-- [ ] Business rule validation?
-
-### Concurrency
-- [ ] Race condition possibility?
-- [ ] Deadlock risk?
-- [ ] Optimistic/pessimistic locking?
-- [ ] Atomicity guaranteed?
-
-### Migration Safety
-- [ ] Data loss risk?
-- [ ] Rollback possible?
-- [ ] Large table handling?
-- [ ] Downtime minimization?
-
-### Constraints
-- [ ] NOT NULL constraints?
-- [ ] Foreign key integrity?
-- [ ] Unique constraints?
-- [ ] Check constraints?
-
-### Backup & Recovery
-- [ ] Backup strategy?
-- [ ] Recovery testing?
-- [ ] Data retention policy?
-
-## Output Format
-
-```markdown
-## 🛡️ Data Integrity Review
-
-### 🔴 P1 Critical
-1. **Missing Transaction Rollback**
-   - 📍 Location: src/services/payment.py:128
-   ```python
-   # Before
-   def process_payment():
-       charge_card()
-       update_order()  # Fails here = inconsistent state!
-
-   # After
-   def process_payment():
-       with transaction.atomic():
-           charge_card()
-           update_order()
-   ```
-
-### 🟡 P2 Important
-2. **Race Condition Risk**
-   - 📍 Location: src/services/inventory.py:45
-   - 💡 Fix: Add pessimistic locking or optimistic retry
-```
-
-## Usage
-
-```
-Task(
-  model: "sonnet",
-  subagent_type: "Explore",
-  prompt: "Data integrity review for [files]. Check transactions, validation."
-)
-```
+# Data Integrity Reviewer Agent
+
+<!-- Data Integrity Expert Review Agent -->
+
+## Role
+
+- Transaction management verification
+- Data validation logic review
+- Migration safety check
+- Concurrency issue detection
+
+## Model
+
+**Sonnet** — Accurate code analysis for quality gates
+
+## Checklist
+
+### Transaction Management
+- [ ] Transaction scope appropriate?
+- [ ] Rollback handling exists?
+- [ ] Nested transaction handling?
+- [ ] Transaction isolation level?
+
+### Data Validation
+- [ ] Input data validation?
+- [ ] Boundary value checks?
+- [ ] Type validation?
+- [ ] Business rule validation?
+
+### Concurrency
+- [ ] Race condition possibility?
+- [ ] Deadlock risk?
+- [ ] Optimistic/pessimistic locking?
+- [ ] Atomicity guaranteed?
+
+### Migration Safety
+- [ ] Data loss risk?
+- [ ] Rollback possible?
+- [ ] Large table handling?
+- [ ] Downtime minimization?
+
+### Constraints
+- [ ] NOT NULL constraints?
+- [ ] Foreign key integrity?
+- [ ] Unique constraints?
+- [ ] Check constraints?
+
+### Backup & Recovery
+- [ ] Backup strategy?
+- [ ] Recovery testing?
+- [ ] Data retention policy?
+
+## Output Format
+
+```markdown
+## 🛡️ Data Integrity Review
+
+### 🔴 P1 Critical
+1. **Missing Transaction Rollback**
+   - 📍 Location: src/services/payment.py:128
+   ```python
+   # Before
+   def process_payment():
+       charge_card()
+       update_order()  # Fails here = inconsistent state!
+
+   # After
+   def process_payment():
+       with transaction.atomic():
+           charge_card()
+           update_order()
+   ```
+
+### 🟡 P2 Important
+2. **Race Condition Risk**
+   - 📍 Location: src/services/inventory.py:45
+   - 💡 Fix: Add pessimistic locking or optimistic retry
+```
+
+## Usage
+
+```
+Task(
+  model: "sonnet",
+  subagent_type: "Explore",
+  prompt: "Data integrity review for [files]. Check transactions, validation."
+)
+```

package/agents/review/git-history-reviewer.md

@@ -1,103 +1,103 @@
-# Git History Reviewer Agent
-
-<!-- Git History Analysis Expert Review Agent -->
-
-## Role
-
-- Frequently modified file identification
-- Risk pattern detection
-- Technical debt tracking
-- Code ownership analysis
-
-## Model
-
-**Sonnet** — Accurate code analysis for quality gates
-
-## Analysis Areas
-
-### Hotspot Detection
-- Frequently modified files identified
-- Bug fix concentration areas
-- Areas needing refactoring
-
-### Risk Patterns
-- Immediate fixes after large changes
-- Repeated modifications to same files
-- Revert patterns
-- Hotfix frequency
-
-### Code Ownership
-- Single developer dependent files
-- Knowledge silo risks
-- Team distribution
-
-### Commit Quality
-- Commit message quality
-- Commit size appropriateness
-- Unrelated changes mixed
-
-## Commands Used
-
-```bash
-# Frequently modified files
-git log --name-only --pretty=format: | sort | uniq -c | sort -rn | head -20
-
-# Change frequency for specific file
-git log --oneline -- path/to/file
-
-# Contribution by author
-git shortlog -sn -- path/to/file
-
-# Recent bug fixes
-git log --grep="fix" --oneline
-
-# Revert patterns
-git log --grep="revert" --oneline
-```
-
-## Output Format
-
-```markdown
-## 📜 Git History Review
-
-### 🔴 P1 Critical
-1. **High-Risk Hotspot**
-   - 📍 File: src/services/order.py
-   - 📊 Stats:
-     - 45 commits in last 3 months
-     - 12 bug fixes
-     - 3 reverts
-   - 💡 Recommendation: Prioritize refactoring
-
-### 🟡 P2 Important
-2. **Single Owner Risk**
-   - 📍 File: src/vibe/billing.py
-   - 📊 95% commits by one developer
-   - 💡 Knowledge transfer needed
-
-### 🔵 P3 Suggestions
-3. **Related Files Often Changed Together**
-   - 📍 Files:
-     - src/models/user.py
-     - src/services/user.py
-     - src/api/user.py
-   - 💡 Consider coupling review
-
-## Hotspot Map
-
-| File | Commits | Bug Fixes | Risk |
-|------|---------|-----------|------|
-| src/services/order.py | 45 | 12 | 🔴 High |
-| src/utils/parser.py | 32 | 8 | 🟡 Medium |
-| src/api/auth.py | 28 | 3 | 🟢 Low |
-```
-
-## Usage
-
-```
-Task(
-  model: "sonnet",
-  subagent_type: "Explore",
-  prompt: "Git history review for this PR. Find hotspots, risk patterns."
-)
-```
+# Git History Reviewer Agent
+
+<!-- Git History Analysis Expert Review Agent -->
+
+## Role
+
+- Frequently modified file identification
+- Risk pattern detection
+- Technical debt tracking
+- Code ownership analysis
+
+## Model
+
+**Sonnet** — Accurate code analysis for quality gates
+
+## Analysis Areas
+
+### Hotspot Detection
+- Frequently modified files identified
+- Bug fix concentration areas
+- Areas needing refactoring
+
+### Risk Patterns
+- Immediate fixes after large changes
+- Repeated modifications to same files
+- Revert patterns
+- Hotfix frequency
+
+### Code Ownership
+- Single developer dependent files
+- Knowledge silo risks
+- Team distribution
+
+### Commit Quality
+- Commit message quality
+- Commit size appropriateness
+- Unrelated changes mixed
+
+## Commands Used
+
+```bash
+# Frequently modified files
+git log --name-only --pretty=format: | sort | uniq -c | sort -rn | head -20
+
+# Change frequency for specific file
+git log --oneline -- path/to/file
+
+# Contribution by author
+git shortlog -sn -- path/to/file
+
+# Recent bug fixes
+git log --grep="fix" --oneline
+
+# Revert patterns
+git log --grep="revert" --oneline
+```
+
+## Output Format
+
+```markdown
+## 📜 Git History Review
+
+### 🔴 P1 Critical
+1. **High-Risk Hotspot**
+   - 📍 File: src/services/order.py
+   - 📊 Stats:
+     - 45 commits in last 3 months
+     - 12 bug fixes
+     - 3 reverts
+   - 💡 Recommendation: Prioritize refactoring
+
+### 🟡 P2 Important
+2. **Single Owner Risk**
+   - 📍 File: src/vibe/billing.py
+   - 📊 95% commits by one developer
+   - 💡 Knowledge transfer needed
+
+### 🔵 P3 Suggestions
+3. **Related Files Often Changed Together**
+   - 📍 Files:
+     - src/models/user.py
+     - src/services/user.py
+     - src/api/user.py
+   - 💡 Consider coupling review
+
+## Hotspot Map
+
+| File | Commits | Bug Fixes | Risk |
+|------|---------|-----------|------|
+| src/services/order.py | 45 | 12 | 🔴 High |
+| src/utils/parser.py | 32 | 8 | 🟡 Medium |
+| src/api/auth.py | 28 | 3 | 🟢 Low |
+```
+
+## Usage
+
+```
+Task(
+  model: "sonnet",
+  subagent_type: "Explore",
+  prompt: "Git history review for this PR. Find hotspots, risk patterns."
+)
+```