@su-record/vibe 2.9.18 → 2.9.20

package/skills/arch-guard/scripts/check-boundaries.js

@@ -1,90 +1,90 @@
-#!/usr/bin/env node
-/**
- * arch-guard/scripts/check-boundaries.js
- * Read arch-rules.json and scan imports for violations.
- * Usage: node check-boundaries.js [arch-rules.json] [src-dir]
- * Output: JSON array of violations to stdout.
- */
-
-import fs from 'fs';
-import path from 'path';
-
-const IMPORT_RE = /(?:import|from|require)\s*\(?['"]([^'"]+)['"]\)?/g;
-const CODE_EXTS = new Set(['.ts', '.tsx', '.js', '.jsx']);
-
-/** @returns {string[]} */
-function collectFiles(dir) {
-  if (!fs.existsSync(dir)) return [];
-  const results = [];
-  for (const entry of fs.readdirSync(dir, { withFileTypes: true })) {
-    if (entry.name.startsWith('.') || entry.name === 'node_modules' || entry.name === 'dist') continue;
-    const full = path.join(dir, entry.name);
-    if (entry.isDirectory()) results.push(...collectFiles(full));
-    else if (CODE_EXTS.has(path.extname(entry.name))) results.push(full);
-  }
-  return results;
-}
-
-/** @param {string} pattern @param {string} filePath @returns {boolean} */
-function matchesGlob(pattern, filePath) {
-  const normalized = filePath.replace(/\\/g, '/');
-  const regexStr = pattern
-    .replace(/\\/g, '/')
-    .replace(/\./g, '\\.')
-    .replace(/\*\*/g, '__DOUBLE__')
-    .replace(/\*/g, '[^/]+')
-    .replace(/__DOUBLE__/g, '.+');
-  return new RegExp(`^${regexStr}$`).test(normalized);
-}
-
-/** @param {string} file @returns {string[]} */
-function extractImports(file) {
-  const content = fs.readFileSync(file, 'utf-8');
-  const imports = [];
-  let m;
-  IMPORT_RE.lastIndex = 0;
-  while ((m = IMPORT_RE.exec(content)) !== null) imports.push(m[1]);
-  return imports;
-}
-
-/** @param {string} fromFile @param {string} imp @param {string} baseDir @returns {string} */
-function resolveImport(fromFile, imp, baseDir) {
-  if (!imp.startsWith('.')) return imp;
-  return path.resolve(path.dirname(fromFile), imp).replace(baseDir + path.sep, '').replace(/\\/g, '/');
-}
-
-const rulesPath = process.argv[2] || '.claude/vibe/arch-rules.json';
-const srcDir = path.resolve(process.argv[3] || 'src');
-const baseDir = path.resolve('.');
-
-if (!fs.existsSync(rulesPath)) {
-  process.stderr.write(`arch-rules.json not found: ${rulesPath}\n`);
-  process.exit(1);
-}
-
-const { rules } = JSON.parse(fs.readFileSync(rulesPath, 'utf-8'));
-const files = collectFiles(srcDir);
-const violations = [];
-
-for (const rule of rules) {
-  const fromFiles = files.filter(f => matchesGlob(rule.from, f.replace(baseDir + path.sep, '').replace(/\\/g, '/')));
-  for (const file of fromFiles) {
-    const imports = extractImports(file);
-    for (const imp of imports) {
-      const resolved = resolveImport(file, imp, baseDir);
-      const forbidden = (rule.cannotImport || []).some(pat => matchesGlob(pat, resolved) || resolved.includes(pat.replace('/**', '').replace('**/', '')));
-      if (forbidden) {
-        violations.push({
-          rule: rule.name,
-          file: file.replace(baseDir + path.sep, '').replace(/\\/g, '/'),
-          import: imp,
-          resolved,
-          reason: rule.reason || `Violates rule: ${rule.name}`,
-        });
-      }
-    }
-  }
-}
-
-process.stdout.write(JSON.stringify(violations, null, 2) + '\n');
-if (violations.length > 0) process.exit(1);
+#!/usr/bin/env node
+/**
+ * arch-guard/scripts/check-boundaries.js
+ * Read arch-rules.json and scan imports for violations.
+ * Usage: node check-boundaries.js [arch-rules.json] [src-dir]
+ * Output: JSON array of violations to stdout.
+ */
+
+import fs from 'fs';
+import path from 'path';
+
+const IMPORT_RE = /(?:import|from|require)\s*\(?['"]([^'"]+)['"]\)?/g;
+const CODE_EXTS = new Set(['.ts', '.tsx', '.js', '.jsx']);
+
+/** @returns {string[]} */
+function collectFiles(dir) {
+  if (!fs.existsSync(dir)) return [];
+  const results = [];
+  for (const entry of fs.readdirSync(dir, { withFileTypes: true })) {
+    if (entry.name.startsWith('.') || entry.name === 'node_modules' || entry.name === 'dist') continue;
+    const full = path.join(dir, entry.name);
+    if (entry.isDirectory()) results.push(...collectFiles(full));
+    else if (CODE_EXTS.has(path.extname(entry.name))) results.push(full);
+  }
+  return results;
+}
+
+/** @param {string} pattern @param {string} filePath @returns {boolean} */
+function matchesGlob(pattern, filePath) {
+  const normalized = filePath.replace(/\\/g, '/');
+  const regexStr = pattern
+    .replace(/\\/g, '/')
+    .replace(/\./g, '\\.')
+    .replace(/\*\*/g, '__DOUBLE__')
+    .replace(/\*/g, '[^/]+')
+    .replace(/__DOUBLE__/g, '.+');
+  return new RegExp(`^${regexStr}$`).test(normalized);
+}
+
+/** @param {string} file @returns {string[]} */
+function extractImports(file) {
+  const content = fs.readFileSync(file, 'utf-8');
+  const imports = [];
+  let m;
+  IMPORT_RE.lastIndex = 0;
+  while ((m = IMPORT_RE.exec(content)) !== null) imports.push(m[1]);
+  return imports;
+}
+
+/** @param {string} fromFile @param {string} imp @param {string} baseDir @returns {string} */
+function resolveImport(fromFile, imp, baseDir) {
+  if (!imp.startsWith('.')) return imp;
+  return path.resolve(path.dirname(fromFile), imp).replace(baseDir + path.sep, '').replace(/\\/g, '/');
+}
+
+const rulesPath = process.argv[2] || '.claude/vibe/arch-rules.json';
+const srcDir = path.resolve(process.argv[3] || 'src');
+const baseDir = path.resolve('.');
+
+if (!fs.existsSync(rulesPath)) {
+  process.stderr.write(`arch-rules.json not found: ${rulesPath}\n`);
+  process.exit(1);
+}
+
+const { rules } = JSON.parse(fs.readFileSync(rulesPath, 'utf-8'));
+const files = collectFiles(srcDir);
+const violations = [];
+
+for (const rule of rules) {
+  const fromFiles = files.filter(f => matchesGlob(rule.from, f.replace(baseDir + path.sep, '').replace(/\\/g, '/')));
+  for (const file of fromFiles) {
+    const imports = extractImports(file);
+    for (const imp of imports) {
+      const resolved = resolveImport(file, imp, baseDir);
+      const forbidden = (rule.cannotImport || []).some(pat => matchesGlob(pat, resolved) || resolved.includes(pat.replace('/**', '').replace('**/', '')));
+      if (forbidden) {
+        violations.push({
+          rule: rule.name,
+          file: file.replace(baseDir + path.sep, '').replace(/\\/g, '/'),
+          import: imp,
+          resolved,
+          reason: rule.reason || `Violates rule: ${rule.name}`,
+        });
+      }
+    }
+  }
+}
+
+process.stdout.write(JSON.stringify(violations, null, 2) + '\n');
+if (violations.length > 0) process.exit(1);

package/skills/arch-guard/templates/arch-rules.json

@@ -1,47 +1,47 @@
-{
-  "_comment": "Architecture boundary rules for arch-guard. Copy to .claude/vibe/arch-rules.json and customize.",
-  "rules": [
-    {
-      "name": "services-no-ui",
-      "from": "src/services/**",
-      "cannotImport": ["src/components/**", "src/pages/**", "src/app/**"],
-      "canImport": ["src/models/**", "src/utils/**", "src/types/**"],
-      "reason": "Services must be UI-agnostic for testability and reuse"
-    },
-    {
-      "name": "domain-no-infra",
-      "from": "src/domain/**",
-      "cannotImport": ["src/infra/**", "src/db/**", "src/adapters/**"],
-      "canImport": ["src/domain/**", "src/types/**"],
-      "reason": "Domain layer must not depend on infrastructure (Clean Architecture)"
-    },
-    {
-      "name": "components-no-pages",
-      "from": "src/components/**",
-      "cannotImport": ["src/pages/**", "src/app/**"],
-      "canImport": ["src/components/**", "src/hooks/**", "src/utils/**", "src/types/**"],
-      "reason": "Shared components must not import from page-level modules"
-    },
-    {
-      "name": "lib-no-components",
-      "from": "src/lib/**",
-      "cannotImport": ["src/components/**", "src/pages/**"],
-      "canImport": ["src/lib/**", "src/types/**"],
-      "reason": "Library utilities must be framework-agnostic"
-    },
-    {
-      "name": "models-no-controllers",
-      "from": "src/models/**",
-      "cannotImport": ["src/controllers/**", "src/handlers/**", "src/routes/**"],
-      "canImport": ["src/models/**", "src/types/**"],
-      "reason": "Models must not depend on request/response layer (MVC)"
-    },
-    {
-      "name": "no-direct-db-in-handlers",
-      "from": "src/handlers/**",
-      "cannotImport": ["src/db/**", "src/repositories/**"],
-      "canImport": ["src/services/**", "src/types/**"],
-      "reason": "Handlers must use services, not access the database directly"
-    }
-  ]
-}
+{
+  "_comment": "Architecture boundary rules for arch-guard. Copy to .claude/vibe/arch-rules.json and customize.",
+  "rules": [
+    {
+      "name": "services-no-ui",
+      "from": "src/services/**",
+      "cannotImport": ["src/components/**", "src/pages/**", "src/app/**"],
+      "canImport": ["src/models/**", "src/utils/**", "src/types/**"],
+      "reason": "Services must be UI-agnostic for testability and reuse"
+    },
+    {
+      "name": "domain-no-infra",
+      "from": "src/domain/**",
+      "cannotImport": ["src/infra/**", "src/db/**", "src/adapters/**"],
+      "canImport": ["src/domain/**", "src/types/**"],
+      "reason": "Domain layer must not depend on infrastructure (Clean Architecture)"
+    },
+    {
+      "name": "components-no-pages",
+      "from": "src/components/**",
+      "cannotImport": ["src/pages/**", "src/app/**"],
+      "canImport": ["src/components/**", "src/hooks/**", "src/utils/**", "src/types/**"],
+      "reason": "Shared components must not import from page-level modules"
+    },
+    {
+      "name": "lib-no-components",
+      "from": "src/lib/**",
+      "cannotImport": ["src/components/**", "src/pages/**"],
+      "canImport": ["src/lib/**", "src/types/**"],
+      "reason": "Library utilities must be framework-agnostic"
+    },
+    {
+      "name": "models-no-controllers",
+      "from": "src/models/**",
+      "cannotImport": ["src/controllers/**", "src/handlers/**", "src/routes/**"],
+      "canImport": ["src/models/**", "src/types/**"],
+      "reason": "Models must not depend on request/response layer (MVC)"
+    },
+    {
+      "name": "no-direct-db-in-handlers",
+      "from": "src/handlers/**",
+      "cannotImport": ["src/db/**", "src/repositories/**"],
+      "canImport": ["src/services/**", "src/types/**"],
+      "reason": "Handlers must use services, not access the database directly"
+    }
+  ]
+}

package/skills/arch-guard/templates/violation-report.md

@@ -1,53 +1,53 @@
-# Architecture Violation Report
-
-**Project**: {{PROJECT_NAME}}
-**Date**: {{DATE}}
-**Rules File**: {{RULES_FILE}}
-**Total Violations**: {{VIOLATION_COUNT}}
-
----
-
-## Summary
-
-| Rule | Violations |
-|------|-----------|
-{{RULE_SUMMARY_TABLE}}
-
----
-
-## Violations by Rule
-
-{{VIOLATIONS_BY_RULE}}
-
-<!-- Example entry:
-### services-no-ui (3 violations)
-
-**Rule**: Services must be UI-agnostic for testability and reuse
-
-| File | Forbidden Import |
-|------|-----------------|
-| src/services/auth.ts | src/components/Button.tsx |
-| src/services/user.ts | src/pages/dashboard/index.ts |
--->
-
----
-
-## How to Fix
-
-For each violation, choose one:
-
-1. **Move the dependency** — relocate shared logic to a layer both sides can import
-2. **Invert the dependency** — use an interface/callback instead of a direct import
-3. **Promote the import** — move the imported file to a shared/common layer
-4. **Update the rule** — if the violation is intentional, document why and update arch-rules.json
-
-> Do NOT suppress violations without documenting the reason in arch-rules.json.
-
----
-
-## Next Steps
-
-1. Fix all violations in the table above
-2. Re-run: `node skills/arch-guard/scripts/check-boundaries.js {{RULES_FILE}} {{SRC_DIR}}`
-3. Commit clean state: `git commit -m "fix: resolve arch-guard boundary violations"`
-4. Add to CI: run check-boundaries.js in pre-commit or CI pipeline
+# Architecture Violation Report
+
+**Project**: {{PROJECT_NAME}}
+**Date**: {{DATE}}
+**Rules File**: {{RULES_FILE}}
+**Total Violations**: {{VIOLATION_COUNT}}
+
+---
+
+## Summary
+
+| Rule | Violations |
+|------|-----------|
+{{RULE_SUMMARY_TABLE}}
+
+---
+
+## Violations by Rule
+
+{{VIOLATIONS_BY_RULE}}
+
+<!-- Example entry:
+### services-no-ui (3 violations)
+
+**Rule**: Services must be UI-agnostic for testability and reuse
+
+| File | Forbidden Import |
+|------|-----------------|
+| src/services/auth.ts | src/components/Button.tsx |
+| src/services/user.ts | src/pages/dashboard/index.ts |
+-->
+
+---
+
+## How to Fix
+
+For each violation, choose one:
+
+1. **Move the dependency** — relocate shared logic to a layer both sides can import
+2. **Invert the dependency** — use an interface/callback instead of a direct import
+3. **Promote the import** — move the imported file to a shared/common layer
+4. **Update the rule** — if the violation is intentional, document why and update arch-rules.json
+
+> Do NOT suppress violations without documenting the reason in arch-rules.json.
+
+---
+
+## Next Steps
+
+1. Fix all violations in the table above
+2. Re-run: `node skills/arch-guard/scripts/check-boundaries.js {{RULES_FILE}} {{SRC_DIR}}`
+3. Commit clean state: `git commit -m "fix: resolve arch-guard boundary violations"`
+4. Add to CI: run check-boundaries.js in pre-commit or CI pipeline