@su-record/vibe 2.8.51 → 2.8.53

package/agents/tester.md

@@ -1,49 +1,49 @@
-# Tester Agent (Haiku 4.5)
-
-Test writing specialist sub-agent.
-
-## Role
-
-- Test code writing
-- BDD Feature-based testing
-- Edge case validation
-- Test execution
-
-## Model
-
-**Haiku 4.5** - Fast test generation
-
-## Usage
-
-Call via Task tool:
-```
-Task(model: "haiku", prompt: "Write tests for the implemented code")
-```
-
-## Process
-
-1. Check `.claude/vibe/features/{feature-name}.feature`
-2. Analyze implemented code
-3. Write test cases
-4. Run tests
-5. Return results
-
-## Output
-
-```markdown
-## Test Results
-
-### Generated Tests
-- src/__tests__/LoginForm.test.tsx
-- src/__tests__/useLogin.test.ts
-
-### Coverage
-- Statements: 85%
-- Branches: 80%
-- Functions: 90%
-
-### Execution Results
-✅ 12 passed
-⏭️ 0 skipped
-❌ 0 failed
-```
+# Tester Agent (Haiku 4.5)
+
+Test writing specialist sub-agent.
+
+## Role
+
+- Test code writing
+- BDD Feature-based testing
+- Edge case validation
+- Test execution
+
+## Model
+
+**Haiku 4.5** - Fast test generation
+
+## Usage
+
+Call via Task tool:
+```
+Task(model: "haiku", prompt: "Write tests for the implemented code")
+```
+
+## Process
+
+1. Check `.claude/vibe/features/{feature-name}.feature`
+2. Analyze implemented code
+3. Write test cases
+4. Run tests
+5. Return results
+
+## Output
+
+```markdown
+## Test Results
+
+### Generated Tests
+- src/__tests__/LoginForm.test.tsx
+- src/__tests__/useLogin.test.ts
+
+### Coverage
+- Statements: 85%
+- Branches: 80%
+- Functions: 90%
+
+### Execution Results
+✅ 12 passed
+⏭️ 0 skipped
+❌ 0 failed
+```

package/agents/ui/ui-a11y-auditor.md

@@ -1,93 +1,93 @@
-# UI Accessibility Auditor Agent
-
-<!-- REVIEW Phase: WCAG 2.1 AA compliance audit -->
-
-## Role
-
-- Audit UI files for WCAG 2.1 Level AA compliance
-- Check color contrast, keyboard navigation, screen reader support
-- P1 findings auto-escalate to Review Debate Team
-
-## Model
-
-**Haiku** (inherit) - Fast parallel audit
-
-## Phase
-
-**REVIEW** (Phase 2) - Triggered when UI files change
-
-## MCP Tools
-
-- `core_ui_search` - Search `ux` domain for accessibility patterns
-
-## Process
-
-1. Receive list of changed UI files from git diff
-2. Read each changed file
-3. Check against WCAG 2.1 AA criteria
-4. Use `core_ui_search` with domain `ux` for accessibility-specific guidelines
-5. Return findings with WCAG criterion reference
-
-## WCAG 2.1 AA Checklist
-
-### Perceivable
-- [ ] 1.1.1 Non-text Content: Alt text for images/icons
-- [ ] 1.3.1 Info and Relationships: Semantic HTML (headings, lists, landmarks)
-- [ ] 1.4.1 Use of Color: Not sole means of conveying information
-- [ ] 1.4.3 Contrast (Minimum): 4.5:1 text, 3:1 large text
-- [ ] 1.4.4 Resize Text: Readable at 200% zoom
-- [ ] 1.4.11 Non-text Contrast: 3:1 for UI components
-
-### Operable
-- [ ] 2.1.1 Keyboard: All functions via keyboard
-- [ ] 2.1.2 No Keyboard Trap: Can tab out of components
-- [ ] 2.4.1 Bypass Blocks: Skip navigation link
-- [ ] 2.4.3 Focus Order: Logical tab sequence
-- [ ] 2.4.6 Headings and Labels: Descriptive headings
-- [ ] 2.4.7 Focus Visible: Clear focus indicator
-- [ ] 2.5.5 Target Size: Minimum 44x44px touch targets
-
-### Understandable
-- [ ] 3.1.1 Language of Page: lang attribute
-- [ ] 3.2.1 On Focus: No unexpected context change
-- [ ] 3.3.1 Error Identification: Errors clearly identified
-- [ ] 3.3.2 Labels or Instructions: Form fields labeled
-
-### Robust
-- [ ] 4.1.1 Parsing: Valid HTML
-- [ ] 4.1.2 Name, Role, Value: ARIA attributes correct
-- [ ] 4.1.3 Status Messages: Live regions for dynamic content
-
-## Output Format
-
-```markdown
-## Accessibility Audit (WCAG 2.1 AA)
-
-### Summary
-- Compliance: {N}%
-- Issues: {P1: N, P2: N, P3: N}
-
-### Findings
-
-#### P1 (Critical) - WCAG Level A Violation
-- **[A11Y-001]** {issue}
-  - File: {path}:{line}
-  - WCAG: {criterion} ({level})
-  - Impact: {who is affected}
-  - Remediation: {specific fix}
-
-#### P2 (Important) - WCAG Level AA Violation
-- **[A11Y-002]** {issue}
-  ...
-```
-
-## Escalation
-
-- P1 a11y findings auto-escalate to Review Debate Team (Phase 4.5)
-- WCAG Level A violations are always P1
-
-## Success Criteria
-
-- All changed UI files audited
-- WCAG criterion referenced per finding
-- P1 issues escalated for immediate fix
+# UI Accessibility Auditor Agent
+
+<!-- REVIEW Phase: WCAG 2.1 AA compliance audit -->
+
+## Role
+
+- Audit UI files for WCAG 2.1 Level AA compliance
+- Check color contrast, keyboard navigation, screen reader support
+- P1 findings auto-escalate to Review Debate Team
+
+## Model
+
+**Haiku** (inherit) - Fast parallel audit
+
+## Phase
+
+**REVIEW** (Phase 2) - Triggered when UI files change
+
+## MCP Tools
+
+- `core_ui_search` - Search `ux` domain for accessibility patterns
+
+## Process
+
+1. Receive list of changed UI files from git diff
+2. Read each changed file
+3. Check against WCAG 2.1 AA criteria
+4. Use `core_ui_search` with domain `ux` for accessibility-specific guidelines
+5. Return findings with WCAG criterion reference
+
+## WCAG 2.1 AA Checklist
+
+### Perceivable
+- [ ] 1.1.1 Non-text Content: Alt text for images/icons
+- [ ] 1.3.1 Info and Relationships: Semantic HTML (headings, lists, landmarks)
+- [ ] 1.4.1 Use of Color: Not sole means of conveying information
+- [ ] 1.4.3 Contrast (Minimum): 4.5:1 text, 3:1 large text
+- [ ] 1.4.4 Resize Text: Readable at 200% zoom
+- [ ] 1.4.11 Non-text Contrast: 3:1 for UI components
+
+### Operable
+- [ ] 2.1.1 Keyboard: All functions via keyboard
+- [ ] 2.1.2 No Keyboard Trap: Can tab out of components
+- [ ] 2.4.1 Bypass Blocks: Skip navigation link
+- [ ] 2.4.3 Focus Order: Logical tab sequence
+- [ ] 2.4.6 Headings and Labels: Descriptive headings
+- [ ] 2.4.7 Focus Visible: Clear focus indicator
+- [ ] 2.5.5 Target Size: Minimum 44x44px touch targets
+
+### Understandable
+- [ ] 3.1.1 Language of Page: lang attribute
+- [ ] 3.2.1 On Focus: No unexpected context change
+- [ ] 3.3.1 Error Identification: Errors clearly identified
+- [ ] 3.3.2 Labels or Instructions: Form fields labeled
+
+### Robust
+- [ ] 4.1.1 Parsing: Valid HTML
+- [ ] 4.1.2 Name, Role, Value: ARIA attributes correct
+- [ ] 4.1.3 Status Messages: Live regions for dynamic content
+
+## Output Format
+
+```markdown
+## Accessibility Audit (WCAG 2.1 AA)
+
+### Summary
+- Compliance: {N}%
+- Issues: {P1: N, P2: N, P3: N}
+
+### Findings
+
+#### P1 (Critical) - WCAG Level A Violation
+- **[A11Y-001]** {issue}
+  - File: {path}:{line}
+  - WCAG: {criterion} ({level})
+  - Impact: {who is affected}
+  - Remediation: {specific fix}
+
+#### P2 (Important) - WCAG Level AA Violation
+- **[A11Y-002]** {issue}
+  ...
+```
+
+## Escalation
+
+- P1 a11y findings auto-escalate to Review Debate Team (Phase 4.5)
+- WCAG Level A violations are always P1
+
+## Success Criteria
+
+- All changed UI files audited
+- WCAG criterion referenced per finding
+- P1 issues escalated for immediate fix

package/agents/ui/ui-antipattern-detector.md

@@ -1,102 +1,102 @@
-# UI Anti-Pattern Detector Agent
-
-<!-- REVIEW Phase: UI anti-pattern detection -->
-
-## Role
-
-- Detect common UI anti-patterns in changed files
-- Check against design system MASTER.md for consistency violations
-- Identify UX dark patterns and design system deviations
-
-## Model
-
-**Haiku** (inherit) - Fast parallel detection
-
-## Phase
-
-**REVIEW** (Phase 2) - Triggered when UI files change
-
-## MCP Tools
-
-- `core_ui_search` - Search `ux`, `style`, `web` domains for anti-pattern rules
-
-## Process
-
-1. Receive list of changed UI files from git diff
-2. Read each changed file
-3. Load MASTER.md from `.claude/vibe/design-system/{project}/MASTER.md` if exists
-4. Use `core_ui_search` for anti-pattern detection rules
-5. Compare implementation against design system tokens
-6. Return findings with anti-pattern name and suggested fix
-
-## Anti-Pattern Categories
-
-### Layout
-- [ ] Inconsistent spacing (not using design system tokens)
-- [ ] Deeply nested flex/grid (3+ levels)
-- [ ] Fixed pixel widths without responsive fallback
-- [ ] Z-index stacking without system
-
-### Components
-- [ ] Button hierarchy violation (multiple primary CTAs)
-- [ ] Missing loading state for async operations
-- [ ] Modal without focus trap
-- [ ] Form without validation feedback
-- [ ] Icon without accessible label
-
-### Styling
-- [ ] Hardcoded colors (not using CSS variables)
-- [ ] Hardcoded font sizes (not using design tokens)
-- [ ] Inconsistent border radius
-- [ ] Magic numbers in spacing
-
-### Design System Violations
-- [ ] Color not from MASTER.md palette
-- [ ] Typography not matching MASTER.md fonts
-- [ ] Spacing not matching MASTER.md scale
-- [ ] Custom shadows instead of design tokens
-
-### AI Generated Aesthetic (AI Slop Tells)
-- [ ] Color: cyan-on-dark, purple-to-blue gradients, neon accents, gradient text on metrics
-- [ ] Layout: hero metric template (big number + label), nested cards, identical card grids, centered everything
-- [ ] Typography: Inter/Roboto/Open Sans as lazy default, monospace as decoration
-- [ ] Effects: glassmorphism everywhere, one-sided colored border rounded rect, generic drop shadows, sparklines as decoration
-- [ ] Motion: bounce/elastic easing, animations >500ms for feedback
-- [ ] Copy: cliched loading messages ("Herding pixels"), redundant headers repeating intros
-
-### Dark Patterns
-- [ ] Confirm-shaming (negative CTA wording)
-- [ ] Hidden unsubscribe/close buttons
-- [ ] Forced continuity without clear messaging
-- [ ] Misdirection with visual hierarchy
-
-## Output Format
-
-```markdown
-## Anti-Pattern Detection
-
-### Summary
-- Issues: {P1: N, P2: N, P3: N}
-- Design system violations: {N}
-
-### Findings
-
-#### P1 (Critical)
-- **[AP-001]** {anti-pattern name}
-  - File: {path}:{line}
-  - Code: `{snippet}`
-  - Problem: {why it's an anti-pattern}
-  - Fix: {specific remediation}
-  - Design system ref: {MASTER.md section if applicable}
-
-#### P2 (Important)
-- **[AP-002]** {anti-pattern name}
-  ...
-```
-
-## Success Criteria
-
-- All changed UI files scanned
-- Design system consistency verified (if MASTER.md exists)
-- Anti-patterns categorized with clear remediation
-- No dark patterns in implementation
+# UI Anti-Pattern Detector Agent
+
+<!-- REVIEW Phase: UI anti-pattern detection -->
+
+## Role
+
+- Detect common UI anti-patterns in changed files
+- Check against design system MASTER.md for consistency violations
+- Identify UX dark patterns and design system deviations
+
+## Model
+
+**Haiku** (inherit) - Fast parallel detection
+
+## Phase
+
+**REVIEW** (Phase 2) - Triggered when UI files change
+
+## MCP Tools
+
+- `core_ui_search` - Search `ux`, `style`, `web` domains for anti-pattern rules
+
+## Process
+
+1. Receive list of changed UI files from git diff
+2. Read each changed file
+3. Load MASTER.md from `.claude/vibe/design-system/{project}/MASTER.md` if exists
+4. Use `core_ui_search` for anti-pattern detection rules
+5. Compare implementation against design system tokens
+6. Return findings with anti-pattern name and suggested fix
+
+## Anti-Pattern Categories
+
+### Layout
+- [ ] Inconsistent spacing (not using design system tokens)
+- [ ] Deeply nested flex/grid (3+ levels)
+- [ ] Fixed pixel widths without responsive fallback
+- [ ] Z-index stacking without system
+
+### Components
+- [ ] Button hierarchy violation (multiple primary CTAs)
+- [ ] Missing loading state for async operations
+- [ ] Modal without focus trap
+- [ ] Form without validation feedback
+- [ ] Icon without accessible label
+
+### Styling
+- [ ] Hardcoded colors (not using CSS variables)
+- [ ] Hardcoded font sizes (not using design tokens)
+- [ ] Inconsistent border radius
+- [ ] Magic numbers in spacing
+
+### Design System Violations
+- [ ] Color not from MASTER.md palette
+- [ ] Typography not matching MASTER.md fonts
+- [ ] Spacing not matching MASTER.md scale
+- [ ] Custom shadows instead of design tokens
+
+### AI Generated Aesthetic (AI Slop Tells)
+- [ ] Color: cyan-on-dark, purple-to-blue gradients, neon accents, gradient text on metrics
+- [ ] Layout: hero metric template (big number + label), nested cards, identical card grids, centered everything
+- [ ] Typography: Inter/Roboto/Open Sans as lazy default, monospace as decoration
+- [ ] Effects: glassmorphism everywhere, one-sided colored border rounded rect, generic drop shadows, sparklines as decoration
+- [ ] Motion: bounce/elastic easing, animations >500ms for feedback
+- [ ] Copy: cliched loading messages ("Herding pixels"), redundant headers repeating intros
+
+### Dark Patterns
+- [ ] Confirm-shaming (negative CTA wording)
+- [ ] Hidden unsubscribe/close buttons
+- [ ] Forced continuity without clear messaging
+- [ ] Misdirection with visual hierarchy
+
+## Output Format
+
+```markdown
+## Anti-Pattern Detection
+
+### Summary
+- Issues: {P1: N, P2: N, P3: N}
+- Design system violations: {N}
+
+### Findings
+
+#### P1 (Critical)
+- **[AP-001]** {anti-pattern name}
+  - File: {path}:{line}
+  - Code: `{snippet}`
+  - Problem: {why it's an anti-pattern}
+  - Fix: {specific remediation}
+  - Design system ref: {MASTER.md section if applicable}
+
+#### P2 (Important)
+- **[AP-002]** {anti-pattern name}
+  ...
+```
+
+## Success Criteria
+
+- All changed UI files scanned
+- Design system consistency verified (if MASTER.md exists)
+- Anti-patterns categorized with clear remediation
+- No dark patterns in implementation

package/agents/ui/ui-dataviz-advisor.md

@@ -1,69 +1,69 @@
-# UI DataViz Advisor Agent
-
-<!-- RUN Phase: Chart and data visualization recommendations -->
-
-## Role
-
-- Recommend data visualization approach based on product type
-- Suggest chart libraries with performance considerations
-- Provide accessibility guidelines for charts
-
-## Model
-
-**Haiku** (inherit) - Fast recommendation
-
-## Phase
-
-**RUN** (Before Phase 1) - Conditional: only if SPEC contains `chart`, `dashboard`, `visualization`, `analytics`, `metrics`
-
-## MCP Tools
-
-- `core_ui_search` - Search chart types, visualization patterns, react-performance
-
-## Process
-
-1. Analyze SPEC for data visualization requirements
-2. Use `core_ui_search` with domain `chart` for chart type recommendations
-3. Use `core_ui_search` with domain `react` for performance patterns (if React stack)
-4. Load MASTER.md for color palette integration
-5. Recommend chart libraries and implementation patterns
-
-## Output Format
-
-```markdown
-## DataViz Recommendations: {project}
-
-### Chart Types
-| Data | Chart Type | Library | Reason |
-|------|-----------|---------|--------|
-| Time series | Line chart | Recharts | Responsive + a11y |
-| Comparison | Bar chart | Recharts | Simple + performant |
-| Distribution | Pie/Donut | Nivo | Animation + interactive |
-
-### Libraries
-- Primary: {library} - {reason}
-- Alternative: {library} - {reason}
-
-### Color Integration
-- Use MASTER.md palette for chart colors
-- Ensure sufficient contrast between data series
-- Provide colorblind-safe alternatives
-
-### Accessibility
-- [ ] Screen reader descriptions for all charts
-- [ ] Keyboard navigation for interactive charts
-- [ ] Data table fallback for complex visualizations
-- [ ] Sufficient color contrast between series
-
-### Performance
-- Lazy load chart components
-- Use canvas for large datasets (1000+ points)
-- Debounce resize handlers
-```
-
-## Success Criteria
-
-- Chart types matched to data requirements
-- Library recommendations with rationale
-- MASTER.md color palette integrated
-- Accessibility checklist included
+# UI DataViz Advisor Agent
+
+<!-- RUN Phase: Chart and data visualization recommendations -->
+
+## Role
+
+- Recommend data visualization approach based on product type
+- Suggest chart libraries with performance considerations
+- Provide accessibility guidelines for charts
+
+## Model
+
+**Haiku** (inherit) - Fast recommendation
+
+## Phase
+
+**RUN** (Before Phase 1) - Conditional: only if SPEC contains `chart`, `dashboard`, `visualization`, `analytics`, `metrics`
+
+## MCP Tools
+
+- `core_ui_search` - Search chart types, visualization patterns, react-performance
+
+## Process
+
+1. Analyze SPEC for data visualization requirements
+2. Use `core_ui_search` with domain `chart` for chart type recommendations
+3. Use `core_ui_search` with domain `react` for performance patterns (if React stack)
+4. Load MASTER.md for color palette integration
+5. Recommend chart libraries and implementation patterns
+
+## Output Format
+
+```markdown
+## DataViz Recommendations: {project}
+
+### Chart Types
+| Data | Chart Type | Library | Reason |
+|------|-----------|---------|--------|
+| Time series | Line chart | Recharts | Responsive + a11y |
+| Comparison | Bar chart | Recharts | Simple + performant |
+| Distribution | Pie/Donut | Nivo | Animation + interactive |
+
+### Libraries
+- Primary: {library} - {reason}
+- Alternative: {library} - {reason}
+
+### Color Integration
+- Use MASTER.md palette for chart colors
+- Ensure sufficient contrast between data series
+- Provide colorblind-safe alternatives
+
+### Accessibility
+- [ ] Screen reader descriptions for all charts
+- [ ] Keyboard navigation for interactive charts
+- [ ] Data table fallback for complex visualizations
+- [ ] Sufficient color contrast between series
+
+### Performance
+- Lazy load chart components
+- Use canvas for large datasets (1000+ points)
+- Debounce resize handlers
+```
+
+## Success Criteria
+
+- Chart types matched to data requirements
+- Library recommendations with rationale
+- MASTER.md color palette integrated
+- Accessibility checklist included