@su-record/vibe 2.7.13 → 2.7.15

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (232) hide show
  1. package/.env.example +37 -37
  2. package/CLAUDE.md +134 -126
  3. package/LICENSE +21 -21
  4. package/README.md +449 -449
  5. package/agents/architect-low.md +41 -41
  6. package/agents/architect-medium.md +59 -59
  7. package/agents/architect.md +80 -80
  8. package/agents/build-error-resolver.md +115 -115
  9. package/agents/compounder.md +261 -261
  10. package/agents/diagrammer.md +178 -178
  11. package/agents/docs/api-documenter.md +99 -99
  12. package/agents/docs/changelog-writer.md +93 -93
  13. package/agents/e2e-tester.md +294 -294
  14. package/agents/explorer-low.md +42 -42
  15. package/agents/explorer-medium.md +59 -59
  16. package/agents/explorer.md +48 -48
  17. package/agents/implementer-low.md +43 -43
  18. package/agents/implementer-medium.md +52 -52
  19. package/agents/implementer.md +54 -54
  20. package/agents/junior-mentor.md +141 -141
  21. package/agents/planning/requirements-analyst.md +84 -84
  22. package/agents/planning/ux-advisor.md +83 -83
  23. package/agents/qa/acceptance-tester.md +86 -86
  24. package/agents/qa/edge-case-finder.md +93 -93
  25. package/agents/refactor-cleaner.md +143 -143
  26. package/agents/research/best-practices-agent.md +199 -199
  27. package/agents/research/codebase-patterns-agent.md +157 -157
  28. package/agents/research/framework-docs-agent.md +188 -188
  29. package/agents/research/security-advisory-agent.md +213 -213
  30. package/agents/review/architecture-reviewer.md +107 -107
  31. package/agents/review/complexity-reviewer.md +116 -116
  32. package/agents/review/data-integrity-reviewer.md +88 -88
  33. package/agents/review/git-history-reviewer.md +103 -103
  34. package/agents/review/performance-reviewer.md +86 -86
  35. package/agents/review/python-reviewer.md +150 -150
  36. package/agents/review/rails-reviewer.md +139 -139
  37. package/agents/review/react-reviewer.md +144 -144
  38. package/agents/review/security-reviewer.md +80 -80
  39. package/agents/review/simplicity-reviewer.md +140 -140
  40. package/agents/review/test-coverage-reviewer.md +116 -116
  41. package/agents/review/typescript-reviewer.md +127 -127
  42. package/agents/searcher.md +54 -54
  43. package/agents/simplifier.md +120 -120
  44. package/agents/tester.md +49 -49
  45. package/agents/ui/ui-a11y-auditor.md +93 -93
  46. package/agents/ui/ui-antipattern-detector.md +94 -94
  47. package/agents/ui/ui-dataviz-advisor.md +69 -69
  48. package/agents/ui/ui-design-system-gen.md +57 -57
  49. package/agents/ui/ui-industry-analyzer.md +49 -49
  50. package/agents/ui/ui-layout-architect.md +65 -65
  51. package/agents/ui/ui-stack-implementer.md +68 -68
  52. package/agents/ui/ux-compliance-reviewer.md +81 -81
  53. package/agents/ui-previewer.md +258 -260
  54. package/commands/vibe.analyze.md +11 -13
  55. package/commands/vibe.review.md +43 -1
  56. package/commands/vibe.run.md +2124 -2078
  57. package/commands/vibe.spec.md +9 -4
  58. package/commands/vibe.spec.review.md +569 -565
  59. package/commands/vibe.utils.md +413 -413
  60. package/commands/vibe.verify.md +33 -8
  61. package/dist/cli/collaborator.js +52 -52
  62. package/dist/cli/commands/evolution.js +12 -12
  63. package/dist/cli/commands/info.js +54 -54
  64. package/dist/cli/commands/init.js +5 -5
  65. package/dist/cli/commands/remove.js +14 -14
  66. package/dist/cli/commands/sentinel.js +27 -27
  67. package/dist/cli/commands/skills.js +5 -5
  68. package/dist/cli/commands/slack.js +10 -10
  69. package/dist/cli/commands/telegram.js +12 -12
  70. package/dist/cli/detect.js +32 -32
  71. package/dist/cli/index.js +51 -51
  72. package/dist/cli/llm/claude-commands.js +16 -16
  73. package/dist/cli/llm/config.js +19 -19
  74. package/dist/cli/llm/config.js.map +1 -1
  75. package/dist/cli/llm/gemini-commands.js +16 -16
  76. package/dist/cli/llm/gpt-commands.js +19 -19
  77. package/dist/cli/llm/help.js +21 -21
  78. package/dist/cli/postinstall/cursor-agents.js +32 -32
  79. package/dist/cli/postinstall/cursor-rules.js +83 -83
  80. package/dist/cli/postinstall/cursor-skills.js +743 -743
  81. package/dist/cli/setup/Provisioner.js +42 -42
  82. package/dist/cli/types.d.ts +0 -2
  83. package/dist/cli/types.d.ts.map +1 -1
  84. package/dist/infra/lib/DeepInit.js +24 -24
  85. package/dist/infra/lib/IterationTracker.js +11 -11
  86. package/dist/infra/lib/PythonParser.js +108 -108
  87. package/dist/infra/lib/ReviewRace.js +96 -96
  88. package/dist/infra/lib/SkillFrontmatter.js +28 -28
  89. package/dist/infra/lib/SkillQualityGate.js +9 -9
  90. package/dist/infra/lib/SkillRepository.js +159 -159
  91. package/dist/infra/lib/UltraQA.js +99 -99
  92. package/dist/infra/lib/autonomy/AuditStore.js +41 -41
  93. package/dist/infra/lib/autonomy/ConfirmationStore.js +30 -30
  94. package/dist/infra/lib/autonomy/EventOutbox.js +38 -38
  95. package/dist/infra/lib/autonomy/PolicyEngine.js +18 -18
  96. package/dist/infra/lib/autonomy/SecuritySentinel.js +1 -1
  97. package/dist/infra/lib/autonomy/SuggestionStore.js +33 -33
  98. package/dist/infra/lib/embedding/VectorStore.js +22 -22
  99. package/dist/infra/lib/evolution/AgentAnalyzer.js +10 -10
  100. package/dist/infra/lib/evolution/DescriptionOptimizer.js +21 -21
  101. package/dist/infra/lib/evolution/GenerationRegistry.js +36 -36
  102. package/dist/infra/lib/evolution/InsightStore.js +90 -90
  103. package/dist/infra/lib/evolution/RollbackManager.js +5 -5
  104. package/dist/infra/lib/evolution/SkillBenchmark.js +23 -23
  105. package/dist/infra/lib/evolution/SkillEvalRunner.js +50 -50
  106. package/dist/infra/lib/evolution/SkillGapDetector.js +10 -10
  107. package/dist/infra/lib/evolution/UsageTracker.js +28 -28
  108. package/dist/infra/lib/gemini/orchestration.js +5 -5
  109. package/dist/infra/lib/gpt/orchestration.js +4 -4
  110. package/dist/infra/lib/memory/KnowledgeGraph.js +4 -4
  111. package/dist/infra/lib/memory/MemorySearch.js +57 -57
  112. package/dist/infra/lib/memory/MemoryStorage.js +181 -181
  113. package/dist/infra/lib/memory/ObservationStore.js +28 -28
  114. package/dist/infra/lib/memory/ReflectionStore.js +30 -30
  115. package/dist/infra/lib/memory/SessionRAGRetriever.js +7 -7
  116. package/dist/infra/lib/memory/SessionRAGStore.js +225 -225
  117. package/dist/infra/lib/memory/SessionSummarizer.js +9 -9
  118. package/dist/infra/orchestrator/AgentManager.js +12 -12
  119. package/dist/infra/orchestrator/AgentRegistry.js +65 -65
  120. package/dist/infra/orchestrator/MultiLlmResearch.js +8 -8
  121. package/dist/infra/orchestrator/SwarmOrchestrator.test.js +16 -16
  122. package/dist/infra/orchestrator/parallelResearch.js +24 -24
  123. package/dist/tools/convention/analyzeComplexity.test.js +115 -115
  124. package/dist/tools/convention/validateCodeQuality.test.js +104 -104
  125. package/dist/tools/memory/createMemoryTimeline.js +10 -10
  126. package/dist/tools/memory/getMemoryGraph.js +12 -12
  127. package/dist/tools/memory/getSessionContext.js +9 -9
  128. package/dist/tools/memory/linkMemories.js +14 -14
  129. package/dist/tools/memory/listMemories.js +4 -4
  130. package/dist/tools/memory/recallMemory.js +4 -4
  131. package/dist/tools/memory/saveMemory.js +4 -4
  132. package/dist/tools/memory/searchMemoriesAdvanced.js +23 -23
  133. package/dist/tools/semantic/analyzeDependencyGraph.js +12 -12
  134. package/dist/tools/semantic/astGrep.test.js +6 -6
  135. package/dist/tools/spec/prdParser.test.js +171 -171
  136. package/dist/tools/spec/specGenerator.js +169 -169
  137. package/dist/tools/spec/traceabilityMatrix.js +64 -64
  138. package/dist/tools/spec/traceabilityMatrix.test.js +28 -28
  139. package/hooks/gemini-hooks.json +73 -73
  140. package/hooks/hooks.json +137 -137
  141. package/hooks/scripts/code-check.js +77 -70
  142. package/hooks/scripts/context-save.js +212 -212
  143. package/hooks/scripts/hud-status.js +291 -291
  144. package/hooks/scripts/keyword-detector.js +214 -214
  145. package/hooks/scripts/llm-orchestrate.js +475 -475
  146. package/hooks/scripts/post-edit.js +32 -32
  147. package/hooks/scripts/pre-tool-guard.js +125 -125
  148. package/hooks/scripts/prompt-dispatcher.js +185 -185
  149. package/hooks/scripts/sentinel-guard.js +104 -104
  150. package/hooks/scripts/session-start.js +106 -106
  151. package/hooks/scripts/stop-notify.js +209 -209
  152. package/hooks/scripts/utils.js +100 -100
  153. package/languages/csharp-unity.md +515 -515
  154. package/languages/gdscript-godot.md +470 -470
  155. package/languages/ruby-rails.md +489 -489
  156. package/languages/typescript-angular.md +433 -433
  157. package/languages/typescript-astro.md +416 -416
  158. package/languages/typescript-electron.md +406 -406
  159. package/languages/typescript-nestjs.md +524 -524
  160. package/languages/typescript-svelte.md +407 -407
  161. package/languages/typescript-tauri.md +365 -365
  162. package/package.json +121 -121
  163. package/skills/agents-md/SKILL.md +120 -120
  164. package/skills/arch-guard/SKILL.md +180 -180
  165. package/skills/brand-assets/SKILL.md +146 -146
  166. package/skills/capability-loop/SKILL.md +167 -167
  167. package/skills/characterization-test/SKILL.md +206 -206
  168. package/skills/commerce-patterns/SKILL.md +59 -59
  169. package/skills/commit-push-pr/SKILL.md +75 -75
  170. package/skills/context7-usage/SKILL.md +105 -105
  171. package/skills/core-capabilities/SKILL.md +48 -48
  172. package/skills/e2e-commerce/SKILL.md +57 -57
  173. package/skills/exec-plan/SKILL.md +147 -147
  174. package/skills/frontend-design/SKILL.md +73 -73
  175. package/skills/git-worktree/SKILL.md +72 -72
  176. package/skills/handoff/SKILL.md +109 -109
  177. package/skills/parallel-research/SKILL.md +87 -87
  178. package/skills/priority-todos/SKILL.md +63 -63
  179. package/skills/seo-checklist/SKILL.md +57 -57
  180. package/skills/techdebt/SKILL.md +122 -122
  181. package/skills/tool-fallback/SKILL.md +103 -103
  182. package/skills/typescript-advanced-types/SKILL.md +66 -65
  183. package/skills/ui-ux-pro-max/SKILL.md +206 -206
  184. package/skills/vercel-react-best-practices/SKILL.md +59 -59
  185. package/skills/video-production/SKILL.md +51 -51
  186. package/vibe/config.json +29 -29
  187. package/vibe/constitution.md +227 -227
  188. package/vibe/rules/principles/communication-guide.md +98 -98
  189. package/vibe/rules/principles/development-philosophy.md +52 -52
  190. package/vibe/rules/principles/quick-start.md +102 -102
  191. package/vibe/rules/quality/bdd-contract-testing.md +393 -393
  192. package/vibe/rules/quality/checklist.md +276 -276
  193. package/vibe/rules/quality/performance.md +236 -236
  194. package/vibe/rules/quality/testing-strategy.md +440 -440
  195. package/vibe/rules/standards/anti-patterns.md +541 -541
  196. package/vibe/rules/standards/code-structure.md +291 -291
  197. package/vibe/rules/standards/complexity-metrics.md +313 -313
  198. package/vibe/rules/standards/git-workflow.md +237 -237
  199. package/vibe/rules/standards/naming-conventions.md +198 -198
  200. package/vibe/rules/standards/security.md +305 -305
  201. package/vibe/rules/writing/document-style.md +74 -74
  202. package/vibe/setup.sh +31 -31
  203. package/vibe/templates/constitution-template.md +252 -252
  204. package/vibe/templates/contract-backend-template.md +526 -526
  205. package/vibe/templates/contract-frontend-template.md +599 -599
  206. package/vibe/templates/feature-template.md +96 -96
  207. package/vibe/templates/spec-template.md +221 -221
  208. package/vibe/ui-ux-data/charts.csv +26 -26
  209. package/vibe/ui-ux-data/colors.csv +97 -97
  210. package/vibe/ui-ux-data/icons.csv +101 -101
  211. package/vibe/ui-ux-data/landing.csv +31 -31
  212. package/vibe/ui-ux-data/products.csv +96 -96
  213. package/vibe/ui-ux-data/react-performance.csv +45 -45
  214. package/vibe/ui-ux-data/stacks/astro.csv +54 -54
  215. package/vibe/ui-ux-data/stacks/flutter.csv +53 -53
  216. package/vibe/ui-ux-data/stacks/html-tailwind.csv +56 -56
  217. package/vibe/ui-ux-data/stacks/jetpack-compose.csv +53 -53
  218. package/vibe/ui-ux-data/stacks/nextjs.csv +53 -53
  219. package/vibe/ui-ux-data/stacks/nuxt-ui.csv +51 -51
  220. package/vibe/ui-ux-data/stacks/nuxtjs.csv +59 -59
  221. package/vibe/ui-ux-data/stacks/react-native.csv +52 -52
  222. package/vibe/ui-ux-data/stacks/react.csv +54 -54
  223. package/vibe/ui-ux-data/stacks/shadcn.csv +61 -61
  224. package/vibe/ui-ux-data/stacks/svelte.csv +54 -54
  225. package/vibe/ui-ux-data/stacks/swiftui.csv +51 -51
  226. package/vibe/ui-ux-data/stacks/vue.csv +50 -50
  227. package/vibe/ui-ux-data/styles.csv +68 -68
  228. package/vibe/ui-ux-data/typography.csv +57 -57
  229. package/vibe/ui-ux-data/ui-reasoning.csv +101 -101
  230. package/vibe/ui-ux-data/ux-guidelines.csv +99 -99
  231. package/vibe/ui-ux-data/version.json +31 -31
  232. package/vibe/ui-ux-data/web-interface.csv +31 -31
@@ -1,541 +1,541 @@
1
- # Automatic Anti-Pattern Avoidance
2
-
3
- ## TypeScript Anti-Patterns
4
-
5
- ### 1. Using any Type
6
-
7
- ```typescript
8
- // ❌ Using any
9
- function processData(data: any) {
10
- return data.value; // Loss of type safety
11
- }
12
-
13
- // ✅ unknown + type guard
14
- function processData(data: unknown) {
15
- if (isValidData(data)) {
16
- return data.value; // Type safe
17
- }
18
- throw new Error('Invalid data');
19
- }
20
-
21
- function isValidData(data: unknown): data is { value: string } {
22
- return typeof data === 'object' && data !== null && 'value' in data;
23
- }
24
- ```
25
-
26
- ### 2. Forced Type Casting with as any
27
-
28
- ```typescript
29
- // ❌ Bypassing types with as any
30
- const user = response as any;
31
- user.name; // Runtime error risk
32
-
33
- // ✅ Proper type definition
34
- interface User {
35
- name: string;
36
- email: string;
37
- }
38
-
39
- const user = response as User;
40
- user.name; // Type safe
41
- ```
42
-
43
- ### 3. Overusing @ts-ignore
44
-
45
- ```typescript
46
- // ❌ Ignoring errors with @ts-ignore
47
- // @ts-ignore
48
- const result = problematicCode();
49
-
50
- // ✅ Fix the type issue at its root
51
- interface Expected {
52
- id: string;
53
- }
54
-
55
- const result: Expected = {
56
- id: String(problematicCode()),
57
- };
58
- ```
59
-
60
- ## React Anti-Patterns
61
-
62
- ### 1. Using dangerouslySetInnerHTML
63
-
64
- ```typescript
65
- // ❌ XSS vulnerability
66
- function Component({ html }: { html: string }) {
67
- return <div dangerouslySetInnerHTML={{ __html: html }} />;
68
- }
69
-
70
- // ✅ Safe rendering
71
- import DOMPurify from 'dompurify';
72
-
73
- function Component({ html }: { html: string }) {
74
- const sanitized = DOMPurify.sanitize(html);
75
- return <div dangerouslySetInnerHTML={{ __html: sanitized }} />;
76
- }
77
-
78
- // ✅ Better approach: Use markdown library
79
- import ReactMarkdown from 'react-markdown';
80
-
81
- function Component({ markdown }: { markdown: string }) {
82
- return <ReactMarkdown>{markdown}</ReactMarkdown>;
83
- }
84
- ```
85
-
86
- ### 2. Props Drilling (More than 3 levels)
87
-
88
- ```typescript
89
- // ❌ Props drilling
90
- function App() {
91
- const [user, setUser] = useState<User>();
92
- return <Parent user={user} />;
93
- }
94
-
95
- function Parent({ user }: { user: User }) {
96
- return <Child user={user} />;
97
- }
98
-
99
- function Child({ user }: { user: User }) {
100
- return <GrandChild user={user} />;
101
- }
102
-
103
- function GrandChild({ user }: { user: User }) {
104
- return <div>{user.name}</div>;
105
- }
106
-
107
- // ✅ Use Context API
108
- const UserContext = createContext<User | undefined>(undefined);
109
-
110
- function App() {
111
- const [user, setUser] = useState<User>();
112
- return (
113
- <UserContext.Provider value={user}>
114
- <Parent />
115
- </UserContext.Provider>
116
- );
117
- }
118
-
119
- function GrandChild() {
120
- const user = useContext(UserContext);
121
- return <div>{user?.name}</div>;
122
- }
123
- ```
124
-
125
- ### 3. Missing useEffect Dependency Array
126
-
127
- ```typescript
128
- // ❌ Missing dependency
129
- function Component({ userId }: { userId: string }) {
130
- const [user, setUser] = useState<User>();
131
-
132
- useEffect(() => {
133
- fetchUser(userId).then(setUser);
134
- }, []); // Missing userId dependency!
135
-
136
- return <div>{user?.name}</div>;
137
- }
138
-
139
- // ✅ Specify all dependencies
140
- function Component({ userId }: { userId: string }) {
141
- const [user, setUser] = useState<User>();
142
-
143
- useEffect(() => {
144
- fetchUser(userId).then(setUser);
145
- }, [userId]); // Dependency specified
146
-
147
- return <div>{user?.name}</div>;
148
- }
149
- ```
150
-
151
- ## JavaScript Anti-Patterns
152
-
153
- ### 1. Using var
154
-
155
- ```typescript
156
- // ❌ Using var
157
- var count = 0;
158
- if (true) {
159
- var count = 1; // Same variable!
160
- }
161
- console.log(count); // 1
162
-
163
- // ✅ Use const/let
164
- let count = 0;
165
- if (true) {
166
- let count = 1; // Block scope
167
- }
168
- console.log(count); // 0
169
- ```
170
-
171
- ### 2. Using == (Loose Comparison)
172
-
173
- ```typescript
174
- // ❌ Using ==
175
- if (value == null) { } // Also matches undefined
176
- if ('5' == 5) { } // true (type coercion)
177
-
178
- // ✅ Use ===
179
- if (value === null) { }
180
- if (value === undefined) { }
181
- if ('5' === 5) { } // false
182
- ```
183
-
184
- ### 3. Using eval()
185
-
186
- ```typescript
187
- // ❌ Using eval() (security risk)
188
- const code = userInput;
189
- eval(code); // Can execute arbitrary code
190
-
191
- // ✅ Alternative implementation
192
- const allowedOperations = {
193
- add: (a: number, b: number) => a + b,
194
- subtract: (a: number, b: number) => a - b,
195
- };
196
-
197
- const operation = allowedOperations[userInput];
198
- if (operation) {
199
- result = operation(a, b);
200
- }
201
- ```
202
-
203
- ## CSS Anti-Patterns
204
-
205
- ### 1. Overusing !important
206
-
207
- ```css
208
- /* ❌ Overusing !important */
209
- .button {
210
- color: blue !important;
211
- background: red !important;
212
- }
213
-
214
- /* ✅ Use specific selectors */
215
- .navigation .button.primary {
216
- color: blue;
217
- background: red;
218
- }
219
- ```
220
-
221
- ### 2. Overusing Inline Styles
222
-
223
- ```typescript
224
- // ❌ Inline styles
225
- function Button() {
226
- return (
227
- <button
228
- style={{
229
- backgroundColor: 'blue',
230
- color: 'white',
231
- padding: '10px',
232
- borderRadius: '5px',
233
- }}
234
- >
235
- Click me
236
- </button>
237
- );
238
- }
239
-
240
- // ✅ Use CSS classes
241
- function Button() {
242
- return <button className="btn-primary">Click me</button>;
243
- }
244
-
245
- // styles.css
246
- .btn-primary {
247
- background-color: blue;
248
- color: white;
249
- padding: 10px;
250
- border-radius: 5px;
251
- }
252
- ```
253
-
254
- ## Performance Anti-Patterns
255
-
256
- ### 1. Unnecessary Re-renders
257
-
258
- ```typescript
259
- // ❌ Creating new objects/functions every render
260
- function Parent() {
261
- return <Child config={{ theme: 'dark' }} onClick={() => {}} />;
262
- // New object/function created every render → Child re-renders
263
- }
264
-
265
- // ✅ Use useMemo/useCallback
266
- function Parent() {
267
- const config = useMemo(() => ({ theme: 'dark' }), []);
268
- const handleClick = useCallback(() => {}, []);
269
-
270
- return <Child config={config} onClick={handleClick} />;
271
- }
272
- ```
273
-
274
- ### 2. Synchronous Heavy Computations
275
-
276
- ```typescript
277
- // ❌ Blocking main thread
278
- function Component({ data }: { data: number[] }) {
279
- const result = data
280
- .map(heavyComputation)
281
- .filter(x => x > 0)
282
- .reduce((a, b) => a + b);
283
-
284
- return <div>{result}</div>;
285
- }
286
-
287
- // ✅ Memoization with useMemo
288
- function Component({ data }: { data: number[] }) {
289
- const result = useMemo(
290
- () =>
291
- data
292
- .map(heavyComputation)
293
- .filter(x => x > 0)
294
- .reduce((a, b) => a + b),
295
- [data]
296
- );
297
-
298
- return <div>{result}</div>;
299
- }
300
- ```
301
-
302
- ## Security Anti-Patterns
303
-
304
- ### 1. Hardcoding Sensitive Information
305
-
306
- ```typescript
307
- // ❌ Hardcoded API key
308
- const API_KEY = 'sk-1234567890abcdef';
309
-
310
- // ✅ Use environment variables
311
- const API_KEY = process.env.NEXT_PUBLIC_API_KEY;
312
- ```
313
-
314
- ### 2. SQL Injection Vulnerability
315
-
316
- ```typescript
317
- // ❌ Direct string concatenation
318
- const query = `SELECT * FROM users WHERE id = ${userId}`;
319
-
320
- // ✅ Parameterized query
321
- const query = 'SELECT * FROM users WHERE id = ?';
322
- db.execute(query, [userId]);
323
- ```
324
-
325
- ## Immutability Anti-Patterns
326
-
327
- ### 1. Direct State Mutation
328
-
329
- ```typescript
330
- // ❌ Directly mutating state
331
- const [user, setUser] = useState({ name: 'John', age: 30 });
332
-
333
- function updateAge() {
334
- user.age = 31; // Direct mutation!
335
- setUser(user); // React won't detect the change
336
- }
337
-
338
- // ✅ Use spread operator for immutable update
339
- function updateAge() {
340
- setUser({ ...user, age: 31 }); // New object created
341
- }
342
-
343
- // ✅ Or use functional update
344
- function updateAge() {
345
- setUser(prev => ({ ...prev, age: prev.age + 1 }));
346
- }
347
- ```
348
-
349
- ### 2. Array Mutation Methods
350
-
351
- ```typescript
352
- // ❌ Mutating array methods
353
- const [items, setItems] = useState(['a', 'b', 'c']);
354
-
355
- function addItem(item: string) {
356
- items.push(item); // Mutates original array!
357
- setItems(items);
358
- }
359
-
360
- function removeItem(index: number) {
361
- items.splice(index, 1); // Mutates original array!
362
- setItems(items);
363
- }
364
-
365
- // ✅ Immutable array operations
366
- function addItem(item: string) {
367
- setItems([...items, item]); // Spread creates new array
368
- }
369
-
370
- function removeItem(index: number) {
371
- setItems(items.filter((_, i) => i !== index)); // filter returns new array
372
- }
373
-
374
- function updateItem(index: number, newValue: string) {
375
- setItems(items.map((item, i) => i === index ? newValue : item));
376
- }
377
- ```
378
-
379
- ### 3. Nested Object Mutation
380
-
381
- ```typescript
382
- // ❌ Deeply nested mutation
383
- const [state, setState] = useState({
384
- user: {
385
- profile: {
386
- name: 'John',
387
- settings: { theme: 'dark' }
388
- }
389
- }
390
- });
391
-
392
- function updateTheme(theme: string) {
393
- state.user.profile.settings.theme = theme; // Deep mutation!
394
- setState(state);
395
- }
396
-
397
- // ✅ Immutable deep update
398
- function updateTheme(theme: string) {
399
- setState({
400
- ...state,
401
- user: {
402
- ...state.user,
403
- profile: {
404
- ...state.user.profile,
405
- settings: {
406
- ...state.user.profile.settings,
407
- theme
408
- }
409
- }
410
- }
411
- });
412
- }
413
-
414
- // ✅ Better: Use immer for complex updates
415
- import { produce } from 'immer';
416
-
417
- function updateTheme(theme: string) {
418
- setState(produce(draft => {
419
- draft.user.profile.settings.theme = theme; // Safe with immer
420
- }));
421
- }
422
- ```
423
-
424
- ### 4. Object.assign Misuse
425
-
426
- ```typescript
427
- // ❌ Object.assign mutating first argument
428
- const original = { a: 1, b: 2 };
429
- const updated = Object.assign(original, { b: 3 }); // Mutates original!
430
-
431
- // ✅ Use empty object as first argument
432
- const updated = Object.assign({}, original, { b: 3 });
433
-
434
- // ✅ Or use spread (preferred)
435
- const updated = { ...original, b: 3 };
436
- ```
437
-
438
- ### 5. Reducer State Mutation
439
-
440
- ```typescript
441
- // ❌ Mutating state in reducer
442
- function reducer(state: State, action: Action) {
443
- switch (action.type) {
444
- case 'ADD_ITEM':
445
- state.items.push(action.payload); // Mutation!
446
- return state;
447
- default:
448
- return state;
449
- }
450
- }
451
-
452
- // ✅ Return new state
453
- function reducer(state: State, action: Action) {
454
- switch (action.type) {
455
- case 'ADD_ITEM':
456
- return {
457
- ...state,
458
- items: [...state.items, action.payload]
459
- };
460
- default:
461
- return state;
462
- }
463
- }
464
- ```
465
-
466
- ### 6. Mutating Function Parameters
467
-
468
- ```typescript
469
- // ❌ Mutating input parameter
470
- function addTimestamp(data: Record<string, unknown>) {
471
- data.timestamp = Date.now(); // Mutates caller's object!
472
- return data;
473
- }
474
-
475
- // ✅ Create new object
476
- function addTimestamp(data: Record<string, unknown>) {
477
- return {
478
- ...data,
479
- timestamp: Date.now()
480
- };
481
- }
482
- ```
483
-
484
- ### Immutable Methods Reference
485
-
486
- | Mutating (Avoid) | Immutable (Use) |
487
- |------------------|-----------------|
488
- | `push()` | `[...arr, item]` |
489
- | `pop()` | `arr.slice(0, -1)` |
490
- | `shift()` | `arr.slice(1)` |
491
- | `unshift()` | `[item, ...arr]` |
492
- | `splice()` | `filter()` / `slice()` + spread |
493
- | `sort()` | `[...arr].sort()` |
494
- | `reverse()` | `[...arr].reverse()` |
495
- | `obj.prop = x` | `{ ...obj, prop: x }` |
496
-
497
- ## Error Handling Anti-Patterns
498
-
499
- ### 1. Empty catch Block
500
-
501
- ```typescript
502
- // ❌ Ignoring errors
503
- try {
504
- riskyOperation();
505
- } catch (e) {
506
- // Does nothing
507
- }
508
-
509
- // ✅ Proper error handling
510
- try {
511
- riskyOperation();
512
- } catch (error) {
513
- console.error('Operation failed:', error);
514
- showErrorNotification(error);
515
- trackError(error);
516
- }
517
- ```
518
-
519
- ### 2. Handling Without Error Type Check
520
-
521
- ```typescript
522
- // ❌ Treating all errors the same
523
- try {
524
- await fetchData();
525
- } catch (error) {
526
- showError('Failed'); // Not specific
527
- }
528
-
529
- // ✅ Handle by error type
530
- try {
531
- await fetchData();
532
- } catch (error) {
533
- if (error instanceof NetworkError) {
534
- showError('Please check your network connection');
535
- } else if (error instanceof AuthError) {
536
- redirectToLogin();
537
- } else {
538
- showError('An unknown error occurred');
539
- }
540
- }
541
- ```
1
+ # Automatic Anti-Pattern Avoidance
2
+
3
+ ## TypeScript Anti-Patterns
4
+
5
+ ### 1. Using any Type
6
+
7
+ ```typescript
8
+ // ❌ Using any
9
+ function processData(data: any) {
10
+ return data.value; // Loss of type safety
11
+ }
12
+
13
+ // ✅ unknown + type guard
14
+ function processData(data: unknown) {
15
+ if (isValidData(data)) {
16
+ return data.value; // Type safe
17
+ }
18
+ throw new Error('Invalid data');
19
+ }
20
+
21
+ function isValidData(data: unknown): data is { value: string } {
22
+ return typeof data === 'object' && data !== null && 'value' in data;
23
+ }
24
+ ```
25
+
26
+ ### 2. Forced Type Casting with as any
27
+
28
+ ```typescript
29
+ // ❌ Bypassing types with as any
30
+ const user = response as any;
31
+ user.name; // Runtime error risk
32
+
33
+ // ✅ Proper type definition
34
+ interface User {
35
+ name: string;
36
+ email: string;
37
+ }
38
+
39
+ const user = response as User;
40
+ user.name; // Type safe
41
+ ```
42
+
43
+ ### 3. Overusing @ts-ignore
44
+
45
+ ```typescript
46
+ // ❌ Ignoring errors with @ts-ignore
47
+ // @ts-ignore
48
+ const result = problematicCode();
49
+
50
+ // ✅ Fix the type issue at its root
51
+ interface Expected {
52
+ id: string;
53
+ }
54
+
55
+ const result: Expected = {
56
+ id: String(problematicCode()),
57
+ };
58
+ ```
59
+
60
+ ## React Anti-Patterns
61
+
62
+ ### 1. Using dangerouslySetInnerHTML
63
+
64
+ ```typescript
65
+ // ❌ XSS vulnerability
66
+ function Component({ html }: { html: string }) {
67
+ return <div dangerouslySetInnerHTML={{ __html: html }} />;
68
+ }
69
+
70
+ // ✅ Safe rendering
71
+ import DOMPurify from 'dompurify';
72
+
73
+ function Component({ html }: { html: string }) {
74
+ const sanitized = DOMPurify.sanitize(html);
75
+ return <div dangerouslySetInnerHTML={{ __html: sanitized }} />;
76
+ }
77
+
78
+ // ✅ Better approach: Use markdown library
79
+ import ReactMarkdown from 'react-markdown';
80
+
81
+ function Component({ markdown }: { markdown: string }) {
82
+ return <ReactMarkdown>{markdown}</ReactMarkdown>;
83
+ }
84
+ ```
85
+
86
+ ### 2. Props Drilling (More than 3 levels)
87
+
88
+ ```typescript
89
+ // ❌ Props drilling
90
+ function App() {
91
+ const [user, setUser] = useState<User>();
92
+ return <Parent user={user} />;
93
+ }
94
+
95
+ function Parent({ user }: { user: User }) {
96
+ return <Child user={user} />;
97
+ }
98
+
99
+ function Child({ user }: { user: User }) {
100
+ return <GrandChild user={user} />;
101
+ }
102
+
103
+ function GrandChild({ user }: { user: User }) {
104
+ return <div>{user.name}</div>;
105
+ }
106
+
107
+ // ✅ Use Context API
108
+ const UserContext = createContext<User | undefined>(undefined);
109
+
110
+ function App() {
111
+ const [user, setUser] = useState<User>();
112
+ return (
113
+ <UserContext.Provider value={user}>
114
+ <Parent />
115
+ </UserContext.Provider>
116
+ );
117
+ }
118
+
119
+ function GrandChild() {
120
+ const user = useContext(UserContext);
121
+ return <div>{user?.name}</div>;
122
+ }
123
+ ```
124
+
125
+ ### 3. Missing useEffect Dependency Array
126
+
127
+ ```typescript
128
+ // ❌ Missing dependency
129
+ function Component({ userId }: { userId: string }) {
130
+ const [user, setUser] = useState<User>();
131
+
132
+ useEffect(() => {
133
+ fetchUser(userId).then(setUser);
134
+ }, []); // Missing userId dependency!
135
+
136
+ return <div>{user?.name}</div>;
137
+ }
138
+
139
+ // ✅ Specify all dependencies
140
+ function Component({ userId }: { userId: string }) {
141
+ const [user, setUser] = useState<User>();
142
+
143
+ useEffect(() => {
144
+ fetchUser(userId).then(setUser);
145
+ }, [userId]); // Dependency specified
146
+
147
+ return <div>{user?.name}</div>;
148
+ }
149
+ ```
150
+
151
+ ## JavaScript Anti-Patterns
152
+
153
+ ### 1. Using var
154
+
155
+ ```typescript
156
+ // ❌ Using var
157
+ var count = 0;
158
+ if (true) {
159
+ var count = 1; // Same variable!
160
+ }
161
+ console.log(count); // 1
162
+
163
+ // ✅ Use const/let
164
+ let count = 0;
165
+ if (true) {
166
+ let count = 1; // Block scope
167
+ }
168
+ console.log(count); // 0
169
+ ```
170
+
171
+ ### 2. Using == (Loose Comparison)
172
+
173
+ ```typescript
174
+ // ❌ Using ==
175
+ if (value == null) { } // Also matches undefined
176
+ if ('5' == 5) { } // true (type coercion)
177
+
178
+ // ✅ Use ===
179
+ if (value === null) { }
180
+ if (value === undefined) { }
181
+ if ('5' === 5) { } // false
182
+ ```
183
+
184
+ ### 3. Using eval()
185
+
186
+ ```typescript
187
+ // ❌ Using eval() (security risk)
188
+ const code = userInput;
189
+ eval(code); // Can execute arbitrary code
190
+
191
+ // ✅ Alternative implementation
192
+ const allowedOperations = {
193
+ add: (a: number, b: number) => a + b,
194
+ subtract: (a: number, b: number) => a - b,
195
+ };
196
+
197
+ const operation = allowedOperations[userInput];
198
+ if (operation) {
199
+ result = operation(a, b);
200
+ }
201
+ ```
202
+
203
+ ## CSS Anti-Patterns
204
+
205
+ ### 1. Overusing !important
206
+
207
+ ```css
208
+ /* ❌ Overusing !important */
209
+ .button {
210
+ color: blue !important;
211
+ background: red !important;
212
+ }
213
+
214
+ /* ✅ Use specific selectors */
215
+ .navigation .button.primary {
216
+ color: blue;
217
+ background: red;
218
+ }
219
+ ```
220
+
221
+ ### 2. Overusing Inline Styles
222
+
223
+ ```typescript
224
+ // ❌ Inline styles
225
+ function Button() {
226
+ return (
227
+ <button
228
+ style={{
229
+ backgroundColor: 'blue',
230
+ color: 'white',
231
+ padding: '10px',
232
+ borderRadius: '5px',
233
+ }}
234
+ >
235
+ Click me
236
+ </button>
237
+ );
238
+ }
239
+
240
+ // ✅ Use CSS classes
241
+ function Button() {
242
+ return <button className="btn-primary">Click me</button>;
243
+ }
244
+
245
+ // styles.css
246
+ .btn-primary {
247
+ background-color: blue;
248
+ color: white;
249
+ padding: 10px;
250
+ border-radius: 5px;
251
+ }
252
+ ```
253
+
254
+ ## Performance Anti-Patterns
255
+
256
+ ### 1. Unnecessary Re-renders
257
+
258
+ ```typescript
259
+ // ❌ Creating new objects/functions every render
260
+ function Parent() {
261
+ return <Child config={{ theme: 'dark' }} onClick={() => {}} />;
262
+ // New object/function created every render → Child re-renders
263
+ }
264
+
265
+ // ✅ Use useMemo/useCallback
266
+ function Parent() {
267
+ const config = useMemo(() => ({ theme: 'dark' }), []);
268
+ const handleClick = useCallback(() => {}, []);
269
+
270
+ return <Child config={config} onClick={handleClick} />;
271
+ }
272
+ ```
273
+
274
+ ### 2. Synchronous Heavy Computations
275
+
276
+ ```typescript
277
+ // ❌ Blocking main thread
278
+ function Component({ data }: { data: number[] }) {
279
+ const result = data
280
+ .map(heavyComputation)
281
+ .filter(x => x > 0)
282
+ .reduce((a, b) => a + b);
283
+
284
+ return <div>{result}</div>;
285
+ }
286
+
287
+ // ✅ Memoization with useMemo
288
+ function Component({ data }: { data: number[] }) {
289
+ const result = useMemo(
290
+ () =>
291
+ data
292
+ .map(heavyComputation)
293
+ .filter(x => x > 0)
294
+ .reduce((a, b) => a + b),
295
+ [data]
296
+ );
297
+
298
+ return <div>{result}</div>;
299
+ }
300
+ ```
301
+
302
+ ## Security Anti-Patterns
303
+
304
+ ### 1. Hardcoding Sensitive Information
305
+
306
+ ```typescript
307
+ // ❌ Hardcoded API key
308
+ const API_KEY = 'sk-1234567890abcdef';
309
+
310
+ // ✅ Use environment variables
311
+ const API_KEY = process.env.NEXT_PUBLIC_API_KEY;
312
+ ```
313
+
314
+ ### 2. SQL Injection Vulnerability
315
+
316
+ ```typescript
317
+ // ❌ Direct string concatenation
318
+ const query = `SELECT * FROM users WHERE id = ${userId}`;
319
+
320
+ // ✅ Parameterized query
321
+ const query = 'SELECT * FROM users WHERE id = ?';
322
+ db.execute(query, [userId]);
323
+ ```
324
+
325
+ ## Immutability Anti-Patterns
326
+
327
+ ### 1. Direct State Mutation
328
+
329
+ ```typescript
330
+ // ❌ Directly mutating state
331
+ const [user, setUser] = useState({ name: 'John', age: 30 });
332
+
333
+ function updateAge() {
334
+ user.age = 31; // Direct mutation!
335
+ setUser(user); // React won't detect the change
336
+ }
337
+
338
+ // ✅ Use spread operator for immutable update
339
+ function updateAge() {
340
+ setUser({ ...user, age: 31 }); // New object created
341
+ }
342
+
343
+ // ✅ Or use functional update
344
+ function updateAge() {
345
+ setUser(prev => ({ ...prev, age: prev.age + 1 }));
346
+ }
347
+ ```
348
+
349
+ ### 2. Array Mutation Methods
350
+
351
+ ```typescript
352
+ // ❌ Mutating array methods
353
+ const [items, setItems] = useState(['a', 'b', 'c']);
354
+
355
+ function addItem(item: string) {
356
+ items.push(item); // Mutates original array!
357
+ setItems(items);
358
+ }
359
+
360
+ function removeItem(index: number) {
361
+ items.splice(index, 1); // Mutates original array!
362
+ setItems(items);
363
+ }
364
+
365
+ // ✅ Immutable array operations
366
+ function addItem(item: string) {
367
+ setItems([...items, item]); // Spread creates new array
368
+ }
369
+
370
+ function removeItem(index: number) {
371
+ setItems(items.filter((_, i) => i !== index)); // filter returns new array
372
+ }
373
+
374
+ function updateItem(index: number, newValue: string) {
375
+ setItems(items.map((item, i) => i === index ? newValue : item));
376
+ }
377
+ ```
378
+
379
+ ### 3. Nested Object Mutation
380
+
381
+ ```typescript
382
+ // ❌ Deeply nested mutation
383
+ const [state, setState] = useState({
384
+ user: {
385
+ profile: {
386
+ name: 'John',
387
+ settings: { theme: 'dark' }
388
+ }
389
+ }
390
+ });
391
+
392
+ function updateTheme(theme: string) {
393
+ state.user.profile.settings.theme = theme; // Deep mutation!
394
+ setState(state);
395
+ }
396
+
397
+ // ✅ Immutable deep update
398
+ function updateTheme(theme: string) {
399
+ setState({
400
+ ...state,
401
+ user: {
402
+ ...state.user,
403
+ profile: {
404
+ ...state.user.profile,
405
+ settings: {
406
+ ...state.user.profile.settings,
407
+ theme
408
+ }
409
+ }
410
+ }
411
+ });
412
+ }
413
+
414
+ // ✅ Better: Use immer for complex updates
415
+ import { produce } from 'immer';
416
+
417
+ function updateTheme(theme: string) {
418
+ setState(produce(draft => {
419
+ draft.user.profile.settings.theme = theme; // Safe with immer
420
+ }));
421
+ }
422
+ ```
423
+
424
+ ### 4. Object.assign Misuse
425
+
426
+ ```typescript
427
+ // ❌ Object.assign mutating first argument
428
+ const original = { a: 1, b: 2 };
429
+ const updated = Object.assign(original, { b: 3 }); // Mutates original!
430
+
431
+ // ✅ Use empty object as first argument
432
+ const updated = Object.assign({}, original, { b: 3 });
433
+
434
+ // ✅ Or use spread (preferred)
435
+ const updated = { ...original, b: 3 };
436
+ ```
437
+
438
+ ### 5. Reducer State Mutation
439
+
440
+ ```typescript
441
+ // ❌ Mutating state in reducer
442
+ function reducer(state: State, action: Action) {
443
+ switch (action.type) {
444
+ case 'ADD_ITEM':
445
+ state.items.push(action.payload); // Mutation!
446
+ return state;
447
+ default:
448
+ return state;
449
+ }
450
+ }
451
+
452
+ // ✅ Return new state
453
+ function reducer(state: State, action: Action) {
454
+ switch (action.type) {
455
+ case 'ADD_ITEM':
456
+ return {
457
+ ...state,
458
+ items: [...state.items, action.payload]
459
+ };
460
+ default:
461
+ return state;
462
+ }
463
+ }
464
+ ```
465
+
466
+ ### 6. Mutating Function Parameters
467
+
468
+ ```typescript
469
+ // ❌ Mutating input parameter
470
+ function addTimestamp(data: Record<string, unknown>) {
471
+ data.timestamp = Date.now(); // Mutates caller's object!
472
+ return data;
473
+ }
474
+
475
+ // ✅ Create new object
476
+ function addTimestamp(data: Record<string, unknown>) {
477
+ return {
478
+ ...data,
479
+ timestamp: Date.now()
480
+ };
481
+ }
482
+ ```
483
+
484
+ ### Immutable Methods Reference
485
+
486
+ | Mutating (Avoid) | Immutable (Use) |
487
+ |------------------|-----------------|
488
+ | `push()` | `[...arr, item]` |
489
+ | `pop()` | `arr.slice(0, -1)` |
490
+ | `shift()` | `arr.slice(1)` |
491
+ | `unshift()` | `[item, ...arr]` |
492
+ | `splice()` | `filter()` / `slice()` + spread |
493
+ | `sort()` | `[...arr].sort()` |
494
+ | `reverse()` | `[...arr].reverse()` |
495
+ | `obj.prop = x` | `{ ...obj, prop: x }` |
496
+
497
+ ## Error Handling Anti-Patterns
498
+
499
+ ### 1. Empty catch Block
500
+
501
+ ```typescript
502
+ // ❌ Ignoring errors
503
+ try {
504
+ riskyOperation();
505
+ } catch (e) {
506
+ // Does nothing
507
+ }
508
+
509
+ // ✅ Proper error handling
510
+ try {
511
+ riskyOperation();
512
+ } catch (error) {
513
+ console.error('Operation failed:', error);
514
+ showErrorNotification(error);
515
+ trackError(error);
516
+ }
517
+ ```
518
+
519
+ ### 2. Handling Without Error Type Check
520
+
521
+ ```typescript
522
+ // ❌ Treating all errors the same
523
+ try {
524
+ await fetchData();
525
+ } catch (error) {
526
+ showError('Failed'); // Not specific
527
+ }
528
+
529
+ // ✅ Handle by error type
530
+ try {
531
+ await fetchData();
532
+ } catch (error) {
533
+ if (error instanceof NetworkError) {
534
+ showError('Please check your network connection');
535
+ } else if (error instanceof AuthError) {
536
+ redirectToLogin();
537
+ } else {
538
+ showError('An unknown error occurred');
539
+ }
540
+ }
541
+ ```