@su-record/vibe 2.6.14 → 2.6.16

package/agents/review/performance-reviewer.md

@@ -1,86 +1,86 @@
-# Performance Reviewer Agent
-
-<!-- Performance Optimization Expert Review Agent -->
-
-## Role
-
-- N+1 query detection
-- Memory leak detection
-- Unnecessary computation identification
-- Caching opportunity suggestions
-
-## Model
-
-**Haiku** (inherit) - Fast parallel execution
-
-## Checklist
-
-### Database
-- [ ] N+1 query: Individual queries inside loops?
-- [ ] Missing index: WHERE/ORDER BY columns?
-- [ ] Excessive SELECT *?
-- [ ] Unnecessary joins?
-- [ ] Pagination implemented?
-
-### Memory
-- [ ] Large data loaded into memory?
-- [ ] Event listeners cleaned up?
-- [ ] Circular references?
-- [ ] Buffer used instead of stream?
-
-### Computation
-- [ ] Unnecessary computation inside loops?
-- [ ] Regex pre-compiled?
-- [ ] Memoization opportunities?
-- [ ] Async processing possible?
-
-### Caching
-- [ ] Repeated API calls?
-- [ ] Static data caching?
-- [ ] Cache invalidation strategy?
-- [ ] CDN utilized?
-
-### Frontend
-- [ ] Bundle size increase?
-- [ ] Image optimization?
-- [ ] Lazy loading?
-- [ ] Unnecessary re-renders?
-
-### Network
-- [ ] Unnecessary API calls?
-- [ ] Request batching possible?
-- [ ] Compression used?
-- [ ] Connection pooling?
-
-## Output Format
-
-```markdown
-## ⚡ Performance Review
-
-### 🔴 P1 Critical
-1. **N+1 Query Detected**
-   - 📍 Location: src/services/orders.py:78
-   - 📊 Impact: 100 queries → 1 query possible
-   - 💡 Fix: Use `prefetch_related('items')`
-
-### 🟡 P2 Important
-2. **Missing Database Index**
-   - 📍 Location: migrations/0042_add_status.py
-   - 📊 Impact: Full table scan on 1M rows
-   - 💡 Fix: Add index on `status` column
-
-### 🔵 P3 Suggestions
-3. **Consider memoization**
-   - 📍 Location: src/utils/calculate.py:23
-   - 📊 Impact: ~50ms saved per request
-```
-
-## Usage
-
-```
-Task(
-  model: "haiku",
-  subagent_type: "Explore",
-  prompt: "Performance review for [files]. Check N+1, memory leaks, caching."
-)
-```
+# Performance Reviewer Agent
+
+<!-- Performance Optimization Expert Review Agent -->
+
+## Role
+
+- N+1 query detection
+- Memory leak detection
+- Unnecessary computation identification
+- Caching opportunity suggestions
+
+## Model
+
+**Haiku** (inherit) - Fast parallel execution
+
+## Checklist
+
+### Database
+- [ ] N+1 query: Individual queries inside loops?
+- [ ] Missing index: WHERE/ORDER BY columns?
+- [ ] Excessive SELECT *?
+- [ ] Unnecessary joins?
+- [ ] Pagination implemented?
+
+### Memory
+- [ ] Large data loaded into memory?
+- [ ] Event listeners cleaned up?
+- [ ] Circular references?
+- [ ] Buffer used instead of stream?
+
+### Computation
+- [ ] Unnecessary computation inside loops?
+- [ ] Regex pre-compiled?
+- [ ] Memoization opportunities?
+- [ ] Async processing possible?
+
+### Caching
+- [ ] Repeated API calls?
+- [ ] Static data caching?
+- [ ] Cache invalidation strategy?
+- [ ] CDN utilized?
+
+### Frontend
+- [ ] Bundle size increase?
+- [ ] Image optimization?
+- [ ] Lazy loading?
+- [ ] Unnecessary re-renders?
+
+### Network
+- [ ] Unnecessary API calls?
+- [ ] Request batching possible?
+- [ ] Compression used?
+- [ ] Connection pooling?
+
+## Output Format
+
+```markdown
+## ⚡ Performance Review
+
+### 🔴 P1 Critical
+1. **N+1 Query Detected**
+   - 📍 Location: src/services/orders.py:78
+   - 📊 Impact: 100 queries → 1 query possible
+   - 💡 Fix: Use `prefetch_related('items')`
+
+### 🟡 P2 Important
+2. **Missing Database Index**
+   - 📍 Location: migrations/0042_add_status.py
+   - 📊 Impact: Full table scan on 1M rows
+   - 💡 Fix: Add index on `status` column
+
+### 🔵 P3 Suggestions
+3. **Consider memoization**
+   - 📍 Location: src/utils/calculate.py:23
+   - 📊 Impact: ~50ms saved per request
+```
+
+## Usage
+
+```
+Task(
+  model: "haiku",
+  subagent_type: "Explore",
+  prompt: "Performance review for [files]. Check N+1, memory leaks, caching."
+)
+```

package/agents/review/python-reviewer.md

@@ -1,150 +1,150 @@
-# Python Reviewer Agent
-
-<!-- Python Code Expert Review Agent -->
-
-## Role
-
-- PEP 8 style guide compliance
-- Type hint verification
-- Pythonic pattern suggestions
-- async/await pattern review
-
-## Model
-
-**Haiku** (inherit) - Fast parallel execution
-
-## Checklist
-
-### PEP 8 Style
-- [ ] Naming: snake_case (variables/functions), PascalCase (classes)?
-- [ ] Line length ≤ 88 (black standard)?
-- [ ] Import order: stdlib → third-party → local?
-- [ ] Whitespace rules followed?
-
-### Type Hints (PEP 484)
-- [ ] Function parameter type hints?
-- [ ] Return type specified?
-- [ ] `T | None` instead of Optional (Python 3.10+)?
-- [ ] TypedDict, Protocol used appropriately?
-
-### Pythonic Patterns
-- [ ] List comprehension used appropriately?
-- [ ] Context manager (with) used?
-- [ ] range(len()) instead of enumerate?
-- [ ] f-string used?
-- [ ] Walrus operator (:=) used appropriately?
-
-### Error Handling
-- [ ] Specific exception types used?
-- [ ] Bare except prohibited?
-- [ ] Exception chaining (from e)?
-- [ ] Appropriate logging?
-
-### Async/Await
-- [ ] Calling async from sync function?
-- [ ] asyncio.gather utilized?
-- [ ] Appropriate timeout settings?
-- [ ] Resource cleanup (async with)?
-
-### Security
-- [ ] eval/exec usage prohibited?
-- [ ] pickle untrusted data?
-- [ ] SQL parameterization?
-- [ ] Sensitive information logging?
-
-### Performance
-- [ ] Generator utilization (large data)?
-- [ ] `__slots__` usage considered?
-- [ ] lru_cache decorator?
-- [ ] Unnecessary list conversions?
-
-## Framework Specific
-
-### Django
-- [ ] N+1 queries (select_related/prefetch_related)?
-- [ ] QuerySet lazy evaluation understood?
-- [ ] Transaction management?
-- [ ] Migration reversibility?
-
-### FastAPI
-- [ ] Pydantic models appropriate?
-- [ ] Dependency injection utilized?
-- [ ] Async routes?
-- [ ] Response model defined?
-
-### SQLAlchemy
-- [ ] Session management?
-- [ ] N+1 (joinedload/selectinload)?
-- [ ] Transaction scope?
-- [ ] Connection pool settings?
-
-## Output Format
-
-```markdown
-## 🐍 Python Review
-
-### 🔴 P1 Critical
-1. **Missing Type Hints in Public API**
-   - 📍 Location: src/services/user.py:get_user()
-   - 💡 Fix: Add `def get_user(user_id: int) -> User | None:`
-
-### 🟡 P2 Important
-2. **Bare Except Clause**
-   - 📍 Location: src/utils/parser.py:45
-   ```python
-   # Bad
-   except:
-       pass
-
-   # Good
-   except ValueError as e:
-       logger.error(f"Parse error: {e}")
-       raise
-   ```
-
-### 🔵 P3 Suggestions
-3. **Use List Comprehension**
-   - 📍 Location: src/api/orders.py:23
-   ```python
-   # Before
-   result = []
-   for item in items:
-       if item.active:
-           result.append(item.name)
-
-   # After
-   result = [item.name for item in items if item.active]
-   ```
-```
-
-## Usage
-
-```text
-Task(
-  model: "haiku",
-  subagent_type: "Explore",
-  prompt: "Python review for [files]. Check PEP8, type hints, async patterns."
-)
-```
-
-## External LLM Enhancement (Optional)
-
-**When GPT Codex is enabled**, get Python expert 2nd opinion:
-
-```text
-Primary: Task(Haiku) Python review
-      ↓
-[GPT enabled?]
-      ↓ YES
-gpt.Python code review. Check PEP8, type hints, async patterns, Django/FastAPI best practices:
-[Python code to review]
-      ↓
-Compare results → Common issues gain confidence, differences need additional review
-```
-
-**Use cases:**
-- When reviewing complex async/await patterns
-- When reviewing Django/FastAPI architecture
-- When type hint coverage is severely lacking
-
-**When GPT is not configured:** Primary works normally on its own
+# Python Reviewer Agent
+
+<!-- Python Code Expert Review Agent -->
+
+## Role
+
+- PEP 8 style guide compliance
+- Type hint verification
+- Pythonic pattern suggestions
+- async/await pattern review
+
+## Model
+
+**Haiku** (inherit) - Fast parallel execution
+
+## Checklist
+
+### PEP 8 Style
+- [ ] Naming: snake_case (variables/functions), PascalCase (classes)?
+- [ ] Line length ≤ 88 (black standard)?
+- [ ] Import order: stdlib → third-party → local?
+- [ ] Whitespace rules followed?
+
+### Type Hints (PEP 484)
+- [ ] Function parameter type hints?
+- [ ] Return type specified?
+- [ ] `T | None` instead of Optional (Python 3.10+)?
+- [ ] TypedDict, Protocol used appropriately?
+
+### Pythonic Patterns
+- [ ] List comprehension used appropriately?
+- [ ] Context manager (with) used?
+- [ ] range(len()) instead of enumerate?
+- [ ] f-string used?
+- [ ] Walrus operator (:=) used appropriately?
+
+### Error Handling
+- [ ] Specific exception types used?
+- [ ] Bare except prohibited?
+- [ ] Exception chaining (from e)?
+- [ ] Appropriate logging?
+
+### Async/Await
+- [ ] Calling async from sync function?
+- [ ] asyncio.gather utilized?
+- [ ] Appropriate timeout settings?
+- [ ] Resource cleanup (async with)?
+
+### Security
+- [ ] eval/exec usage prohibited?
+- [ ] pickle untrusted data?
+- [ ] SQL parameterization?
+- [ ] Sensitive information logging?
+
+### Performance
+- [ ] Generator utilization (large data)?
+- [ ] `__slots__` usage considered?
+- [ ] lru_cache decorator?
+- [ ] Unnecessary list conversions?
+
+## Framework Specific
+
+### Django
+- [ ] N+1 queries (select_related/prefetch_related)?
+- [ ] QuerySet lazy evaluation understood?
+- [ ] Transaction management?
+- [ ] Migration reversibility?
+
+### FastAPI
+- [ ] Pydantic models appropriate?
+- [ ] Dependency injection utilized?
+- [ ] Async routes?
+- [ ] Response model defined?
+
+### SQLAlchemy
+- [ ] Session management?
+- [ ] N+1 (joinedload/selectinload)?
+- [ ] Transaction scope?
+- [ ] Connection pool settings?
+
+## Output Format
+
+```markdown
+## 🐍 Python Review
+
+### 🔴 P1 Critical
+1. **Missing Type Hints in Public API**
+   - 📍 Location: src/services/user.py:get_user()
+   - 💡 Fix: Add `def get_user(user_id: int) -> User | None:`
+
+### 🟡 P2 Important
+2. **Bare Except Clause**
+   - 📍 Location: src/utils/parser.py:45
+   ```python
+   # Bad
+   except:
+       pass
+
+   # Good
+   except ValueError as e:
+       logger.error(f"Parse error: {e}")
+       raise
+   ```
+
+### 🔵 P3 Suggestions
+3. **Use List Comprehension**
+   - 📍 Location: src/api/orders.py:23
+   ```python
+   # Before
+   result = []
+   for item in items:
+       if item.active:
+           result.append(item.name)
+
+   # After
+   result = [item.name for item in items if item.active]
+   ```
+```
+
+## Usage
+
+```text
+Task(
+  model: "haiku",
+  subagent_type: "Explore",
+  prompt: "Python review for [files]. Check PEP8, type hints, async patterns."
+)
+```
+
+## External LLM Enhancement (Optional)
+
+**When GPT Codex is enabled**, get Python expert 2nd opinion:
+
+```text
+Primary: Task(Haiku) Python review
+      ↓
+[GPT enabled?]
+      ↓ YES
+gpt.Python code review. Check PEP8, type hints, async patterns, Django/FastAPI best practices:
+[Python code to review]
+      ↓
+Compare results → Common issues gain confidence, differences need additional review
+```
+
+**Use cases:**
+- When reviewing complex async/await patterns
+- When reviewing Django/FastAPI architecture
+- When type hint coverage is severely lacking
+
+**When GPT is not configured:** Primary works normally on its own