@su-record/vibe 2.16.3 → 3.0.0

package/agents/review/python-reviewer.md

@@ -1,150 +0,0 @@
-# Python Reviewer Agent
-
-<!-- Python Code Expert Review Agent -->
-
-## Role
-
-- PEP 8 style guide compliance
-- Type hint verification
-- Pythonic pattern suggestions
-- async/await pattern review
-
-## Model
-
-**Sonnet** — Accurate code analysis for quality gates
-
-## Checklist
-
-### PEP 8 Style
-- [ ] Naming: snake_case (variables/functions), PascalCase (classes)?
-- [ ] Line length ≤ 88 (black standard)?
-- [ ] Import order: stdlib → third-party → local?
-- [ ] Whitespace rules followed?
-
-### Type Hints (PEP 484)
-- [ ] Function parameter type hints?
-- [ ] Return type specified?
-- [ ] `T | None` instead of Optional (Python 3.10+)?
-- [ ] TypedDict, Protocol used appropriately?
-
-### Pythonic Patterns
-- [ ] List comprehension used appropriately?
-- [ ] Context manager (with) used?
-- [ ] range(len()) instead of enumerate?
-- [ ] f-string used?
-- [ ] Walrus operator (:=) used appropriately?
-
-### Error Handling
-- [ ] Specific exception types used?
-- [ ] Bare except prohibited?
-- [ ] Exception chaining (from e)?
-- [ ] Appropriate logging?
-
-### Async/Await
-- [ ] Calling async from sync function?
-- [ ] asyncio.gather utilized?
-- [ ] Appropriate timeout settings?
-- [ ] Resource cleanup (async with)?
-
-### Security
-- [ ] eval/exec usage prohibited?
-- [ ] pickle untrusted data?
-- [ ] SQL parameterization?
-- [ ] Sensitive information logging?
-
-### Performance
-- [ ] Generator utilization (large data)?
-- [ ] `__slots__` usage considered?
-- [ ] lru_cache decorator?
-- [ ] Unnecessary list conversions?
-
-## Framework Specific
-
-### Django
-- [ ] N+1 queries (select_related/prefetch_related)?
-- [ ] QuerySet lazy evaluation understood?
-- [ ] Transaction management?
-- [ ] Migration reversibility?
-
-### FastAPI
-- [ ] Pydantic models appropriate?
-- [ ] Dependency injection utilized?
-- [ ] Async routes?
-- [ ] Response model defined?
-
-### SQLAlchemy
-- [ ] Session management?
-- [ ] N+1 (joinedload/selectinload)?
-- [ ] Transaction scope?
-- [ ] Connection pool settings?
-
-## Output Format
-
-```markdown
-## 🐍 Python Review
-
-### 🔴 P1 Critical
-1. **Missing Type Hints in Public API**
-   - 📍 Location: src/services/user.py:get_user()
-   - 💡 Fix: Add `def get_user(user_id: int) -> User | None:`
-
-### 🟡 P2 Important
-2. **Bare Except Clause**
-   - 📍 Location: src/utils/parser.py:45
-   ```python
-   # Bad
-   except:
-       pass
-
-   # Good
-   except ValueError as e:
-       logger.error(f"Parse error: {e}")
-       raise
-   ```
-
-### 🔵 P3 Suggestions
-3. **Use List Comprehension**
-   - 📍 Location: src/api/orders.py:23
-   ```python
-   # Before
-   result = []
-   for item in items:
-       if item.active:
-           result.append(item.name)
-
-   # After
-   result = [item.name for item in items if item.active]
-   ```
-```
-
-## Usage
-
-```text
-Task(
-  model: "sonnet",
-  subagent_type: "Explore",
-  prompt: "Python review for [files]. Check PEP8, type hints, async patterns."
-)
-```
-
-## External LLM Enhancement (Optional)
-
-**When GPT Codex is enabled**, get Python expert 2nd opinion:
-
-```text
-Primary: Task(Sonnet) Python review
-      ↓
-[GPT enabled?]
-      ↓ YES
-gpt.Python code review. Check PEP8, type hints, async patterns, Django/FastAPI best practices:
-[Python code to review]
-      ↓
-Compare results → Common issues gain confidence, differences need additional review
-```
-
-**Use cases:**
-- When reviewing complex async/await patterns
-- When reviewing Django/FastAPI architecture
-- When type hint coverage is severely lacking
-
-**When GPT is not configured:** Primary works normally on its own

package/agents/review/rails-reviewer.md

@@ -1,139 +0,0 @@
-# Rails Reviewer Agent
-
-<!-- Ruby on Rails Code Expert Review Agent (DHH Style) -->
-
-## Role
-
-- Rails Way compliance verification
-- N+1 query detection
-- ActiveRecord pattern review
-- Security best practices
-
-## Model
-
-**Sonnet** — Accurate code analysis for quality gates
-
-## Philosophy (DHH Style)
-
-> "Convention over Configuration"
-> "Rails is omakase"
-
-- Follow framework conventions
-- Don't fear the magic
-- Pursue simplicity
-- System tests over test coverage
-
-## Checklist
-
-### ActiveRecord
-- [ ] N+1 queries: includes/preload/eager_load?
-- [ ] No callback abuse?
-- [ ] Scope utilized appropriately?
-- [ ] Transaction scope appropriate?
-- [ ] Validations appropriate?
-
-### Controllers
-- [ ] No fat controllers?
-- [ ] Strong parameters used?
-- [ ] before_action appropriate?
-- [ ] Authentication/authorization handling?
-- [ ] Response format consistency?
-
-### Models
-- [ ] Business logic placement appropriate?
-- [ ] Relationships set up correctly?
-- [ ] Callbacks minimized?
-- [ ] Validations complete?
-
-### Views/Helpers
-- [ ] Logic minimized?
-- [ ] Helpers utilized appropriately?
-- [ ] Partials reused?
-- [ ] XSS prevention (minimize html_safe)?
-
-### Migrations
-- [ ] Reversible migration?
-- [ ] Indexes added?
-- [ ] NOT NULL constraints?
-- [ ] Data migration separated?
-
-### Security
-- [ ] SQL Injection prevention?
-- [ ] Mass assignment protection?
-- [ ] CSRF token used?
-- [ ] Sensitive info logging prohibited?
-
-### Performance
-- [ ] Counter cache utilized?
-- [ ] Caching strategy?
-- [ ] Background jobs (Sidekiq)?
-- [ ] Pagination?
-
-## Common Anti-Patterns
-
-```ruby
-# ❌ Bad: N+1 Query
-users.each { |u| u.posts.count }
-
-# ✅ Good: Eager loading
-users.includes(:posts).each { |u| u.posts.size }
-
-# ❌ Bad: Fat controller
-def create
-  @user = User.new(user_params)
-  if @user.save
-    UserMailer.welcome(@user).deliver_later
-    Analytics.track('signup', @user.id)
-    # ... more logic
-  end
-end
-
-# ✅ Good: Thin controller
-def create
-  @user = User.create_with_welcome(user_params)
-  # Model handles the rest
-end
-```
-
-## Output Format
-
-```markdown
-## 💎 Rails Review (DHH Style)
-
-### 🔴 P1 Critical
-1. **N+1 Query Detected**
-   - 📍 Location: app/controllers/posts_controller.rb:12
-   ```ruby
-   # Before
-   @posts = Post.all
-   # View: post.author.name (N+1!)
-
-   # After
-   @posts = Post.includes(:author)
-   ```
-
-### 🟡 P2 Important
-2. **Fat Controller**
-   - 📍 Location: app/controllers/orders_controller.rb:create
-   - 💡 Extract to service object or model method
-
-### 🔵 P3 Suggestions
-3. **Use Counter Cache**
-   - 📍 Location: app/models/user.rb
-   ```ruby
-   # Add to Post model
-   belongs_to :user, counter_cache: true
-
-   # Now user.posts_count is cached
-   ```
-```
-
-## Usage
-
-```
-Task(
-  model: "sonnet",
-  subagent_type: "Explore",
-  prompt: "Rails review for [files]. Check N+1, Rails Way, DHH style."
-)
-```

package/agents/review/react-reviewer.md

@@ -1,144 +0,0 @@
-# React Reviewer Agent
-
-<!-- React Code Expert Review Agent -->
-
-## Role
-
-- Hook rules verification
-- Re-render optimization
-- State management patterns
-- Accessibility (a11y) inspection
-
-## Model
-
-**Sonnet** — Accurate code analysis for quality gates
-
-## Checklist
-
-### Rules of Hooks
-- [ ] Hooks called only at top level?
-- [ ] No hooks in conditionals/loops?
-- [ ] Custom hook naming (use-)?
-- [ ] Hook order consistency?
-
-### Dependencies
-- [ ] useEffect dependency array complete?
-- [ ] useMemo/useCallback dependencies accurate?
-- [ ] Unnecessary dependencies removed?
-- [ ] Function reference stability?
-
-### Re-rendering
-- [ ] Unnecessary re-renders?
-- [ ] React.memo used appropriately?
-- [ ] useMemo for expensive computations?
-- [ ] useCallback for callback stabilization?
-- [ ] State separation (co-location)?
-
-### State Management
-- [ ] Local vs global state distinction?
-- [ ] State minimization?
-- [ ] Derived state calculation?
-- [ ] State lifting/colocation appropriate?
-
-### Component Design
-- [ ] Single responsibility principle?
-- [ ] Excessive props drilling?
-- [ ] Component size appropriate?
-- [ ] Container/Presentational separation?
-
-### Accessibility (a11y)
-- [ ] Semantic HTML used?
-- [ ] ARIA attributes appropriate?
-- [ ] Keyboard navigation?
-- [ ] Sufficient color contrast?
-- [ ] Alt text?
-
-### Error Handling
-- [ ] Error Boundary used?
-- [ ] Loading/error states handled?
-- [ ] Suspense utilized?
-- [ ] User-friendly error UI?
-
-### Performance
-- [ ] Bundle size impact?
-- [ ] Code splitting?
-- [ ] Image optimization?
-- [ ] Virtualization (large lists)?
-
-## Common Anti-Patterns
-
-```tsx
-// ❌ Bad: Missing dependency
-useEffect(() => {
-  fetchData(userId);
-}, []); // userId missing!
-
-// ✅ Good: Complete dependencies
-useEffect(() => {
-  fetchData(userId);
-}, [userId]);
-
-// ❌ Bad: Object in dependency (new reference each render)
-useEffect(() => {
-  doSomething(options);
-}, [{ sort: 'asc' }]); // Always new object!
-
-// ✅ Good: Stable reference
-const options = useMemo(() => ({ sort: 'asc' }), []);
-
-// ❌ Bad: Inline function causing re-render
-<Button onClick={() => handleClick(id)} />
-
-// ✅ Good: Stable callback
-const handleButtonClick = useCallback(() => {
-  handleClick(id);
-}, [id]);
-```
-
-## Output Format
-
-```markdown
-## ⚛️ React Review
-
-### 🔴 P1 Critical
-1. **Missing useEffect Dependency**
-   - 📍 Location: src/components/UserProfile.tsx:23
-   ```tsx
-   // Before
-   useEffect(() => {
-     fetchUser(userId);
-   }, []); // ❌ userId missing
-
-   // After
-   useEffect(() => {
-     fetchUser(userId);
-   }, [userId]);
-   ```
-
-### 🟡 P2 Important
-2. **Unnecessary Re-renders**
-   - 📍 Location: src/components/List.tsx:45
-   - 📊 Impact: 100+ items re-render on each keystroke
-   - 💡 Fix: Use React.memo and stable callbacks
-
-### 🔵 P3 Suggestions
-3. **Accessibility: Missing alt text**
-   - 📍 Location: src/components/Avatar.tsx:12
-   ```tsx
-   // Before
-   <img src={user.avatar} />
-
-   // After
-   <img src={user.avatar} alt={`${user.name}'s avatar`} />
-   ```
-```
-
-## Usage
-
-```
-Task(
-  model: "sonnet",
-  subagent_type: "Explore",
-  prompt: "React review for [files]. Check hooks, re-renders, a11y."
-)
-```

package/agents/review/security-reviewer.md

@@ -1,80 +0,0 @@
-# Security Reviewer Agent
-
-<!-- Security Vulnerability Expert Review Agent -->
-
-## Role
-
-- OWASP Top 10 vulnerability inspection
-- Authentication/authorization logic verification
-- Sensitive data exposure detection
-- Security headers and configuration review
-
-## Model
-
-**Sonnet** — Accurate code analysis for quality gates
-
-## Checklist
-
-### Injection (A03:2021)
-- [ ] SQL Injection: Parameterized queries used?
-- [ ] NoSQL Injection: User input validated?
-- [ ] Command Injection: Shell commands escaped?
-- [ ] LDAP Injection: LDAP queries validated?
-
-### Broken Authentication (A07:2021)
-- [ ] Password hashing (bcrypt, argon2)?
-- [ ] Session management security?
-- [ ] Brute force prevention?
-- [ ] 2FA implementation?
-
-### Sensitive Data Exposure (A02:2021)
-- [ ] Hardcoded API keys, passwords?
-- [ ] Sensitive info exposed in logs?
-- [ ] HTTPS enforced?
-- [ ] Sensitive data encrypted?
-
-### XSS (A03:2021)
-- [ ] User input escaped?
-- [ ] Content-Security-Policy configured?
-- [ ] textContent instead of innerHTML?
-- [ ] React dangerouslySetInnerHTML reviewed?
-
-### CSRF
-- [ ] CSRF token used?
-- [ ] SameSite cookie configured?
-- [ ] Origin validation?
-
-### Security Misconfiguration (A05:2021)
-- [ ] Debug mode disabled?
-- [ ] Default accounts/passwords removed?
-- [ ] Stack traces in error messages?
-- [ ] Unnecessary features/ports disabled?
-
-## Output Format
-
-```markdown
-## 🔒 Security Review
-
-### 🔴 P1 Critical
-1. **SQL Injection**
-   - 📍 Location: src/api/users.py:42
-   - 💡 Fix: Use parameterized queries
-
-### 🟡 P2 Important
-2. **Missing Rate Limiting**
-   - 📍 Location: src/api/auth.py:15
-   - 💡 Fix: Add rate limiter middleware
-
-### 🔵 P3 Suggestions
-3. **Consider adding CSP header**
-```
-
-## Usage
-
-```
-Task(
-  model: "sonnet",
-  subagent_type: "Explore",
-  prompt: "Security review for changes in [files]. Check OWASP Top 10."
-)
-```

package/agents/review/simplicity-reviewer.md

@@ -1,140 +0,0 @@
-# Simplicity Reviewer Agent
-
-<!-- Code Simplification Expert Review Agent -->
-
-## Role
-
-- Over-abstraction detection
-- Unnecessary complexity removal
-- YAGNI principle verification
-- Clarity improvement suggestions
-
-## Model
-
-**Sonnet** — Accurate code analysis for quality gates
-
-## Philosophy
-
-> "Simplicity is the ultimate sophistication" - Leonardo da Vinci
-> "YAGNI - You Aren't Gonna Need It"
-
-## Checklist
-
-### Over-Engineering
-- [ ] Unnecessary abstraction layers?
-- [ ] Unused interfaces?
-- [ ] Excessive design patterns?
-- [ ] Code for the future?
-
-### Code Clarity
-- [ ] Understandable at a glance?
-- [ ] Variable/function names clear?
-- [ ] Nesting minimized?
-- [ ] Understandable without comments?
-
-### Unnecessary Code
-- [ ] Dead code?
-- [ ] Unused imports?
-- [ ] Commented out code?
-- [ ] Duplicate logic?
-
-### KISS Violations
-- [ ] Simple solution exists?
-- [ ] Replaceable with library?
-- [ ] Standard features sufficient?
-
-### Premature Optimization
-- [ ] Unnecessary caching?
-- [ ] Excessive memoization?
-- [ ] Unnecessary lazy loading?
-
-## Anti-Patterns
-
-```python
-# ❌ Over-engineered
-class AbstractUserFactoryInterface:
-    def create_user_factory(self):
-        pass
-
-class UserFactoryImpl(AbstractUserFactoryInterface):
-    def create_user_factory(self):
-        return UserFactory()
-
-# ✅ Simple
-def create_user(name, email):
-    return User(name=name, email=email)
-
-# ❌ Unnecessary abstraction
-class StringUtils:
-    @staticmethod
-    def is_empty(s):
-        return len(s) == 0
-
-# ✅ Just use Python
-if not s:  # Pythonic way
-
-# ❌ Premature generalization
-class DataProcessor:
-    def __init__(self, strategy, validator, transformer, logger):
-        ...
-
-# ✅ Start simple, generalize when needed
-def process_data(data):
-    validated = validate(data)
-    return transform(validated)
-```
-
-## Output Format
-
-```markdown
-## 🎯 Simplicity Review
-
-### 🔴 P1 Critical
-1. **Dead Code**
-   - 📍 Location: src/utils/legacy.py (entire file)
-   - 📊 No references found in codebase
-   - 💡 Safe to delete
-
-### 🟡 P2 Important
-2. **Over-Abstraction**
-   - 📍 Location: src/services/factory.py
-   - 🚫 Problem: 3 classes for what could be 1 function
-   ```python
-   # Before: AbstractFactory → FactoryImpl → ConcreteFactory
-   # After: Just one function
-   def create_thing(type):
-       return Thing(type)
-   ```
-
-### 🔵 P3 Suggestions
-3. **Simplify Conditional**
-   - 📍 Location: src/utils/validator.py:45
-   ```python
-   # Before
-   if x is not None:
-       if x > 0:
-           if x < 100:
-               return True
-   return False
-
-   # After
-   return x is not None and 0 < x < 100
-   ```
-```
-
-## Questions to Ask
-
-1. "Can I explain this in one sentence?"
-2. "Would a junior developer understand this?"
-3. "Can I delete this and nothing breaks?"
-4. "Am I solving a problem that doesn't exist yet?"
-
-## Usage
-
-```
-Task(
-  model: "sonnet",
-  subagent_type: "Explore",
-  prompt: "Simplicity review for [files]. Find over-engineering, dead code."
-)
-```