@studious-lms/server 1.4.5 → 1.4.7

package/tests/routers/assignment.test.ts

@@ -1,5 +1,5 @@
 import { test, expect, describe, beforeEach } from 'vitest';
-import { user1Caller, user2Caller } from '../setup';
+import { user1Caller, user2Caller, user3Caller } from '../setup';
 import { expectForbidden, expectUnauth } from '../helpers';
 
 describe('Assignment Router', () => {
@@ -145,6 +145,73 @@ describe('Assignment Router', () => {
     });
   });
 
+  describe('comments', () => {
+    test('allows class members to add and read assignment-level comments', async () => {
+      const { comment } = await user2Caller.assignment.addComment({
+        classId: testClass.id,
+        assignmentId: testAssignment.id,
+        content: 'I have a question about this assignment.',
+      });
+
+      expect(comment.assignmentId).toBe(testAssignment.id);
+      expect(comment.submissionId).toBeNull();
+
+      const { comments } = await user1Caller.assignment.getComments({
+        classId: testClass.id,
+        assignmentId: testAssignment.id,
+      });
+
+      expect(comments.some((item) => item.id === comment.id)).toBe(true);
+    });
+
+    test('allows only the submission student and teachers to read private submission comments', async () => {
+      const submission = await user2Caller.assignment.getSubmission({
+        classId: testClass.id,
+        assignmentId: testAssignment.id,
+      });
+
+      const { comment } = await user1Caller.assignment.addSubmissionComment({
+        classId: testClass.id,
+        assignmentId: testAssignment.id,
+        submissionId: submission.id,
+        content: 'Private note for this submission.',
+      });
+
+      expect(comment.submissionId).toBe(submission.id);
+
+      const studentView = await user2Caller.assignment.getSubmissionComments({
+        classId: testClass.id,
+        assignmentId: testAssignment.id,
+        submissionId: submission.id,
+      });
+      expect(studentView.comments.some((item) => item.id === comment.id)).toBe(true);
+
+      const teacherView = await user1Caller.assignment.getSubmissionComments({
+        classId: testClass.id,
+        assignmentId: testAssignment.id,
+        submissionId: submission.id,
+      });
+      expect(teacherView.comments.some((item) => item.id === comment.id)).toBe(true);
+
+      const classmateProfile = await user3Caller.user.getProfile();
+      await user1Caller.class.addStudent({
+        classId: testClass.id,
+        studentId: classmateProfile.id,
+      });
+
+      await expect(
+        user3Caller.assignment.getSubmissionComments({
+          classId: testClass.id,
+          assignmentId: testAssignment.id,
+          submissionId: submission.id,
+        }),
+      ).rejects.toMatchObject({
+        code: 'NOT_FOUND',
+        message: 'Submission not found',
+      });
+    });
+  });
+
   // describe('getAll', () => {
   //   test('should get all assignments for class', async () => {
   //     const result = await user1Caller.assignment.get({
@@ -834,4 +901,3 @@ describe('Assignment Router', () => {
     });
   });
 });
-

package/tests/routers/comment.test.ts

@@ -1,5 +1,5 @@
 import { test, expect, describe, beforeAll } from 'vitest';
-import { user1Caller, user2Caller } from '../setup';
+import { user1Caller, user2Caller, user3Caller } from '../setup';
 
 describe('Comment Router', () => {
   let testClass: any;
@@ -42,6 +42,47 @@ describe('Comment Router', () => {
         user1Caller.comment.get({ id: 'nonexistent-id' }),
       ).rejects.toThrow();
     });
+
+    test('should fail for users outside the comment class', async () => {
+      await expect(
+        user2Caller.comment.get({ id: commentId }),
+      ).rejects.toMatchObject({ code: 'FORBIDDEN' });
+    });
+
+    test('should fail for the author after class removal', async () => {
+      const removalClass = await user1Caller.class.create({
+        name: 'Removed Comment Author Class',
+        subject: 'History',
+        section: '11th Grade',
+      });
+      const user3Profile = await user3Caller.user.getProfile();
+      await user1Caller.class.addStudent({
+        classId: removalClass.id,
+        studentId: user3Profile.id,
+      });
+
+      const { announcement: removalAnnouncement } = await user1Caller.announcement.create({
+        classId: removalClass.id,
+        remarks: 'Announcement with removable author comment',
+      });
+      const { comment } = await user3Caller.announcement.addComment({
+        announcementId: removalAnnouncement.id,
+        classId: removalClass.id,
+        content: 'I should lose access when removed.',
+      });
+
+      await user1Caller.class.removeMember({
+        classId: removalClass.id,
+        userId: user3Profile.id,
+      });
+
+      await expect(
+        user3Caller.comment.get({ id: comment.id }),
+      ).rejects.toThrow();
+      await expect(
+        user3Caller.comment.update({ id: comment.id, content: 'Updated after removal' }),
+      ).rejects.toThrow();
+    });
   });
 
   describe('replyToComment', () => {

package/vercel.json

@@ -0,0 +1,8 @@
+{
+    "fluid": true,
+    "functions": {
+      "src/index.ts": {
+        "maxDuration": 500
+      }
+    }
+  }