@studious-lms/server 1.17.0 → 1.18.0

package/src/services/tag.ts

@@ -9,6 +9,7 @@ import {
   createTag,
   deleteTag,
   detachTagFromTarget,
+  findTagByName,
   getTag,
   listTagsAttachedTo,
   listTagsForSchool,
@@ -20,6 +21,23 @@ import {
   findSchoolMembership,
 } from "../models/school.js";
 
+/**
+ * Normalises a tag name to a canonical display form: trimmed with internal
+ * whitespace collapsed to single spaces. Casing is preserved so labels like
+ * "AP" or "Year 12" read naturally; uniqueness is enforced case-insensitively
+ * separately via {@link findTagByName}.
+ */
+function normalizeTagName(name: string): string {
+  const normalized = name.trim().replace(/\s+/g, " ");
+  if (!normalized) {
+    throw new TRPCError({
+      code: "BAD_REQUEST",
+      message: "Tag name can't be empty",
+    });
+  }
+  return normalized;
+}
+
 async function requireAdmin(schoolId: string, userId: string) {
   const membership = await findActiveSchoolAdminMembership(schoolId, userId);
   if (!membership) {
@@ -73,7 +91,15 @@ export async function createTagRecord(
       });
     }
   }
-  return createTag(input);
+  const name = normalizeTagName(input.name);
+  const existing = await findTagByName(input.schoolId, name);
+  if (existing) {
+    throw new TRPCError({
+      code: "CONFLICT",
+      message: `A tag named "${existing.name}" already exists in this institution`,
+    });
+  }
+  return createTag({ ...input, name });
 }
 
 export async function updateTagRecord(
@@ -102,8 +128,19 @@ export async function updateTagRecord(
       });
     }
   }
+  let name = input.name;
+  if (name !== undefined) {
+    name = normalizeTagName(name);
+    const existing = await findTagByName(tag.schoolId, name, input.tagId);
+    if (existing) {
+      throw new TRPCError({
+        code: "CONFLICT",
+        message: `A tag named "${existing.name}" already exists in this institution`,
+      });
+    }
+  }
   return updateTag(input.tagId, {
-    name: input.name,
+    name,
     color: input.color,
     departmentId: input.departmentId,
   });