@stubber/virtual-worker 1.6.0 → 1.6.1

package/.env_dev

@@ -1,4 +1,4 @@
-FILESERVER_URL=https://uploads.secure-link.services.dev.stubber.com/api/v1
+FILESERVER_URL=https://uploads.secure-link.services.staging.stubber.com/api/v1
 API_KEY=123-456-789
 WORKER_NAME=worker-01
 VNC_ORIGIN=ws://localhost:3000

package/app/commands/browser/browser_execute.js

@@ -4,8 +4,8 @@ import { create_error_technical } from "#app/functions/create_error_technical.js
 import { create_success } from "#app/functions/create_success.js";
 import { get_chromium_page } from "../../helpers/get_chromium_page.js";
 import * as playwright from "playwright";
+import { upload_files } from "../file-server/upload_files.js";
 
-const DEFAULT_TIMEOUT_MS = 30000;
 const MAX_SERIALIZATION_DEPTH = 6;
 const MAX_SERIALIZATION_KEYS = 100;
 const async_function_constructor = async function () {}.constructor;
@@ -29,7 +29,6 @@ const async_function_constructor = async function () {}.constructor;
  * @param {Object} params
  * @param {string} params.code - The Playwright code to execute
  * @param {Object} [params.args] - Optional arguments to pass to the code
- * @param {number} [params.timeout_ms] - Optional timeout for code execution in milliseconds (default: 30000)
  *
  *
  */
@@ -46,17 +45,12 @@ export const browser_execute = async (params, stubber_context) => {
   const page = page_result.payload;
   const context = page.context();
   const browser = context.browser();
-  const timeout_ms = normalize_timeout(params.timeout_ms);
 
-  if (timeout_ms === null) {
-    return create_error_conceptual({
-      message: "timeout_ms must be a non-negative number",
-      details: { timeout_ms: params.timeout_ms },
-    });
-  }
+  const logs = [];
+  const attachments = [];
 
   try {
-    const logs = [];
+    const uploadFile = create_upload_file(stubber_context, attachments);
     const execution_console = create_execution_console(logs);
     const execution = run_user_code(params.code, {
       page,
@@ -66,6 +60,7 @@ export const browser_execute = async (params, stubber_context) => {
       params,
       args: params.args || {},
       console: execution_console,
+      uploadFile,
       setTimeout,
       clearTimeout,
       setInterval,
@@ -78,7 +73,7 @@ export const browser_execute = async (params, stubber_context) => {
       AbortSignal,
     });
 
-    const raw_result = await with_timeout(Promise.resolve(execution), timeout_ms);
+    const raw_result = await Promise.resolve(execution);
     const result = serialize_for_payload(raw_result);
 
     return create_success({
@@ -86,13 +81,44 @@ export const browser_execute = async (params, stubber_context) => {
       payload: {
         result,
         logs,
+        attachments,
       },
     });
   } catch (error) {
-    return create_error_technical(error);
+    const technical_error = create_error_technical(error);
+    technical_error.error.details.logs = logs;
+    technical_error.error.details.attachments = attachments;
+    return technical_error;
   }
 };
 
+const create_upload_file = (stubber_context, attachments) => {
+  return async (screenshot_path) => {
+    if (!screenshot_path) {
+      return create_error_conceptual({ message: "No screenshot path provided for upload" });
+    }
+
+    const upload_result = await upload_files({ files: [screenshot_path] }, stubber_context);
+    if (!upload_result.success) {
+      return upload_result;
+    }
+
+    const uploaded_files = upload_result.payload.uploaded_files;
+    const file_info = uploaded_files.length > 0 ? uploaded_files[0] : null;
+
+    if (file_info && attachments) {
+      attachments.push(file_info);
+    }
+
+    return create_success({
+      message: "Screenshot uploaded successfully",
+      payload: {
+        file_info,
+      },
+    });
+  };
+};
+
 /**
  * @param {string} code
  * @param {object} execution_scope
@@ -105,48 +131,6 @@ const run_user_code = (code, execution_scope) => {
   return execute(...parameter_values);
 };
 
-/**
- * @param {unknown} timeout_ms
- * @returns {number|null}
- */
-const normalize_timeout = (timeout_ms) => {
-  if (!timeout_ms) {
-    return DEFAULT_TIMEOUT_MS;
-  }
-
-  const normalized = Number(timeout_ms);
-
-  if (Number.isNaN(normalized) || normalized < 0) {
-    return null;
-  }
-
-  return normalized;
-};
-
-/**
- * @param {Promise<unknown>} promise
- * @param {number} timeout_ms
- */
-const with_timeout = async (promise, timeout_ms) => {
-  if (timeout_ms === 0) {
-    return await promise;
-  }
-
-  let timeout_id;
-
-  const timeout_promise = new Promise((_, reject) => {
-    timeout_id = setTimeout(() => {
-      reject(new Error(`Playwright code execution timed out after ${timeout_ms}ms`));
-    }, timeout_ms);
-  });
-
-  try {
-    return await Promise.race([promise, timeout_promise]);
-  } finally {
-    clearTimeout(timeout_id);
-  }
-};
-
 /**
  * @param {Array<{ level: string, args: unknown[] }>} logs
  */
@@ -168,9 +152,6 @@ const create_execution_console = (logs) => {
 const log_execution = (level, args, logs) => {
   const serialized_args = args.map((arg) => serialize_for_payload(arg));
   logs.push({ level, args: serialized_args });
-
-  const logger = console[level] || console.log;
-  logger("[browser_execute]", ...serialized_args);
 };
 
 /**

package/app/commands/file-server/upload_files.js

@@ -72,11 +72,14 @@ export const upload_files = async (params, _stubber) => {
     });
 
     if (!response.ok) {
-      let error_payload = null;
+      let error_payload;
+
+      const raw = await response.text();
+
       try {
-        error_payload = await response.json();
-      } catch (_) {
-        error_payload = { raw_error: await response.text() };
+        error_payload = JSON.parse(raw);
+      } catch {
+        error_payload = { raw_error: raw };
       }
 
       return create_error_conceptual({

package/app/helpers/get_chromium_page.js

@@ -41,6 +41,7 @@ export const get_chromium_page = async (params, stubber_context) => {
       headless: headless === true || headless === "true",
       // eslint-disable-next-line id-match
       slowMo: slow_mo,
+      // executablePath: "/usr/bin/google-chrome",
     });
     browser.on("disconnected", () => {
       console.log("Chromium browser disconnected. Cleaning up browser instance.");

package/devel/browser_execute.http

@@ -25,7 +25,7 @@ stubber-virtual-worker-apikey: {{apiKey}}
             "args": {
               "selector": "h1"
             },
-            "code": "const title = await page.title();\nconst headings = await page.locator(args.selector).allInnerTexts();\nconsole.log({ title, headings });\nreturn { title, headings, url: page.url() };"
+            "code": "const title = await page.title();const headings = await page.locator(args.selector).allInnerTexts();const screenshotPath = `./screenshot-${Date.now()}.png`;await page.screenshot({ path: screenshotPath, fullPage: true });const upload = await uploadScreenshot(screenshotPath);console.log({ title, headings, upload });return {title,headings,url: page.url(),screenshotPath};"
           }
         }
       }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@stubber/virtual-worker",
-  "version": "1.6.0",
+  "version": "1.6.1",
   "description": "Template to easily create a node app and keep development standards",
   "main": "app.js",
   "directories": {