@structured-id/ui-core 4.14.0 → 4.14.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@structured-id/ui-core",
-  "version": "4.14.0",
+  "version": "4.14.1",
   "type": "module",
   "publishConfig": {
     "access": "public",

package/src/profile/components/ProfileEditor.vue

@@ -86,7 +86,7 @@
 
 <script setup lang="ts">
 import { reactive, computed, watch } from "vue";
-import type { Profile } from "@structured-id/proto/sid/v1/identity/identity";
+import type { Profile } from "../composables/useIdentityApi";
 
 const props = withDefaults(
   defineProps<{

package/src/profile/components/SecuritySettings.vue

@@ -52,7 +52,7 @@
     </div>
 
     <q-list v-else-if="credentials.length > 0" separator>
-      <q-item v-for="cred in credentials" :key="cred.id">
+      <q-item v-for="cred in credentials" :key="cred.id.toString()">
         <q-item-section avatar>
           <q-icon :name="credIcon(cred.type)" :color="credColor(cred.type)" />
         </q-item-section>
@@ -96,11 +96,9 @@
 </template>
 
 <script setup lang="ts">
-import {
-  type Credential,
-  CredentialType,
-} from "@structured-id/proto/sid/v1/identity/identity";
+import { CredentialType } from "@structured-id/proto/sid/v1/identity/identity";
 import { Timestamp } from "@structured-id/proto/google/protobuf/timestamp";
+import type { Credential } from "../composables/useIdentityApi";
 import type { FactorCategory } from "../composables/useSecurityLevel";
 
 defineProps<{

package/src/profile/composables/useSecurityLevel.test.ts

@@ -1,5 +1,10 @@
 import { describe, it, expect } from "vitest";
-import { ref } from "vue";
+import { ref, shallowRef } from "vue";
+import { CredentialId, PrincipalId } from "@structured-id/ids";
+import type {
+  Credential as IdentityCredential,
+  Principal as IdentityPrincipal,
+} from "./useIdentityApi";
 import {
   useSecurityLevel,
   SecurityLevel,
@@ -42,7 +47,6 @@ function makeCred(
 
 function makePrincipal(type: PrincipalType, verified: boolean): Principal {
   return {
-    id: "p-1",
     type,
     value: "test",
     verified,
@@ -54,6 +58,30 @@ function makePrincipal(type: PrincipalType, verified: boolean): Principal {
 // ── Security Level ──
 
 describe("useSecurityLevel", () => {
+  // Regression: the assessment took the wire types, so the typed lists the
+  // identity composable answers (held in shallow refs) did not fit it.
+  it("assesses the identity composable's typed lists", () => {
+    const creds = shallowRef<IdentityCredential[]>([
+      {
+        ...makeCred(CredentialType.OPAQUE),
+        id: CredentialId.parse("0192f3a4-7c1e-7b2a-9d4e-3f5a6b7c8d50"),
+      },
+    ]);
+    const principals = shallowRef<IdentityPrincipal[]>([
+      {
+        ...makePrincipal(PrincipalType.EMAIL, true),
+        id: PrincipalId.parse("0192f3a4-7c1e-7b2a-9d4e-3f5a6b7c8d51"),
+        sourceEmailId: undefined,
+      },
+    ]);
+    const { factorCount, recoveryMethods } = useSecurityLevel(
+      creds,
+      principals,
+    );
+    expect(factorCount.value).toBe(1);
+    expect(recoveryMethods.value).toContain("recovery_email");
+  });
+
   it("MINIMAL with no credentials", () => {
     const { securityLevel } = useSecurityLevel(ref([]), ref([]));
     expect(securityLevel.value).toBe(SecurityLevel.MINIMAL);

package/src/profile/composables/useSecurityLevel.ts

@@ -13,6 +13,15 @@ import {
   PrincipalType,
 } from "@structured-id/proto/sid/v1/identity/identity";
 
+/** What the assessment reads of a credential: its kind and authenticator. */
+export type CredentialFacts = Pick<Credential, "type" | "info">;
+
+/** What the assessment reads of a login handle: its kind and proof. */
+export type PrincipalFacts = Pick<
+  Principal,
+  "type" | "verified" | "needsAddressConfirmation"
+>;
+
 // ── Security Level ──
 
 export enum SecurityLevel {
@@ -66,7 +75,7 @@ const RECOVERABILITY_COLORS: Record<RecoverabilityLevel, string> = {
 
 export type FactorCategory = "knowledge" | "possession" | "inherence";
 
-function getCategory(cred: Credential): FactorCategory | null {
+function getCategory(cred: CredentialFacts): FactorCategory | null {
   switch (cred.type) {
     case CredentialType.OPAQUE:
     case CredentialType.LEGACY_HASH:
@@ -89,7 +98,7 @@ function getCategory(cred: Credential): FactorCategory | null {
   }
 }
 
-function isHardwareKey(cred: Credential): boolean {
+function isHardwareKey(cred: CredentialFacts): boolean {
   return (
     cred.type === CredentialType.WEBAUTHN &&
     cred.info.oneofKind === "webauthnInfo" &&
@@ -113,8 +122,8 @@ export interface ActionNudge {
 // ── Composable ──
 
 export function useSecurityLevel(
-  credentials: Ref<Credential[]>,
-  identifiers: Ref<Principal[]>,
+  credentials: Readonly<Ref<readonly CredentialFacts[]>>,
+  identifiers: Readonly<Ref<readonly PrincipalFacts[]>>,
 ) {
   const authFactors = computed(() =>
     credentials.value.filter((c) => c.type !== CredentialType.RECOVERY),