@structor-dev/cli 0.1.0 → 0.2.1

package/template/scripts/check-template-governance.mjs.tpl

@@ -4,6 +4,7 @@ import { access, readFile } from "node:fs/promises";
 import { constants as fsConstants } from "node:fs";
 import path from "node:path";
 import { fileURLToPath } from "node:url";
+import { requiredGeneratedHarnessFilesForGovernance } from "./generated-harness-contract.mjs";
 
 const repoRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..");
 const models = {
@@ -16,120 +17,7 @@ const clientSupport = {
   claudeHooks: {{CLIENT_CLAUDE_HOOKS_ENABLED}},
   claudeSkills: {{CLIENT_CLAUDE_SKILLS_ENABLED}},
 };
-const openaiRequiredFiles = ["AGENTS.md", "ai/model-overlays/openai/AGENTS.md", "workspace/AGENTS.md"];
-const claudeRequiredFiles = [
-  "CLAUDE.md",
-  ".claude/CLAUDE.md",
-  ".claude/settings.json",
-  "ai/model-overlays/anthropic/CLAUDE.md",
-  "workspace/CLAUDE.md",
-  "workspace/.claude/CLAUDE.md",
-  "workspace/.claude/settings.json",
-  "scripts/check-claude-compatibility.mjs",
-];
-const codexRequiredFiles = [
-  ".codex/hooks.json",
-  "ai/contracts/codex-hooks.contract.json",
-  "scripts/check-codex-hooks.mjs",
-  "scripts/hooks/codex-hook.mjs",
-  "scripts/hooks/lib/codex-hooks-core.mjs",
-];
-const claudeRulesRequiredFiles = [".claude/rules/harness-client-surfaces.md", "workspace/.claude/rules/harness-client-surfaces.md"];
-const driftFile = "scripts/check-overlay-drift.mjs";
-const requiredFiles = [
-  "README.md",
-  "ai/AGENTS.md",
-  "ai/HUB.md",
-  "ai/context.md",
-  "ai/HARNESS.md",
-  "ai/HARNESS-ENGINEERING.md",
-  "ai/READINESS.md",
-  "ai/QUALITY.md",
-  "ai/DECISIONS.md",
-  "ai/PRODUCT-SUMMARY.md",
-  "ai/PRODUCT.md",
-  "ai/ARCHITECTURE.md",
-  "ai/DESIGN.md",
-  "ai/WORKFLOW.md",
-  "ai/VERSIONING.md",
-  "ai/CODEX-HOOKS.md",
-  "ai/RUNNER-SAFETY.md",
-  "ai/RUNNER-READINESS.md",
-  "ai/AGENT-GARBAGE-COLLECTION.md",
-  "ai/knowledge-manifest.json",
-  "ai/workspace/REPOS.md",
-  "ai/workspace/SYSTEM-MAP.md",
-  "ai/workspace/SESSION-BOOTSTRAP.md",
-  "ai/workspace/LOCAL-STACK.md",
-  "ai/workspace/TEST-STRATEGY.md",
-  "ai/contracts/README.md",
-  "ai/contracts/repo-boundaries.md",
-  "ai/contracts/repo-boundaries.contract.json",
-  "ai/contracts/app-legibility.md",
-  "ai/contracts/app-legibility.contract.json",
-  "ai/contracts/api-boundary.md",
-  "ai/contracts/api-boundary.contract.json",
-  "ai/contracts/security-boundary.md",
-  "ai/contracts/security-boundary.contract.json",
-  "ai/contracts/codex-hooks.md",
-  "ai/contracts/release-flow.md",
-  "ai/contracts/release-flow.contract.json",
-  "ai/contracts/github-safety.md",
-  "ai/contracts/github-safety.contract.json",
-  "ai/templates/README.md",
-  "ai/templates/task-brief-template.md",
-  "ai/templates/issue-template.md",
-  "ai/templates/fixtures/issues/valid-ready.md",
-  "ai/templates/fixtures/issues/invalid-placeholder.md",
-  "ai/templates/fixtures/issues/invalid-protected-surface.md",
-  "ai/skills/README.md",
-  "ai/skills/review-architecture.md",
-  "ai/skills/review-security.md",
-  "ai/skills/review-contract-drift.md",
-  "ai/skills/review-governance-drift.md",
-  "ai/plans/README.md",
-  "ai/plans/tech-debt.md",
-  "ai/specs/README.md",
-  "scripts/bootstrap-workspace.mjs",
-  "scripts/check-workspace.mjs",
-  "scripts/validate-governance.mjs",
-  "scripts/check-template-governance.mjs",
-  "scripts/check-readiness.mjs",
-  "scripts/check-task-template.mjs",
-  "scripts/check-issue-template.mjs",
-  "scripts/check-knowledge-manifest.mjs",
-  "scripts/check-plans.mjs",
-  "scripts/check-review-skills.mjs",
-  "scripts/check-garbage-collection.mjs",
-  "scripts/check-contract-manifests.mjs",
-  "scripts/generate-html-views.mjs",
-  "scripts/check-html-views.mjs",
-  "scripts/bootstrap-codex-worktree.mjs",
-  "scripts/check-worktrees.mjs",
-  "scripts/check-worktree-bootstrap-fixtures.mjs",
-  "scripts/lib/worktree-bootstrap.mjs",
-  "scripts/fixtures/worktrees/README.md",
-];
-
-if (models.openai) {
-  requiredFiles.push(...openaiRequiredFiles);
-}
-
-if (models.anthropic) {
-  requiredFiles.push(...claudeRequiredFiles);
-}
-
-if (clientSupport.codexHooks) {
-  requiredFiles.push(...codexRequiredFiles);
-}
-
-if (clientSupport.claudeRules) {
-  requiredFiles.push(...claudeRulesRequiredFiles);
-}
-
-if (models.openai || models.anthropic) {
-  requiredFiles.push(driftFile);
-}
+const requiredFiles = requiredGeneratedHarnessFilesForGovernance({ models, clientSupport });
 
 async function exists(relativePath) {
   try {

package/template/scripts/check-workspace.mjs.tpl

@@ -5,6 +5,12 @@ import { constants as fsConstants } from "node:fs";
 import path from "node:path";
 import { fileURLToPath } from "node:url";
 import { assertReferencesHarnessRoot } from "./lib/worktree-bootstrap.mjs";
+import {
+  consumerEntrypointsForSettings,
+  requiredHarnessRepoFilesForWorkspaceCheck,
+  requiredWorkspaceFilesForWorkspaceCheck,
+  workspaceEntrypointsForSettings,
+} from "./generated-harness-contract.mjs";
 
 const repoRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..");
 const workspaceRoot = path.resolve(repoRoot, "..");
@@ -18,93 +24,15 @@ const clientSupport = {
   codexHooks: {{CLIENT_CODEX_HOOKS_ENABLED}},
   claudeRules: {{CLIENT_CLAUDE_RULES_ENABLED}},
 };
+const settings = { models, clientSupport };
 const harnessRepoNameError = "repo folder name: expected";
 const missingEntryPrefix = "missing ";
-const repoBaseFiles = [
-  "README.md",
-  "ai/AGENTS.md",
-  "ai/HUB.md",
-  "ai/context.md",
-  "ai/HARNESS.md",
-  "ai/HARNESS-ENGINEERING.md",
-  "ai/READINESS.md",
-  "ai/QUALITY.md",
-  "ai/DECISIONS.md",
-  "ai/PRODUCT-SUMMARY.md",
-  "ai/PRODUCT.md",
-  "ai/ARCHITECTURE.md",
-  "ai/DESIGN.md",
-  "ai/WORKFLOW.md",
-  "ai/VERSIONING.md",
-  "ai/CODEX-HOOKS.md",
-  "ai/RUNNER-SAFETY.md",
-  "ai/RUNNER-READINESS.md",
-  "ai/AGENT-GARBAGE-COLLECTION.md",
-  "ai/knowledge-manifest.json",
-  "ai/workspace/REPOS.md",
-  "ai/workspace/SYSTEM-MAP.md",
-  "ai/workspace/SESSION-BOOTSTRAP.md",
-  "ai/workspace/LOCAL-STACK.md",
-  "ai/workspace/TEST-STRATEGY.md",
-  "ai/contracts/README.md",
-  "ai/templates/README.md",
-  "ai/skills/README.md",
-  "ai/specs/README.md",
-  "scripts/bootstrap-workspace.mjs",
-  "scripts/check-workspace.mjs",
-  "scripts/validate-governance.mjs",
-  "scripts/check-readiness.mjs",
-  "scripts/check-task-template.mjs",
-  "scripts/check-issue-template.mjs",
-  "scripts/check-knowledge-manifest.mjs",
-  "scripts/check-plans.mjs",
-  "scripts/check-review-skills.mjs",
-  "scripts/check-garbage-collection.mjs",
-  "scripts/check-contract-manifests.mjs",
-  "scripts/generate-html-views.mjs",
-  "scripts/check-html-views.mjs",
-  "scripts/bootstrap-codex-worktree.mjs",
-  "scripts/check-worktrees.mjs",
-  "scripts/check-worktree-bootstrap-fixtures.mjs",
-];
-const openaiRepoFiles = ["AGENTS.md", "ai/model-overlays/openai/AGENTS.md", "scripts/check-overlay-drift.mjs"];
-const anthopicRepoFiles = [
-  "CLAUDE.md",
-  ".claude/CLAUDE.md",
-  ".claude/settings.json",
-  "ai/model-overlays/anthropic/CLAUDE.md",
-  "scripts/check-claude-compatibility.mjs",
-  "scripts/check-overlay-drift.mjs",
-];
-const codexRepoFiles = [".codex/hooks.json", "scripts/check-codex-hooks.mjs", "scripts/hooks/codex-hook.mjs"];
-const claudeRulesRepoFiles = [".claude/rules/harness-client-surfaces.md"];
-const workspaceOpenaiFiles = ["AGENTS.md"];
-const workspaceAnthropicFiles = ["CLAUDE.md", ".claude/CLAUDE.md", ".claude/settings.json"];
-const workspaceClaudeRulesFiles = [".claude/rules/harness-client-surfaces.md"];
-const CLAUDE_MD = "CLAUDE.md";
-
-const repoRequiredFiles = [...repoBaseFiles];
-
-if (models.openai) {
-  repoRequiredFiles.push(...openaiRepoFiles);
-}
-
-if (models.anthropic) {
-  repoRequiredFiles.push(...anthopicRepoFiles);
-}
-
-if (clientSupport.codexHooks) {
-  repoRequiredFiles.push(...codexRepoFiles);
-}
-
-if (clientSupport.claudeRules) {
-  repoRequiredFiles.push(...claudeRulesRepoFiles);
-}
-
-const workspaceRequiredFiles = [];
-if (models.openai) workspaceRequiredFiles.push(...workspaceOpenaiFiles);
-if (models.anthropic) workspaceRequiredFiles.push(...workspaceAnthropicFiles);
-if (clientSupport.claudeRules) workspaceRequiredFiles.push(...workspaceClaudeRulesFiles);
+const repoRequiredFiles = requiredHarnessRepoFilesForWorkspaceCheck(settings);
+const workspaceRequiredFiles = requiredWorkspaceFilesForWorkspaceCheck(settings);
+const workspaceRoutingEntrypoints = workspaceEntrypointsForSettings(settings).filter(
+  (entrypoint) => entrypoint.routing !== "presence",
+);
+const consumerRoutingEntrypoints = consumerEntrypointsForSettings(settings);
 
 async function exists(filePath) {
   try {
@@ -160,6 +88,13 @@ async function collectClaudeMemoryRoutingIssue({ basePath, relativePath }) {
   });
 }
 
+async function collectEntrypointRoutingIssue({ basePath, entrypoint, expectedHarnessRoot }) {
+  if (entrypoint.routing === "claude-memory") {
+    return collectClaudeMemoryRoutingIssue({ basePath, relativePath: entrypoint.path });
+  }
+  return collectHarnessRoutingIssue({ basePath, relativePath: entrypoint.path, expectedHarnessRoot });
+}
+
 async function main() {
   const missing = [];
   if (path.basename(repoRoot) !== harnessRepoName) {
@@ -169,31 +104,20 @@ async function main() {
   missing.push(...(await collectMissing(repoRoot, repoRequiredFiles, "repo")));
   missing.push(...(await collectMissing(workspaceRoot, workspaceRequiredFiles, "workspace")));
 
+  for (const entrypoint of workspaceRoutingEntrypoints) {
+    const issue = await collectEntrypointRoutingIssue({ basePath: workspaceRoot, entrypoint, expectedHarnessRoot: repoRoot });
+    if (issue) missing.push(`workspace:${issue}`);
+  }
+
   for (const consumer of consumers) {
     const consumerRoot = path.resolve(workspaceRoot, consumer.workspacePath);
     if (!(await exists(consumerRoot))) {
       missing.push(`consumer:${consumer.name}:missing repo at ${consumerRoot}`);
       continue;
     }
-    if (models.openai) {
-      const issue = await collectHarnessRoutingIssue({ basePath: workspaceRoot, relativePath: "AGENTS.md", expectedHarnessRoot: repoRoot });
-      if (issue) missing.push(`workspace:${issue}`);
-    }
-    if (models.anthropic) {
-      const issue = await collectHarnessRoutingIssue({ basePath: workspaceRoot, relativePath: CLAUDE_MD, expectedHarnessRoot: repoRoot });
-      if (issue) missing.push(`workspace:${issue}`);
-      const memoryIssue = await collectClaudeMemoryRoutingIssue({ basePath: workspaceRoot, relativePath: ".claude/CLAUDE.md" });
-      if (memoryIssue) missing.push(`workspace:${memoryIssue}`);
-    }
-    if (models.openai) {
-      const issue = await collectHarnessRoutingIssue({ basePath: consumerRoot, relativePath: "AGENTS.md", expectedHarnessRoot: repoRoot });
-      if (issue) missing.push(`consumer:${consumer.name}:${issue}`);
-    }
-    if (models.anthropic) {
-      const issue = await collectHarnessRoutingIssue({ basePath: consumerRoot, relativePath: CLAUDE_MD, expectedHarnessRoot: repoRoot });
+    for (const entrypoint of consumerRoutingEntrypoints) {
+      const issue = await collectEntrypointRoutingIssue({ basePath: consumerRoot, entrypoint, expectedHarnessRoot: repoRoot });
       if (issue) missing.push(`consumer:${consumer.name}:${issue}`);
-      const memoryIssue = await collectClaudeMemoryRoutingIssue({ basePath: consumerRoot, relativePath: ".claude/CLAUDE.md" });
-      if (memoryIssue) missing.push(`consumer:${consumer.name}:${memoryIssue}`);
     }
   }
 

package/template/scripts/check-worktree-bootstrap-fixtures.mjs.tpl

@@ -8,8 +8,10 @@ import {
   classifyWorktreeBootstrap,
   models,
   parseWorktreeListPorcelain,
+  repairCommand,
   requiredPointerFiles,
   renderPointerFile,
+  shellQuote,
 } from "./lib/worktree-bootstrap.mjs";
 
 const repoRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..");
@@ -32,6 +34,8 @@ const tempConsumerRoot = "/tmp/{{PRIMARY_CONSUMER_NAME}}";
 const testCaseTemplateConsumer = "{{PRIMARY_CONSUMER_NAME}}";
 const invalidHarnessRoot = "Read ../{{HARNESS_REPO_NAME}}/AGENTS.md before editing.";
 const wrongHarnessRootPointer = `Read /other/{{HARNESS_REPO_NAME}}/AGENTS.md before editing.`;
+const unsafeHarnessRoot = "/workspace/{{HARNESS_REPO_NAME}} with spaces/'quotes';$(touch /tmp/unsafe)";
+const unsafeCheckoutPath = "/workspace/{{PRIMARY_CONSUMER_NAME}} with spaces/'quotes';$(touch /tmp/checkout)";
 const harnessFiles = new Set([
   ...(models.openai ? ["AGENTS.md"] : []),
   ...(models.anthropic ? ["CLAUDE.md"] : []),
@@ -115,8 +119,16 @@ assert.equal(mixedResult.state, stateMissing, "mixed_references");
 
 const pointerPattern = new RegExp(`{{HARNESS_REPO_NAME}}/${models.openai ? "AGENTS" : "CLAUDE"}\\.md`);
 const worktreePorcelainOutput = "worktree /repo/main\nHEAD abc\nbranch refs/heads/main\n\nworktree /repo/detached\nHEAD def\ndetached\n";
+const quotedPointer = renderPointerFile({
+  relativePath: requiredPointerFiles[0],
+  harnessRoot: unsafeHarnessRoot,
+  repoName: testCaseTemplateConsumer,
+});
+const quotedBootstrapScript = path.join(path.resolve(unsafeHarnessRoot), "scripts/bootstrap-codex-worktree.mjs");
 
 assert.match(renderPointerFile({ relativePath: requiredPointerFiles[0], harnessRoot, repoName: testCaseTemplateConsumer }), pointerPattern);
+assert.match(quotedPointer, new RegExp(`node ${shellQuote(quotedBootstrapScript).replace(/[.*+?^${}()|[\]\\]/g, "\\$&")} ${shellQuote("<checkout-path>").replace(/[.*+?^${}()|[\]\\]/g, "\\$&")}`));
+assert.equal(repairCommand({ harnessRoot: unsafeHarnessRoot, targetPath: unsafeCheckoutPath }), `node ${shellQuote(path.join(unsafeHarnessRoot, "scripts/bootstrap-codex-worktree.mjs"))} ${shellQuote(unsafeCheckoutPath)}`);
 assert.equal(parseWorktreeListPorcelain(worktreePorcelainOutput).length, 2);
 
 console.log("Worktree bootstrap fixture check passed.");