@stripe/stripe-react-native 0.63.0 → 0.64.1

package/README.md

@@ -75,8 +75,8 @@ to your `app.json` file, where `merchantIdentifier` is the Apple merchant ID obt
 
 #### Android
 
-- Android 5.0 (API level 21) and above
-  - Your `compileSdkVersion` must be `34`. See [this issue](https://github.com/stripe/stripe-react-native/issues/812) for potential workarounds.
+- Android 6.0 (API level 23) and above
+  - Your `compileSdkVersion` must be `36` or higher.
 - Android gradle plugin 4.x and above
 - Kotlin 2.x and above. See [this issue](https://github.com/stripe/stripe-react-native/issues/1924#issuecomment-2867227374) for how to update the Kotlin version when using react-native 0.77 and below or Expo SDK 52.
 

package/android/build.gradle

@@ -15,7 +15,7 @@ buildscript {
     classpath "com.android.tools.build:gradle:7.2.2"
     // noinspection DifferentKotlinGradleVersion
     classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion"
-    classpath "com.diffplug.spotless:spotless-plugin-gradle:6.25.0"
+    classpath "dev.detekt:detekt-gradle-plugin:2.0.0-alpha.2"
     // only use this old compose-compiler plugin when Kotlin >= 2.0
     if (kotlinMajor >= 2) {
       classpath "org.jetbrains.kotlin:compose-compiler-gradle-plugin:$kotlinVersion"
@@ -24,7 +24,7 @@ buildscript {
 }
 
 if (project == rootProject) {
-  apply from: "spotless.gradle"
+  apply from: "detekt/detekt.gradle"
   return
 }
 

package/android/detekt/detekt-baseline.xml

@@ -0,0 +1,81 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<SmellBaseline>
+  <ManuallySuppressedIssues/>
+  <CurrentIssues>
+    <ID>CyclomaticComplexMethod:CardFieldView.kt:CardFieldView$fun setCardStyle</ID>
+    <ID>CyclomaticComplexMethod:CardFormView.kt:CardFormView$@SuppressLint("RestrictedApi", "VisibleForTests") fun setCardStyle</ID>
+    <ID>CyclomaticComplexMethod:EmbeddedPaymentElementView.kt:EmbeddedPaymentElementView$@SuppressLint("RestrictedApi") @Composable override fun Content</ID>
+    <ID>CyclomaticComplexMethod:Mappers.kt:@SuppressLint("RestrictedApi") internal fun mapNextAction: WritableMap?</ID>
+    <ID>CyclomaticComplexMethod:Mappers.kt:fun mapToUICustomization: PaymentAuthConfig.Stripe3ds2UiCustomization</ID>
+    <ID>CyclomaticComplexMethod:Mappers.kt:internal fun mapPaymentMethodType: String</ID>
+    <ID>CyclomaticComplexMethod:Mappers.kt:internal fun mapToPaymentMethodType: PaymentMethod.Type?</ID>
+    <ID>CyclomaticComplexMethod:PaymentMethodCreateParamsFactory.kt:PaymentMethodCreateParamsFactory$@Throws(PaymentMethodCreateParamsException::class) fun createPaymentMethodParams: PaymentMethodCreateParams</ID>
+    <ID>CyclomaticComplexMethod:PaymentSheetAppearance.kt:@SuppressLint("RestrictedApi") @Throws(PaymentSheetAppearanceException::class) private fun buildEmbeddedAppearance: PaymentSheet.Appearance.Embedded</ID>
+    <ID>EmptyFunctionBlock:CardFieldView.kt:CardFieldView.&lt;no name provided>${ }</ID>
+    <ID>EmptyFunctionBlock:CardFieldView.kt:CardFieldView.&lt;no name provided>${}</ID>
+    <ID>EmptyFunctionBlock:CustomerSheetManager.kt:CustomerSheetManager.&lt;no name provided>${ }</ID>
+    <ID>EmptyFunctionBlock:CustomerSheetManager.kt:CustomerSheetManager.&lt;no name provided>${}</ID>
+    <ID>EmptyFunctionBlock:DrawableLoadingTest.kt:DrawableLoadingTest.MockAsyncDrawable${}</ID>
+    <ID>EmptyFunctionBlock:PaymentSheetManager.kt:&lt;no name provided>${}</ID>
+    <ID>EmptyFunctionBlock:PaymentSheetManager.kt:PaymentSheetManager.&lt;no name provided>${ }</ID>
+    <ID>EmptyFunctionBlock:PaymentSheetManager.kt:PaymentSheetManager.&lt;no name provided>${}</ID>
+    <ID>EmptyFunctionBlock:StripeAbstractComposeView.kt:StripeAbstractComposeView.CompatView${ }</ID>
+    <ID>EmptyFunctionBlock:StripeSdkModule.kt:StripeSdkModule.&lt;no name provided>${}</ID>
+    <ID>ForbiddenComment:Mappers.kt:// TODO: Can't access, private</ID>
+    <ID>ForbiddenComment:PaymentSheetAppearance.kt:// TODO: The theme is so crazy long, why does each Color thing has the same redundant Theme...</ID>
+    <ID>ForbiddenComment:PaymentSheetAppearance.kt:// TODO: Why is background a string but successBackgroundColor a "dynamic" color?</ID>
+    <ID>ForbiddenComment:StripeSdkModule.kt:StripeSdkModule$// TODO:</ID>
+    <ID>ForbiddenComment:StripeSdkModule.kt:StripeSdkModule$// TODO: Uncomment when WeChat is re-enabled in stripe-ios</ID>
+    <ID>LargeClass:PaymentElementConfigTest.kt:PaymentElementConfigTest</ID>
+    <ID>LargeClass:PaymentSheetAppearanceTest.kt:PaymentSheetAppearanceTest</ID>
+    <ID>LargeClass:StripeSdkModule.kt:StripeSdkModule : NativeStripeSdkModuleSpec</ID>
+    <ID>LongMethod:CardFieldView.kt:CardFieldView$fun setCardStyle</ID>
+    <ID>LongMethod:CardFieldView.kt:CardFieldView$private fun setListeners</ID>
+    <ID>LongMethod:CardFormView.kt:CardFormView$@SuppressLint("RestrictedApi", "VisibleForTests") fun setCardStyle</ID>
+    <ID>LongMethod:CardFormView.kt:CardFormView$private fun setListeners</ID>
+    <ID>LongMethod:CustomerSheetManager.kt:CustomerSheetManager$override fun onCreate</ID>
+    <ID>LongMethod:EmbeddedPaymentElementView.kt:EmbeddedPaymentElementView$@SuppressLint("RestrictedApi") @Composable override fun Content</ID>
+    <ID>LongMethod:EmbeddedPaymentElementViewManager.kt:EmbeddedPaymentElementViewManager$@SuppressLint("RestrictedApi") @OptIn( ExperimentalAllowsRemovalOfLastSavedPaymentMethodApi::class, CardFundingFilteringPrivatePreview::class, ) private fun parseElementConfiguration: EmbeddedPaymentElement.Configuration</ID>
+    <ID>LongMethod:Mappers.kt:@SuppressLint("RestrictedApi") internal fun mapNextAction: WritableMap?</ID>
+    <ID>LongMethod:Mappers.kt:fun mapToUICustomization: PaymentAuthConfig.Stripe3ds2UiCustomization</ID>
+    <ID>LongMethod:Mappers.kt:internal fun mapFromPaymentMethod: WritableMap</ID>
+    <ID>LongMethod:PaymentOptionDisplayDataMapper.kt:fun AnnotatedString.toHtmlString: String</ID>
+    <ID>LongMethod:PaymentSheetAppearance.kt:@SuppressLint("RestrictedApi") @Throws(PaymentSheetAppearanceException::class) private fun buildEmbeddedAppearance: PaymentSheet.Appearance.Embedded</ID>
+    <ID>LongMethod:PaymentSheetAppearanceTest.kt:PaymentSheetAppearanceTest$@Test fun testFullAppearanceConfiguration</ID>
+    <ID>LongMethod:PaymentSheetAppearanceTest.kt:PaymentSheetAppearanceTest$@Test fun testFullEmbeddedAppearance_FlatWithRadio</ID>
+    <ID>LongMethod:PaymentSheetAppearanceTest.kt:PaymentSheetAppearanceTest$@Test fun testPartialAppearanceConfiguration</ID>
+    <ID>LongMethod:PaymentSheetManager.kt:PaymentSheetManager$fun configure</ID>
+    <ID>LongMethod:StripeSdkModule.kt:StripeSdkModule$@ReactMethod override fun confirmPlatformPay</ID>
+    <ID>RethrowCaughtException:PaymentMethodCreateParamsFactory.kt:PaymentMethodCreateParamsFactory$throw error</ID>
+    <ID>SwallowedException:StripeSdkModule.kt:StripeSdkModule$e: Exception</ID>
+    <ID>ThrowsCount:PaymentSheetAppearance.kt:@Throws(PaymentSheetAppearanceException::class) internal fun getFontResId: Int?</ID>
+    <ID>TooGenericExceptionCaught:CardFieldView.kt:CardFieldView$e: Exception</ID>
+    <ID>TooGenericExceptionCaught:CustomerSheetManager.kt:CustomerSheetManager$e: Exception</ID>
+    <ID>TooGenericExceptionCaught:EmbeddedPaymentElementView.kt:EmbeddedPaymentElementView$e: Exception</ID>
+    <ID>TooGenericExceptionCaught:EmbeddedPaymentElementViewManager.kt:EmbeddedPaymentElementViewManager$e: Exception</ID>
+    <ID>TooGenericExceptionCaught:PaymentSheetManager.kt:PaymentSheetManager$e: Exception</ID>
+    <ID>TooGenericExceptionCaught:PaymentSheetManager.kt:e: Exception</ID>
+    <ID>TooGenericExceptionCaught:PushProvisioningProxy.kt:PushProvisioningProxy$e: Exception</ID>
+    <ID>TooGenericExceptionCaught:StripeConnectDeepLinkInterceptorActivity.kt:StripeConnectDeepLinkInterceptorActivity$e: Exception</ID>
+    <ID>TooGenericExceptionCaught:StripeSdkModule.kt:StripeSdkModule$e: Exception</ID>
+    <ID>TooGenericExceptionCaught:TapAndPayProxy.kt:TapAndPayProxy$e: Exception</ID>
+    <ID>TooGenericExceptionThrown:EmbeddedPaymentElementViewManager.kt:EmbeddedPaymentElementViewManager$throw Error()</ID>
+    <ID>TooGenericExceptionThrown:PaymentLauncherManager.kt:PaymentLauncherManager$throw Exception( "Invalid parameters provided to PaymentLauncher. Ensure that you are providing the correct client " + "secret and setup params (if necessary).", )</ID>
+    <ID>TooGenericExceptionThrown:PaymentLauncherManager.kt:PaymentLauncherManager$throw Exception("Failed to create Payment Launcher. No client secret provided.")</ID>
+    <ID>TooGenericExceptionThrown:PaymentMethodCreateParamsFactory.kt:PaymentMethodCreateParamsFactory$throw Exception("This paymentMethodType is not supported yet")</ID>
+    <ID>TooManyFunctions:AddToWalletButtonManager.kt:AddToWalletButtonManager : SimpleViewManagerAddToWalletButtonManagerInterface</ID>
+    <ID>TooManyFunctions:AddressSheetViewManager.kt:AddressSheetViewManager : SimpleViewManagerAddressSheetViewManagerInterface</ID>
+    <ID>TooManyFunctions:CardFieldView.kt:CardFieldView : FrameLayout</ID>
+    <ID>TooManyFunctions:CardFieldViewManager.kt:CardFieldViewManager : SimpleViewManagerCardFieldManagerInterface</ID>
+    <ID>TooManyFunctions:CardFormViewManager.kt:CardFormViewManager : SimpleViewManagerCardFormManagerInterface</ID>
+    <ID>TooManyFunctions:EventEmitterCompat.kt:EventEmitterCompat</ID>
+    <ID>TooManyFunctions:Extensions.kt:com.reactnativestripesdk.utils.Extensions.kt</ID>
+    <ID>TooManyFunctions:Mappers.kt:com.reactnativestripesdk.utils.Mappers.kt</ID>
+    <ID>TooManyFunctions:PaymentElementConfig.kt:com.reactnativestripesdk.PaymentElementConfig.kt</ID>
+    <ID>TooManyFunctions:StripeSdkModule.kt:StripeSdkModule : NativeStripeSdkModuleSpec</ID>
+    <ID>UtilityClassWithPublicConstructor:GooglePayRequestHelper.kt:GooglePayRequestHelper</ID>
+    <ID>UtilityClassWithPublicConstructor:PaymentSheetAppearance.kt:PaymentSheetAppearanceKeys</ID>
+    <ID>UtilityClassWithPublicConstructor:PostalCodeUtilities.kt:PostalCodeUtilities</ID>
+    <ID>UtilityClassWithPublicConstructor:ShadowArguments.kt:ShadowArguments</ID>
+  </CurrentIssues>
+</SmellBaseline>

package/android/detekt/detekt.gradle

@@ -0,0 +1,45 @@
+apply plugin: 'dev.detekt'
+
+repositories {
+    google()
+    mavenCentral()
+}
+
+def isDetektFormat = gradle.startParameter.taskNames.any { it.contains('detektFormat') }
+
+detekt {
+    buildUponDefaultConfig = true
+    config.setFrom(file("detekt/detekt.yml"))
+    baseline = file("detekt/detekt-baseline.xml") // https://detekt.dev/docs/introduction/baseline/
+    ignoredBuildTypes = ["debug"]
+    ignoredFlavors = []
+    ignoredVariants = []
+    parallel = true
+    autoCorrect = isDetektFormat
+}
+
+tasks.register('detektFormat') {
+    group = 'formatting'
+    description = 'Run detekt with auto-correction enabled.'
+    dependsOn 'detekt'
+}
+
+def detektIgnoreFile = file('detekt/.detektignore')
+if (detektIgnoreFile.exists()) {
+    def detektIgnorePatterns = []
+    detektIgnoreFile.eachLine { line ->
+        line = line.trim()
+        if (!line.isEmpty() && !line.startsWith('#')) {
+            detektIgnorePatterns.add(line)
+        }
+    }
+    afterEvaluate {
+        tasks.matching { it.name.startsWith('detekt') && it instanceof org.gradle.api.tasks.SourceTask }.configureEach {
+            detektIgnorePatterns.each { pattern -> exclude(pattern) }
+        }
+    }
+}
+
+dependencies {
+    detektPlugins "dev.detekt:detekt-rules-ktlint-wrapper:2.0.0-alpha.2"
+}