@stripchatdev/create-stripchat-extension 0.1.45 → 0.1.47

package/dist/src/validators/validateSlots.test.js

@@ -1,15 +1,24 @@
 import { describe, expect, it } from 'vitest';
+import { SLOT_RULES_BY_CATEGORY } from '../constants.js';
 import { validateSlots } from './validateSlots.js';
 describe('validateSlots', () => {
     it('accepts right overlay for games-and-fun', () => {
-        const result = validateSlots(['EXTENSION_SLOT_RIGHT_OVERLAY'], 'games-and-fun');
-        expect(result.selected).toEqual(['EXTENSION_SLOT_RIGHT_OVERLAY']);
+        const slots = [
+            ...SLOT_RULES_BY_CATEGORY['games-and-fun'].requiredBase,
+            'EXTENSION_SLOT_RIGHT_OVERLAY',
+        ];
+        const result = validateSlots(slots, 'games-and-fun');
+        expect(result.selected).toEqual(slots);
         expect(result.invalid).toEqual([]);
         expect(result.violations).toEqual([]);
     });
     it('accepts video decorative overlay for games-and-fun', () => {
-        const result = validateSlots(['EXTENSION_SLOT_VIDEO_DECORATIVE_OVERLAY'], 'games-and-fun');
-        expect(result.selected).toEqual(['EXTENSION_SLOT_VIDEO_DECORATIVE_OVERLAY']);
+        const slots = [
+            ...SLOT_RULES_BY_CATEGORY['games-and-fun'].requiredBase,
+            'EXTENSION_SLOT_VIDEO_DECORATIVE_OVERLAY',
+        ];
+        const result = validateSlots(slots, 'games-and-fun');
+        expect(result.selected).toEqual(slots);
         expect(result.invalid).toEqual([]);
         expect(result.violations).toEqual([]);
     });
@@ -18,48 +27,93 @@ describe('validateSlots', () => {
         expect(result.selected).toEqual([]);
         expect(result.invalid).toEqual([]);
         expect(result.violations).toEqual([
+            'Missing required slots: EXTENSION_SLOT_MAIN_GAME_FUN, EXTENSION_SLOT_BACKGROUND.',
+            'Choose exactly one of: EXTENSION_SLOT_RIGHT_OVERLAY, EXTENSION_SLOT_VIDEO_DECORATIVE_OVERLAY.',
+        ]);
+    });
+    it('report about missing required base slots for game-and-fun', () => {
+        const result = validateSlots(['EXTENSION_SLOT_VIDEO_DECORATIVE_OVERLAY'], 'games-and-fun');
+        expect(result.selected).toEqual(['EXTENSION_SLOT_VIDEO_DECORATIVE_OVERLAY']);
+        expect(result.invalid).toEqual([]);
+        expect(result.violations).toEqual([
+            'Missing required slots: EXTENSION_SLOT_MAIN_GAME_FUN, EXTENSION_SLOT_BACKGROUND.',
+        ]);
+    });
+    it('report about missing required base and selectable slots for game-and-fun', () => {
+        const result = validateSlots([], 'games-and-fun');
+        expect(result.selected).toEqual([]);
+        expect(result.invalid).toEqual([]);
+        expect(result.violations).toEqual([
+            'Missing required slots: EXTENSION_SLOT_MAIN_GAME_FUN, EXTENSION_SLOT_BACKGROUND.',
             'Choose exactly one of: EXTENSION_SLOT_RIGHT_OVERLAY, EXTENSION_SLOT_VIDEO_DECORATIVE_OVERLAY.',
         ]);
     });
     it('rejects both shared activity overlays for games-and-fun', () => {
-        const result = validateSlots(['EXTENSION_SLOT_RIGHT_OVERLAY', 'EXTENSION_SLOT_VIDEO_DECORATIVE_OVERLAY'], 'games-and-fun');
-        expect(result.selected).toEqual([
+        const slots = [
+            ...SLOT_RULES_BY_CATEGORY['games-and-fun'].requiredBase,
             'EXTENSION_SLOT_RIGHT_OVERLAY',
             'EXTENSION_SLOT_VIDEO_DECORATIVE_OVERLAY',
-        ]);
+        ];
+        const result = validateSlots(slots, 'games-and-fun');
+        expect(result.selected).toEqual(slots);
         expect(result.invalid).toEqual([]);
         expect(result.violations).toEqual([
             'Choose exactly one of: EXTENSION_SLOT_RIGHT_OVERLAY, EXTENSION_SLOT_VIDEO_DECORATIVE_OVERLAY.',
         ]);
     });
     it('allows sex-toys with no optional slots', () => {
-        const result = validateSlots([], 'sex-toys');
-        expect(result.selected).toEqual([]);
+        const slots = [
+            ...SLOT_RULES_BY_CATEGORY['sex-toys'].requiredBase,
+        ];
+        const result = validateSlots(slots, 'sex-toys');
+        expect(result.selected).toEqual(slots);
         expect(result.invalid).toEqual([]);
         expect(result.violations).toEqual([]);
     });
     it('allows moveable overlay for sex-toys', () => {
-        const result = validateSlots(['EXTENSION_SLOT_MOVEABLE_OVERLAY'], 'sex-toys');
-        expect(result.selected).toEqual(['EXTENSION_SLOT_MOVEABLE_OVERLAY']);
+        const result = validateSlots([...SLOT_RULES_BY_CATEGORY['sex-toys'].requiredBase, 'EXTENSION_SLOT_MOVEABLE_OVERLAY'], 'sex-toys');
+        expect(result.selected).toEqual([
+            ...SLOT_RULES_BY_CATEGORY['sex-toys'].requiredBase,
+            'EXTENSION_SLOT_MOVEABLE_OVERLAY',
+        ]);
         expect(result.invalid).toEqual([]);
         expect(result.violations).toEqual([]);
     });
     it('allows one shared activity overlay for sex-toys', () => {
-        const result = validateSlots(['EXTENSION_SLOT_VIDEO_DECORATIVE_OVERLAY'], 'sex-toys');
-        expect(result.selected).toEqual(['EXTENSION_SLOT_VIDEO_DECORATIVE_OVERLAY']);
+        const slots = [
+            ...SLOT_RULES_BY_CATEGORY['sex-toys'].requiredBase,
+            'EXTENSION_SLOT_VIDEO_DECORATIVE_OVERLAY',
+        ];
+        const result = validateSlots(slots, 'sex-toys');
+        expect(result.selected).toEqual(slots);
         expect(result.invalid).toEqual([]);
         expect(result.violations).toEqual([]);
     });
     it('allows one shared activity overlay plus moveable overlay for sex-toys', () => {
-        const result = validateSlots(['EXTENSION_SLOT_MOVEABLE_OVERLAY', 'EXTENSION_SLOT_RIGHT_OVERLAY'], 'sex-toys');
-        expect(result.selected).toEqual([
+        const slots = [
+            ...SLOT_RULES_BY_CATEGORY['sex-toys'].requiredBase,
             'EXTENSION_SLOT_MOVEABLE_OVERLAY',
             'EXTENSION_SLOT_RIGHT_OVERLAY',
-        ]);
+        ];
+        const result = validateSlots(slots, 'sex-toys');
+        expect(result.selected).toEqual(slots);
         expect(result.invalid).toEqual([]);
         expect(result.violations).toEqual([]);
     });
     it('rejects both shared activity overlays for sex-toys', () => {
+        const slots = [
+            ...SLOT_RULES_BY_CATEGORY['sex-toys'].requiredBase,
+            'EXTENSION_SLOT_RIGHT_OVERLAY',
+            'EXTENSION_SLOT_VIDEO_DECORATIVE_OVERLAY',
+        ];
+        const result = validateSlots(slots, 'sex-toys');
+        expect(result.selected).toEqual(slots);
+        expect(result.invalid).toEqual([]);
+        expect(result.violations).toEqual([
+            'Choose at most one of: EXTENSION_SLOT_RIGHT_OVERLAY, EXTENSION_SLOT_VIDEO_DECORATIVE_OVERLAY.',
+        ]);
+    });
+    it('reports missing required base slots together with overlay-group violation for sex-toys', () => {
         const result = validateSlots(['EXTENSION_SLOT_RIGHT_OVERLAY', 'EXTENSION_SLOT_VIDEO_DECORATIVE_OVERLAY'], 'sex-toys');
         expect(result.selected).toEqual([
             'EXTENSION_SLOT_RIGHT_OVERLAY',
@@ -67,63 +121,100 @@ describe('validateSlots', () => {
         ]);
         expect(result.invalid).toEqual([]);
         expect(result.violations).toEqual([
+            'Missing required slots: EXTENSION_SLOT_MAIN_SEX_TOY, EXTENSION_SLOT_BACKGROUND.',
             'Choose at most one of: EXTENSION_SLOT_RIGHT_OVERLAY, EXTENSION_SLOT_VIDEO_DECORATIVE_OVERLAY.',
         ]);
     });
     it('reports invalid slot names separately from rule violations', () => {
-        const result = validateSlots(['EXTENSION_SLOT_RIGHT_OVERLAY', 'unknown-slot'], 'games-and-fun');
-        expect(result.selected).toEqual(['EXTENSION_SLOT_RIGHT_OVERLAY']);
+        const result = validateSlots([
+            ...SLOT_RULES_BY_CATEGORY['games-and-fun'].requiredBase,
+            'EXTENSION_SLOT_RIGHT_OVERLAY',
+            'unknown-slot',
+        ], 'games-and-fun');
+        expect(result.selected).toEqual([
+            ...SLOT_RULES_BY_CATEGORY['games-and-fun'].requiredBase,
+            'EXTENSION_SLOT_RIGHT_OVERLAY',
+        ]);
         expect(result.invalid).toEqual(['unknown-slot']);
         expect(result.violations).toEqual([]);
     });
     it('rejects all optional slots for chat-bots', () => {
-        const result = validateSlots(['EXTENSION_SLOT_RIGHT_OVERLAY'], 'chat-bots');
-        expect(result.selected).toEqual([]);
+        const result = validateSlots([...SLOT_RULES_BY_CATEGORY['chat-bots'].requiredBase, 'EXTENSION_SLOT_RIGHT_OVERLAY'], 'chat-bots');
+        expect(result.selected).toEqual(SLOT_RULES_BY_CATEGORY['chat-bots'].requiredBase);
         expect(result.invalid).toEqual(['EXTENSION_SLOT_RIGHT_OVERLAY']);
         expect(result.violations).toEqual([]);
     });
-    it('returns empty result for empty input on category with no selectable slots', () => {
+    it('reports missing required slots for empty input on category with no selectable slots', () => {
         const result = validateSlots([], 'chat-bots');
         expect(result.selected).toEqual([]);
         expect(result.invalid).toEqual([]);
-        expect(result.violations).toEqual([]);
+        expect(result.violations).toEqual([
+            'Missing required slots: EXTENSION_SLOT_BACKGROUND.',
+        ]);
     });
     it('allows broadcast-tools with no optional slots', () => {
-        const result = validateSlots([], 'broadcast-tools');
-        expect(result.selected).toEqual([]);
+        const slots = [
+            ...SLOT_RULES_BY_CATEGORY['broadcast-tools'].requiredBase,
+        ];
+        const result = validateSlots(slots, 'broadcast-tools');
+        expect(result.selected).toEqual(slots);
         expect(result.invalid).toEqual([]);
         expect(result.violations).toEqual([]);
     });
     it('allows moveable overlay for broadcast-tools', () => {
-        const result = validateSlots(['EXTENSION_SLOT_MOVEABLE_OVERLAY'], 'broadcast-tools');
-        expect(result.selected).toEqual(['EXTENSION_SLOT_MOVEABLE_OVERLAY']);
+        const slots = [
+            ...SLOT_RULES_BY_CATEGORY['broadcast-tools'].requiredBase,
+            'EXTENSION_SLOT_MOVEABLE_OVERLAY',
+        ];
+        const result = validateSlots(slots, 'broadcast-tools');
+        expect(result.selected).toEqual(slots);
         expect(result.invalid).toEqual([]);
         expect(result.violations).toEqual([]);
     });
     it('rejects unsupported optional slots for broadcast-tools', () => {
-        const result = validateSlots(['EXTENSION_SLOT_RIGHT_OVERLAY'], 'broadcast-tools');
-        expect(result.selected).toEqual([]);
+        const slots = [
+            'EXTENSION_SLOT_BACKGROUND',
+            'EXTENSION_SLOT_RIGHT_OVERLAY',
+        ];
+        const result = validateSlots(slots, 'broadcast-tools');
+        expect(result.selected).toEqual(['EXTENSION_SLOT_BACKGROUND']);
         expect(result.invalid).toEqual(['EXTENSION_SLOT_RIGHT_OVERLAY']);
         expect(result.violations).toEqual([]);
     });
     it('filters invalid slot names while preserving valid selections', () => {
-        const result = validateSlots(['EXTENSION_SLOT_RIGHT_OVERLAY', 'nonExistent', 'alsoWrong'], 'sex-toys');
-        expect(result.selected).toEqual(['EXTENSION_SLOT_RIGHT_OVERLAY']);
+        const result = validateSlots([
+            ...SLOT_RULES_BY_CATEGORY['sex-toys'].requiredBase,
+            'EXTENSION_SLOT_RIGHT_OVERLAY',
+            'nonExistent',
+            'alsoWrong',
+        ], 'sex-toys');
+        expect(result.selected).toEqual([
+            ...SLOT_RULES_BY_CATEGORY['sex-toys'].requiredBase,
+            'EXTENSION_SLOT_RIGHT_OVERLAY',
+        ]);
         expect(result.invalid).toEqual(['nonExistent', 'alsoWrong']);
         expect(result.violations).toEqual([]);
     });
     it('rejects alias-like slot names that are not slot constants', () => {
-        const result = validateSlots(['moveableOverlay'], 'games-and-fun');
-        expect(result.selected).toEqual([]);
+        const result = validateSlots([...SLOT_RULES_BY_CATEGORY['games-and-fun'].requiredBase, 'moveableOverlay'], 'games-and-fun');
+        expect(result.selected).toEqual(SLOT_RULES_BY_CATEGORY['games-and-fun'].requiredBase);
         expect(result.invalid).toEqual(['moveableOverlay']);
         expect(result.violations).toEqual([
             'Choose exactly one of: EXTENSION_SLOT_RIGHT_OVERLAY, EXTENSION_SLOT_VIDEO_DECORATIVE_OVERLAY.',
         ]);
     });
     it('handles all invalid slots', () => {
-        const result = validateSlots(['unknown1', 'unknown2'], 'sex-toys');
-        expect(result.selected).toEqual([]);
+        const result = validateSlots([...SLOT_RULES_BY_CATEGORY['sex-toys'].requiredBase, 'unknown1', 'unknown2'], 'sex-toys');
+        expect(result.selected).toEqual(SLOT_RULES_BY_CATEGORY['sex-toys'].requiredBase);
         expect(result.invalid).toEqual(['unknown1', 'unknown2']);
         expect(result.violations).toEqual([]);
     });
+    it('report about missing required slots for game-and-fun', () => {
+        const result = validateSlots(['EXTENSION_SLOT_VIDEO_DECORATIVE_OVERLAY'], 'games-and-fun');
+        expect(result.selected).toEqual(['EXTENSION_SLOT_VIDEO_DECORATIVE_OVERLAY']);
+        expect(result.invalid).toEqual([]);
+        expect(result.violations).toEqual([
+            'Missing required slots: EXTENSION_SLOT_MAIN_GAME_FUN, EXTENSION_SLOT_BACKGROUND.',
+        ]);
+    });
 });