@stream-io/video-client 1.8.2 → 1.8.4

package/dist/src/compatibility.d.ts

@@ -0,0 +1,7 @@
+/**
+ * Checks if the current platform is a mobile device.
+ *
+ * See:
+ * https://developer.mozilla.org/en-US/docs/Web/HTTP/Browser_detection_using_the_user_agent
+ */
+export declare const isMobile: () => boolean;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@stream-io/video-client",
-  "version": "1.8.2",
+  "version": "1.8.4",
   "packageManager": "yarn@3.2.4",
   "main": "dist/index.cjs.js",
   "module": "dist/index.es.js",

package/src/compatibility.ts

@@ -0,0 +1,7 @@
+/**
+ * Checks if the current platform is a mobile device.
+ *
+ * See:
+ * https://developer.mozilla.org/en-US/docs/Web/HTTP/Browser_detection_using_the_user_agent
+ */
+export const isMobile = () => /Mobi/i.test(navigator.userAgent);

package/src/devices/CameraManager.ts

@@ -5,6 +5,7 @@ import { InputMediaDeviceManager } from './InputMediaDeviceManager';
 import { getVideoDevices, getVideoStream } from './devices';
 import { TrackType } from '../gen/video/sfu/models/models';
 import { PreferredCodec, PublishOptions } from '../types';
+import { isMobile } from '../compatibility';
 
 export class CameraManager extends InputMediaDeviceManager<CameraManagerState> {
   private targetResolution = {
@@ -34,10 +35,14 @@ export class CameraManager extends InputMediaDeviceManager<CameraManagerState> {
    * @param direction the direction of the camera to select.
    */
   async selectDirection(direction: Exclude<CameraDirection, undefined>) {
-    this.state.setDirection(direction);
-    // Providing both device id and direction doesn't work, so we deselect the device
-    this.state.setDevice(undefined);
-    await this.applySettingsToStream();
+    if (isMobile()) {
+      this.state.setDirection(direction);
+      // Providing both device id and direction doesn't work, so we deselect the device
+      this.state.setDevice(undefined);
+      await this.applySettingsToStream();
+    } else {
+      this.logger('warn', 'Camera direction ignored for desktop devices');
+    }
   }
 
   /**
@@ -131,7 +136,7 @@ export class CameraManager extends InputMediaDeviceManager<CameraManagerState> {
     constraints.height = this.targetResolution.height;
     // We can't set both device id and facing mode
     // Device id has higher priority
-    if (!constraints.deviceId && this.state.direction) {
+    if (!constraints.deviceId && this.state.direction && isMobile()) {
       constraints.facingMode =
         this.state.direction === 'front' ? 'user' : 'environment';
     }

package/src/devices/InputMediaDeviceManager.ts

@@ -279,14 +279,7 @@ export abstract class InputMediaDeviceManager<
 
   private stopTracks() {
     this.getTracks().forEach((track) => {
-      if (track.readyState === 'live') {
-        track.stop();
-        // @ts-expect-error release() is present in react-native-webrtc and must be called to dispose the track
-        if (typeof track.release === 'function') {
-          // @ts-expect-error
-          track.release();
-        }
-      }
+      if (track.readyState === 'live') track.stop();
     });
   }
 

package/src/devices/__tests__/CameraManager.test.ts

@@ -36,6 +36,13 @@ vi.mock('../../Call.ts', () => {
   };
 });
 
+vi.mock('../../compatibility.ts', () => {
+  console.log('MOCKING mobile device');
+  return {
+    isMobile: () => true,
+  };
+});
+
 describe('CameraManager', () => {
   let manager: CameraManager;
 

package/src/devices/devices.ts

@@ -276,12 +276,6 @@ export const disposeOfMediaStream = (stream: MediaStream) => {
   if (!stream.active) return;
   stream.getTracks().forEach((track) => {
     track.stop();
-    stream.removeTrack(track);
-    // @ts-expect-error release() is present in react-native-webrtc and must be called to dispose the track
-    if (typeof track.release === 'function') {
-      // @ts-expect-error
-      track.release();
-    }
   });
   // @ts-expect-error release() is present in react-native-webrtc and must be called to dispose the stream
   if (typeof stream.release === 'function') {

package/src/helpers/RNSpeechDetector.ts

@@ -106,14 +106,7 @@ export class RNSpeechDetector {
     if (!this.audioStream) {
       return;
     }
-    this.audioStream.getTracks().forEach((track) => {
-      track.stop();
-      // @ts-expect-error release() is present in react-native-webrtc and must be called to dispose the track
-      if (typeof track.release === 'function') {
-        // @ts-expect-error
-        track.release();
-      }
-    });
+    this.audioStream.getTracks().forEach((track) => track.stop());
     if (
       // @ts-expect-error release() is present in react-native-webrtc
       typeof this.audioStream.release === 'function'

package/src/rtc/Publisher.ts

@@ -316,11 +316,6 @@ export class Publisher {
       if (previousTrack && previousTrack !== track) {
         previousTrack.stop();
         previousTrack.removeEventListener('ended', handleTrackEnded);
-        // @ts-expect-error release() is present in react-native-webrtc and must be called to dispose the track
-        if (typeof previousTrack.release === 'function') {
-          // @ts-expect-error
-          track.release();
-        }
         track.addEventListener('ended', handleTrackEnded);
       }
       if (!track.enabled) {
@@ -342,18 +337,16 @@ export class Publisher {
     const transceiver = this.pc
       .getTransceivers()
       .find((t) => t === this.transceiverRegistry[trackType] && t.sender.track);
-    const track = transceiver?.sender.track;
-    if (track && (stopTrack ? track.readyState === 'live' : track.enabled)) {
-      if (stopTrack) {
-        track.stop();
-        // @ts-expect-error release() is present in react-native-webrtc and must be called to dispose the track
-        if (typeof track.release === 'function') {
-          // @ts-expect-error
-          track.release();
-        }
-      } else {
-        track.enabled = false;
-      }
+    if (
+      transceiver &&
+      transceiver.sender.track &&
+      (stopTrack
+        ? transceiver.sender.track.readyState === 'live'
+        : transceiver.sender.track.enabled)
+    ) {
+      stopTrack
+        ? transceiver.sender.track.stop()
+        : (transceiver.sender.track.enabled = false);
       // We don't need to notify SFU if unpublishing in response to remote soft mute
       if (this.state.localParticipant?.publishedTracks.includes(trackType)) {
         await this.notifyTrackMuteStateChanged(undefined, trackType, true);
@@ -406,13 +399,7 @@ export class Publisher {
   private stopPublishing = () => {
     this.logger('debug', 'Stopping publishing all tracks');
     this.pc.getSenders().forEach((s) => {
-      const track = s.track;
-      track?.stop();
-      // @ts-expect-error release() is present in react-native-webrtc and must be called to dispose the track
-      if (typeof track?.release === 'function') {
-        // @ts-expect-error
-        track.release();
-      }
+      s.track?.stop();
       if (this.pc.signalingState !== 'closed') {
         this.pc.removeTrack(s);
       }