@stream-io/video-client 1.6.1 → 1.6.3

package/CHANGELOG.md

@@ -2,6 +2,20 @@
 
 This file was generated using [@jscutlery/semver](https://github.com/jscutlery/semver).
 
+## [1.6.3](https://github.com/GetStream/stream-video-js/compare/@stream-io/video-client-1.6.2...@stream-io/video-client-1.6.3) (2024-09-11)
+
+
+### Bug Fixes
+
+* client instance removal used a wrong key ([#1484](https://github.com/GetStream/stream-video-js/issues/1484)) ([edff5d7](https://github.com/GetStream/stream-video-js/commit/edff5d7ca0cc241a3929da3b752073883f29da32))
+
+## [1.6.2](https://github.com/GetStream/stream-video-js/compare/@stream-io/video-client-1.6.1...@stream-io/video-client-1.6.2) (2024-09-09)
+
+
+### Bug Fixes
+
+* prioritize h264 baseline profile ([#1482](https://github.com/GetStream/stream-video-js/issues/1482)) ([3ea3c5e](https://github.com/GetStream/stream-video-js/commit/3ea3c5ecf57b50d3f909d59a96811f636b07d8aa))
+
 ## [1.6.1](https://github.com/GetStream/stream-video-js/compare/@stream-io/video-client-1.6.0...@stream-io/video-client-1.6.1) (2024-09-05)
 
 

package/dist/index.browser.es.js

@@ -6820,50 +6820,74 @@ const retryable = async (rpc, signal) => {
     return result;
 };
 
+/**
+ * Returns back a list of sorted codecs, with the preferred codec first.
+ *
+ * @param kind the kind of codec to get.
+ * @param preferredCodec the codec to prioritize (vp8, h264, vp9, av1...).
+ * @param codecToRemove the codec to exclude from the list.
+ */
 const getPreferredCodecs = (kind, preferredCodec, codecToRemove) => {
-    const logger = getLogger(['codecs']);
-    if (!('getCapabilities' in RTCRtpReceiver)) {
-        logger('warn', 'RTCRtpReceiver.getCapabilities is not supported');
+    if (!('getCapabilities' in RTCRtpReceiver))
         return;
-    }
-    const cap = RTCRtpReceiver.getCapabilities(kind);
-    if (!cap)
+    const capabilities = RTCRtpReceiver.getCapabilities(kind);
+    if (!capabilities)
         return;
-    const matched = [];
-    const partialMatched = [];
-    const unmatched = [];
-    cap.codecs.forEach((c) => {
-        const codec = c.mimeType.toLowerCase();
-        logger('debug', `Found supported codec: ${codec}`);
-        const shouldRemoveCodec = codecToRemove && codec === `${kind}/${codecToRemove.toLowerCase()}`;
+    const preferred = [];
+    const partiallyPreferred = [];
+    const unpreferred = [];
+    const preferredCodecMimeType = `${kind}/${preferredCodec.toLowerCase()}`;
+    const codecToRemoveMimeType = codecToRemove && `${kind}/${codecToRemove.toLowerCase()}`;
+    for (const codec of capabilities.codecs) {
+        const codecMimeType = codec.mimeType.toLowerCase();
+        const shouldRemoveCodec = codecMimeType === codecToRemoveMimeType;
         if (shouldRemoveCodec)
-            return;
-        const matchesCodec = codec === `${kind}/${preferredCodec.toLowerCase()}`;
-        if (!matchesCodec) {
-            unmatched.push(c);
-            return;
+            continue; // skip this codec
+        const isPreferredCodec = codecMimeType === preferredCodecMimeType;
+        if (!isPreferredCodec) {
+            unpreferred.push(codec);
+            continue;
         }
-        // for h264 codecs that have sdpFmtpLine available, use only if the
-        // profile-level-id is 42e01f for cross-browser compatibility
-        if (codec === 'h264') {
-            if (c.sdpFmtpLine && c.sdpFmtpLine.includes('profile-level-id=42e01f')) {
-                matched.push(c);
-            }
-            else {
-                partialMatched.push(c);
-            }
-            return;
+        // h264 is a special case, we want to prioritize the baseline codec with
+        // profile-level-id is 42e01f and packetization-mode=0 for maximum
+        // cross-browser compatibility.
+        // this branch covers the other cases, such as vp8.
+        if (codecMimeType !== 'video/h264') {
+            preferred.push(codec);
+            continue;
         }
-        matched.push(c);
-    });
-    return [...matched, ...partialMatched, ...unmatched];
+        const sdpFmtpLine = codec.sdpFmtpLine;
+        if (!sdpFmtpLine || !sdpFmtpLine.includes('profile-level-id=42e01f')) {
+            // this is not the baseline h264 codec, prioritize it lower
+            partiallyPreferred.push(codec);
+            continue;
+        }
+        // packetization-mode mode is optional; when not present it defaults to 0:
+        // https://datatracker.ietf.org/doc/html/rfc6184#section-6.2
+        if (sdpFmtpLine.includes('packetization-mode=0') ||
+            !sdpFmtpLine.includes('packetization-mode')) {
+            preferred.unshift(codec);
+        }
+        else {
+            preferred.push(codec);
+        }
+    }
+    // return a sorted list of codecs, with the preferred codecs first
+    return [...preferred, ...partiallyPreferred, ...unpreferred];
 };
+/**
+ * Returns a generic SDP for the given direction.
+ * We use this SDP to send it as part of our JoinRequest so that the SFU
+ * can use it to determine client's codec capabilities.
+ *
+ * @param direction the direction of the transceiver.
+ */
 const getGenericSdp = async (direction) => {
     const tempPc = new RTCPeerConnection();
     tempPc.addTransceiver('video', { direction });
     tempPc.addTransceiver('audio', { direction });
     const offer = await tempPc.createOffer();
-    let sdp = offer.sdp ?? '';
+    const sdp = offer.sdp ?? '';
     tempPc.getTransceivers().forEach((t) => {
         t.stop?.();
     });
@@ -8724,7 +8748,7 @@ const enableHighQualityAudio = (sdp, trackMid, maxBitrate = 510000) => {
     return SDP.write(parsedSdp);
 };
 
-const version = "1.6.1" ;
+const version = "1.6.3" ;
 const [major, minor, patch] = version.split('.');
 let sdkInfo = {
     type: SdkType.PLAIN_JAVASCRIPT,
@@ -16068,7 +16092,7 @@ class StreamClient {
             });
         };
         this.getUserAgent = () => {
-            const version = "1.6.1" ;
+            const version = "1.6.3" ;
             return (this.userAgent ||
                 `stream-video-javascript-client-${this.node ? 'node' : 'browser'}-${version}`);
         };
@@ -16314,6 +16338,7 @@ class StreamVideoClient {
                 return;
             }
             const userId = this.streamClient.user?.id;
+            const apiKey = this.streamClient.key;
             const disconnectUser = () => this.streamClient.disconnectUser(timeout);
             this.disconnectionPromise = this.connectionPromise
                 ? this.connectionPromise.then(() => disconnectUser())
@@ -16321,7 +16346,7 @@ class StreamVideoClient {
             this.disconnectionPromise.finally(() => (this.disconnectionPromise = undefined));
             await this.disconnectionPromise;
             if (userId) {
-                StreamVideoClient._instanceMap.delete(userId);
+                StreamVideoClient._instanceMap.delete(apiKey + userId);
             }
             this.eventHandlersToUnregister.forEach((unregister) => unregister());
             this.eventHandlersToUnregister = [];