@stream-io/video-client 1.16.1 → 1.16.2

package/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 This file was generated using [@jscutlery/semver](https://github.com/jscutlery/semver).
 
+## [1.16.2](https://github.com/GetStream/stream-video-js/compare/@stream-io/video-client-1.16.1...@stream-io/video-client-1.16.2) (2025-02-05)
+
+
+### Bug Fixes
+
+* race condition with unrecoverable error handling  ([#1672](https://github.com/GetStream/stream-video-js/issues/1672)) ([be8095c](https://github.com/GetStream/stream-video-js/commit/be8095ce946cf98a0dfc1f3ea3391376cc7d2896)), closes [#1649](https://github.com/GetStream/stream-video-js/issues/1649) [#1618](https://github.com/GetStream/stream-video-js/issues/1618)
+
 ## [1.16.1](https://github.com/GetStream/stream-video-js/compare/@stream-io/video-client-1.16.0...@stream-io/video-client-1.16.1) (2025-02-05)
 
 

package/dist/index.browser.es.js

@@ -5183,11 +5183,14 @@ class BasePeerConnection {
      */
     constructor(peerType, { sfuClient, connectionConfig, state, dispatcher, onUnrecoverableError, logTag, }) {
         this.isIceRestarting = false;
+        this.isDisposed = false;
         this.subscriptions = [];
         /**
          * Disposes the `RTCPeerConnection` instance.
          */
         this.dispose = () => {
+            this.onUnrecoverableError = undefined;
+            this.isDisposed = true;
             this.detachEventHandlers();
             this.pc.close();
         };
@@ -5198,6 +5201,8 @@ class BasePeerConnection {
         this.on = (event, fn) => {
             this.subscriptions.push(this.dispatcher.on(event, (e) => {
                 withoutConcurrency(`pc.${event}`, async () => fn(e)).catch((err) => {
+                    if (this.isDisposed)
+                        return;
                     this.logger('warn', `Error handling ${event}`, err);
                 });
             }));
@@ -5213,6 +5218,8 @@ class BasePeerConnection {
             this.unsubscribeIceTrickle?.();
             this.unsubscribeIceTrickle = createSafeAsyncSubscription(observable, async (candidate) => {
                 return this.pc.addIceCandidate(candidate).catch((e) => {
+                    if (this.isDisposed)
+                        return;
                     this.logger('warn', `ICE candidate error`, e, candidate);
                 });
             });
@@ -5245,7 +5252,11 @@ class BasePeerConnection {
             const iceCandidate = this.toJSON(candidate);
             this.sfuClient
                 .iceTrickle({ peerType: this.peerType, iceCandidate })
-                .catch((err) => this.logger('warn', `ICETrickle failed`, err));
+                .catch((err) => {
+                if (this.isDisposed)
+                    return;
+                this.logger('warn', `ICETrickle failed`, err);
+            });
         };
         /**
          * Converts the ICE candidate to a JSON string.
@@ -5274,6 +5285,8 @@ class BasePeerConnection {
             if (state === 'failed' || state === 'disconnected') {
                 this.logger('debug', `Attempting to restart ICE`);
                 this.restartIce().catch((e) => {
+                    if (this.isDisposed)
+                        return;
                     this.logger('error', `ICE restart failed`, e);
                     this.onUnrecoverableError?.();
                 });
@@ -5325,6 +5338,8 @@ class BasePeerConnection {
         this.pc.removeEventListener('icecandidateerror', this.onIceCandidateError);
         this.pc.removeEventListener('signalingstatechange', this.onSignalingChange);
         this.pc.removeEventListener('iceconnectionstatechange', this.onIceConnectionStateChange);
+        // cancel any ongoing ICE restart process
+        withCancellation('onIceConnectionStateChange', () => Promise.resolve());
         this.pc.removeEventListener('icegatheringstatechange', this.onIceGatherChange);
         this.unsubscribeIceTrickle?.();
         this.subscriptions.forEach((unsubscribe) => unsubscribe());
@@ -5840,10 +5855,12 @@ class Publisher extends BasePeerConnection {
             await this.negotiate({ iceRestart: true });
         };
         this.onNegotiationNeeded = () => {
-            withoutConcurrency('publisher.negotiate', () => this.negotiate()).catch((err) => {
+            withCancellation('publisher.negotiate', (signal) => this.negotiate().catch((err) => {
+                if (signal.aborted)
+                    return;
                 this.logger('error', `Negotiation failed.`, err);
                 this.onUnrecoverableError?.();
-            });
+            }));
         };
         /**
          * Initiates a new offer/answer exchange with the currently connected SFU.
@@ -5970,6 +5987,8 @@ class Publisher extends BasePeerConnection {
     detachEventHandlers() {
         super.detachEventHandlers();
         this.pc.removeEventListener('negotiationneeded', this.onNegotiationNeeded);
+        // abort any ongoing negotiation
+        withCancellation('publisher.negotiate', () => Promise.resolve());
     }
 }
 
@@ -7394,7 +7413,7 @@ const aggregate = (stats) => {
     return report;
 };
 
-const version = "1.16.1";
+const version = "1.16.2";
 const [major, minor, patch] = version.split('.');
 let sdkInfo = {
     type: SdkType.PLAIN_JAVASCRIPT,
@@ -13001,7 +13020,7 @@ class StreamClient {
             return await this.wsConnection.connect(this.defaultWSTimeout);
         };
         this.getUserAgent = () => {
-            const version = "1.16.1";
+            const version = "1.16.2";
             return (this.userAgent ||
                 `stream-video-javascript-client-${this.node ? 'node' : 'browser'}-${version}`);
         };