@strapi/strapi 4.11.0-beta.1 → 4.11.0-exp.2

package/lib/core/domain/content-type/index.js

@@ -2,7 +2,7 @@
 
 const { cloneDeep } = require('lodash/fp');
 const _ = require('lodash');
-const { hasDraftAndPublish, getPrivateAttributes } = require('@strapi/utils').contentTypes;
+const { hasDraftAndPublish } = require('@strapi/utils').contentTypes;
 const {
   CREATED_AT_ATTRIBUTE,
   UPDATED_AT_ATTRIBUTE,
@@ -58,12 +58,6 @@ const createContentType = (uid, definition) => {
     );
   }
 
-  Object.defineProperty(schema, 'privateAttributes', {
-    get() {
-      return getPrivateAttributes(schema);
-    },
-  });
-
   // attributes
   Object.assign(schema.attributes, {
     [CREATED_AT_ATTRIBUTE]: {

package/lib/services/entity-service/index.d.ts

@@ -1,8 +1,6 @@
-import { Database } from '@strapi/database';
+import type { Database, ID } from '@strapi/database';
 import { Strapi } from '../../';
 
-type ID = number | string;
-
 type EntityServiceAction =
   | 'findMany'
   | 'findPage'

package/lib/services/entity-service/index.js

@@ -4,11 +4,7 @@ const _ = require('lodash');
 const delegate = require('delegates');
 const { InvalidTimeError, InvalidDateError, InvalidDateTimeError, InvalidRelationError } =
   require('@strapi/database').errors;
-const {
-  webhook: webhookUtils,
-  contentTypes: contentTypesUtils,
-  sanitize,
-} = require('@strapi/utils');
+const { contentTypes: contentTypesUtils, sanitize } = require('@strapi/utils');
 const { ValidationError } = require('@strapi/utils').errors;
 const { isAnyToMany } = require('@strapi/utils').relations;
 const { transformParamsToQuery } = require('@strapi/utils').convertQueryParams;
@@ -31,9 +27,6 @@ const transformLoadParamsToQuery = (uid, field, params = {}, pagination = {}) =>
   };
 };
 
-// TODO: those should be strapi events used by the webhooks not the other way arround
-const { ENTRY_CREATE, ENTRY_UPDATE, ENTRY_DELETE } = webhookUtils.webhookEvents;
-
 const databaseErrorsToTransform = [
   InvalidTimeError,
   InvalidDateTimeError,
@@ -49,6 +42,12 @@ const updatePipeline = (data, context) => {
   return applyTransforms(data, context);
 };
 
+const ALLOWED_WEBHOOK_EVENTS = {
+  ENTRY_CREATE: 'entry.create',
+  ENTRY_UPDATE: 'entry.update',
+  ENTRY_DELETE: 'entry.delete',
+};
+
 /**
  * @type {import('.').default}
  */
@@ -180,6 +179,7 @@ const createDefaultImplementation = ({ strapi, db, eventHub, entityValidator })
 
     entity = await this.wrapResult(entity, { uid, action: 'create' });
 
+    const { ENTRY_CREATE } = ALLOWED_WEBHOOK_EVENTS;
     await this.emitEvent(uid, ENTRY_CREATE, entity);
 
     return entity;
@@ -233,6 +233,7 @@ const createDefaultImplementation = ({ strapi, db, eventHub, entityValidator })
 
     entity = await this.wrapResult(entity, { uid, action: 'update' });
 
+    const { ENTRY_UPDATE } = ALLOWED_WEBHOOK_EVENTS;
     await this.emitEvent(uid, ENTRY_UPDATE, entity);
 
     return entity;
@@ -260,6 +261,7 @@ const createDefaultImplementation = ({ strapi, db, eventHub, entityValidator })
 
     entityToDelete = await this.wrapResult(entityToDelete, { uid, action: 'delete' });
 
+    const { ENTRY_DELETE } = ALLOWED_WEBHOOK_EVENTS;
     await this.emitEvent(uid, ENTRY_DELETE, entityToDelete);
 
     return entityToDelete;
@@ -290,6 +292,7 @@ const createDefaultImplementation = ({ strapi, db, eventHub, entityValidator })
     entitiesToDelete = await this.wrapResult(entitiesToDelete, { uid, action: 'delete' });
 
     // Trigger webhooks. One for each entity
+    const { ENTRY_DELETE } = ALLOWED_WEBHOOK_EVENTS;
     await Promise.all(entitiesToDelete.map((entity) => this.emitEvent(uid, ENTRY_DELETE, entity)));
 
     return deletedEntities;
@@ -331,6 +334,10 @@ const createDefaultImplementation = ({ strapi, db, eventHub, entityValidator })
 });
 
 module.exports = (ctx) => {
+  Object.entries(ALLOWED_WEBHOOK_EVENTS).forEach(([key, value]) => {
+    ctx.strapi.webhookStore.addAllowedEvent(key, value);
+  });
+
   const implementation = createDefaultImplementation(ctx);
 
   const service = {

package/lib/services/webhook-store.js

@@ -4,6 +4,9 @@
 
 'use strict';
 
+const { mapAsync } = require('@strapi/utils');
+const { ValidationError } = require('@strapi/utils').errors;
+
 const webhookModel = {
   uid: 'webhook',
   collectionName: 'strapi_webhooks',
@@ -47,30 +50,56 @@ const fromDBObject = (row) => {
   };
 };
 
+const webhookEventValidator = async (allowedEvents, events) => {
+  const allowedValues = Array.from(allowedEvents.values());
+
+  await mapAsync(events, (event) => {
+    if (allowedValues.includes(event)) {
+      return;
+    }
+
+    throw new ValidationError(`Webhook event ${event} is not supported`);
+  });
+};
+
 const createWebhookStore = ({ db }) => {
   const webhookQueries = db.query('webhook');
 
   return {
+    allowedEvents: new Map([]),
+    addAllowedEvent(key, value) {
+      this.allowedEvents.set(key, value);
+    },
+    removeAllowedEvent(key) {
+      this.allowedEvents.delete(key);
+    },
+    listAllowedEvents() {
+      return Array.from(this.allowedEvents.keys());
+    },
+    getAllowedEvent(key) {
+      return this.allowedEvents.get(key);
+    },
     async findWebhooks() {
       const results = await webhookQueries.findMany();
 
       return results.map(fromDBObject);
     },
-
     async findWebhook(id) {
       const result = await webhookQueries.findOne({ where: { id } });
       return result ? fromDBObject(result) : null;
     },
+    async createWebhook(data) {
+      await webhookEventValidator(this.allowedEvents, data.events);
 
-    createWebhook(data) {
       return webhookQueries
         .create({
           data: toDBObject({ ...data, isEnabled: true }),
         })
         .then(fromDBObject);
     },
-
     async updateWebhook(id, data) {
+      await webhookEventValidator(this.allowedEvents, data.events);
+
       const webhook = await webhookQueries.update({
         where: { id },
         data: toDBObject(data),
@@ -78,7 +107,6 @@ const createWebhookStore = ({ db }) => {
 
       return webhook ? fromDBObject(webhook) : null;
     },
-
     async deleteWebhook(id) {
       const webhook = await webhookQueries.delete({ where: { id } });
       return webhook ? fromDBObject(webhook) : null;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@strapi/strapi",
-  "version": "4.11.0-beta.1",
+  "version": "4.11.0-exp.2",
   "description": "An open source headless CMS solution to create and manage your own API. It provides a powerful dashboard and features to make your life easier. Databases supported: MySQL, MariaDB, PostgreSQL, SQLite",
   "keywords": [
     "strapi",
@@ -81,19 +81,19 @@
   "dependencies": {
     "@koa/cors": "3.4.3",
     "@koa/router": "10.1.1",
-    "@strapi/admin": "4.11.0-beta.1",
-    "@strapi/data-transfer": "4.11.0-beta.1",
-    "@strapi/database": "4.11.0-beta.1",
-    "@strapi/generate-new": "4.11.0-beta.1",
-    "@strapi/generators": "4.11.0-beta.1",
-    "@strapi/logger": "4.11.0-beta.1",
-    "@strapi/permissions": "4.11.0-beta.1",
-    "@strapi/plugin-content-manager": "4.11.0-beta.1",
-    "@strapi/plugin-content-type-builder": "4.11.0-beta.1",
-    "@strapi/plugin-email": "4.11.0-beta.1",
-    "@strapi/plugin-upload": "4.11.0-beta.1",
-    "@strapi/typescript-utils": "4.11.0-beta.1",
-    "@strapi/utils": "4.11.0-beta.1",
+    "@strapi/admin": "4.11.0-exp.2",
+    "@strapi/data-transfer": "4.11.0-exp.2",
+    "@strapi/database": "4.11.0-exp.2",
+    "@strapi/generate-new": "4.11.0-exp.2",
+    "@strapi/generators": "4.11.0-exp.2",
+    "@strapi/logger": "4.11.0-exp.2",
+    "@strapi/permissions": "4.11.0-exp.2",
+    "@strapi/plugin-content-manager": "4.11.0-exp.2",
+    "@strapi/plugin-content-type-builder": "4.11.0-exp.2",
+    "@strapi/plugin-email": "4.11.0-exp.2",
+    "@strapi/plugin-upload": "4.11.0-exp.2",
+    "@strapi/typescript-utils": "4.11.0-exp.2",
+    "@strapi/utils": "4.11.0-exp.2",
     "bcryptjs": "2.4.3",
     "boxen": "5.1.2",
     "chalk": "4.1.2",
@@ -136,11 +136,11 @@
   },
   "devDependencies": {
     "supertest": "6.3.3",
-    "typescript": "5.0.4"
+    "typescript": "5.1.3"
   },
   "engines": {
     "node": ">=14.19.1 <=18.x.x",
     "npm": ">=6.0.0"
   },
-  "gitHead": "a5fa3bd7e1c4680dd350580620d383612597d25d"
+  "gitHead": "d0785a2eb7588c1314108a40fee617bdfd3148e2"
 }