@strapi/database 5.0.0-rc.22 → 5.0.0-rc.23

package/dist/index.mjs

@@ -2261,7 +2261,7 @@ const createOneToOne = (attributeName, attribute, meta, metadata) => {
   }
 };
 const createOneToMany = (attributeName, attribute, meta, metadata) => {
-  if (!isBidirectional(attribute)) {
+  if (shouldUseJoinTable(attribute) && !isBidirectional(attribute)) {
     createJoinTable(metadata, {
       attribute,
       attributeName,
@@ -2290,7 +2290,7 @@ const createManyToOne = (attributeName, attribute, meta, metadata) => {
   }
 };
 const createManyToMany = (attributeName, attribute, meta, metadata) => {
-  if (!isBidirectional(attribute) || isOwner(attribute)) {
+  if (shouldUseJoinTable(attribute) && (!isBidirectional(attribute) || isOwner(attribute))) {
     createJoinTable(metadata, {
       attribute,
       attributeName,
@@ -2451,6 +2451,9 @@ const createJoinColumn = (metadata, { attribute, attributeName }) => {
   }
 };
 const createJoinTable = (metadata, { attributeName, attribute, meta }) => {
+  if (!shouldUseJoinTable(attribute)) {
+    throw new Error("Attempted to create join table when useJoinTable is false");
+  }
   const targetMeta = metadata.get(attribute.target);
   if (!targetMeta) {
     throw new Error(`Unknown target ${attribute.target}`);
@@ -2685,6 +2688,9 @@ class Metadata extends Map {
     for (const meta of this.values()) {
       for (const [attributeName, attribute] of Object.entries(meta.attributes)) {
         try {
+          if (attribute.unstable_virtual) {
+            continue;
+          }
           if (isRelationalAttribute(attribute)) {
             createRelation(attributeName, attribute, meta, this);
             continue;
@@ -6258,21 +6264,24 @@ const renameIndex = async (knex2, db, diff) => {
     debug(`not renaming index ${full.indexName} because name hasn't changed`);
     return;
   }
-  if (short.indexName.includes("_lnk_") || full.indexName.includes("_lnk_") || short.indexName.endsWith("fk") || full.indexName.endsWith("fk")) {
+  if (short.indexName.endsWith("fk") || full.indexName.endsWith("fk")) {
     return;
   }
   debug(`renaming index from ${full.indexName} to ${short.indexName}`);
   try {
     await knex2.transaction(async (trx) => {
       if (client === "mysql" || client === "mariadb") {
-        await knex2.raw(
-          `ALTER TABLE \`${full.tableName}\` RENAME INDEX \`${full.indexName}\` TO \`${short.indexName}\``
-        ).transacting(trx);
+        await knex2.raw("ALTER TABLE ?? RENAME INDEX ?? TO ??", [
+          full.tableName,
+          full.indexName,
+          short.indexName
+        ]).transacting(trx);
       } else if (client === "pg" || client === "postgres") {
-        await knex2.raw(`ALTER INDEX "${full.indexName}" RENAME TO "${short.indexName}"`).transacting(trx);
-      } else if (client === "sqlite" || client === "better") {
+        await knex2.raw("ALTER INDEX ?? RENAME TO ??", [full.indexName, short.indexName]).transacting(trx);
+      } else if (["sqlite", "sqlite3", "better-sqlite3"].includes(client)) {
+        debug(`SQLite does not support index renaming, not renaming index ${full.indexName}`);
       } else {
-        debug("No db client name matches, not creating index");
+        debug(`No db client name matches, not renaming index ${full.indexName}`);
       }
     });
   } catch (err) {