@strapi/database 4.0.0-next.8 → 4.0.2

package/lib/dialects/postgresql/schema-inspector.js

@@ -0,0 +1,232 @@
+'use strict';
+
+const SQL_QUERIES = {
+  TABLE_LIST: /* sql */ `
+    SELECT *
+    FROM information_schema.tables
+    WHERE
+      table_schema = ?
+      AND table_type = 'BASE TABLE'
+      AND table_name != 'geometry_columns'
+      AND table_name != 'spatial_ref_sys';
+  `,
+  LIST_COLUMNS: /* sql */ `
+    SELECT data_type, column_name, character_maximum_length, column_default, is_nullable
+    FROM information_schema.columns
+    WHERE table_schema = ? AND table_name = ?;
+  `,
+  INDEX_LIST: /* sql */ `
+    SELECT
+      ix.indexrelid,
+      i.relname as index_name,
+      a.attname as column_name,
+      ix.indisunique as is_unique,
+      ix.indisprimary as is_primary
+    FROM
+      pg_class t,
+      pg_namespace s,
+      pg_class i,
+      pg_index ix,
+      pg_attribute a
+    WHERE
+      t.oid = ix.indrelid
+      AND i.oid = ix.indexrelid
+      AND a.attrelid = t.oid
+      AND a.attnum = ANY(ix.indkey)
+      AND t.relkind = 'r'
+      AND t.relnamespace = s.oid
+      AND s.nspname = ?
+      AND t.relname = ?;
+  `,
+  FOREIGN_KEY_LIST: /* sql */ `
+    SELECT
+      tco."constraint_name" as constraint_name,
+      kcu."column_name" as column_name,
+      rel_kcu."table_name" as foreign_table,
+      rel_kcu."column_name" as fk_column_name,
+      rco.update_rule as on_update,
+      rco.delete_rule as on_delete
+    FROM information_schema.table_constraints tco
+    JOIN information_schema.key_column_usage kcu
+      ON tco.constraint_schema = kcu.constraint_schema
+      AND tco.constraint_name = kcu.constraint_name
+    JOIN information_schema.referential_constraints rco
+      ON tco.constraint_schema = rco.constraint_schema
+      AND tco.constraint_name = rco.constraint_name
+    JOIN information_schema.key_column_usage rel_kcu
+      ON rco.unique_constraint_schema = rel_kcu.constraint_schema
+      AND rco.unique_constraint_name = rel_kcu.constraint_name
+      AND kcu.ordinal_position = rel_kcu.ordinal_position
+    WHERE
+      tco.constraint_type = 'FOREIGN KEY'
+      AND tco.constraint_schema = ?
+      AND tco.table_name = ?
+    ORDER BY kcu.table_schema, kcu.table_name, kcu.ordinal_position, kcu.constraint_name;
+  `,
+};
+
+const toStrapiType = column => {
+  const rootType = column.data_type.toLowerCase().match(/[^(), ]+/)[0];
+
+  switch (rootType) {
+    case 'integer': {
+      // find a way to figure out the increments
+      return { type: 'integer' };
+    }
+    case 'text': {
+      return { type: 'text', args: ['longtext'] };
+    }
+    case 'boolean': {
+      return { type: 'boolean' };
+    }
+    case 'character': {
+      return { type: 'string', args: [column.character_maximum_length] };
+    }
+    case 'timestamp': {
+      return { type: 'datetime', args: [{ useTz: false, precision: 6 }] };
+    }
+    case 'date': {
+      return { type: 'date' };
+    }
+    case 'time': {
+      return { type: 'time', args: [{ precision: 3 }] };
+    }
+    case 'numeric': {
+      return { type: 'decimal', args: [10, 2] };
+    }
+    case 'real':
+    case 'double': {
+      return { type: 'double' };
+    }
+    case 'bigint': {
+      return { type: 'bigInteger' };
+    }
+    case 'jsonb': {
+      return { type: 'jsonb' };
+    }
+    default: {
+      return { type: 'specificType', args: [column.data_type] };
+    }
+  }
+};
+
+class PostgresqlSchemaInspector {
+  constructor(db) {
+    this.db = db;
+  }
+
+  async getSchema() {
+    const schema = { tables: [] };
+
+    const tables = await this.getTables();
+
+    schema.tables = await Promise.all(
+      tables.map(async tableName => {
+        const columns = await this.getColumns(tableName);
+        const indexes = await this.getIndexes(tableName);
+        const foreignKeys = await this.getForeignKeys(tableName);
+
+        return {
+          name: tableName,
+          columns,
+          indexes,
+          foreignKeys,
+        };
+      })
+    );
+
+    return schema;
+  }
+
+  getDatabaseSchema() {
+    return this.db.connection.getSchemaName() || 'public';
+  }
+
+  async getTables() {
+    const { rows } = await this.db.connection.raw(SQL_QUERIES.TABLE_LIST, [
+      this.getDatabaseSchema(),
+    ]);
+
+    return rows.map(row => row.table_name);
+  }
+
+  async getColumns(tableName) {
+    const { rows } = await this.db.connection.raw(SQL_QUERIES.LIST_COLUMNS, [
+      this.getDatabaseSchema(),
+      tableName,
+    ]);
+
+    return rows.map(row => {
+      const { type, args = [], ...rest } = toStrapiType(row);
+
+      const defaultTo =
+        row.column_default && row.column_default.includes('nextval(') ? null : row.column_default;
+
+      return {
+        type,
+        args,
+        defaultTo,
+        name: row.column_name,
+        notNullable: row.is_nullable === 'NO',
+        unsigned: false,
+        ...rest,
+      };
+    });
+  }
+
+  async getIndexes(tableName) {
+    const { rows } = await this.db.connection.raw(SQL_QUERIES.INDEX_LIST, [
+      this.getDatabaseSchema(),
+      tableName,
+    ]);
+
+    const ret = {};
+
+    for (const index of rows) {
+      if (index.column_name === 'id') {
+        continue;
+      }
+
+      if (!ret[index.indexrelid]) {
+        ret[index.indexrelid] = {
+          columns: [index.column_name],
+          name: index.index_name,
+          type: index.is_primary ? 'primary' : index.is_unique ? 'unique' : null,
+        };
+      } else {
+        ret[index.indexrelid].columns.push(index.column_name);
+      }
+    }
+
+    return Object.values(ret);
+  }
+
+  async getForeignKeys(tableName) {
+    const { rows } = await this.db.connection.raw(SQL_QUERIES.FOREIGN_KEY_LIST, [
+      this.getDatabaseSchema(),
+      tableName,
+    ]);
+
+    const ret = {};
+
+    for (const fk of rows) {
+      if (!ret[fk.constraint_name]) {
+        ret[fk.constraint_name] = {
+          name: fk.constraint_name,
+          columns: [fk.column_name],
+          referencedColumns: [fk.fk_column_name],
+          referencedTable: fk.foreign_table,
+          onUpdate: fk.on_update.toUpperCase(),
+          onDelete: fk.on_delete.toUpperCase(),
+        };
+      } else {
+        ret[fk.constraint_name].columns.push(fk.column_name);
+        ret[fk.constraint_name].referencedColumns.push(fk.fk_column_name);
+      }
+    }
+
+    return Object.values(ret);
+  }
+}
+
+module.exports = PostgresqlSchemaInspector;

package/lib/dialects/sqlite/index.js

@@ -0,0 +1,73 @@
+'use strict';
+
+const path = require('path');
+const fse = require('fs-extra');
+
+const errors = require('../../errors');
+const { Dialect } = require('../dialect');
+const SqliteSchmeaInspector = require('./schema-inspector');
+
+class SqliteDialect extends Dialect {
+  constructor(db) {
+    super(db);
+
+    this.schemaInspector = new SqliteSchmeaInspector(db);
+  }
+
+  configure() {
+    this.db.config.connection.connection.filename = path.resolve(
+      this.db.config.connection.connection.filename
+    );
+
+    const dbDir = path.dirname(this.db.config.connection.connection.filename);
+
+    fse.ensureDirSync(dbDir);
+  }
+
+  async initialize() {
+    await this.db.connection.raw('pragma foreign_keys = on');
+  }
+
+  canAlterConstraints() {
+    return false;
+  }
+
+  getSqlType(type) {
+    switch (type) {
+      case 'enum': {
+        return 'text';
+      }
+      case 'double':
+      case 'decimal': {
+        return 'float';
+      }
+      case 'timestamp': {
+        return 'datetime';
+      }
+      default: {
+        return type;
+      }
+    }
+  }
+
+  async startSchemaUpdate() {
+    await this.db.connection.raw(`pragma foreign_keys = off`);
+  }
+
+  async endSchemaUpdate() {
+    await this.db.connection.raw(`pragma foreign_keys = on`);
+  }
+
+  transformErrors(error) {
+    switch (error.errno) {
+      case 19: {
+        throw new errors.NotNullConstraint(); // TODO: extract column name
+      }
+      default: {
+        super.transformErrors(error);
+      }
+    }
+  }
+}
+
+module.exports = SqliteDialect;

package/lib/dialects/sqlite/schema-inspector.js

@@ -0,0 +1,151 @@
+'use strict';
+
+const SQL_QUERIES = {
+  TABLE_LIST: `select name from sqlite_master where type = 'table' and name NOT LIKE 'sqlite%'`,
+  TABLE_INFO: `pragma table_info(??)`,
+  INDEX_LIST: 'pragma index_list(??)',
+  INDEX_INFO: 'pragma index_info(??)',
+  FOREIGN_KEY_LIST: 'pragma foreign_key_list(??)',
+};
+
+const toStrapiType = column => {
+  const { type } = column;
+
+  const rootType = type.toLowerCase().match(/[^(), ]+/)[0];
+
+  switch (rootType) {
+    case 'integer': {
+      if (column.pk) {
+        return { type: 'increments', args: [{ primary: true }] };
+      }
+
+      return { type: 'integer' };
+    }
+    case 'float': {
+      return { type: 'float', args: [10, 2] };
+    }
+    case 'bigint': {
+      return { type: 'bigInteger' };
+    }
+    case 'varchar': {
+      const length = type.slice(8, type.length - 1);
+
+      return { type: 'string', args: [Number(length)] };
+    }
+    case 'text': {
+      return { type: 'text', args: ['longtext'] };
+    }
+    case 'json': {
+      return { type: 'jsonb' };
+    }
+    case 'boolean': {
+      return { type: 'boolean' };
+    }
+    case 'datetime': {
+      return { type: 'datetime', args: [{ useTz: false, precision: 6 }] };
+    }
+    case 'date': {
+      return { type: 'date' };
+    }
+    case 'time': {
+      return { type: 'time', args: [{ precision: 3 }] };
+    }
+    default: {
+      return { type: 'specificType', args: [column.data_type] };
+    }
+  }
+};
+
+class SqliteSchemaInspector {
+  constructor(db) {
+    this.db = db;
+  }
+
+  async getSchema() {
+    const schema = { tables: [] };
+    const tables = await this.getTables();
+
+    for (const tableName of tables) {
+      const columns = await this.getColumns(tableName);
+      const indexes = await this.getIndexes(tableName);
+      const foreignKeys = await this.getForeignKeys(tableName);
+
+      schema.tables.push({
+        name: tableName,
+        columns,
+        indexes,
+        foreignKeys,
+      });
+    }
+
+    return schema;
+  }
+
+  async getTables() {
+    const rows = await this.db.connection.raw(SQL_QUERIES.TABLE_LIST);
+
+    return rows.map(row => row.name);
+  }
+
+  async getColumns(tableName) {
+    const rows = await this.db.connection.raw(SQL_QUERIES.TABLE_INFO, [tableName]);
+
+    return rows.map(row => {
+      const { type, args = [], ...rest } = toStrapiType(row);
+
+      return {
+        type,
+        args,
+        name: row.name,
+        defaultTo: row.dflt_value,
+        notNullable: row.notnull !== null ? Boolean(row.notnull) : null,
+        unsigned: false,
+        ...rest,
+      };
+    });
+  }
+
+  async getIndexes(tableName) {
+    const indexes = await this.db.connection.raw(SQL_QUERIES.INDEX_LIST, [tableName]);
+
+    const ret = [];
+
+    for (const index of indexes.filter(index => !index.name.startsWith('sqlite_'))) {
+      const res = await this.db.connection.raw(SQL_QUERIES.INDEX_INFO, [index.name]);
+
+      ret.push({
+        columns: res.map(row => row.name),
+        name: index.name,
+        type: index.unique ? 'unique' : null,
+      });
+    }
+
+    return ret;
+  }
+
+  async getForeignKeys(tableName) {
+    const fks = await this.db.connection.raw(SQL_QUERIES.FOREIGN_KEY_LIST, [tableName]);
+
+    const ret = {};
+
+    for (const fk of fks) {
+      if (!ret[fk.id]) {
+        ret[fk.id] = {
+          // TODO: name, //  find name
+          columns: [fk.from],
+          referencedColumns: [fk.to],
+          referencedTable: fk.table,
+          onUpdate: fk.on_update.toUpperCase(),
+          onDelete: fk.on_delete.toUpperCase(),
+        };
+      } else {
+        ret[fk.id].columns.push(fk.from);
+        ret[fk.id].referencedColumns.push(fk.to);
+      }
+    }
+
+    return Object.values(ret);
+  }
+}
+
+module.exports = SqliteSchemaInspector;

package/lib/entity-manager.js

@@ -29,8 +29,7 @@ const toAssocs = data => {
     });
 };
 
-// TODO: handle programmatic defaults
-const toRow = (metadata, data = {}, { withDefaults = false } = {}) => {
+const processData = (metadata, data = {}, { withDefaults = false } = {}) => {
   const { attributes } = metadata;
 
   const obj = {};
@@ -38,7 +37,6 @@ const toRow = (metadata, data = {}, { withDefaults = false } = {}) => {
   for (const attributeName in attributes) {
     const attribute = attributes[attributeName];
 
-    // TODO:  convert to column name
     if (types.isScalar(attribute.type)) {
       const field = createField(attribute);
 
@@ -65,7 +63,6 @@ const toRow = (metadata, data = {}, { withDefaults = false } = {}) => {
     if (types.isRelation(attribute.type)) {
       // oneToOne & manyToOne
       if (attribute.joinColumn && attribute.owner) {
-        // TODO: ensure joinColumn name respect convention ?
         const joinColumnName = attribute.joinColumn.name;
 
         // allow setting to null
@@ -145,7 +142,7 @@ const createEntityManager = db => {
       await db.lifecycles.run('beforeCount', uid, { params });
 
       const res = await this.createQueryBuilder(uid)
-        .init(_.pick(['_q', 'where'], params))
+        .init(_.pick(['_q', 'where', 'filters'], params))
         .count()
         .first()
         .execute();
@@ -167,7 +164,7 @@ const createEntityManager = db => {
         throw new Error('Create expects a data object');
       }
 
-      const dataToInsert = toRow(metadata, data, { withDefaults: true });
+      const dataToInsert = processData(metadata, data, { withDefaults: true });
 
       const [id] = await this.createQueryBuilder(uid)
         .insert(dataToInsert)
@@ -175,7 +172,7 @@ const createEntityManager = db => {
 
       await this.attachRelations(uid, id, data);
 
-      // TODO: in case there is not select or populate specified return the inserted data ?
+      // TODO: in case there is no select or populate specified return the inserted data ?
       // TODO: do not trigger the findOne lifecycles ?
       const result = await this.findOne(uid, {
         where: { id },
@@ -199,7 +196,7 @@ const createEntityManager = db => {
         throw new Error('CreateMany expects data to be an array');
       }
 
-      const dataToInsert = data.map(datum => toRow(metadata, datum, { withDefaults: true }));
+      const dataToInsert = data.map(datum => processData(metadata, datum, { withDefaults: true }));
 
       if (_.isEmpty(dataToInsert)) {
         throw new Error('Nothing to insert');
@@ -242,7 +239,7 @@ const createEntityManager = db => {
 
       const { id } = entity;
 
-      const dataToUpdate = toRow(metadata, data);
+      const dataToUpdate = processData(metadata, data);
 
       if (!_.isEmpty(dataToUpdate)) {
         await this.createQueryBuilder(uid)
@@ -272,7 +269,7 @@ const createEntityManager = db => {
       const metadata = db.metadata.get(uid);
       const { where, data } = params;
 
-      const dataToUpdate = toRow(metadata, data);
+      const dataToUpdate = processData(metadata, data);
 
       if (_.isEmpty(dataToUpdate)) {
         throw new Error('Update requires data');
@@ -299,7 +296,7 @@ const createEntityManager = db => {
         throw new Error('Delete requires a where parameter');
       }
 
-      // TODO: avoid trigger the findOne lifecycles in the case ?
+      // TODO: do not trigger the findOne lifecycles ?
       const entity = await this.findOne(uid, {
         select: select && ['id'].concat(select),
         where,
@@ -472,7 +469,6 @@ const createEntityManager = db => {
           const { joinTable } = attribute;
           const { joinColumn, inverseJoinColumn } = joinTable;
 
-          // TODO: validate logic of delete
           if (isOneToAny(attribute) && isBidirectional(attribute)) {
             await this.createQueryBuilder(joinTable.name)
               .delete()
@@ -654,7 +650,10 @@ const createEntityManager = db => {
             .where(joinTable.on || {})
             .execute();
 
-          if (['oneToOne', 'oneToMany'].includes(attribute.relation)) {
+          if (
+            isBidirectional(attribute) &&
+            ['oneToOne', 'oneToMany'].includes(attribute.relation)
+          ) {
             await this.createQueryBuilder(joinTable.name)
               .delete()
               .where({ [inverseJoinColumn.name]: toIds(data[attributeName]) })
@@ -772,6 +771,7 @@ const createEntityManager = db => {
           continue;
         }
 
+        // do not need to delete links when using foreign keys
         if (db.dialect.usesForeignKeys()) {
           return;
         }
@@ -812,7 +812,7 @@ const createEntityManager = db => {
       const entry = await this.findOne(uid, {
         select: ['id'],
         where: { id: entity.id },
-        populate: populate,
+        populate,
       });
 
       return Object.assign({}, entity, entry);
@@ -837,6 +837,10 @@ const createEntityManager = db => {
         },
       });
 
+      if (!entry) {
+        return null;
+      }
+
       return entry[field];
     },
 

package/lib/entity-repository.js

@@ -95,9 +95,8 @@ const createRepository = (uid, db) => {
       return db.entityManager.deleteRelations(uid, id);
     },
 
-    // TODO: add relation API
-    populate(entity, field, params) {
-      return db.entityManager.populate(uid, entity, field, params);
+    populate(entity, populate) {
+      return db.entityManager.populate(uid, entity, populate);
     },
 
     load(entity, field, params) {

package/lib/errors.js

@@ -1,14 +1,56 @@
 'use strict';
 
-class NotNullConstraint extends Error {
+/* DatabaseError */
+class DatabaseError extends Error {
+  constructor(message, details = {}) {
+    super();
+    this.name = 'DatabaseError';
+    this.message = message || 'A database error occured';
+    this.details = details;
+  }
+}
+
+class NotNullConstraint extends DatabaseError {
   constructor({ column = '' } = {}) {
     super();
     this.name = 'NotNullConstraint';
-    this.message = `Not null constraint violation${column ? `on on column ${column}` : ''}.`;
+    this.message = `Not null constraint violation${column ? ` on column ${column}` : ''}.`;
+    this.details = { column };
     this.stack = '';
   }
 }
 
+class InvalidTimeError extends DatabaseError {
+  constructor(message) {
+    super();
+    this.name = 'InvalidTimeFormat';
+    this.message = message || 'Invalid time format, expected HH:mm:ss.SSS';
+    this.details = {};
+  }
+}
+
+class InvalidDateError extends DatabaseError {
+  constructor(message) {
+    super();
+    this.name = 'InvalidTimeFormat';
+    this.message = message || 'Invalid date format, expected YYYY-MM-DD';
+    this.details = {};
+  }
+}
+
+class InvalidDateTimeError extends DatabaseError {
+  constructor(message) {
+    super();
+    this.name = 'InvalidTimeFormat';
+    this.message = message || 'Invalid datetime format, expected a timestamp or an ISO date';
+    this.details = {};
+  }
+}
+
 module.exports = {
+  DatabaseError,
   NotNullConstraint,
+  InvalidTimeError,
+  InvalidDateError,
+  InvalidDateTimeError,
 };

package/lib/fields.d.ts

@@ -1,10 +1,9 @@
+import { Attribute } from './schema';
+
 interface Field {
   config: {};
   toDB(value: any): any;
   fromDB(value: any): any;
 }
 
-interface Attribute {
-  type: string
-}
 export function createField(attribute: Attribute): Field;