@strapi/admin 4.16.2 → 4.17.0

package/ee/server/migrations/review-workflows-content-types.js

@@ -1,29 +0,0 @@
-'use strict';
-
-const { get, keys, pickBy, pipe } = require('lodash/fp');
-const { WORKFLOW_MODEL_UID } = require('../constants/workflows');
-
-async function migrateWorkflowsContentTypes({ oldContentTypes, contentTypes }) {
-  // Look for RW contentTypes attribute
-  const hadContentTypes = !!oldContentTypes?.[WORKFLOW_MODEL_UID]?.attributes?.contentTypes;
-  const hasContentTypes = !!contentTypes?.[WORKFLOW_MODEL_UID]?.attributes?.contentTypes;
-
-  if (!hadContentTypes && hasContentTypes) {
-    // Initialize contentTypes with an empty array and assign only to one
-    // workflow the Content Types which were using Review Workflow before.
-    await strapi.query(WORKFLOW_MODEL_UID).updateMany({ data: { contentTypes: [] } });
-
-    // Find Content Types which were using Review Workflow before
-    const contentTypes = pipe([pickBy(get('options.reviewWorkflows')), keys])(oldContentTypes);
-
-    if (contentTypes.length) {
-      // Update only one workflow with the contentTypes
-      // Before this release there was only one workflow, so this operation is safe.
-      await strapi
-        .query(WORKFLOW_MODEL_UID)
-        .update({ where: { id: { $notNull: true } }, data: { contentTypes } });
-    }
-  }
-}
-
-module.exports = migrateWorkflowsContentTypes;

package/ee/server/migrations/review-workflows-deleted-ct-in-workflows.js

@@ -1,39 +0,0 @@
-'use strict';
-
-const { difference, keys } = require('lodash/fp');
-const { mapAsync } = require('@strapi/utils');
-const { WORKFLOW_MODEL_UID } = require('../constants/workflows');
-const { getWorkflowContentTypeFilter } = require('../utils/review-workflows');
-
-/**
- * @param {Object} oldContentTypes
- * @param {Object} contentTypes
- * @return {Promise<void>}
- */
-async function migrateDeletedCTInWorkflows({ oldContentTypes, contentTypes }) {
-  const deletedContentTypes = difference(keys(oldContentTypes), keys(contentTypes)) ?? [];
-
-  if (deletedContentTypes.length) {
-    await mapAsync(deletedContentTypes, async (deletedContentTypeUID) => {
-      const workflow = await strapi.query(WORKFLOW_MODEL_UID).findOne({
-        select: ['id', 'contentTypes'],
-        where: {
-          contentTypes: getWorkflowContentTypeFilter({ strapi }, deletedContentTypeUID),
-        },
-      });
-
-      if (workflow) {
-        await strapi.query(WORKFLOW_MODEL_UID).update({
-          where: { id: workflow.id },
-          data: {
-            contentTypes: workflow.contentTypes.filter(
-              (contentTypeUID) => contentTypeUID !== deletedContentTypeUID
-            ),
-          },
-        });
-      }
-    });
-  }
-}
-
-module.exports = migrateDeletedCTInWorkflows;

package/ee/server/migrations/review-workflows-stage-attribute.js

@@ -1,49 +0,0 @@
-'use strict';
-
-const semver = require('semver');
-const { getOr } = require('lodash/fp');
-const { mapAsync } = require('@strapi/utils');
-const { STAGE_MODEL_UID } = require('../constants/workflows');
-const { findTables } = require('../utils/persisted-tables');
-
-function checkVersionThreshold(startVersion, currentVersion, thresholdVersion) {
-  return semver.gte(currentVersion, thresholdVersion) && semver.lt(startVersion, thresholdVersion);
-}
-
-async function migrateStageAttribute({ oldContentTypes, contentTypes }) {
-  const getRWVersion = getOr('0.0.0', `${STAGE_MODEL_UID}.options.version`);
-  const oldRWVersion = getRWVersion(oldContentTypes);
-  const currentRWVersion = getRWVersion(contentTypes);
-
-  const migrationNeeded = checkVersionThreshold(oldRWVersion, currentRWVersion, '1.1.0');
-
-  if (migrationNeeded) {
-    const oldAttributeTableName = 'strapi_review_workflows_stage';
-    const newAttributeTableName = 'strapi_stage';
-    const tables = await findTables({ strapi }, new RegExp(oldAttributeTableName));
-
-    await mapAsync(tables, async (tableName) => {
-      const newTableName = tableName.replace(oldAttributeTableName, newAttributeTableName);
-      const alreadyHasNextTable = await strapi.db.connection.schema.hasTable(newTableName);
-
-      // The table can be already created but empty. In order to rename the old one, we need to drop the previously created empty one.
-      if (alreadyHasNextTable) {
-        const dataInTable = await strapi.db.connection(newTableName).select().limit(1);
-        if (!dataInTable.length) {
-          await strapi.db.connection.schema.dropTable(newTableName);
-        }
-      }
-
-      try {
-        await strapi.db.connection.schema.renameTable(tableName, newTableName);
-      } catch (e) {
-        strapi.log.warn(
-          `An error occurred during the migration of ${tableName} table to ${newTableName}.\nIf ${newTableName} already exists, migration can't be done automatically.`
-        );
-        strapi.log.warn(e.message);
-      }
-    });
-  }
-}
-
-module.exports = migrateStageAttribute;

package/ee/server/migrations/review-workflows-stages-color.js

@@ -1,20 +0,0 @@
-'use strict';
-
-const { STAGE_DEFAULT_COLOR } = require('../constants/workflows');
-
-async function migrateReviewWorkflowStagesColor({ oldContentTypes, contentTypes }) {
-  // Look for CT's color attribute
-  const hadColor = !!oldContentTypes?.['admin::workflow-stage']?.attributes?.color;
-  const hasColor = !!contentTypes?.['admin::workflow-stage']?.attributes?.color;
-
-  // Add the default stage color if color attribute was added
-  if (!hadColor && hasColor) {
-    await strapi.query('admin::workflow-stage').updateMany({
-      data: {
-        color: STAGE_DEFAULT_COLOR,
-      },
-    });
-  }
-}
-
-module.exports = migrateReviewWorkflowStagesColor;

package/ee/server/migrations/review-workflows-stages-roles.js

@@ -1,68 +0,0 @@
-'use strict';
-
-const { STAGE_TRANSITION_UID, STAGE_MODEL_UID } = require('../constants/workflows');
-const { getService } = require('../utils');
-
-async function migrateReviewWorkflowStagesRoles({ oldContentTypes, contentTypes }) {
-  const stageUID = 'admin::workflow-stage';
-  const hadRolePermissions = !!oldContentTypes?.[stageUID]?.attributes?.permissions;
-  const hasRolePermissions = !!contentTypes?.[stageUID]?.attributes?.permissions;
-
-  // If the stage content type did not have permissions in the previous version
-  // then we set the permissions of every stage to be every current role in the app.
-  // This ensures consistent behaviour when upgrading to a strapi version with review workflows RBAC.
-  if (!hadRolePermissions && hasRolePermissions) {
-    const roleUID = 'admin::role';
-    strapi.log.info(
-      `Migrating all existing review workflow stages to have RBAC permissions for all ${roleUID}.`
-    );
-
-    const stagePermissionsService = getService('stage-permissions');
-
-    const stages = await strapi.query(stageUID).findMany();
-    const roles = await strapi.query(roleUID).findMany();
-
-    // Collect the permissions to add and group them by stage id.
-    const groupedPermissions = {};
-    roles
-      .map((role) => role.id)
-      .forEach((roleId) => {
-        stages
-          .map((stage) => stage.id)
-          .forEach((stageId) => {
-            if (!groupedPermissions[stageId]) {
-              groupedPermissions[stageId] = [];
-            }
-
-            groupedPermissions[stageId].push({
-              roleId,
-              fromStage: stageId,
-              action: STAGE_TRANSITION_UID,
-            });
-          });
-      });
-
-    for (const [stageId, permissions] of Object.entries(groupedPermissions)) {
-      const numericalStageId = Number(stageId);
-
-      if (Number.isNaN(numericalStageId)) {
-        strapi.log.warn(
-          `Unable to apply ${roleUID} migration for ${stageUID} with id ${stageId}. The stage does not have a numerical id.`
-        );
-        continue;
-      }
-
-      // Register the permissions for this stage
-      const stagePermissions = await stagePermissionsService.registerMany(permissions);
-
-      // Update the stage with its new permissions
-      await strapi.entityService.update(STAGE_MODEL_UID, numericalStageId, {
-        data: {
-          permissions: stagePermissions.flat().map((permission) => permission.id),
-        },
-      });
-    }
-  }
-}
-
-module.exports = migrateReviewWorkflowStagesRoles;

package/ee/server/migrations/review-workflows-workflow-name.js

@@ -1,28 +0,0 @@
-'use strict';
-
-const { WORKFLOW_MODEL_UID } = require('../constants/workflows');
-const defaultWorkflow = require('../constants/default-workflow.json');
-
-/**
- * Multiple workflows introduced the ability to name a workflow.
- * This migration adds the default workflow name if the name attribute was added.
- */
-async function migrateReviewWorkflowName({ oldContentTypes, contentTypes }) {
-  // Look for RW name attribute
-  const hadName = !!oldContentTypes?.[WORKFLOW_MODEL_UID]?.attributes?.name;
-  const hasName = !!contentTypes?.[WORKFLOW_MODEL_UID]?.attributes?.name;
-
-  // Add the default workflow name if name attribute was added
-  if (!hadName && hasName) {
-    await strapi.query(WORKFLOW_MODEL_UID).updateMany({
-      where: {
-        name: { $null: true },
-      },
-      data: {
-        name: defaultWorkflow.name,
-      },
-    });
-  }
-}
-
-module.exports = migrateReviewWorkflowName;

package/ee/server/register.js

@@ -1,40 +0,0 @@
-'use strict';
-
-const { features } = require('@strapi/strapi/dist/utils/ee');
-const executeCERegister = require('../../server/register');
-const migrateAuditLogsTable = require('./migrations/audit-logs-table');
-const migrateReviewWorkflowStagesColor = require('./migrations/review-workflows-stages-color');
-const migrateReviewWorkflowStagesRoles = require('./migrations/review-workflows-stages-roles');
-const migrateReviewWorkflowName = require('./migrations/review-workflows-workflow-name');
-const migrateWorkflowsContentTypes = require('./migrations/review-workflows-content-types');
-const migrateStageAttribute = require('./migrations/review-workflows-stage-attribute');
-const migrateDeletedCTInWorkflows = require('./migrations/review-workflows-deleted-ct-in-workflows');
-const createAuditLogsService = require('./services/audit-logs');
-const reviewWorkflowsMiddlewares = require('./middlewares/review-workflows');
-const { getService } = require('./utils');
-
-module.exports = async ({ strapi }) => {
-  const auditLogsIsEnabled = strapi.config.get('admin.auditLogs.enabled', true);
-
-  if (auditLogsIsEnabled) {
-    strapi.hook('strapi::content-types.beforeSync').register(migrateAuditLogsTable);
-    const auditLogsService = createAuditLogsService(strapi);
-    strapi.container.register('audit-logs', auditLogsService);
-    await auditLogsService.register();
-  }
-  if (features.isEnabled('review-workflows')) {
-    strapi.hook('strapi::content-types.beforeSync').register(migrateStageAttribute);
-    strapi
-      .hook('strapi::content-types.afterSync')
-      .register(migrateReviewWorkflowStagesColor)
-      .register(migrateReviewWorkflowStagesRoles)
-      .register(migrateReviewWorkflowName)
-      .register(migrateWorkflowsContentTypes)
-      .register(migrateDeletedCTInWorkflows);
-    const reviewWorkflowService = getService('review-workflows');
-
-    reviewWorkflowsMiddlewares.contentTypeMiddleware(strapi);
-    await reviewWorkflowService.register(features.get('review-workflows'));
-  }
-  await executeCERegister({ strapi });
-};

package/ee/server/routes/audit-logs.js

@@ -1,43 +0,0 @@
-'use strict';
-
-const { enableFeatureMiddleware } = require('./utils');
-
-module.exports = {
-  type: 'admin',
-  routes: [
-    {
-      method: 'GET',
-      path: '/audit-logs',
-      handler: 'auditLogs.findMany',
-      config: {
-        middlewares: [enableFeatureMiddleware('audit-logs')],
-        policies: [
-          'admin::isAuthenticatedAdmin',
-          {
-            name: 'admin::hasPermissions',
-            config: {
-              actions: ['admin::audit-logs.read'],
-            },
-          },
-        ],
-      },
-    },
-    {
-      method: 'GET',
-      path: '/audit-logs/:id',
-      handler: 'auditLogs.findOne',
-      config: {
-        middlewares: [enableFeatureMiddleware('audit-logs')],
-        policies: [
-          'admin::isAuthenticatedAdmin',
-          {
-            name: 'admin::hasPermissions',
-            config: {
-              actions: ['admin::audit-logs.read'],
-            },
-          },
-        ],
-      },
-    },
-  ],
-};

package/ee/server/routes/index.js

@@ -1,8 +0,0 @@
-'use strict';
-
-module.exports = {
-  sso: require('./sso'),
-  'license-limit': require('./license-limit'),
-  'audit-logs': require('./audit-logs'),
-  'review-workflows': require('./review-workflows'),
-};

package/ee/server/routes/license-limit.js

@@ -1,29 +0,0 @@
-'use strict';
-
-module.exports = {
-  type: 'admin',
-  routes: [
-    // License limit infos
-    {
-      method: 'GET',
-      path: '/license-limit-information',
-      handler: 'admin.licenseLimitInformation',
-      config: {
-        policies: [
-          'admin::isAuthenticatedAdmin',
-          {
-            name: 'admin::hasPermissions',
-            config: {
-              actions: [
-                'admin::users.create',
-                'admin::users.read',
-                'admin::users.update',
-                'admin::users.delete',
-              ],
-            },
-          },
-        ],
-      },
-    },
-  ],
-};

package/ee/server/routes/review-workflows.js

@@ -1,164 +0,0 @@
-'use strict';
-
-const { enableFeatureMiddleware } = require('./utils');
-
-module.exports = {
-  type: 'admin',
-  routes: [
-    // Review workflow
-    {
-      method: 'POST',
-      path: '/review-workflows/workflows',
-      handler: 'workflows.create',
-      config: {
-        middlewares: [enableFeatureMiddleware('review-workflows')],
-        policies: [
-          'admin::isAuthenticatedAdmin',
-          {
-            name: 'admin::hasPermissions',
-            config: {
-              actions: ['admin::review-workflows.create'],
-            },
-          },
-        ],
-      },
-    },
-    {
-      method: 'PUT',
-      path: '/review-workflows/workflows/:id',
-      handler: 'workflows.update',
-      config: {
-        middlewares: [enableFeatureMiddleware('review-workflows')],
-        policies: [
-          'admin::isAuthenticatedAdmin',
-          {
-            name: 'admin::hasPermissions',
-            config: {
-              actions: ['admin::review-workflows.update'],
-            },
-          },
-        ],
-      },
-    },
-    {
-      method: 'DELETE',
-      path: '/review-workflows/workflows/:id',
-      handler: 'workflows.delete',
-      config: {
-        middlewares: [enableFeatureMiddleware('review-workflows')],
-        policies: [
-          'admin::isAuthenticatedAdmin',
-          {
-            name: 'admin::hasPermissions',
-            config: {
-              actions: ['admin::review-workflows.delete'],
-            },
-          },
-        ],
-      },
-    },
-    {
-      method: 'GET',
-      path: '/review-workflows/workflows',
-      handler: 'workflows.find',
-      config: {
-        middlewares: [enableFeatureMiddleware('review-workflows')],
-        policies: [
-          'admin::isAuthenticatedAdmin',
-          {
-            name: 'admin::hasPermissions',
-            config: {
-              actions: ['admin::review-workflows.read'],
-            },
-          },
-        ],
-      },
-    },
-    {
-      method: 'GET',
-      path: '/review-workflows/workflows/:id',
-      handler: 'workflows.findById',
-      config: {
-        middlewares: [enableFeatureMiddleware('review-workflows')],
-        policies: [
-          'admin::isAuthenticatedAdmin',
-          {
-            name: 'admin::hasPermissions',
-            config: {
-              actions: ['admin::review-workflows.read'],
-            },
-          },
-        ],
-      },
-    },
-    {
-      method: 'GET',
-      path: '/review-workflows/workflows/:workflow_id/stages',
-      handler: 'stages.find',
-      config: {
-        middlewares: [enableFeatureMiddleware('review-workflows')],
-        policies: [
-          'admin::isAuthenticatedAdmin',
-          {
-            name: 'admin::hasPermissions',
-            config: {
-              actions: ['admin::review-workflows.read'],
-            },
-          },
-        ],
-      },
-    },
-    {
-      method: 'GET',
-      path: '/review-workflows/workflows/:workflow_id/stages/:id',
-      handler: 'stages.findById',
-      config: {
-        middlewares: [enableFeatureMiddleware('review-workflows')],
-        policies: [
-          'admin::isAuthenticatedAdmin',
-          {
-            name: 'admin::hasPermissions',
-            config: {
-              actions: ['admin::review-workflows.read'],
-            },
-          },
-        ],
-      },
-    },
-    {
-      method: 'PUT',
-      path: '/content-manager/(collection|single)-types/:model_uid/:id/stage',
-      handler: 'stages.updateEntity',
-      config: {
-        middlewares: [enableFeatureMiddleware('review-workflows')],
-        policies: ['admin::isAuthenticatedAdmin'],
-      },
-    },
-    {
-      method: 'GET',
-      path: '/content-manager/(collection|single)-types/:model_uid/:id/stages',
-      handler: 'stages.listAvailableStages',
-      config: {
-        middlewares: [enableFeatureMiddleware('review-workflows')],
-        policies: ['admin::isAuthenticatedAdmin'],
-      },
-    },
-    {
-      method: 'PUT',
-      path: '/content-manager/(collection|single)-types/:model_uid/:id/assignee',
-      handler: 'assignees.updateEntity',
-      config: {
-        middlewares: [enableFeatureMiddleware('review-workflows')],
-        policies: [
-          'admin::isAuthenticatedAdmin',
-          {
-            name: 'admin::hasPermissions',
-            config: {
-              actions: ['admin::users.read', 'admin::review-workflows.read'],
-            },
-          },
-        ],
-      },
-    },
-  ],
-};

package/ee/server/routes/sso.js

@@ -1,69 +0,0 @@
-'use strict';
-
-const { enableFeatureMiddleware } = require('./utils');
-
-module.exports = {
-  type: 'admin',
-  routes: [
-    {
-      method: 'GET',
-      path: '/providers',
-      handler: 'authentication.getProviders',
-      config: {
-        middlewares: [enableFeatureMiddleware('sso')],
-        auth: false,
-      },
-    },
-    {
-      method: 'GET',
-      path: '/connect/:provider',
-      handler: 'authentication.providerLogin',
-      config: {
-        middlewares: [enableFeatureMiddleware('sso')],
-        auth: false,
-      },
-    },
-    {
-      method: 'POST',
-      path: '/connect/:provider',
-      handler: 'authentication.providerLogin',
-      config: {
-        middlewares: [enableFeatureMiddleware('sso')],
-        auth: false,
-      },
-    },
-    {
-      method: 'GET',
-      path: '/providers/options',
-      handler: 'authentication.getProviderLoginOptions',
-      config: {
-        middlewares: [enableFeatureMiddleware('sso')],
-        policies: [
-          'admin::isAuthenticatedAdmin',
-          { name: 'admin::hasPermissions', config: { actions: ['admin::provider-login.read'] } },
-        ],
-      },
-    },
-    {
-      method: 'PUT',
-      path: '/providers/options',
-      handler: 'authentication.updateProviderLoginOptions',
-      config: {
-        middlewares: [enableFeatureMiddleware('sso')],
-        policies: [
-          'admin::isAuthenticatedAdmin',
-          { name: 'admin::hasPermissions', config: { actions: ['admin::provider-login.update'] } },
-        ],
-      },
-    },
-    {
-      method: 'GET',
-      path: '/providers/isSSOLocked',
-      handler: 'user.isSSOLocked',
-      config: {
-        middlewares: [enableFeatureMiddleware('sso')],
-        policies: ['admin::isAuthenticatedAdmin'],
-      },
-    },
-  ],
-};

package/ee/server/routes/utils.js

@@ -1,15 +0,0 @@
-'use strict';
-
-const { features } = require('@strapi/strapi/dist/utils/ee');
-
-const enableFeatureMiddleware = (featureName) => (ctx, next) => {
-  if (features.isEnabled(featureName)) {
-    return next();
-  }
-
-  ctx.status = 404;
-};
-
-module.exports = {
-  enableFeatureMiddleware,
-};

package/ee/server/services/__tests__/assignees.test.js

@@ -1,76 +0,0 @@
-'use strict';
-
-jest.mock('@strapi/strapi/dist/utils/ee', () => {
-  const eeModule = () => true;
-
-  Object.assign(eeModule, {
-    features: {
-      isEnabled() {
-        return true;
-      },
-      getEnabled() {
-        return ['review-workflows'];
-      },
-    },
-  });
-
-  return eeModule;
-});
-
-const { ENTITY_ASSIGNEE_ATTRIBUTE } = require('../../constants/workflows');
-const assigneeFactory = require('../review-workflows/assignees');
-
-const uid = 'uid';
-const fromAssigneeId = 1;
-const entityServiceMock = {
-  findOne: jest.fn(() => {
-    return {
-      [ENTITY_ASSIGNEE_ATTRIBUTE]: {
-        id: fromAssigneeId,
-      },
-    };
-  }),
-  update: jest.fn((uid, id, { data }) => data),
-};
-const servicesMock = {
-  'admin::user': {
-    exists: jest.fn(() => true),
-  },
-  'admin::review-workflows-metrics': {
-    sendDidEditAssignee: jest.fn(),
-  },
-};
-
-const strapiMock = {
-  entityService: entityServiceMock,
-  service: jest.fn((serviceName) => {
-    return servicesMock[serviceName];
-  }),
-};
-
-const assigneeService = assigneeFactory({ strapi: strapiMock });
-
-describe('Review workflows - Stages service', () => {
-  afterEach(() => {
-    jest.clearAllMocks();
-  });
-
-  describe('updateEntityAssignee', () => {
-    it('should update the assignee of an entity', async () => {
-      const id = 10;
-      const toId = 2;
-      await assigneeService.updateEntityAssignee(id, uid, toId);
-
-      expect(servicesMock['admin::user'].exists).toBeCalled();
-      expect(servicesMock['admin::review-workflows-metrics'].sendDidEditAssignee).toBeCalledWith(
-        fromAssigneeId,
-        toId
-      );
-      expect(entityServiceMock.update).toBeCalledWith(uid, id, {
-        data: { [ENTITY_ASSIGNEE_ATTRIBUTE]: toId },
-        fields: [],
-        populate: [ENTITY_ASSIGNEE_ATTRIBUTE],
-      });
-    });
-  });
-});