@straiffi/archon 1.8.7 → 1.8.8

package/dist/server/index.js

@@ -21,7 +21,7 @@ import { resolveSessionTargetForExecution } from './lib/sessionTargets.js';
 import { createChatMessage, getChatMessage, updateChatMessageContent } from './lib/chatMessages.js';
 import { attachChatTicketProposalsToMessageContent } from './lib/chatTicketProposals.js';
 import { createCorsOriginResolver, parseCorsOrigins } from './lib/cors.js';
-import { abortGitOperation, branchExistsLocally, commitGitChanges, createWorktreeAsync, deleteWorktree, getBundleReviewDiffForCwd, getGitDiffData, getGitDiffFiles, getGitStatus, getGitUnifiedDiff, getLocalProjectBranch, getProjectBranch, getProjectBranchSuggestions, getSelectedGitUnifiedDiff, getUnpushedCommitDiffForCwd, getUnpushedCommitSummaryForCwd, hasKnownBranchRef, listUnpushedCommitsForCwd, pullGitBranch, pushCurrentBranch, rebaseGitBranchOntoBase, resolveExistingWorktreePath, resolveWorktreePath, squashUnpushedCommitsForCwd, summarizeTicketDiffFiles, switchProjectBranch, syncWorktreeFilesAsync, undoLatestUnpushedCommitForCwd, UnpushedCommitDiffSelectionError } from './lib/git.js';
+import { abortGitOperation, branchExistsLocally, commitGitChanges, createWorktreeAsync, deleteWorktree, getBundleReviewDiffForCwd, getGitDiffDataAsync, getGitDiffFiles, getGitStatus, getGitStatusAsync, getGitUnifiedDiff, getGitUnifiedDiffAsync, getLocalProjectBranch, getProjectBranch, getProjectBranchSuggestions, getSelectedGitUnifiedDiff, getUnpushedCommitDiffForCwd, getUnpushedCommitSummaryForCwd, getUnpushedCommitSummaryForCwdAsync, hasKnownBranchRef, listUnpushedCommitsForCwd, pullGitBranch, pushCurrentBranch, rebaseGitBranchOntoBase, resolveExistingWorktreePath, resolveWorktreePath, squashUnpushedCommitsForCwd, summarizeTicketDiffFiles, switchProjectBranch, syncWorktreeFilesAsync, undoLatestUnpushedCommitForCwd, UnpushedCommitDiffSelectionError } from './lib/git.js';
 import config from './lib/config.js';
 import { autoConfigProject, ProjectAutoConfigError } from './lib/projectAutoConfig.js';
 import { analyzeRepoPath, createInitialCommit, ensureInitialCommitForWorktrees, initializeGitRepo, isInitialCommitRequiredError, } from './lib/projectRepos.js';
@@ -1446,8 +1446,8 @@ const bundlePullRequestDiscoveryErrorTimestamps = new Map();
 const bundlePullRequestSyncInFlight = new Map();
 const bundlePullRequestSyncErrorTimestamps = new Map();
 const getBundlePullRequestDiscoveryKey = (projectId, bundleId) => `${projectId}:${bundleId}`;
-const startPassiveGitHubWork = (label, callback) => {
-    setImmediate(() => {
+const startPassiveGitHubWork = (response, label, callback) => {
+    const start = () => setImmediate(() => {
         try {
             callback();
         }
@@ -1455,6 +1455,11 @@ const startPassiveGitHubWork = (label, callback) => {
             console.warn(`[integrations] github passive work failed ${label}`, error);
         }
     });
+    if (response.writableFinished) {
+        start();
+        return;
+    }
+    response.once('finish', start);
 };
 const isBundlePullRequestDiscoveryCoolingDown = (timestamps, key, cooldownMs) => {
     const lastAttemptAt = timestamps.get(key);
@@ -2019,7 +2024,7 @@ const buildBundleTickets = (projectId, bundleId, broadcaster) => {
         value: details,
     };
 };
-const getCurrentReviewWorkspaceSignature = (ticket) => {
+const getCurrentReviewWorkspaceSignature = async (ticket) => {
     if (!ticket) {
         return null;
     }
@@ -2027,9 +2032,9 @@ const getCurrentReviewWorkspaceSignature = (ticket) => {
     if ('error' in workspace) {
         return null;
     }
-    return getGitStatus(workspace.cwd, workspace.branch, workspace.project).workspace_signature ?? null;
+    return (await getGitStatusAsync(workspace.cwd, workspace.branch, workspace.project)).workspace_signature ?? null;
 };
-const getCurrentReviewDiffSignature = (ticket) => {
+const getCurrentReviewDiffSignature = async (ticket) => {
     if (!ticket) {
         return null;
     }
@@ -2037,9 +2042,9 @@ const getCurrentReviewDiffSignature = (ticket) => {
     if ('error' in workspace) {
         return null;
     }
-    return computeDiffSignature(getGitUnifiedDiff(workspace.cwd));
+    return computeDiffSignature(await getGitUnifiedDiffAsync(workspace.cwd));
 };
-const getBundleReviewFindings = (projectId, bundleId) => {
+const getBundleReviewFindings = async (projectId, bundleId) => {
     const bundle = getBundle(bundleId, projectId);
     if (!bundle) {
         return null;
@@ -2070,13 +2075,13 @@ const getBundleReviewFindings = (projectId, bundleId) => {
     return buildReviewFindingsResponse({
         context,
         isContextRunning: tickets.some(ticket => ticket.agent_status === 'running'),
-        currentWorkspaceSignature: getCurrentReviewWorkspaceSignature(representativeTicket),
+        currentWorkspaceSignature: await getCurrentReviewWorkspaceSignature(representativeTicket),
         currentDiffSignature: latestReviewRun && latestReviewRun.workspace_signature === null
-            ? getCurrentReviewDiffSignature(representativeTicket)
+            ? await getCurrentReviewDiffSignature(representativeTicket)
             : null,
     });
 };
-const getTicketReviewFindings = (ticketId) => {
+const getTicketReviewFindings = async (ticketId) => {
     const ticket = getTicketRouteContext(ticketId);
     if (!ticket) {
         return null;
@@ -2090,9 +2095,9 @@ const getTicketReviewFindings = (ticketId) => {
     return buildReviewFindingsResponse({
         context,
         isContextRunning: ticket.agent_status === 'running',
-        currentWorkspaceSignature: getCurrentReviewWorkspaceSignature(ticket),
+        currentWorkspaceSignature: await getCurrentReviewWorkspaceSignature(ticket),
         currentDiffSignature: latestReviewRun && latestReviewRun.workspace_signature === null
-            ? getCurrentReviewDiffSignature(ticket)
+            ? await getCurrentReviewDiffSignature(ticket)
             : null,
     });
 };
@@ -2739,7 +2744,7 @@ app.post('/projects/:id/chat-sessions/:sessionId/stop', async (req, res) => {
     }
     return res.status(result.status).json(result.value);
 });
-app.get('/projects/:id/chat-sessions/:sessionId/diff', (req, res) => {
+app.get('/projects/:id/chat-sessions/:sessionId/diff', async (req, res) => {
     const project = getProjectById(req.params.id);
     if (!project) {
         return res.status(404).json({ error: 'Not found' });
@@ -2752,14 +2757,14 @@ app.get('/projects/:id/chat-sessions/:sessionId/diff', (req, res) => {
     if (!workspace.target_available || !workspace.cwd) {
         return res.status(409).json({ error: workspace.target_unavailable_reason ?? 'Chat target is unavailable.' });
     }
-    const diffData = getGitDiffData(workspace.cwd);
+    const diffData = await getGitDiffDataAsync(workspace.cwd);
     return res.json({
         stats: summarizeTicketDiffFiles(diffData.files),
         files: diffData.files,
         diff: diffData.diff,
     });
 });
-app.get('/projects/:id/chat-sessions/:sessionId/git-status', (req, res) => {
+app.get('/projects/:id/chat-sessions/:sessionId/git-status', async (req, res) => {
     const project = getProjectById(req.params.id);
     if (!project) {
         return res.status(404).json({ error: 'Not found' });
@@ -2772,7 +2777,7 @@ app.get('/projects/:id/chat-sessions/:sessionId/git-status', (req, res) => {
     if (!workspace.target_available || !workspace.cwd) {
         return res.status(409).json({ error: workspace.target_unavailable_reason ?? 'Chat target is unavailable.' });
     }
-    return res.json(getGitStatus(workspace.cwd, workspace.branch, project));
+    return res.json(await getGitStatusAsync(workspace.cwd, workspace.branch, project));
 });
 app.delete('/projects/:id/chat-sessions/:sessionId', (req, res) => {
     const project = getProjectById(req.params.id);
@@ -3353,14 +3358,14 @@ app.get('/tickets/:id', async (req, res) => {
     res.json(ticket);
     if (passivePullRequestContext) {
         const { project, bundle } = passivePullRequestContext;
-        startPassiveGitHubWork('ticket-open-pr-sync', () => {
+        startPassiveGitHubWork(res, 'ticket-open-pr-sync', () => {
             startTrackedBundlePullRequestSyncIfNeeded(project, bundle);
             startBundlePullRequestDiscoveryIfNeeded(project, bundle);
         });
     }
     return;
 });
-app.get('/tickets/:id/review-findings', (req, res) => {
+app.get('/tickets/:id/review-findings', async (req, res) => {
     const ticket = getTicketRouteContext(req.params.id);
     if (!ticket) {
         return res.status(404).json({ error: 'Not found' });
@@ -3368,7 +3373,7 @@ app.get('/tickets/:id/review-findings', (req, res) => {
     if (!matchesTicketProjectContext(ticket, req)) {
         return res.status(404).json({ error: 'Not found' });
     }
-    const response = getTicketReviewFindings(ticket.id);
+    const response = await getTicketReviewFindings(ticket.id);
     if (!response) {
         return res.status(404).json({ error: 'Not found' });
     }
@@ -3384,7 +3389,7 @@ app.get('/tickets/:id/agent-runs', (req, res) => {
     }
     return res.json({ runs: listAgentRunsForParent('ticket', ticket.id) });
 });
-app.get('/tickets/:id/diff', (req, res) => {
+app.get('/tickets/:id/diff', async (req, res) => {
     const ticket = getTicketRouteContext(req.params.id);
     if (!ticket) {
         return res.status(404).json({ error: 'Not found' });
@@ -3397,7 +3402,7 @@ app.get('/tickets/:id/diff', (req, res) => {
         const { status, error } = workspace;
         return res.status(status).json({ error });
     }
-    const diffData = getGitDiffData(workspace.cwd);
+    const diffData = await getGitDiffDataAsync(workspace.cwd);
     return res.json({
         stats: summarizeTicketDiffFiles(diffData.files),
         files: diffData.files,
@@ -3418,7 +3423,7 @@ app.get('/tickets/:id/committed-diff', (req, res) => {
     }
     return sendUnpushedCommitDiff(res, workspace, getCommitHashQuery(req));
 });
-app.get('/tickets/:id/git-status', (req, res) => {
+app.get('/tickets/:id/git-status', async (req, res) => {
     const ticket = getTicketRouteContext(req.params.id);
     if (!ticket) {
         return res.status(404).json({ error: 'Not found' });
@@ -3431,9 +3436,9 @@ app.get('/tickets/:id/git-status', (req, res) => {
         return res.status(workspace.status).json({ error: workspace.error });
     }
     const refreshRemote = req.query.refresh_remote === 'true';
-    return res.json(getGitStatus(workspace.cwd, workspace.branch, workspace.project, { refreshRemote }));
+    return res.json(await getGitStatusAsync(workspace.cwd, workspace.branch, workspace.project, { refreshRemote }));
 });
-app.get('/tickets/:id/git-commits', (req, res) => {
+app.get('/tickets/:id/git-commits', async (req, res) => {
     const ticket = getTicketRouteContext(req.params.id);
     if (!ticket) {
         return res.status(404).json({ error: 'Not found' });
@@ -3445,7 +3450,7 @@ app.get('/tickets/:id/git-commits', (req, res) => {
     if ('error' in workspace) {
         return res.status(workspace.status).json({ error: workspace.error });
     }
-    const summary = getUnpushedCommitSummaryForCwd(workspace.cwd, workspace.branch, workspace.project);
+    const summary = await getUnpushedCommitSummaryForCwdAsync(workspace.cwd, workspace.branch, workspace.project);
     return res.json({ commits: summary.commits, total_count: summary.totalCount });
 });
 app.get('/bundles', async (req, res) => {
@@ -3465,7 +3470,7 @@ app.get('/bundles', async (req, res) => {
     timing.mark('serialize_bundles');
     timing.end({ count: serializedBundles.length });
     res.json(serializedBundles);
-    startPassiveGitHubWork('project-bundle-pr-sync', () => {
+    startPassiveGitHubWork(res, 'project-bundle-pr-sync', () => {
         startProjectBundlePullRequestSyncIfNeeded(result.project, bundles);
     });
 });
@@ -3493,16 +3498,16 @@ app.get('/bundles/:id/conversation', (req, res) => {
     }
     const payload = serializeBundleConversationDetails(result.project, bundle);
     res.json(payload);
-    startPassiveGitHubWork('bundle-conversation-pr-discovery', () => {
+    startPassiveGitHubWork(res, 'bundle-conversation-pr-discovery', () => {
         startBundlePullRequestDiscoveryIfNeeded(result.project, bundle);
     });
 });
-app.get('/bundles/:id/review-findings', (req, res) => {
+app.get('/bundles/:id/review-findings', async (req, res) => {
     const result = getRequiredProject(req);
     if ('error' in result) {
         return res.status(400).json({ error: result.error });
     }
-    const response = getBundleReviewFindings(result.project.id, req.params.id);
+    const response = await getBundleReviewFindings(result.project.id, req.params.id);
     if (!response) {
         return res.status(404).json({ error: 'Bundle not found' });
     }
@@ -6873,7 +6878,7 @@ app.post('/projects/:id/git-abort', async (req, res) => {
         return res.status(500).json({ error: 'Unable to determine project branch' });
     }
 });
-app.get('/projects/:id/diff', (req, res) => {
+app.get('/projects/:id/diff', async (req, res) => {
     const project = getProjectById(req.params.id);
     if (!project) {
         return res.status(404).json({ error: 'Not found' });
@@ -6882,7 +6887,7 @@ app.get('/projects/:id/diff', (req, res) => {
     if ('error' in workspace) {
         return res.status(workspace.status).json({ error: workspace.error });
     }
-    const diffData = getGitDiffData(workspace.cwd);
+    const diffData = await getGitDiffDataAsync(workspace.cwd);
     return res.json({
         stats: summarizeTicketDiffFiles(diffData.files),
         files: diffData.files,
@@ -6900,7 +6905,7 @@ app.get('/projects/:id/committed-diff', (req, res) => {
     }
     return sendUnpushedCommitDiff(res, workspace, getCommitHashQuery(req));
 });
-app.get('/projects/:id/git-status', (req, res) => {
+app.get('/projects/:id/git-status', async (req, res) => {
     const project = getProjectById(req.params.id);
     if (!project) {
         return res.status(404).json({ error: 'Not found' });
@@ -6910,9 +6915,9 @@ app.get('/projects/:id/git-status', (req, res) => {
         return res.status(workspace.status).json({ error: workspace.error });
     }
     const refreshRemote = req.query.refresh_remote === 'true';
-    return res.json(getGitStatus(workspace.cwd, workspace.branch, workspace.project, { refreshRemote }));
+    return res.json(await getGitStatusAsync(workspace.cwd, workspace.branch, workspace.project, { refreshRemote }));
 });
-app.get('/projects/:id/git-commits', (req, res) => {
+app.get('/projects/:id/git-commits', async (req, res) => {
     const project = getProjectById(req.params.id);
     if (!project) {
         return res.status(404).json({ error: 'Not found' });
@@ -6921,7 +6926,7 @@ app.get('/projects/:id/git-commits', (req, res) => {
     if ('error' in workspace) {
         return res.status(workspace.status).json({ error: workspace.error });
     }
-    const summary = getUnpushedCommitSummaryForCwd(workspace.cwd, workspace.branch, workspace.project);
+    const summary = await getUnpushedCommitSummaryForCwdAsync(workspace.cwd, workspace.branch, workspace.project);
     return res.json({ commits: summary.commits, total_count: summary.totalCount });
 });
 app.post('/projects/:id/git-commit', async (req, res) => {