@straiffi/archon 1.8.21 → 1.8.22

package/dist/server/db.js

@@ -3,7 +3,7 @@ import { createHash } from 'crypto';
 import { parseCheckDefinitionsJsonStrict, parseLegacyTestCommandsJsonStrict, projectCheckDefinitionsToTestCommands, } from './lib/checkDefinitions.js';
 import { ensureParentDirectory, resolveArchonDbPath } from './lib/runtimePaths.js';
 import { TRANSCRIPT_RUN_TEXT_LIMIT_BYTES, truncateUtf8 } from './lib/transcriptRuns.js';
-import { createExecutionProfile, fingerprintExecutionProfile, serializeExecutionProfile, } from './lib/executionProfiles.js';
+import { createExecutionProfile, EXECUTION_PROFILE_SCHEMA_VERSION, fingerprintExecutionProfile, normalizeExecutionProfile, serializeExecutionProfile, } from './lib/executionProfiles.js';
 const dbPath = ensureParentDirectory(resolveArchonDbPath());
 const db = new Database(dbPath);
 db.pragma('foreign_keys = ON');
@@ -181,7 +181,7 @@ db.exec(`
     id             TEXT PRIMARY KEY,
     project_id     TEXT NOT NULL,
     revision       INTEGER NOT NULL CHECK (revision > 0),
-    schema_version INTEGER NOT NULL CHECK (schema_version = 1),
+    schema_version INTEGER NOT NULL CHECK (schema_version IN (1, 2)),
     fingerprint    TEXT NOT NULL CHECK (length(fingerprint) = 64),
     profile_json   TEXT NOT NULL CHECK (
       json_valid(profile_json)
@@ -220,6 +220,46 @@ db.exec(`
   CREATE INDEX IF NOT EXISTS idx_execution_profile_audit_project
     ON execution_profile_audit_events(project_id, created_at DESC, id DESC);
 `);
+const executionProfileRevisionsTableSql = db.prepare("SELECT sql FROM sqlite_master WHERE type = 'table' AND name = 'execution_profile_revisions'").get()?.sql ?? '';
+if (!executionProfileRevisionsTableSql.includes('schema_version IN (1, 2)')) {
+    db.pragma('foreign_keys = OFF');
+    db.transaction(() => {
+        const referencingTriggers = db.prepare(`
+      SELECT name FROM sqlite_master
+      WHERE type = 'trigger' AND instr(sql, 'execution_profile_revisions') > 0
+    `).all();
+        for (const trigger of referencingTriggers) {
+            db.exec(`DROP TRIGGER IF EXISTS "${trigger.name.replaceAll('"', '""')}"`);
+        }
+        db.exec(`
+      CREATE TABLE execution_profile_revisions_v2 (
+        id             TEXT PRIMARY KEY,
+        project_id     TEXT NOT NULL,
+        revision       INTEGER NOT NULL CHECK (revision > 0),
+        schema_version INTEGER NOT NULL CHECK (schema_version IN (1, 2)),
+        fingerprint    TEXT NOT NULL CHECK (length(fingerprint) = 64),
+        profile_json   TEXT NOT NULL CHECK (
+          json_valid(profile_json)
+          AND json_type(profile_json) = 'object'
+          AND length(CAST(profile_json AS BLOB)) BETWEEN 2 AND 16384
+        ),
+        created_at     DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
+        UNIQUE (project_id, revision),
+        UNIQUE (project_id, fingerprint),
+        UNIQUE (project_id, id),
+        FOREIGN KEY (project_id) REFERENCES projects(id) ON DELETE CASCADE
+      );
+      INSERT INTO execution_profile_revisions_v2 (
+        id, project_id, revision, schema_version, fingerprint, profile_json, created_at
+      )
+      SELECT id, project_id, revision, schema_version, fingerprint, profile_json, created_at
+      FROM execution_profile_revisions;
+      DROP TABLE execution_profile_revisions;
+      ALTER TABLE execution_profile_revisions_v2 RENAME TO execution_profile_revisions;
+    `);
+    })();
+    db.pragma('foreign_keys = ON');
+}
 const backfillExecutionProfiles = () => {
     const projects = db.prepare(`
     SELECT id, build_execution_provider, active_execution_profile_revision_id
@@ -231,7 +271,7 @@ const backfillExecutionProfiles = () => {
     const insertRevision = db.prepare(`
     INSERT OR IGNORE INTO execution_profile_revisions (
       id, project_id, revision, schema_version, fingerprint, profile_json
-    ) VALUES (?, ?, 1, 1, ?, ?)
+    ) VALUES (?, ?, 1, ${EXECUTION_PROFILE_SCHEMA_VERSION}, ?, ?)
   `);
     const activateRevision = db.prepare(`
     UPDATE projects SET active_execution_profile_revision_id = ? WHERE id = ?
@@ -257,7 +297,70 @@ const backfillExecutionProfiles = () => {
         }
     })();
 };
+const backfillExecutionProfilesToSchemaV2 = () => {
+    const legacyRows = db.prepare(`
+    SELECT projects.id AS project_id,
+      revisions.id AS revision_id,
+      revisions.profile_json
+    FROM projects
+    INNER JOIN execution_profile_revisions revisions
+      ON revisions.id = projects.active_execution_profile_revision_id
+      AND revisions.project_id = projects.id
+    WHERE revisions.schema_version = 1 AND projects.deletion_started_at IS NULL
+  `).all();
+    const nextRevisionNumber = db.prepare(`
+    SELECT COALESCE(MAX(revision), 0) + 1 AS revision
+    FROM execution_profile_revisions WHERE project_id = ?
+  `);
+    const findRevisionByFingerprint = db.prepare(`
+    SELECT id FROM execution_profile_revisions WHERE project_id = ? AND fingerprint = ?
+  `);
+    const insertRevision = db.prepare(`
+    INSERT OR IGNORE INTO execution_profile_revisions (
+      id, project_id, revision, schema_version, fingerprint, profile_json
+    ) VALUES (?, ?, ?, ${EXECUTION_PROFILE_SCHEMA_VERSION}, ?, ?)
+  `);
+    const activateRevision = db.prepare(`
+    UPDATE projects SET active_execution_profile_revision_id = ?
+    WHERE id = ? AND active_execution_profile_revision_id = ?
+  `);
+    const insertEvent = db.prepare(`
+    INSERT OR IGNORE INTO execution_profile_audit_events (
+      id, project_id, event_type, profile_revision_id, previous_profile_revision_id
+    ) VALUES (?, ?, 'revision_activated', ?, ?)
+  `);
+    db.transaction(() => {
+        for (const row of legacyRows) {
+            let normalized;
+            try {
+                normalized = normalizeExecutionProfile(JSON.parse(row.profile_json));
+            }
+            catch {
+                normalized = null;
+            }
+            if (!normalized?.ok) {
+                throw new Error(`Stored execution profile revision ${row.revision_id} is invalid`);
+            }
+            const fingerprint = fingerprintExecutionProfile(normalized.profile);
+            const existing = findRevisionByFingerprint.get(row.project_id, fingerprint);
+            let revisionId;
+            if (existing) {
+                revisionId = existing.id;
+            }
+            else {
+                revisionId = `${row.project_id}:execution-profile:v2`;
+                const revisionNumber = nextRevisionNumber.get(row.project_id).revision;
+                insertRevision.run(revisionId, row.project_id, revisionNumber, fingerprint, serializeExecutionProfile(normalized.profile));
+            }
+            const activated = activateRevision.run(revisionId, row.project_id, row.revision_id);
+            if (activated.changes > 0) {
+                insertEvent.run(`${revisionId}:v2-backfill`, row.project_id, revisionId, row.revision_id);
+            }
+        }
+    })();
+};
 backfillExecutionProfiles();
+backfillExecutionProfilesToSchemaV2();
 const hostCompatibilityProfile = createExecutionProfile('host');
 const hostCompatibilityProfileJson = serializeExecutionProfile(hostCompatibilityProfile).replaceAll("'", "''");
 const hostCompatibilityFingerprint = fingerprintExecutionProfile(hostCompatibilityProfile);
@@ -272,7 +375,7 @@ db.exec(`
     INSERT INTO execution_profile_revisions (
       id, project_id, revision, schema_version, fingerprint, profile_json
     ) VALUES (
-      NEW.id || ':execution-profile:1', NEW.id, 1, 1,
+      NEW.id || ':execution-profile:1', NEW.id, 1, ${EXECUTION_PROFILE_SCHEMA_VERSION},
       CASE WHEN NEW.build_execution_provider = 'docker_sandbox'
         THEN '${dockerProfileFingerprint}' ELSE '${hostCompatibilityFingerprint}' END,
       CASE WHEN NEW.build_execution_provider = 'docker_sandbox'
@@ -2614,6 +2717,217 @@ db.exec(`
   END;
 
 `);
+db.exec(`
+  CREATE TABLE IF NOT EXISTS approval_requests (
+    id                        TEXT PRIMARY KEY,
+    project_id                TEXT NOT NULL,
+    execution_run_id          TEXT NOT NULL,
+    action_kind               TEXT NOT NULL,
+    action_schema_version     INTEGER NOT NULL,
+    action_json               TEXT NOT NULL,
+    action_fingerprint        TEXT NOT NULL,
+    authority_schema_version  INTEGER NOT NULL,
+    authority_json            TEXT NOT NULL,
+    status                    TEXT NOT NULL DEFAULT 'pending',
+    expires_at                DATETIME NOT NULL,
+    decision_at               DATETIME,
+    consumed_at               DATETIME,
+    created_at                DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
+    updated_at                DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
+    UNIQUE (id, project_id),
+    UNIQUE (execution_run_id),
+    FOREIGN KEY (project_id) REFERENCES projects(id) ON DELETE CASCADE,
+    FOREIGN KEY (execution_run_id, project_id) REFERENCES execution_runs(id, project_id) ON DELETE CASCADE,
+    CHECK (length(id) BETWEEN 1 AND 128),
+    CHECK (action_kind IN ('git_push', 'custom_check')),
+    CHECK (action_schema_version = 1),
+    CHECK (length(CAST(action_json AS BLOB)) BETWEEN 2 AND 65536),
+    CHECK (length(action_fingerprint) = 64 AND action_fingerprint NOT GLOB '*[^0-9a-f]*'),
+    CHECK (authority_schema_version = 1),
+    CHECK (length(CAST(authority_json AS BLOB)) BETWEEN 2 AND 16384),
+    CHECK (status IN ('pending', 'approved', 'denied', 'cancelled', 'expired', 'invalidated', 'consumed')),
+    CHECK (status NOT IN ('approved', 'denied', 'consumed') OR decision_at IS NOT NULL),
+    CHECK (status <> 'pending' OR decision_at IS NULL),
+    CHECK ((status = 'consumed') = (consumed_at IS NOT NULL))
+  );
+
+  CREATE TABLE IF NOT EXISTS approval_request_events (
+    id                    TEXT PRIMARY KEY,
+    project_id            TEXT NOT NULL,
+    approval_request_id   TEXT NOT NULL,
+    sequence              INTEGER NOT NULL,
+    event_type            TEXT NOT NULL,
+    from_status           TEXT,
+    to_status             TEXT NOT NULL,
+    actor_classification  TEXT NOT NULL,
+    actor_reference       TEXT,
+    reason                TEXT,
+    metadata_schema_version INTEGER NOT NULL DEFAULT 1,
+    metadata_json         TEXT,
+    created_at            DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
+    UNIQUE (approval_request_id, sequence),
+    FOREIGN KEY (approval_request_id, project_id) REFERENCES approval_requests(id, project_id) ON DELETE CASCADE,
+    CHECK (sequence >= 1),
+    CHECK (length(event_type) BETWEEN 1 AND 100),
+    CHECK (from_status IS NULL OR from_status IN ('pending', 'approved', 'denied', 'cancelled', 'expired', 'invalidated', 'consumed')),
+    CHECK (to_status IN ('pending', 'approved', 'denied', 'cancelled', 'expired', 'invalidated', 'consumed')),
+    CHECK (actor_classification IN ('human', 'system', 'action_executor')),
+    CHECK (actor_reference IS NULL OR length(CAST(actor_reference AS BLOB)) BETWEEN 1 AND 200),
+    CHECK (reason IS NULL OR length(CAST(reason AS BLOB)) <= 2000),
+    CHECK (metadata_schema_version = 1),
+    CHECK (metadata_json IS NULL OR length(CAST(metadata_json AS BLOB)) <= 4096)
+  );
+
+  CREATE TRIGGER IF NOT EXISTS preserve_approval_request_identity
+  BEFORE UPDATE OF id, project_id, execution_run_id, action_kind, action_schema_version,
+    action_json, action_fingerprint, authority_schema_version, authority_json, expires_at, created_at
+    ON approval_requests
+  BEGIN
+    SELECT RAISE(ABORT, 'Approval request identity and evidence are immutable');
+  END;
+
+  CREATE TRIGGER IF NOT EXISTS preserve_approval_request_decision_evidence
+  BEFORE UPDATE OF decision_at, consumed_at ON approval_requests
+  WHEN (OLD.decision_at IS NOT NULL AND NEW.decision_at IS NOT OLD.decision_at)
+    OR (OLD.consumed_at IS NOT NULL AND NEW.consumed_at IS NOT OLD.consumed_at)
+  BEGIN
+    SELECT RAISE(ABORT, 'Approval request decision evidence is immutable');
+  END;
+
+  CREATE TRIGGER IF NOT EXISTS validate_approval_request_status_transition
+  BEFORE UPDATE OF status ON approval_requests
+  WHEN NOT (
+    (OLD.status = 'pending' AND NEW.status IN ('approved', 'denied', 'cancelled', 'expired', 'invalidated'))
+    OR (OLD.status = 'approved' AND NEW.status IN ('consumed', 'expired', 'invalidated'))
+  )
+  BEGIN
+    SELECT RAISE(ABORT, 'Invalid approval request status transition');
+  END;
+
+  CREATE TRIGGER IF NOT EXISTS preserve_approval_request_events
+  BEFORE UPDATE ON approval_request_events
+  BEGIN
+    SELECT RAISE(ABORT, 'Approval request events are append-only');
+  END;
+
+  CREATE TRIGGER IF NOT EXISTS prevent_approval_request_event_deletion
+  BEFORE DELETE ON approval_request_events
+  WHEN EXISTS (
+    SELECT 1 FROM projects
+    WHERE id = OLD.project_id AND deletion_started_at IS NULL
+  )
+  BEGIN
+    SELECT RAISE(ABORT, 'Approval request events are append-only');
+  END;
+
+  CREATE INDEX IF NOT EXISTS idx_approval_requests_project_created
+    ON approval_requests(project_id, created_at DESC, id DESC);
+  CREATE INDEX IF NOT EXISTS idx_approval_requests_project_status_expiry
+    ON approval_requests(project_id, status, expires_at, id);
+  CREATE INDEX IF NOT EXISTS idx_approval_requests_action_kind
+    ON approval_requests(project_id, action_kind, created_at DESC, id DESC);
+  CREATE INDEX IF NOT EXISTS idx_approval_request_events_sequence
+    ON approval_request_events(project_id, approval_request_id, sequence ASC);
+`);
+const migrateApprovalRequestActionLimit = () => {
+    const tableSql = db.prepare("SELECT sql FROM sqlite_master WHERE type = 'table' AND name = 'approval_requests'").get()?.sql ?? '';
+    if (tableSql.includes('BETWEEN 2 AND 65536')) {
+        return;
+    }
+    db.exec('PRAGMA foreign_keys = OFF');
+    try {
+        db.exec('BEGIN');
+        db.exec(`
+      CREATE TABLE approval_requests_v2 (
+        id                        TEXT PRIMARY KEY,
+        project_id                TEXT NOT NULL,
+        execution_run_id          TEXT NOT NULL,
+        action_kind               TEXT NOT NULL,
+        action_schema_version     INTEGER NOT NULL,
+        action_json               TEXT NOT NULL,
+        action_fingerprint        TEXT NOT NULL,
+        authority_schema_version  INTEGER NOT NULL,
+        authority_json            TEXT NOT NULL,
+        status                    TEXT NOT NULL DEFAULT 'pending',
+        expires_at                DATETIME NOT NULL,
+        decision_at               DATETIME,
+        consumed_at               DATETIME,
+        created_at                DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
+        updated_at                DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
+        UNIQUE (id, project_id),
+        UNIQUE (execution_run_id),
+        FOREIGN KEY (project_id) REFERENCES projects(id) ON DELETE CASCADE,
+        FOREIGN KEY (execution_run_id, project_id) REFERENCES execution_runs(id, project_id) ON DELETE CASCADE,
+        CHECK (length(id) BETWEEN 1 AND 128),
+        CHECK (action_kind IN ('git_push', 'custom_check')),
+        CHECK (action_schema_version = 1),
+        CHECK (length(CAST(action_json AS BLOB)) BETWEEN 2 AND 65536),
+        CHECK (length(action_fingerprint) = 64 AND action_fingerprint NOT GLOB '*[^0-9a-f]*'),
+        CHECK (authority_schema_version = 1),
+        CHECK (length(CAST(authority_json AS BLOB)) BETWEEN 2 AND 16384),
+        CHECK (status IN ('pending', 'approved', 'denied', 'cancelled', 'expired', 'invalidated', 'consumed')),
+        CHECK (status NOT IN ('approved', 'denied', 'consumed') OR decision_at IS NOT NULL),
+        CHECK (status <> 'pending' OR decision_at IS NULL),
+        CHECK ((status = 'consumed') = (consumed_at IS NOT NULL))
+      );
+      INSERT INTO approval_requests_v2 (
+        id, project_id, execution_run_id, action_kind, action_schema_version, action_json,
+        action_fingerprint, authority_schema_version, authority_json, status, expires_at,
+        decision_at, consumed_at, created_at, updated_at
+      )
+      SELECT
+        id, project_id, execution_run_id, action_kind, action_schema_version, action_json,
+        action_fingerprint, authority_schema_version, authority_json, status, expires_at,
+        decision_at, consumed_at, created_at, updated_at
+      FROM approval_requests;
+      DROP TABLE approval_requests;
+      ALTER TABLE approval_requests_v2 RENAME TO approval_requests;
+    `);
+        db.exec('COMMIT');
+    }
+    catch (error) {
+        db.exec('ROLLBACK');
+        throw error;
+    }
+    finally {
+        db.exec('PRAGMA foreign_keys = ON');
+    }
+    db.exec(`
+    CREATE TRIGGER preserve_approval_request_identity
+    BEFORE UPDATE OF id, project_id, execution_run_id, action_kind, action_schema_version,
+      action_json, action_fingerprint, authority_schema_version, authority_json, expires_at, created_at
+      ON approval_requests
+    BEGIN
+      SELECT RAISE(ABORT, 'Approval request identity and evidence are immutable');
+    END;
+
+    CREATE TRIGGER preserve_approval_request_decision_evidence
+    BEFORE UPDATE OF decision_at, consumed_at ON approval_requests
+    WHEN (OLD.decision_at IS NOT NULL AND NEW.decision_at IS NOT OLD.decision_at)
+      OR (OLD.consumed_at IS NOT NULL AND NEW.consumed_at IS NOT OLD.consumed_at)
+    BEGIN
+      SELECT RAISE(ABORT, 'Approval request decision evidence is immutable');
+    END;
+
+    CREATE TRIGGER validate_approval_request_status_transition
+    BEFORE UPDATE OF status ON approval_requests
+    WHEN NOT (
+      (OLD.status = 'pending' AND NEW.status IN ('approved', 'denied', 'cancelled', 'expired', 'invalidated'))
+      OR (OLD.status = 'approved' AND NEW.status IN ('consumed', 'expired', 'invalidated'))
+    )
+    BEGIN
+      SELECT RAISE(ABORT, 'Invalid approval request status transition');
+    END;
+
+    CREATE INDEX idx_approval_requests_project_created
+      ON approval_requests(project_id, created_at DESC, id DESC);
+    CREATE INDEX idx_approval_requests_project_status_expiry
+      ON approval_requests(project_id, status, expires_at, id);
+    CREATE INDEX idx_approval_requests_action_kind
+      ON approval_requests(project_id, action_kind, created_at DESC, id DESC);
+  `);
+};
+migrateApprovalRequestActionLimit();
 db.exec(`
   CREATE TABLE IF NOT EXISTS build_setup_evidence (
     id                              TEXT PRIMARY KEY,
@@ -3102,7 +3416,7 @@ db.exec(`
     CHECK (length(definition_fingerprint) = 64 AND definition_fingerprint NOT GLOB '*[^0-9a-f]*'),
     CHECK (outcome IS NULL OR outcome IN ('passed', 'command_failure', 'spawn_failure',
       'infrastructure_failure', 'evidence_persistence_failure', 'timeout',
-      'workspace_changed_before_start', 'user_stop', 'restart_loss', 'shutdown_loss')),
+      'workspace_changed_before_start', 'user_stop', 'restart_loss', 'shutdown_loss', 'ambiguous_process_loss')),
     CHECK (output_revision >= 0 AND retained_start_offset >= 0 AND retained_end_offset >= retained_start_offset
       AND total_persisted_bytes >= retained_end_offset),
     CHECK (output_retention_state IN ('retained', 'expired'))
@@ -3113,14 +3427,23 @@ ensureColumn('check_attempt_details', 'retained_output', "TEXT NOT NULL DEFAULT
 const checkAttemptSchema = db.prepare(`
   SELECT sql FROM sqlite_master WHERE type = 'table' AND name = 'check_attempt_details'
 `).get();
-if (checkAttemptSchema && !checkAttemptSchema.sql.includes('evidence_persistence_failure')) {
-    db.transaction(() => {
-        db.exec(`
-      DROP TRIGGER IF EXISTS preserve_check_attempt_snapshots;
-      DROP TRIGGER IF EXISTS preserve_completed_check_attempt_details;
-      ALTER TABLE check_attempt_details RENAME TO check_attempt_details_legacy;
-
-      CREATE TABLE check_attempt_details (
+if (checkAttemptSchema && (!checkAttemptSchema.sql.includes('evidence_persistence_failure')
+    || !checkAttemptSchema.sql.includes('ambiguous_process_loss'))) {
+    const foreignKeysEnabled = db.pragma('foreign_keys', { simple: true }) === 1;
+    if (foreignKeysEnabled) {
+        db.pragma('foreign_keys = OFF');
+    }
+    try {
+        const referencingTriggers = db.prepare(`
+      SELECT name FROM sqlite_master
+      WHERE type = 'trigger' AND sql LIKE '%check_attempt_details%'
+    `).all();
+        for (const trigger of referencingTriggers) {
+            db.exec(`DROP TRIGGER IF EXISTS "${trigger.name.replaceAll('"', '""')}"`);
+        }
+        db.transaction(() => {
+            db.exec(`
+      CREATE TABLE check_attempt_details_replacement (
         execution_run_id                TEXT PRIMARY KEY,
         batch_run_id                    TEXT NOT NULL,
         definition_id                  TEXT NOT NULL,
@@ -3146,13 +3469,13 @@ if (checkAttemptSchema && !checkAttemptSchema.sql.includes('evidence_persistence
         CHECK (length(definition_fingerprint) = 64 AND definition_fingerprint NOT GLOB '*[^0-9a-f]*'),
         CHECK (outcome IS NULL OR outcome IN ('passed', 'command_failure', 'spawn_failure',
           'infrastructure_failure', 'evidence_persistence_failure', 'timeout',
-          'workspace_changed_before_start', 'user_stop', 'restart_loss', 'shutdown_loss')),
+          'workspace_changed_before_start', 'user_stop', 'restart_loss', 'shutdown_loss', 'ambiguous_process_loss')),
         CHECK (output_revision >= 0 AND retained_start_offset >= 0 AND retained_end_offset >= retained_start_offset
           AND total_persisted_bytes >= retained_end_offset),
         CHECK (output_retention_state IN ('retained', 'expired'))
       );
 
-      INSERT INTO check_attempt_details (
+      INSERT INTO check_attempt_details_replacement (
         execution_run_id, batch_run_id, definition_id, command_snapshot_json, definition_fingerprint,
         initial_workspace_identity_json, final_workspace_identity_json, outcome, rerun_of_attempt_run_id,
         exit_code, exit_signal, exit_error, output_revision, retained_start_offset, retained_end_offset,
@@ -3163,11 +3486,22 @@ if (checkAttemptSchema && !checkAttemptSchema.sql.includes('evidence_persistence
         initial_workspace_identity_json, final_workspace_identity_json, outcome, rerun_of_attempt_run_id,
         exit_code, exit_signal, exit_error, output_revision, retained_start_offset, retained_end_offset,
         total_persisted_bytes, retained_output, output_retention_state
-      FROM check_attempt_details_legacy;
+      FROM check_attempt_details;
 
-      DROP TABLE check_attempt_details_legacy;
-    `);
-    })();
+      DROP TABLE check_attempt_details;
+      ALTER TABLE check_attempt_details_replacement RENAME TO check_attempt_details;
+      `);
+        })();
+    }
+    finally {
+        if (foreignKeysEnabled) {
+            db.pragma('foreign_keys = ON');
+        }
+    }
+    const foreignKeyViolation = db.pragma('foreign_key_check')[0];
+    if (foreignKeyViolation) {
+        throw new Error(`Check attempt migration left an invalid foreign key: ${JSON.stringify(foreignKeyViolation)}`);
+    }
 }
 db.exec(`
   CREATE TABLE IF NOT EXISTS check_attempt_diagnostic_parsers (