@straiffi/archon 1.8.12 → 1.8.13

package/dist/server/index.js

@@ -50,7 +50,7 @@ import { getProjectFileManifest, ProjectFileContentError, ProjectFileTargetUnava
 import { updateProjectTargetSelection } from './lib/projectTargets.js';
 import { hasActiveBundleSpecWork } from './lib/specWorkspaceActivity.js';
 import { exportProjectMemoryArchive, importProjectMemoryArchive } from './lib/projectMemoryTransfer.js';
-import { buildReviewFindingsResponse, computeDiffSignature, getLatestReviewRunForContext, listReviewFindings } from './lib/reviewFindings.js';
+import { buildReviewFindingsResponse, computeDiffSignature, getLatestCompletedReviewRunForContext, listReviewFindings } from './lib/reviewFindings.js';
 import { formatBuildOpenQuestionAnswersPrompt, getLatestBuildOpenQuestionBatchStatus, hasActiveBuildOpenQuestionBatch, listBuildOpenQuestionsForBundle, loadBuildOpenQuestionsByBundleIds, } from './lib/buildOpenQuestions.js';
 import { acceptBuildOpenQuestionResolution } from './lib/buildOpenQuestionOperations.js';
 import { areBundleTicketsReadyForAutomaticReview } from './lib/bundleAutomationReadiness.js';
@@ -108,11 +108,12 @@ import { getBundleReviewRecovery, recoverBundleReview, rerunTicketReviewOperatio
 import { resolveReviewContinuation } from './workers/review.js';
 import { clearTicketStageSnapshots, getActiveBundleStageChangeHead, reconcileStageSnapshots, undoTicketStage } from './lib/ticketUndo.js';
 import { closeAllTerminalSessions, createProjectTerminalSession, createTerminalSessionForWorkspace, destroyTerminalSessionById, registerTerminalSocketHandlers, } from './lib/terminal.js';
-import { countBundleTickets, createTicketRecord, createBundle, deleteBundle, ensureProjectRootBundle, autoParkTicketIfStale, autoParkSettledBundleTicket, isBundleSettledForAutoPark, clearAutoParkDismissalIfNeeded, assignTicketDoneOrder, assignTicketLaneOrder, getBundle, getBundleByName, getBundleByBranch, getBundleRepresentativeTicketContext, isProjectRootBundle, getTicket, isBundledTicket, listTicketsInRunContext, listBundles, listBoardTicketEnrichment, listTickets, resolveTicketBranch, resolveTicketTool, updateBundleAutomationConfig, updateBundleIdentity, } from './lib/tickets.js';
+import { countBundleTickets, createTicketRecord, createBundle, deleteBundle, ensureProjectRootBundle, autoParkTicketIfStale, autoParkSettledBundleTicket, isBundleSettledForAutoPark, clearAutoParkDismissalIfNeeded, assignTicketDoneOrder, assignTicketLaneOrder, getBundle, getBundleByName, getBundleByBranch, getBundleRepresentativeTicketContext, isProjectRootBundle, getTicket, isBundledTicket, listTicketsInRunContext, listBundles, listBoardTicketEnrichment, listTickets, resolveTicketBranch, resolveTicketTool, updateBundleAutomationConfig, updateBundleReviewerConfig, updateBundleIdentity, } from './lib/tickets.js';
 import { createTicketMessage, upsertTicketDescriptionMessage } from './lib/ticketMessages.js';
 import { listAgentRunsForExecutionRun, listAgentRunsForParent, terminalizeAgentRunsForExecutionRun } from './lib/agentRuns.js';
 import { HttpError } from './lib/httpError.js';
 import { parseIncomingExternalSource } from './lib/externalSource.js';
+import { resolveReviewerConfig } from './lib/reviewerConfig.js';
 import { materializeTicketsWithDependencies } from './lib/ticketBatch.js';
 import { IMPLEMENTATION_READY_DESCRIPTION_SECTION_HEADINGS } from './lib/ticketDescriptionContract.js';
 import { buildImplementationResourcesAppendix, buildSpecImplementationDraft, buildVisualizationAppendix } from './lib/specDraft.js';
@@ -1541,6 +1542,9 @@ const serializeBundleRow = (projectId, bundle, openQuestions = bundle ? loadBuil
     const effectivePolicy = resolveEffectiveRequiredCheckPolicyMembership(project);
     return {
         ...bundle,
+        reviewer_model: bundle.kind === 'project_root' ? null : bundle.reviewer_model ?? null,
+        reviewer_variant: bundle.kind === 'project_root' || !bundle.reviewer_model ? null : bundle.reviewer_variant ?? null,
+        reviewer_config: resolveReviewerConfig(bundle.kind === 'project_root' ? null : bundle, project),
         has_prepared_worktree: hasPreparedWorktree,
         pull_request: getGitHubConnectionConfig(projectId)
             ? serializeBundlePullRequest(getBundlePullRequestRecord(bundle.id, projectId))
@@ -2083,7 +2087,7 @@ const getBundleReviewFindings = async (projectId, bundleId) => {
         projectId,
         worktreeBundleId: representativeTicket.worktree_bundle_id,
     };
-    const latestReviewRun = getLatestReviewRunForContext(context);
+    const latestReviewRun = getLatestCompletedReviewRunForContext(context);
     return buildReviewFindingsResponse({
         context,
         isContextRunning: tickets.some(ticket => ticket.agent_status === 'running'),
@@ -2103,7 +2107,7 @@ const getTicketReviewFindings = async (ticketId) => {
         projectId: ticket.project_id,
         worktreeBundleId: ticket.worktree_bundle_id,
     };
-    const latestReviewRun = getLatestReviewRunForContext(context);
+    const latestReviewRun = getLatestCompletedReviewRunForContext(context);
     return buildReviewFindingsResponse({
         context,
         isContextRunning: ticket.agent_status === 'running',
@@ -3867,7 +3871,7 @@ app.post('/bundles', async (req, res) => {
             });
         }
     }
-    res.status(201).json(bundle);
+    res.status(201).json(serializeBundleRow(result.project.id, bundle, [], result.project));
 });
 app.delete('/bundles/:id', (req, res) => {
     const result = getRequiredProject(req);
@@ -3935,6 +3939,7 @@ app.patch('/bundles/:id', (req, res) => {
         return res.status(404).json({ error: 'Bundle not found' });
     }
     const hasNameUpdate = hasOwn(req.body, 'name');
+    const hasReviewerUpdate = hasOwn(req.body, 'reviewer_model') || hasOwn(req.body, 'reviewer_variant');
     if (hasOwn(req.body, 'required_check_policy_override')) {
         return res.status(400).json({ error: 'Bundle required-check policy overrides are no longer supported; configure required checks on the project' });
     }
@@ -3942,7 +3947,9 @@ app.patch('/bundles/:id', (req, res) => {
         return res.status(409).json({
             error: hasNameUpdate
                 ? 'Project root bundles cannot be renamed'
-                : 'Project root bundle automation cannot be overridden',
+                : hasReviewerUpdate
+                    ? 'Project root bundle reviewer configuration cannot be overridden'
+                    : 'Project root bundle automation cannot be overridden',
         });
     }
     let nextName = bundle.name;
@@ -4028,6 +4035,37 @@ app.patch('/bundles/:id', (req, res) => {
             return res.status(400).json({ error: 'automation_review_max_iterations must be an integer between 1 and 10' });
         }
     }
+    let reviewerModel = bundle.reviewer_model ?? null;
+    let reviewerVariant = reviewerModel ? bundle.reviewer_variant ?? null : null;
+    if (hasOwn(req.body, 'reviewer_model')) {
+        const value = req.body.reviewer_model;
+        if (value == null) {
+            reviewerModel = null;
+            reviewerVariant = null;
+        }
+        else {
+            const normalized = normalizeModelId(value);
+            if (!normalized) {
+                return res.status(400).json({ error: 'reviewer_model must be a valid model id' });
+            }
+            reviewerModel = normalized;
+            if (!hasOwn(req.body, 'reviewer_variant')) {
+                reviewerVariant = null;
+            }
+        }
+    }
+    if (hasOwn(req.body, 'reviewer_variant')) {
+        const value = req.body.reviewer_variant;
+        if (value == null) {
+            reviewerVariant = null;
+        }
+        else if (typeof value === 'string' && value.trim()) {
+            reviewerVariant = reviewerModel ? value.trim() : null;
+        }
+        else {
+            return res.status(400).json({ error: 'reviewer_variant must be a non-empty string' });
+        }
+    }
     let updated = null;
     try {
         updated = db.transaction(() => {
@@ -4039,7 +4077,7 @@ app.patch('/bundles/:id', (req, res) => {
                     branch: nextBranch,
                 });
             }
-            return updateBundleAutomationConfig({
+            updateBundleAutomationConfig({
                 bundleId: bundle.id,
                 projectId: result.project.id,
                 automationDepth,
@@ -4047,6 +4085,12 @@ app.patch('/bundles/:id', (req, res) => {
                 automationPauseOnOpenQuestions,
                 automationReviewMaxIterations,
             });
+            return updateBundleReviewerConfig({
+                bundleId: bundle.id,
+                projectId: result.project.id,
+                reviewerModel,
+                reviewerVariant,
+            });
         })();
     }
     catch (error) {
@@ -5968,7 +6012,7 @@ app.post('/projects', (req, res) => {
         return res.status(400).json({ error: validation.error });
     }
     const projectCount = Number(db.prepare('SELECT COUNT(*) AS count FROM projects').get()?.count ?? 0);
-    const { name, repo_path, linked_project_ids, run_setup, run_services, check_definitions, required_check_definition_ids, pre_review_check_definition_ids, post_build_check_definition_ids, auto_fix_check_definition_ids, test_commands, run_ide, preview_service_name, preview_path, preview_capability_mode, helper_model, helper_variant, commit_message_rules, commit_after_each_ticket, auto_park_stale_tickets, memory_enabled, scan_include_globs_json, scan_exclude_globs_json, worktree_sync, spec_aware_code_review_enabled, automation_depth, automation_review_fix_enabled, automation_pause_on_open_questions, automation_review_severity, automation_review_max_iterations, } = validation.values;
+    const { name, repo_path, linked_project_ids, run_setup, run_services, check_definitions, required_check_definition_ids, pre_review_check_definition_ids, post_build_check_definition_ids, auto_fix_check_definition_ids, test_commands, run_ide, preview_service_name, preview_path, preview_capability_mode, helper_model, helper_variant, reviewer_model, reviewer_variant, commit_message_rules, commit_after_each_ticket, auto_park_stale_tickets, memory_enabled, scan_include_globs_json, scan_exclude_globs_json, worktree_sync, spec_aware_code_review_enabled, automation_depth, automation_review_fix_enabled, automation_pause_on_open_questions, automation_review_severity, automation_review_max_iterations, } = validation.values;
     if (!repo_path) {
         return res.status(400).json({ error: 'repo_path must be a non-empty string' });
     }
@@ -6000,6 +6044,8 @@ app.post('/projects', (req, res) => {
       preview_capability_mode,
       helper_model,
       helper_variant,
+      reviewer_model,
+      reviewer_variant,
       commit_message_rules,
       commit_after_each_ticket,
       auto_park_stale_tickets,
@@ -6014,8 +6060,8 @@ app.post('/projects', (req, res) => {
       automation_review_severity,
       automation_review_max_iterations
     )
-    VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
-  `).run(id, name, normalizedRepoPath, run_setup, run_services, check_definitions, required_check_definition_ids ?? '[]', pre_review_check_definition_ids ?? '[]', post_build_check_definition_ids ?? '[]', auto_fix_check_definition_ids ?? '[]', test_commands, run_ide ?? null, preview_service_name ?? null, preview_path ?? null, preview_capability_mode ?? null, helper_model ?? null, helper_variant ?? null, commit_message_rules ?? null, commit_after_each_ticket ?? 0, auto_park_stale_tickets ?? 0, memory_enabled ?? 0, scan_include_globs_json ?? null, scan_exclude_globs_json ?? null, worktree_sync ?? null, spec_aware_code_review_enabled ?? 0, automation_depth ?? 'manual', automation_review_fix_enabled ?? 0, automation_pause_on_open_questions ?? 0, automation_review_severity ?? 'medium', automation_review_max_iterations ?? 3);
+    VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
+  `).run(id, name, normalizedRepoPath, run_setup, run_services, check_definitions, required_check_definition_ids ?? '[]', pre_review_check_definition_ids ?? '[]', post_build_check_definition_ids ?? '[]', auto_fix_check_definition_ids ?? '[]', test_commands, run_ide ?? null, preview_service_name ?? null, preview_path ?? null, preview_capability_mode ?? null, helper_model ?? null, helper_variant ?? null, reviewer_model ?? null, reviewer_model ? reviewer_variant ?? null : null, commit_message_rules ?? null, commit_after_each_ticket ?? 0, auto_park_stale_tickets ?? 0, memory_enabled ?? 0, scan_include_globs_json ?? null, scan_exclude_globs_json ?? null, worktree_sync ?? null, spec_aware_code_review_enabled ?? 0, automation_depth ?? 'manual', automation_review_fix_enabled ?? 0, automation_pause_on_open_questions ?? 0, automation_review_severity ?? 'medium', automation_review_max_iterations ?? 3);
     replaceProjectLinks(id, linked_project_ids ?? []);
     ensureProjectRootBundle(id);
     if (projectCount === 0) {
@@ -7222,7 +7268,7 @@ app.patch('/projects/:id', (req, res) => {
             });
         }
     }
-    const { name, repo_path, linked_project_ids, run_setup, run_services, check_definitions, required_check_definition_ids, pre_review_check_definition_ids, post_build_check_definition_ids, auto_fix_check_definition_ids, test_commands, run_ide, preview_service_name, preview_path, preview_capability_mode, helper_model, helper_variant, commit_message_rules, commit_after_each_ticket, auto_park_stale_tickets, memory_enabled, scan_include_globs_json, scan_exclude_globs_json, worktree_sync, spec_aware_code_review_enabled, automation_depth, automation_review_fix_enabled, automation_pause_on_open_questions, automation_review_severity, automation_review_max_iterations, } = validation.values;
+    const { name, repo_path, linked_project_ids, run_setup, run_services, check_definitions, required_check_definition_ids, pre_review_check_definition_ids, post_build_check_definition_ids, auto_fix_check_definition_ids, test_commands, run_ide, preview_service_name, preview_path, preview_capability_mode, helper_model, helper_variant, reviewer_model, reviewer_variant, commit_message_rules, commit_after_each_ticket, auto_park_stale_tickets, memory_enabled, scan_include_globs_json, scan_exclude_globs_json, worktree_sync, spec_aware_code_review_enabled, automation_depth, automation_review_fix_enabled, automation_pause_on_open_questions, automation_review_severity, automation_review_max_iterations, } = validation.values;
     const updateProject = db.prepare(`
     UPDATE projects SET
       name = ?,
@@ -7241,6 +7287,8 @@ app.patch('/projects/:id', (req, res) => {
       preview_capability_mode = ?,
       helper_model = ?,
       helper_variant = ?,
+      reviewer_model = ?,
+      reviewer_variant = ?,
       commit_message_rules = ?,
       commit_after_each_ticket = ?,
       auto_park_stale_tickets = ?,
@@ -7270,6 +7318,10 @@ app.patch('/projects/:id', (req, res) => {
     const nextAutoFixCheckDefinitionIds = hasOwn(validation.values, 'auto_fix_check_definition_ids')
         ? auto_fix_check_definition_ids ?? '[]'
         : project.auto_fix_check_definition_ids;
+    const nextReviewerModel = hasOwn(validation.values, 'reviewer_model') ? reviewer_model ?? null : project.reviewer_model;
+    const nextReviewerVariant = nextReviewerModel
+        ? (hasOwn(validation.values, 'reviewer_variant') ? reviewer_variant ?? null : project.reviewer_variant)
+        : null;
     const updateResult = db.transaction(() => {
         const policyReferences = validateProjectRequiredCheckPolicyReferences({
             projectId: project.id,
@@ -7282,7 +7334,7 @@ app.patch('/projects/:id', (req, res) => {
         if ('error' in policyReferences) {
             return policyReferences;
         }
-        updateProject.run(name ?? project.name, repo_path ?? project.repo_path, hasOwn(validation.values, 'run_setup') ? run_setup : project.run_setup, hasOwn(validation.values, 'run_services') ? run_services : project.run_services, nextCheckDefinitions, nextRequiredCheckDefinitionIds, nextPreReviewCheckDefinitionIds, nextPostBuildCheckDefinitionIds, nextAutoFixCheckDefinitionIds, hasOwn(validation.values, 'test_commands') ? test_commands : project.test_commands, hasOwn(validation.values, 'run_ide') ? run_ide : project.run_ide, hasOwn(validation.values, 'preview_service_name') ? preview_service_name : project.preview_service_name, hasOwn(validation.values, 'preview_path') ? preview_path : project.preview_path, hasOwn(validation.values, 'preview_capability_mode') ? preview_capability_mode : project.preview_capability_mode, hasOwn(validation.values, 'helper_model') ? helper_model : project.helper_model, hasOwn(validation.values, 'helper_variant') ? helper_variant : project.helper_variant, hasOwn(validation.values, 'commit_message_rules') ? commit_message_rules : project.commit_message_rules, hasOwn(validation.values, 'commit_after_each_ticket') ? commit_after_each_ticket : project.commit_after_each_ticket, hasOwn(validation.values, 'auto_park_stale_tickets') ? auto_park_stale_tickets : project.auto_park_stale_tickets, hasOwn(validation.values, 'memory_enabled') ? memory_enabled : project.memory_enabled, hasOwn(validation.values, 'scan_include_globs_json') ? scan_include_globs_json : project.scan_include_globs_json, hasOwn(validation.values, 'scan_exclude_globs_json') ? scan_exclude_globs_json : project.scan_exclude_globs_json, hasOwn(validation.values, 'worktree_sync') ? worktree_sync : project.worktree_sync, hasOwn(validation.values, 'spec_aware_code_review_enabled') ? spec_aware_code_review_enabled : project.spec_aware_code_review_enabled, hasOwn(validation.values, 'automation_depth') ? automation_depth : project.automation_depth, hasOwn(validation.values, 'automation_review_fix_enabled') ? automation_review_fix_enabled : project.automation_review_fix_enabled, hasOwn(validation.values, 'automation_pause_on_open_questions') ? automation_pause_on_open_questions : project.automation_pause_on_open_questions, hasOwn(validation.values, 'automation_review_severity') ? automation_review_severity : project.automation_review_severity, hasOwn(validation.values, 'automation_review_max_iterations') ? automation_review_max_iterations : project.automation_review_max_iterations, req.params.id);
+        updateProject.run(name ?? project.name, repo_path ?? project.repo_path, hasOwn(validation.values, 'run_setup') ? run_setup : project.run_setup, hasOwn(validation.values, 'run_services') ? run_services : project.run_services, nextCheckDefinitions, nextRequiredCheckDefinitionIds, nextPreReviewCheckDefinitionIds, nextPostBuildCheckDefinitionIds, nextAutoFixCheckDefinitionIds, hasOwn(validation.values, 'test_commands') ? test_commands : project.test_commands, hasOwn(validation.values, 'run_ide') ? run_ide : project.run_ide, hasOwn(validation.values, 'preview_service_name') ? preview_service_name : project.preview_service_name, hasOwn(validation.values, 'preview_path') ? preview_path : project.preview_path, hasOwn(validation.values, 'preview_capability_mode') ? preview_capability_mode : project.preview_capability_mode, hasOwn(validation.values, 'helper_model') ? helper_model : project.helper_model, hasOwn(validation.values, 'helper_variant') ? helper_variant : project.helper_variant, nextReviewerModel, nextReviewerVariant, hasOwn(validation.values, 'commit_message_rules') ? commit_message_rules : project.commit_message_rules, hasOwn(validation.values, 'commit_after_each_ticket') ? commit_after_each_ticket : project.commit_after_each_ticket, hasOwn(validation.values, 'auto_park_stale_tickets') ? auto_park_stale_tickets : project.auto_park_stale_tickets, hasOwn(validation.values, 'memory_enabled') ? memory_enabled : project.memory_enabled, hasOwn(validation.values, 'scan_include_globs_json') ? scan_include_globs_json : project.scan_include_globs_json, hasOwn(validation.values, 'scan_exclude_globs_json') ? scan_exclude_globs_json : project.scan_exclude_globs_json, hasOwn(validation.values, 'worktree_sync') ? worktree_sync : project.worktree_sync, hasOwn(validation.values, 'spec_aware_code_review_enabled') ? spec_aware_code_review_enabled : project.spec_aware_code_review_enabled, hasOwn(validation.values, 'automation_depth') ? automation_depth : project.automation_depth, hasOwn(validation.values, 'automation_review_fix_enabled') ? automation_review_fix_enabled : project.automation_review_fix_enabled, hasOwn(validation.values, 'automation_pause_on_open_questions') ? automation_pause_on_open_questions : project.automation_pause_on_open_questions, hasOwn(validation.values, 'automation_review_severity') ? automation_review_severity : project.automation_review_severity, hasOwn(validation.values, 'automation_review_max_iterations') ? automation_review_max_iterations : project.automation_review_max_iterations, req.params.id);
         if (hasOwn(validation.values, 'linked_project_ids')) {
             replaceProjectLinks(project.id, linked_project_ids ?? []);
         }