@straiffi/archon 1.7.3 → 1.7.4

package/dist/server/index.js

@@ -54,7 +54,9 @@ import { clearAutomationPause, countBlockingFindings, depthAtLeast, getBundleAut
 import { runAutomationCommitChain } from './lib/ticketAutomationCommit.js';
 import { getDiscoveredSkills, normalizeSkillNames } from './lib/skills.js';
 import { clearAllPreviewProxies } from './lib/previewProxy.js';
-import { createExecutionRun, addExecutionRunLink, addExecutionRunLinks, getExecutionRun, hasActiveBuildExecutionRunForTicket, getGitHubActionsExecutionDetails, hasDirectRetryChild, getTestExecutionDetails, GitHubActionsDispatchConflictError, listExecutionRunLinks, listExecutionRuns, listProjectLifecycleEvents, toCanonicalLifecycleEvent, transitionExecutionRun, withExecutionRunTransaction, } from './lib/executionRuns.js';
+import { createExecutionRun, addExecutionRunLink, addExecutionRunLinks, getExecutionRun, hasActiveBuildExecutionRunForTicket, getGitHubActionsExecutionDetails, getTestExecutionDetails, GitHubActionsDispatchConflictError, listExecutionRunLinks, listExecutionRuns, listLifecycleEvents, listProjectLifecycleEvents, toCanonicalLifecycleEvent, transitionExecutionRun, withExecutionRunTransaction, } from './lib/executionRuns.js';
+import { dispatchExecutionRetry, getExecutionRetryEligibility, resolveExecutionRetry } from './lib/executionRetry.js';
+import { listExecutionTimeline } from './lib/executionTimeline.js';
 import { cleanupAllExecutionEvidence, EXECUTION_EVIDENCE_CLEANUP_INTERVAL_MS, resolveExecutionEvidenceRetentionDays, } from './lib/executionRunRetention.js';
 import { shutdownRealtimeServer } from './lib/shutdown.js';
 import { resolveClientBuildPaths, shouldServeClientApp, STATIC_CLIENT_DIRECTORY_OPTIONS, STATIC_CLIENT_INDEX_OPTIONS, } from './lib/staticClient.js';
@@ -72,7 +74,7 @@ import { buildCommitMessagePrompt, normalizeGeneratedCommitMessage } from './lib
 import { BUNDLE_PULL_REQUEST_SYNC_TTL_MS, getBundlePullRequestRecord, hasOpenBundlePullRequest, serializeBundlePullRequest, shouldSyncBundlePullRequest, syncTrackedBundlePullRequestIfNeeded, upsertBundlePullRequest, upsertBundlePullRequestFromGitHub, } from './lib/bundlePullRequests.js';
 import { countInboundProjectLinks, getEffectiveProject, getProjectById, getProjectTicketStats, hasProjectRunIde, listProjects, replaceProjectLinks, serializeProject, updateProjectActiveTarget, validateProjectPayload, } from './lib/projects.js';
 import { getActiveRunStatus, getActiveRunStatusForProject, getPreviewStatusForProject, hasRunConfig, isRunning, openIde, openTicketIdeInWorkspace, resolveProjectRunContextKey, runSetupCommandsInWorkspace, runTicketInWorkspace, stopAllTickets, stopTicket } from './lib/run.js';
-import { clearAllTestSessions, createTestSession, deleteTestSession, discoverTestsForSession, doesTestFileExist, doesTestFileExistForSession, findProjectTestCommand, getTestSession, isTestSelectionSupported, startTestSessionRun, stopTestSessionRun } from './lib/testSessions.js';
+import { clearAllTestSessions, createTestSession, deleteTestSession, discoverTestsForSession, doesTestFileExistForSession, findProjectTestCommand, getTestSession, isTestSelectionSupported, startTestSessionRun, stopTestSessionRun } from './lib/testSessions.js';
 import { getBundleBuildBlockerResponse, shouldStartBundleBuildNow, transitionTicketState, } from './lib/ticketWorkflowOperations.js';
 import { submitPlanTicketFollowUp, submitTicketFollowUp, } from './lib/ticketFollowUpOperations.js';
 import { canUseBuildControls, formatActiveRunConflict, getTicketRunReadinessError, resumeBuildTicketRun, runProjectTarget, runTicketRun, stopBuildTicketRun, stopReviewTicketRun, stopProjectTargetRun, stopTicketRun, } from './lib/ticketRunOperations.js';
@@ -167,6 +169,44 @@ const parseLifecycleListQuery = (query) => {
         limit,
     };
 };
+const parseExecutionTimelineScope = (projectId, query) => {
+    const hasScopeType = query.scope_type != null && query.scope_type !== '';
+    const hasScopeId = query.scope_id != null && query.scope_id !== '';
+    if (hasScopeType !== hasScopeId) {
+        return { error: 'scope_type and scope_id must be provided together' };
+    }
+    if (!hasScopeType) {
+        return { scopeEntity: undefined };
+    }
+    if (typeof query.scope_type !== 'string' || typeof query.scope_id !== 'string') {
+        return { error: 'scope_type and scope_id must be strings' };
+    }
+    const scopeType = query.scope_type;
+    const scopeId = query.scope_id.trim();
+    if (!['ticket', 'bundle', 'chat_session', 'spec_session'].includes(scopeType)) {
+        return { error: 'scope_type must be ticket, bundle, chat_session, or spec_session' };
+    }
+    if (!scopeId) {
+        return { error: 'scope_id must not be empty' };
+    }
+    const table = scopeType === 'ticket'
+        ? 'tickets'
+        : scopeType === 'bundle'
+            ? 'worktree_bundles'
+            : scopeType === 'chat_session'
+                ? 'chat_sessions'
+                : 'spec_sessions';
+    const exists = db.prepare(`SELECT 1 FROM ${table} WHERE id = ? AND project_id = ?`).get(scopeId, projectId);
+    if (!exists) {
+        return { error: 'Scope not found', status: 404 };
+    }
+    return {
+        scopeEntity: {
+            type: scopeType,
+            id: scopeId,
+        },
+    };
+};
 const serializeTestExecutionDetail = (details, retryEligibility) => {
     if (!details) {
         return { kind: 'test', available: false, retry_eligibility: retryEligibility };
@@ -947,63 +987,6 @@ const parseTestTargetSelection = (value) => {
     }
     return null;
 };
-const unavailableTestRetry = (reason, status, message) => ({
-    eligibility: { eligible: false, reason },
-    error: { status, message },
-});
-const resolveTestRetry = (project, executionRun, details) => {
-    if (!executionRun || executionRun.kind !== 'test' || !details) {
-        return unavailableTestRetry('details_unavailable', 404, 'Test execution run not found');
-    }
-    if (!['failed', 'cancelled', 'interrupted'].includes(executionRun.status)) {
-        return unavailableTestRetry('run_not_terminal', 409, 'Only failed, cancelled, or interrupted test runs can be retried.');
-    }
-    if (hasDirectRetryChild(executionRun.id)) {
-        return unavailableTestRetry('retry_already_created', 409, 'A retry has already been created for this test run.');
-    }
-    if (!details.command_id) {
-        return unavailableTestRetry('command_unidentifiable', 409, 'The original test command is no longer identifiable.');
-    }
-    const command = findProjectTestCommand(project, details.command_id);
-    if (!command) {
-        return unavailableTestRetry('command_missing', 404, 'Test command not found');
-    }
-    const selection = parseTestTargetSelection(details.selection);
-    if (!selection) {
-        return unavailableTestRetry('selection_invalid', 409, 'The original test selection is no longer valid.');
-    }
-    let workspace;
-    if (details.ticket_id) {
-        const ticket = getTicket(details.ticket_id);
-        if (!ticket || ticket.project_id !== project.id) {
-            return unavailableTestRetry('target_missing', 404, 'Ticket not found');
-        }
-        workspace = resolveTicketTestWorkspace(ticket);
-    }
-    else if (details.target_kind === 'repo_root' || details.target_kind === 'bundle') {
-        workspace = resolveExplicitProjectTestWorkspace(project, details.target_kind, details.target_bundle_id);
-    }
-    else {
-        return unavailableTestRetry('target_invalid', 409, 'The original test target is no longer valid.');
-    }
-    if ('error' in workspace) {
-        return unavailableTestRetry('target_unavailable', workspace.status, workspace.error);
-    }
-    if (!isTestSelectionSupported(command, selection, workspace.cwd)) {
-        return unavailableTestRetry('selection_unsupported', 409, 'The selected test command only supports running the full suite.');
-    }
-    if (selection.kind !== 'all' && !doesTestFileExist(workspace.cwd, selection.path, command)) {
-        return unavailableTestRetry('test_file_missing', 404, 'Selected test file no longer exists in this target workspace.');
-    }
-    return {
-        eligibility: { eligible: true, reason: null },
-        details,
-        executionRun,
-        command,
-        selection,
-        workspace,
-    };
-};
 const resolveProjectFileSuggestionWorkspace = (project, options = {}) => {
     const ticketId = options.ticketId?.trim() || null;
     if (ticketId) {
@@ -7582,6 +7565,70 @@ app.get('/projects/:id/lifecycle-events', (req, res) => {
         throw error;
     }
 });
+app.get('/projects/:id/execution-timeline', (req, res) => {
+    const project = getProjectById(req.params.id);
+    if (!project) {
+        return res.status(404).json({ error: 'Not found' });
+    }
+    const query = parseLifecycleListQuery(req.query);
+    if ('error' in query) {
+        return res.status(400).json({ error: query.error });
+    }
+    const scope = parseExecutionTimelineScope(project.id, req.query);
+    if ('error' in scope) {
+        return res.status(scope.status ?? 400).json({ error: scope.error });
+    }
+    try {
+        return res.json(listExecutionTimeline({
+            project,
+            kind: query.kind,
+            statuses: query.statuses,
+            cursor: query.cursor,
+            limit: query.limit,
+            scope: scope.scopeEntity,
+        }));
+    }
+    catch (error) {
+        if (error instanceof Error && error.message === 'Invalid execution run cursor') {
+            return res.status(400).json({ error: 'cursor must be a valid execution run cursor' });
+        }
+        throw error;
+    }
+});
+app.get('/projects/:id/execution-timeline/:runId', (req, res) => {
+    const project = getProjectById(req.params.id);
+    if (!project) {
+        return res.status(404).json({ error: 'Not found' });
+    }
+    const scope = parseExecutionTimelineScope(project.id, req.query);
+    if ('error' in scope) {
+        return res.status(scope.status ?? 400).json({ error: scope.error });
+    }
+    const run = getExecutionRun(project.id, req.params.runId);
+    if (!run) {
+        return res.status(404).json({ error: 'Execution run not found' });
+    }
+    const links = listExecutionRunLinks(project.id, run.id);
+    if (scope.scopeEntity && !links.some(link => link.entity_type === scope.scopeEntity?.type && link.entity_id === scope.scopeEntity.id)) {
+        return res.status(404).json({ error: 'Execution run not found' });
+    }
+    const testDetails = run.kind === 'test' ? getTestExecutionDetails(project.id, run.id) : null;
+    const retryEligibility = getExecutionRetryEligibility(project.id, run.id);
+    const details = run.kind === 'test'
+        ? serializeTestExecutionDetail(testDetails, retryEligibility)
+        : run.kind === 'github_actions'
+            ? { ...serializeGitHubActionsExecutionDetail(getGitHubActionsExecutionDetails(project.id, run.id)), retry_eligibility: retryEligibility }
+            : ['automation_commit', 'automation_push', 'automation_pull_request'].includes(run.kind)
+                ? { kind: run.kind, available: true, automation_stage: getAutomationStageDetails(project.id, run.id), retry_eligibility: retryEligibility }
+                : { kind: run.kind, available: true, retry_eligibility: retryEligibility };
+    return res.json({
+        run,
+        links,
+        events: listLifecycleEvents(project.id, run.id).map(toCanonicalLifecycleEvent),
+        details,
+        agent_runs: listAgentRunsForExecutionRun(run.id),
+    });
+});
 app.get('/projects/:id/execution-runs/:runId', (req, res) => {
     const project = getProjectById(req.params.id);
     if (!project) {
@@ -7592,46 +7639,55 @@ app.get('/projects/:id/execution-runs/:runId', (req, res) => {
         return res.status(404).json({ error: 'Execution run not found' });
     }
     const testDetails = run.kind === 'test' ? getTestExecutionDetails(project.id, run.id) : null;
+    const retryEligibility = getExecutionRetryEligibility(project.id, run.id);
     const details = run.kind === 'test'
-        ? serializeTestExecutionDetail(testDetails, resolveTestRetry(project, run, testDetails).eligibility)
+        ? serializeTestExecutionDetail(testDetails, retryEligibility)
         : run.kind === 'github_actions'
-            ? serializeGitHubActionsExecutionDetail(getGitHubActionsExecutionDetails(project.id, run.id))
-            : { kind: run.kind, available: true };
+            ? { ...serializeGitHubActionsExecutionDetail(getGitHubActionsExecutionDetails(project.id, run.id)), retry_eligibility: retryEligibility }
+            : ['automation_commit', 'automation_push', 'automation_pull_request'].includes(run.kind)
+                ? { kind: run.kind, available: true, automation_stage: getAutomationStageDetails(project.id, run.id), retry_eligibility: retryEligibility }
+                : { kind: run.kind, available: true, retry_eligibility: retryEligibility };
     const links = listExecutionRunLinks(project.id, run.id);
     const agentRuns = listAgentRunsForExecutionRun(run.id);
-    return res.json({ run, links, details, agent_runs: agentRuns });
+    const events = listLifecycleEvents(project.id, run.id).map(toCanonicalLifecycleEvent);
+    return res.json({ run, links, events, details, agent_runs: agentRuns });
 });
 app.post('/projects/:id/execution-runs/:runId/retry', async (req, res) => {
     const project = getProjectById(req.params.id);
     if (!project) {
         return res.status(404).json({ error: 'Not found' });
     }
-    const executionRun = getExecutionRun(project.id, req.params.runId);
-    const details = getTestExecutionDetails(project.id, req.params.runId);
-    const retry = resolveTestRetry(project, executionRun, details);
-    if ('error' in retry) {
-        return res.status(retry.error.status).json({ error: retry.error.message });
-    }
-    const session = createTestSession({
-        projectId: project.id,
-        ticketId: retry.details.ticket_id,
-        targetKind: retry.workspace.target_kind,
-        targetBundleId: retry.workspace.target_bundle_id,
-        cwd: retry.workspace.cwd,
-        targetLabel: retry.workspace.target_label,
+    const resolution = resolveExecutionRetry(project.id, req.params.runId);
+    const result = await dispatchExecutionRetry(resolution, io, async (retry) => {
+        const session = createTestSession({
+            projectId: project.id,
+            ticketId: retry.ticketId,
+            targetKind: retry.workspace.target_kind,
+            targetBundleId: retry.workspace.target_bundle_id,
+            cwd: retry.workspace.cwd,
+            targetLabel: retry.workspace.target_label,
+        });
+        try {
+            const started = await startTestSessionRun(session.id, project, {
+                command: retry.command,
+                selection: retry.selection,
+                retryOfRunId: req.params.runId,
+                deleteOnComplete: true,
+            }, io);
+            if (!started.run_id) {
+                throw new Error('Test retry did not create a replacement execution');
+            }
+            return started.run_id;
+        }
+        catch (error) {
+            await deleteTestSession(session.id, io).catch(() => undefined);
+            throw error;
+        }
     });
-    try {
-        return res.status(201).json(await startTestSessionRun(session.id, project, {
-            command: retry.command,
-            selection: retry.selection,
-            retryOfRunId: retry.executionRun.id,
-            deleteOnComplete: true,
-        }, io));
-    }
-    catch (error) {
-        await deleteTestSession(session.id, io).catch(() => undefined);
-        return res.status(409).json({ error: getErrorMessage(error) });
+    if (!result.ok) {
+        return res.status(result.status).json({ error: result.error, reason: result.reason });
     }
+    return res.status(201).json(result.value);
 });
 app.post('/tickets/:id/test-sessions', (req, res) => {
     const ticket = getTicket(req.params.id);
@@ -7735,7 +7791,7 @@ app.post('/test-sessions/:id/stop', async (req, res) => {
     }
 });
 app.delete('/test-sessions/:id', async (req, res) => {
-    const deleted = await deleteTestSession(req.params.id, io, { purgeExecutionRun: true });
+    const deleted = await deleteTestSession(req.params.id, io);
     if (!deleted) {
         return res.status(404).json({ error: 'Not found' });
     }
@@ -7890,6 +7946,7 @@ app.post('/tickets/:id/plan', (req, res) => {
     }
     const scheduling = startPlan(ticket, io, {
         branch,
+        targetBundleId,
     });
     if (!scheduling.accepted) {
         const status = scheduling.reason === 'queue_failed' ? 503 : 409;