@straiffi/archon 1.3.5 → 1.3.7

package/dist/server/lib/agent.js

@@ -7,6 +7,7 @@ import { getChatSession, updateChatSessionUsageSnapshot } from './chats.js';
 import { normalizeModelId } from './models.js';
 import { PLAN_MODE_QUESTION_TOOL_NAME } from './planModeQuestions.js';
 import { getSpecSession, updateSpecSessionResumeId, updateSpecSessionStatus, updateSpecSessionTitle, updateSpecSessionUsageSnapshot } from './specs.js';
+import { updateSpecReviewRunStatus, updateSpecReviewRunStreaming, updateSpecReviewRunUsage } from './specReviews.js';
 import { resolveOpencodeDbPath } from './runtimePaths.js';
 import { markTicketDescriptionVisibleInBundle } from './ticketMessages.js';
 import { getTicket } from './tickets.js';
@@ -177,6 +178,7 @@ const hasMatchingUsageSnapshot = (current, next) => {
 const activeBuildProcesses = new Map();
 const activeChatProcesses = new Map();
 const activeSpecProcesses = new Map();
+const activeSpecReviewProcesses = new Map();
 const getErrorMessage = (error) => {
     return error instanceof Error ? error.message : String(error);
 };
@@ -1060,6 +1062,13 @@ const untrackSpecProcess = (specSessionId, state) => {
     state.metadataRefresher?.stop();
     state.metadataRefresher = null;
 };
+const untrackSpecReviewProcess = (specReviewRunId, state) => {
+    if (activeSpecReviewProcesses.get(specReviewRunId) === state) {
+        activeSpecReviewProcesses.delete(specReviewRunId);
+    }
+    state.metadataRefresher?.stop();
+    state.metadataRefresher = null;
+};
 export const isBuildAgentRunning = (ticketId) => activeBuildProcesses.has(ticketId);
 export const stopAllBuildAgents = async () => {
     const ticketIds = [...activeBuildProcesses.keys()];
@@ -1109,6 +1118,21 @@ export const stopSpecAgent = async (specSessionId) => {
     }
     return true;
 };
+export const stopSpecReviewAgent = async (specReviewRunId) => {
+    const state = activeSpecReviewProcesses.get(specReviewRunId);
+    if (!state?.child) {
+        return false;
+    }
+    state.stopRequested = true;
+    state.metadataRefresher?.stop();
+    killProcess(state.child, 'SIGTERM');
+    await waitForProcessExit(state.child, 5000);
+    if (isProcessAlive(state.child)) {
+        killProcess(state.child, 'SIGKILL');
+        await waitForProcessExit(state.child, 1000);
+    }
+    return true;
+};
 export const runAgent = ({ ticketId, tool, prompt, cwd, io, model, variant = null, resumeSessionId = null, sessionField = 'session_id', trackBuildProcess = false, emitSuccessUpdate = true, opencodeAgentMode, }) => {
     const resolvedModel = normalizeModelId(model);
     return new Promise((resolve, reject) => {
@@ -2009,4 +2033,224 @@ export const runSpecAgent = ({ specSessionId, tool, prompt, files = [], cwd, io,
         });
     });
 };
+/**
+ * Focused, decoupled runner for a one-shot Spec Review.
+ *
+ * Spawns identically to runSpecAgent (plan permission mode for claude,
+ * `--agent plan` for opencode, cwd = the project repo working dir) so a
+ * code-aware reviewer needs no new permission plumbing. The critical difference
+ * is that all status/streaming writes go to the spec_review_runs row via
+ * updateSpecReviewRunStatus / updateSpecReviewRunStreaming / updateSpecReviewRunUsage —
+ * the spec_sessions row is never touched by this path.
+ */
+export const runSpecReviewAgent = ({ specReviewRunId, tool, prompt, files = [], cwd, io, model, variant = null, }) => {
+    const resolvedModel = normalizeModelId(model);
+    return new Promise((resolve, reject) => {
+        let settled = false;
+        let startTime = null;
+        let firstFinalAnswerTime = null;
+        let usageSnapshot = EMPTY_CHAT_USAGE_SNAPSHOT;
+        const reviewState = {
+            child: null,
+            stopRequested: false,
+            metadataRefresher: null,
+        };
+        const settle = (handler) => (value) => {
+            if (settled) {
+                return;
+            }
+            settled = true;
+            untrackSpecReviewProcess(specReviewRunId, reviewState);
+            handler(value);
+        };
+        const resolveOnce = settle(resolve);
+        const rejectOnce = settle(reject);
+        const emitReviewUpdated = () => {
+            io.emit('spec-review:updated', { spec_review_run_id: specReviewRunId });
+        };
+        const [cmd, args] = tool === 'claude'
+            ? [
+                'claude',
+                [
+                    '--permission-mode',
+                    'plan',
+                    '--disallowedTools',
+                    PLAN_MODE_QUESTION_TOOL_NAME,
+                    '--print',
+                    '--verbose',
+                    '--output-format',
+                    'stream-json',
+                    '--session-id',
+                    randomUUID(),
+                    prompt,
+                ],
+            ]
+            : ['opencode', ['run', '--agent', 'plan', '--format', 'json', '--thinking', ...(resolvedModel ? ['--model', resolvedModel] : []), ...(variant ? ['--variant', variant] : []), ...files.flatMap(filePath => ['--file', filePath]), ...(files.length > 0 ? ['--'] : []), prompt]];
+        updateSpecReviewRunStreaming(specReviewRunId, null);
+        emitReviewUpdated();
+        const child = spawn(cmd, args, {
+            cwd,
+            stdio: ['ignore', 'pipe', 'pipe'],
+            env: { ...process.env, PWD: cwd },
+            detached: process.platform !== 'win32',
+        });
+        reviewState.child = child;
+        activeSpecReviewProcesses.set(specReviewRunId, reviewState);
+        startTime = Date.now();
+        if (tool === 'claude') {
+            const logLines = [];
+            const responseLines = [];
+            let remainder = '';
+            const stderrChunks = [];
+            const progressUpdater = createThrottledProgressUpdater(() => {
+                updateSpecReviewRunStreaming(specReviewRunId, responseLines.join('\n\n') || null);
+            });
+            child.stdout?.on('data', (chunk) => {
+                const text = remainder + chunk.toString();
+                const lines = text.split('\n');
+                remainder = lines.pop() ?? '';
+                for (const line of lines) {
+                    usageSnapshot = mergeUsageFromJsonLine(usageSnapshot, line);
+                    const { logFragment, responseFragment } = parseClaudeStreamJsonLine(line);
+                    if (logFragment !== null) {
+                        logLines.push(logFragment);
+                    }
+                    if (responseFragment !== null) {
+                        responseLines.push(responseFragment);
+                    }
+                    if (logFragment !== null || responseFragment !== null) {
+                        progressUpdater.schedule();
+                    }
+                }
+            });
+            child.stderr?.on('data', (chunk) => stderrChunks.push(chunk));
+            child.on('close', code => {
+                progressUpdater.cancel();
+                if (remainder.trim()) {
+                    usageSnapshot = mergeUsageFromJsonLine(usageSnapshot, remainder);
+                    const { logFragment, responseFragment } = parseClaudeStreamJsonLine(remainder);
+                    if (logFragment !== null) {
+                        logLines.push(logFragment);
+                    }
+                    if (responseFragment !== null) {
+                        responseLines.push(responseFragment);
+                    }
+                }
+                const errOutput = Buffer.concat(stderrChunks).toString();
+                const finalLog = logLines.join('\n\n') || errOutput;
+                const finalResponse = responseLines.join('\n\n') || errOutput;
+                if (reviewState.stopRequested) {
+                    updateSpecReviewRunStreaming(specReviewRunId, finalResponse || null);
+                    resolveOnce({
+                        completionStatus: 'stopped',
+                        finalResponse,
+                        usageSnapshot,
+                        responseTiming: buildResponseTiming({ startTime, firstFinalAnswerTime, isStopped: true }),
+                    });
+                    return;
+                }
+                const modelError = isModelResolutionError(finalLog);
+                if (code === 0 && !modelError) {
+                    updateSpecReviewRunStreaming(specReviewRunId, finalResponse || null);
+                    resolveOnce({
+                        completionStatus: 'done',
+                        finalResponse,
+                        usageSnapshot,
+                        responseTiming: buildResponseTiming({ startTime, firstFinalAnswerTime, isStopped: false }),
+                    });
+                    return;
+                }
+                rejectOnce(new Error(`Agent exited with code ${code ?? 'null'}\n${finalLog}${errOutput !== finalLog && errOutput ? '\n\n' + errOutput : ''}`));
+            });
+            child.on('error', err => {
+                progressUpdater.cancel();
+                rejectOnce(err instanceof Error ? err : new Error(getErrorMessage(err)));
+            });
+            return;
+        }
+        const logLines = [];
+        const responseLines = [];
+        let remainder = '';
+        const stderrChunks = [];
+        const progressUpdater = createThrottledProgressUpdater(() => {
+            updateSpecReviewRunStreaming(specReviewRunId, responseLines.join('\n\n') || null);
+        });
+        child.stdout?.on('data', (chunk) => {
+            const text = remainder + chunk.toString();
+            const lines = text.split('\n');
+            remainder = lines.pop() ?? '';
+            for (const line of lines) {
+                usageSnapshot = mergeUsageFromJsonLine(usageSnapshot, line);
+                if (firstFinalAnswerTime === null && startTime !== null) {
+                    const trimmedLine = line.trim();
+                    if (trimmedLine.startsWith('{')) {
+                        try {
+                            const event = JSON.parse(trimmedLine);
+                            if (event.type === 'text' && event.part?.type === 'text' && event.part.text) {
+                                const phase = event.part.metadata?.openai?.phase;
+                                if (!phase || phase === 'final_answer') {
+                                    firstFinalAnswerTime = Date.now();
+                                }
+                            }
+                        }
+                        catch { /* best-effort timing */ }
+                    }
+                }
+                const { logFragment, responseFragment } = parseOpencodeJsonLine(line, cwd);
+                if (logFragment !== null) {
+                    logLines.push(logFragment);
+                }
+                if (responseFragment !== null) {
+                    responseLines.push(responseFragment);
+                }
+                if (logFragment !== null || responseFragment !== null) {
+                    progressUpdater.schedule();
+                }
+            }
+        });
+        child.stderr?.on('data', (chunk) => stderrChunks.push(chunk));
+        child.on('close', code => {
+            progressUpdater.cancel();
+            if (remainder.trim()) {
+                usageSnapshot = mergeUsageFromJsonLine(usageSnapshot, remainder);
+                const { logFragment, responseFragment } = parseOpencodeJsonLine(remainder, cwd);
+                if (logFragment !== null) {
+                    logLines.push(logFragment);
+                }
+                if (responseFragment !== null) {
+                    responseLines.push(responseFragment);
+                }
+            }
+            const stderrOutput = Buffer.concat(stderrChunks).toString();
+            const log = logLines.join('\n\n') || stderrOutput;
+            const finalResponse = responseLines.join('\n\n') || stderrOutput;
+            if (reviewState.stopRequested) {
+                updateSpecReviewRunStreaming(specReviewRunId, finalResponse || null);
+                resolveOnce({
+                    completionStatus: 'stopped',
+                    finalResponse,
+                    usageSnapshot,
+                    responseTiming: buildResponseTiming({ startTime, firstFinalAnswerTime, isStopped: true }),
+                });
+                return;
+            }
+            const modelError = isModelResolutionError(log);
+            if (code === 0 && !modelError) {
+                updateSpecReviewRunStreaming(specReviewRunId, finalResponse || null);
+                resolveOnce({
+                    completionStatus: 'done',
+                    finalResponse,
+                    usageSnapshot,
+                    responseTiming: buildResponseTiming({ startTime, firstFinalAnswerTime, isStopped: false }),
+                });
+                return;
+            }
+            rejectOnce(new Error(`Agent exited with code ${code ?? 'null'}\n${log}${stderrOutput !== log && stderrOutput ? '\n\n' + stderrOutput : ''}`));
+        });
+        child.on('error', err => {
+            progressUpdater.cancel();
+            rejectOnce(err instanceof Error ? err : new Error(getErrorMessage(err)));
+        });
+    });
+};
 //# sourceMappingURL=agent.js.map