@storm-software/workspace-tools 1.49.31 → 1.50.1

package/CHANGELOG.md

@@ -1,3 +1,27 @@
+## 1.50.1 (2024-01-26)
+
+
+### 🩹 Fixes
+
+- **workspace-tools:** Fixed issue with incorrect external package logic ([a8e7a52a](https://github.com/storm-software/storm-ops/commit/a8e7a52a))
+
+
+### ❤️  Thank You
+
+- Patrick Sullivan
+
+## 1.50.0 (2024-01-26)
+
+
+### 🚀 Features
+
+- **config-tools:** Added the `externalPackagePatterns` option to Storm config ([78f5c9d4](https://github.com/storm-software/storm-ops/commit/78f5c9d4))
+
+
+### ❤️  Thank You
+
+- Patrick Sullivan
+
 ## 1.49.31 (2024-01-26)
 
 

package/index.js

@@ -129881,6 +129881,9 @@ var StormConfigSchema = objectType({
   ci: booleanType().default(true).describe("An indicator specifying if the current environment is a CI environment"),
   workspaceRoot: stringType().trim().optional().describe("The root directory of the workspace"),
   packageDirectory: stringType().trim().optional().describe("The root directory of the package"),
+  externalPackagePatterns: arrayType(stringType()).default([]).describe(
+    "The build will use these package patterns to determine if they should be external to the bundle"
+  ),
   buildDirectory: stringType().trim().default("dist").describe("The build directory for the workspace"),
   runtimeDirectory: stringType().trim().default("node_modules/.storm").describe("The runtime directory of Storm"),
   runtimeVersion: stringType().trim().regex(
@@ -139333,18 +139336,17 @@ ${Object.keys(options).map(
       return ret;
     }, options.external);
   }
-  if (options.bundle === false) {
-    for (const thirdPartyDependency of getExternalDependencies(
-      context.projectName,
-      context.projectGraph
+  for (const thirdPartyDependency of getExternalDependencies(
+    context.projectName,
+    context.projectGraph
+  )) {
+    const packageConfig = thirdPartyDependency.node.data;
+    if (packageConfig?.packageName && config?.externalPackagePatterns?.some(
+      (pattern) => pattern.includes(packageConfig.packageName)
+    ) && !externalDependencies?.some(
+      (externalDependency) => externalDependency.name.includes(packageConfig.packageName)
     )) {
-      const packageConfig = thirdPartyDependency.node.data;
-      if (packageConfig?.packageName) {
-        options.external.push(packageConfig.packageName);
-        if (!packageJson?.devDependencies?.[packageConfig.packageName]) {
-          externalDependencies.push(thirdPartyDependency);
-        }
-      }
+      externalDependencies.push(thirdPartyDependency);
     }
   }
   writeTrace(
@@ -139413,6 +139415,9 @@ ${externalDependencies.map((dep) => {
           packageJson.dependencies ??= {};
           packageJson.dependencies[packageName] = projectGraph.nodes[externalDependency.node.name] ? "latest" : version;
         }
+        if (!options.external.includes(packageName)) {
+          options.external.push(packageName);
+        }
       }
     }
     for (const packageName of internalDependencies) {