@storm-software/eslint 0.22.0 → 0.24.0

package/README.md

@@ -21,7 +21,7 @@ This package is part of the <b>⚡Storm-Ops</b> monorepo. The Storm-Ops packages
 
 <h3 align="center">💻 Visit <a href="https://stormsoftware.com" target="_blank">stormsoftware.com</a> to stay up to date with this developer</h3><br />
 
-[![Version](https://img.shields.io/badge/version-0.21.0-1fb2a6.svg?style=for-the-badge&color=1fb2a6)](https://prettier.io/)&nbsp;[![Nx](https://img.shields.io/badge/Nx-17.0.2-lightgrey?style=for-the-badge&logo=nx&logoWidth=20&&color=1fb2a6)](http://nx.dev/)&nbsp;[![NextJs](https://img.shields.io/badge/Next.js-14.0.2-lightgrey?style=for-the-badge&logo=nextdotjs&logoWidth=20&color=1fb2a6)](https://nextjs.org/)&nbsp;[![Commitizen friendly](https://img.shields.io/badge/commitizen-friendly-brightgreen.svg?style=for-the-badge&logo=commitlint&color=1fb2a6)](http://commitizen.github.io/cz-cli/)&nbsp;![Semantic-Release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg?style=for-the-badge&color=1fb2a6)&nbsp;[![documented with Fumadocs](https://img.shields.io/badge/documented_with-fumadocs-success.svg?style=for-the-badge&logo=readthedocs&color=1fb2a6)](https://fumadocs.vercel.app/)&nbsp;![GitHub Workflow Status (with event)](https://img.shields.io/github/actions/workflow/status/storm-software/storm-ops/cr.yml?style=for-the-badge&logo=github-actions&color=1fb2a6)
+[![Version](https://img.shields.io/badge/version-0.24.0-1fb2a6.svg?style=for-the-badge&color=1fb2a6)](https://prettier.io/)&nbsp;[![Nx](https://img.shields.io/badge/Nx-17.0.2-lightgrey?style=for-the-badge&logo=nx&logoWidth=20&&color=1fb2a6)](http://nx.dev/)&nbsp;[![NextJs](https://img.shields.io/badge/Next.js-14.0.2-lightgrey?style=for-the-badge&logo=nextdotjs&logoWidth=20&color=1fb2a6)](https://nextjs.org/)&nbsp;[![Commitizen friendly](https://img.shields.io/badge/commitizen-friendly-brightgreen.svg?style=for-the-badge&logo=commitlint&color=1fb2a6)](http://commitizen.github.io/cz-cli/)&nbsp;![Semantic-Release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg?style=for-the-badge&color=1fb2a6)&nbsp;[![documented with Fumadocs](https://img.shields.io/badge/documented_with-fumadocs-success.svg?style=for-the-badge&logo=readthedocs&color=1fb2a6)](https://fumadocs.vercel.app/)&nbsp;![GitHub Workflow Status (with event)](https://img.shields.io/github/actions/workflow/status/storm-software/storm-ops/cr.yml?style=for-the-badge&logo=github-actions&color=1fb2a6)
 
 <!-- prettier-ignore-start -->
 <!-- markdownlint-disable -->

package/dist/preset.d.mts

@@ -978,6 +978,10 @@ interface RuleOptions {
    * @see https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/tabindex-no-positive.md
    */
   'jsx-a11y/tabindex-no-positive'?: Linter.RuleEntry<JsxA11yTabindexNoPositive>
+  /**
+   * @see https://github.com/prettier/eslint-plugin-prettier#options
+   */
+  'prettier/prettier'?: Linter.RuleEntry<PrettierPrettier>
   /**
    * verifies the list of dependencies for Hooks like useEffect and similar
    * @see https://github.com/facebook/react/issues/14920
@@ -3723,6 +3727,18 @@ type TypescriptEslintUnifiedSignatures = []|[{
   
   ignoreDifferentlyNamedParameters?: boolean
 }]
+// ----- prettier/prettier -----
+type PrettierPrettier = []|[{
+  [k: string]: unknown | undefined
+}]|[{
+  [k: string]: unknown | undefined
+}, {
+  usePrettierrc?: boolean
+  fileInfoOptions?: {
+    [k: string]: unknown | undefined
+  }
+  [k: string]: unknown | undefined
+}]
 // ----- react-hooks/exhaustive-deps -----
 type ReactHooksExhaustiveDeps = []|[{
   additionalHooks?: string

package/dist/preset.d.ts

@@ -978,6 +978,10 @@ interface RuleOptions {
    * @see https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/tabindex-no-positive.md
    */
   'jsx-a11y/tabindex-no-positive'?: Linter.RuleEntry<JsxA11yTabindexNoPositive>
+  /**
+   * @see https://github.com/prettier/eslint-plugin-prettier#options
+   */
+  'prettier/prettier'?: Linter.RuleEntry<PrettierPrettier>
   /**
    * verifies the list of dependencies for Hooks like useEffect and similar
    * @see https://github.com/facebook/react/issues/14920
@@ -3723,6 +3727,18 @@ type TypescriptEslintUnifiedSignatures = []|[{
   
   ignoreDifferentlyNamedParameters?: boolean
 }]
+// ----- prettier/prettier -----
+type PrettierPrettier = []|[{
+  [k: string]: unknown | undefined
+}]|[{
+  [k: string]: unknown | undefined
+}, {
+  usePrettierrc?: boolean
+  fileInfoOptions?: {
+    [k: string]: unknown | undefined
+  }
+  [k: string]: unknown | undefined
+}]
 // ----- react-hooks/exhaustive-deps -----
 type ReactHooksExhaustiveDeps = []|[{
   additionalHooks?: string

package/dist/preset.mjs

@@ -1,13 +1,14 @@
 import tsEslint from 'typescript-eslint';
 import eslintPluginUnicorn from 'eslint-plugin-unicorn';
-import markdown from 'eslint-plugin-markdown';
-import globals from 'globals';
 import nxPlugin from '@nx/eslint-plugin';
-import jsoncParser from 'jsonc-eslint-parser';
-import react from 'eslint-plugin-react';
 import jsxA11y from 'eslint-plugin-jsx-a11y';
+import markdown from 'eslint-plugin-markdown';
+import prettierConfig from 'eslint-plugin-prettier/recommended';
+import react from 'eslint-plugin-react';
 import reactHooks from 'eslint-plugin-react-hooks';
 import tsdoc from 'eslint-plugin-tsdoc';
+import globals from 'globals';
+import jsoncParser from 'jsonc-eslint-parser';
 
 function getDefaultExportFromCjs (x) {
 	return x && x.__esModule && Object.prototype.hasOwnProperty.call(x, 'default') ? x['default'] : x;
@@ -330,22 +331,6 @@ var src = {
 
 const eslint = /*@__PURE__*/getDefaultExportFromCjs(src);
 
-const formatConfig = (name, config = []) => {
-  return config.map((config2, index) => {
-    if (!config2 || config2.name) {
-      return config2 ?? {};
-    }
-    return {
-      ...config2,
-      name: `Storm Software (${name}) #${index + 1}`,
-      settings: {
-        "import/resolver": "node",
-        ...config2.settings ?? {}
-      }
-    };
-  });
-};
-
 const config$3 = {
   // This rule has been deprecated, but not yet removed.
   "jsx-a11y/no-onchange": "off",
@@ -1204,6 +1189,26 @@ const config = {
   "tsdoc/syntax": "error"
 };
 
+const CODE_BLOCK = "**/*.md{,x}/*";
+const CODE_FILE = "**/*.{,c,m}{j,t}s{,x}";
+const TS_FILE = "**/*.{,c,m}ts{,x}";
+
+const formatConfig = (name, config = []) => {
+  return config.map((config2, index) => {
+    if (!config2 || config2.name) {
+      return config2 ?? {};
+    }
+    return {
+      ...config2,
+      name: `Storm Software (${name}) #${index + 1}`,
+      settings: {
+        "import/resolver": "node",
+        ...config2.settings ?? {}
+      }
+    };
+  });
+};
+
 function stormPreset(options = {
   moduleBoundaries: {
     enforceBuildableLibDependency: true,
@@ -1246,6 +1251,8 @@ function stormPreset(options = {
     ...tsEslint.configs.recommended,
     // https://github.com/sindresorhus/eslint-plugin-unicorn
     eslintPluginUnicorn.configs["flat/recommended"],
+    // Prettier
+    prettierConfig,
     // Preset overrides
     { rules },
     {
@@ -1265,7 +1272,7 @@ function stormPreset(options = {
     // https://www.npmjs.com/package/eslint-plugin-markdown
     options.markdown !== false && { plugins: { markdown } },
     options.markdown !== false && {
-      files: ["*.md"],
+      files: [CODE_BLOCK],
       processor: "markdown/markdown"
     },
     options.markdown !== false && {
@@ -1288,7 +1295,7 @@ function stormPreset(options = {
       plugins: { react, "react-hooks": reactHooks, "jsx-a11y": jsxA11y }
     },
     options.react !== false && {
-      files: ["*.ts", "*.tsx", "*.js", "*.jsx"],
+      files: [CODE_FILE],
       rules: {
         ...config$2,
         ...config$1,
@@ -1296,14 +1303,19 @@ function stormPreset(options = {
         ...options.react?.rules
       }
     },
+    // Import
+    // https://www.npmjs.com/package/eslint-plugin-import
+    // { plugins: { import: importEslint } },
+    // {
+    //   files: [CODE_FILE],
+    //   rules: importRules
+    // },
     // TSDoc
     // https://www.npmjs.com/package/eslint-plugin-tsdoc
     { plugins: { tsdoc } },
     {
-      files: ["*.ts", "*.tsx"],
-      rules: {
-        ...config
-      }
+      files: [TS_FILE],
+      rules: config
     },
     // Nx plugin
     { plugins: { "@nx": nxPlugin } },
@@ -1316,15 +1328,7 @@ function stormPreset(options = {
       },
       rules: {
         "@typescript-eslint/explicit-module-boundary-types": "off",
-        "@typescript-eslint/explicit-function-return-type": [
-          "warn",
-          {
-            allowExpressions: true,
-            allowConciseArrowFunctionExpressionsStartingWithVoid: true,
-            allowFunctionsWithoutTypeParameters: true,
-            allowIIFEs: true
-          }
-        ]
+        "@typescript-eslint/explicit-function-return-type": "off"
       }
     },
     {
@@ -1335,12 +1339,13 @@ function stormPreset(options = {
       rules: {}
     },
     {
-      files: ["*.ts", "*.tsx", "*.js", "*.jsx"],
+      files: [CODE_FILE],
       rules: {
         "@nx/enforce-module-boundaries": [
           "error",
           options.moduleBoundaries ? options.moduleBoundaries : {
             enforceBuildableLibDependency: true,
+            checkDynamicDependenciesExceptions: [".*"],
             allow: [],
             depConstraints: [
               {
@@ -1349,6 +1354,22 @@ function stormPreset(options = {
               }
             ]
           }
+        ],
+        "no-restricted-imports": ["error", "create-nx-workspace"],
+        "@typescript-eslint/no-restricted-imports": [
+          "error",
+          {
+            "patterns": [
+              {
+                "group": ["nx/src/plugins/js*"],
+                "message": "Imports from 'nx/src/plugins/js' are not allowed. Use '@nx/js' instead"
+              },
+              {
+                "group": ["**/native-bindings", "**/native-bindings.js", ""],
+                "message": "Direct imports from native-bindings.js are not allowed. Import from index.js instead."
+              }
+            ]
+          }
         ]
       }
     },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@storm-software/eslint",
-  "version": "0.22.0",
+  "version": "0.24.0",
   "type": "module",
   "description": "⚡ A package containing the base ESLint configuration used by Storm Software across many projects.",
   "repository": {
@@ -69,12 +69,14 @@
     "@graphql-eslint/eslint-plugin": "3.20.1",
     "@next/eslint-plugin-next": "14.2.4",
     "eslint-plugin-es-x": "7.6.0",
+    "eslint-plugin-import": "^2.29.1",
     "eslint-plugin-jsonc": "2.16.0",
     "eslint-plugin-jsx-a11y": "6.8.0",
     "eslint-plugin-markdown": "^5.1.0",
     "eslint-plugin-markdownlint": "0.6.0",
     "eslint-plugin-mdx": "3.1.5",
     "eslint-plugin-n": "17.8.1",
+    "eslint-plugin-prettier": "^5.0.0",
     "eslint-plugin-promise": "6.2.0",
     "eslint-plugin-react": "7.34.3",
     "eslint-plugin-react-hooks": "4.6.2",