@storecraft/storage-s3-compatible 1.0.16 → 1.0.17

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@storecraft/storage-s3-compatible",
-  "version": "1.0.16",
+  "version": "1.0.17",
   "description": "Official S3-Compatible Storage adapter for storecraft",
   "license": "MIT",
   "author": "Tomer Shalev (https://github.com/store-craft)",

package/tests/storage.r2.test.js

@@ -5,10 +5,21 @@ import { readFile } from 'node:fs/promises';
 import { storage as storage_test_runner } from '@storecraft/core/test-runner'
 
 
+/**
+ * @param {Blob} blob1 
+ * @param {Blob} blob2 
+ */
 const areBlobsEqual = async (blob1, blob2) => {
-  return !Buffer.from(await blob1.arrayBuffer()).compare(
-    Buffer.from(await blob2.arrayBuffer())
-  );
+  const array1 = new Uint8Array(await blob1.arrayBuffer());
+  const array2 = new Uint8Array(await blob2.arrayBuffer());
+
+  if (array1.length !== array2.length) return false;
+
+  for (let i = 0; i < array1.length; i++) {
+    if (array1[i] !== array2[i]) return false;
+  }
+
+  return true;
 };
 
 const storage = new R2({
@@ -22,6 +33,12 @@ const suite = storage_test_runner.create(storage);
 
 suite.before(async () => { await storage.init(undefined) });
 
+suite('bad get', async () => {
+  const v = await storage.getBlob('i-dont-exist.png');
+  assert.not(v.value, 'should not exist');
+});
+
+
 suite('blob put/get/delete', async () => {
   const data = [
     {
@@ -61,7 +78,9 @@ suite('blob put (presign)', async () => {
   data.forEach(
     async d => {
       // get put presigned url
-      const { url, method, headers } = await storage.putSigned(d.key);
+      const { 
+        url, method, headers 
+      } = await storage.putSigned(d.key);
       // now let's use it to upload
       const r = await fetch(
         url, {
@@ -71,9 +90,29 @@ suite('blob put (presign)', async () => {
         }
       );
 
-      console.log(url)
-
       assert.ok(r.ok, 'upload failed')
+
+      { // now let's read it back, once with presigned url
+        const {
+          method, url, headers
+        } = await storage.getSigned(d.key);
+        const r_get = await fetch(
+          url, {
+            method,
+            headers,
+          }
+        );
+
+        // compare
+        const equal = await areBlobsEqual(await r_get.blob(), d.blob);
+        assert.ok(equal, 'Blobs are not equal when compared with presigned get !!!');
+      }
+      { // now let's read it back with normal get
+        const { value: blob_read } = await storage.getBlob(d.key);
+        // compare
+        const equal = await areBlobsEqual(blob_read, d.blob);
+        assert.ok(equal, 'Blobs are not equal with regular get !!!');
+      }      
     }
   );