@storecraft/database-sql-base 1.0.12 → 1.0.14

package/src/con.discounts.js

@@ -2,15 +2,19 @@
  * @import { db_discounts as db_col } from '@storecraft/core/database'
  */
 import { enums } from '@storecraft/core/api'
+import { 
+  helper_compute_product_extra_search_keywords_because_of_discount_side_effect_for_db,
+  helper_compute_product_extra_tags_because_of_discount_side_effect_for_db
+ } from '@storecraft/core/database'
 import { SQL } from '../index.js'
 import { discount_to_conjunctions } from './con.discounts.utils.js'
-import { delete_entity_values_by_value_or_reporter, 
+import { 
+  delete_entity_values_by_value_or_reporter_and_context, 
   delete_me, delete_media_of, delete_search_of, 
   delete_tags_of, insert_media_of, insert_search_of, 
-  insert_tags_of, select_entity_ids_by_value_or_reporter, regular_upsert_me, where_id_or_handle_table, 
-  with_media, with_tags,
-  count_regular,
-  with_search} from './con.shared.js'
+  insert_tags_of, regular_upsert_me, where_id_or_handle_table, 
+  with_media, with_tags, count_regular, with_search,
+} from './con.shared.js'
 import { sanitize, sanitize_array } from './utils.funcs.js'
 import { query_to_eb, query_to_sort } from './utils.query.js'
 import { report_document_media } from './con.images.js'
@@ -36,14 +40,25 @@ const upsert = (driver) => {
           // PRODUCTS => DISCOUNTS
           //
           // remove all products relation to this discount
-          await delete_entity_values_by_value_or_reporter('products_to_discounts')(
+          await delete_entity_values_by_value_or_reporter_and_context('products_to_discounts')(
             trx, item.id, item.handle);
+          
+          const extra_search_for_products = 
+            helper_compute_product_extra_search_keywords_because_of_discount_side_effect_for_db(item);
 
-          await delete_entity_values_by_value_or_reporter('entity_to_search_terms')(
-            trx, `discount:${item.id}`);
-          await delete_entity_values_by_value_or_reporter('entity_to_search_terms')(
-            trx, `discount:${item.handle}`);
-
+          const extra_tags_for_products = 
+            helper_compute_product_extra_tags_because_of_discount_side_effect_for_db(item);
+          
+            // maybe i should confine these to `context`=`products`
+          for(const extra_search of extra_search_for_products) {
+            await delete_entity_values_by_value_or_reporter_and_context('entity_to_search_terms')(
+              trx, extra_search);
+          }
+          for(const extra_tag of extra_tags_for_products) {
+            await delete_entity_values_by_value_or_reporter_and_context('entity_to_tags_projections')(
+              trx, extra_tag);
+          }
+  
           if(item.active && item.application.id===enums.DiscountApplicationEnum.Auto.id) {
             // make connections
             await trx
@@ -63,37 +78,44 @@ const upsert = (driver) => {
                 )
             ).execute();
 
-            await trx
-            .insertInto('entity_to_search_terms')
-            .columns(['entity_handle', 'entity_id', 'value'])
-            .expression(eb => 
-              eb.selectFrom('products')
-                .select(eb => [
-                    'handle as entity_handle',
-                    'id as entity_id',
-                    eb.val(`discount:${item.id}`).as('value'),
-                  ]
-                )
-                .where(
-                  eb => eb.and(discount_to_conjunctions(eb, item))
-                )
-            ).execute();      
-
-            await trx
-            .insertInto('entity_to_search_terms')
-            .columns(['entity_handle', 'entity_id', 'value'])
-            .expression(eb => 
-              eb.selectFrom('products')
-                .select(eb => [
-                    'handle as entity_handle',
-                    'id as entity_id',
-                    eb.val(`discount:${item.handle}`).as('value'),
-                  ]
-                )
-                .where(
-                  eb => eb.and(discount_to_conjunctions(eb, item))
-                )
-            ).execute();                     
+            for(const extra_search of extra_search_for_products) {
+              await trx
+              .insertInto('entity_to_search_terms')
+              .columns(['entity_handle', 'entity_id', 'value', 'reporter', 'context'])
+              .expression(eb => 
+                eb.selectFrom('products')
+                  .select(eb => [
+                      'handle as entity_handle',
+                      'id as entity_id',
+                      eb.val(extra_search).as('value'),
+                      eb.val(item.id).as('reporter'),
+                      eb.val('products').as('context'),
+                    ]
+                  )
+                  .where(
+                    eb => eb.and(discount_to_conjunctions(eb, item))
+                  )
+              ).execute();      
+            }
+            for(const extra_tag of extra_tags_for_products) {
+              await trx
+              .insertInto('entity_to_tags_projections')
+              .columns(['entity_handle', 'entity_id', 'value', 'reporter', 'context'])
+              .expression(eb => 
+                eb.selectFrom('products')
+                  .select(eb => [
+                      'handle as entity_handle',
+                      'id as entity_id',
+                      eb.val(extra_tag).as('value'),
+                      eb.val(item.id).as('reporter'),
+                      eb.val('products').as('context'),
+                    ]
+                  )
+                  .where(
+                    eb => eb.and(discount_to_conjunctions(eb, item))
+                  )
+              ).execute();  
+            }                    
           }
 
           ///
@@ -158,17 +180,48 @@ const remove = (driver) => {
         async (trx) => {
             
           // entities
-          await delete_search_of(trx, id_or_handle);
-          await delete_media_of(trx, id_or_handle);
-          await delete_tags_of(trx, id_or_handle);
+          await delete_tags_of(trx, id_or_handle, id_or_handle, table_name);
+          await delete_search_of(trx, id_or_handle, id_or_handle, table_name);
+          await delete_media_of(trx, id_or_handle, id_or_handle, table_name);
           // delete products -> discounts
           // PRODUCTS => DISCOUNTS
-          await delete_entity_values_by_value_or_reporter('products_to_discounts')(
+          await delete_entity_values_by_value_or_reporter_and_context('products_to_discounts')(
             trx, id_or_handle, id_or_handle);
           // STOREFRONT => DISCOUNTS
-          await delete_entity_values_by_value_or_reporter('storefronts_to_other')(
-            trx, id_or_handle, id_or_handle
+          await delete_entity_values_by_value_or_reporter_and_context('storefronts_to_other')(
+            trx, id_or_handle, id_or_handle, table_name
           );
+          // discount might have published search terms and tags for other products, 
+          // so let's remove
+          const discount_handle_and_id = await trx
+          .selectFrom('discounts')
+          .select(['handle', 'id'])
+          .where(
+            (eb) => eb.or([
+              eb('discounts.handle', '=', id_or_handle),
+              eb('discounts.id', '=', id_or_handle)
+            ])
+          )
+          .executeTakeFirst();
+
+          const extra_search_for_products = 
+            helper_compute_product_extra_search_keywords_because_of_discount_side_effect_for_db(
+              discount_handle_and_id
+            );
+
+          const extra_tags_for_products = 
+            helper_compute_product_extra_tags_because_of_discount_side_effect_for_db(
+              discount_handle_and_id
+            );
+
+          for(const extra_search of extra_search_for_products) {
+            await delete_entity_values_by_value_or_reporter_and_context('entity_to_search_terms')(
+              trx, extra_search);
+          }
+          for(const extra_tag of extra_tags_for_products) {
+            await delete_entity_values_by_value_or_reporter_and_context('entity_to_tags_projections')(
+              trx, extra_tag);
+          } 
 
           // delete me
           await delete_me(trx, table_name, id_or_handle);
@@ -220,13 +273,14 @@ const list = (driver) => {
 const list_discount_products = (driver) => {
   return async (handle_or_id, query={}) => {
 
-    // TODO: try to rewrite this with JOIN to products_to_discounts ON products.id=entity_id
-    // TODO: and then filter by value==handle_or_id_of_discount
-    // TODO: I think it will be better and more memory efficient for the database
-    // TODO: becausee right now it loads all the eligible products ids in advance
     const items = await driver.client
       .selectFrom('products')
-      .selectAll()
+      .innerJoin(
+        'products_to_discounts', 
+        'products_to_discounts.entity_id', 
+        'products.id'
+      )
+      .selectAll('products')
       .select(eb => [
         with_media(eb, eb.ref('products.id'), driver.dialectType),
         with_tags(eb, eb.ref('products.id'), driver.dialectType),
@@ -235,12 +289,13 @@ const list_discount_products = (driver) => {
         (eb) => eb.and(
           [
             query_to_eb(eb, query, 'products'),
-            eb('products.id', 'in', 
-              eb => select_entity_ids_by_value_or_reporter( // select all the product ids by discount id
-                eb, 'products_to_discounts', handle_or_id
-              )
+            eb.or(
+              [
+                eb('products_to_discounts.reporter', '=', handle_or_id),
+                eb('products_to_discounts.value', '=', handle_or_id)
+              ]
             )
-          ].filter(Boolean)
+          ].filter(Boolean)        
         )
       )
       .orderBy(query_to_sort(query, 'products'))
@@ -253,6 +308,84 @@ const list_discount_products = (driver) => {
   }
 }
 
+
+
+/**
+ * @param {SQL} driver 
+ * @returns {db_col["list_all_discount_products_tags"]}
+ */
+const list_all_discount_products_tags = (driver) => {
+  return async (handle_or_id) => {
+
+    const items = await driver.client
+      .selectFrom('products')
+      .innerJoin(
+        'products_to_discounts', 
+        'products_to_discounts.entity_id', 
+        'products.id'
+      )
+      .innerJoin(
+        'entity_to_tags_projections', 
+        'entity_to_tags_projections.entity_id', 
+        'products.id'
+      )
+      .select('entity_to_tags_projections.value as tag')
+      .where(
+        (eb) => eb.or(
+          [
+            eb('products_to_discounts.reporter', '=', handle_or_id),
+            eb('products_to_discounts.value', '=', handle_or_id)
+          ]
+        )
+      )
+      .groupBy('tag')
+      .execute();
+
+      // .compile();
+      // console.log(items[0])
+
+    return items.map(e => e.tag);
+  }
+}
+
+
+/**
+ * @param {SQL} driver 
+ * @returns {db_col["count_discount_products"]}
+ */
+const count_discount_products = (driver) => {
+  return async (handle_or_id, query={}) => {
+
+    const result = await driver.client
+      .selectFrom('products')
+      .innerJoin(
+        'products_to_discounts', 
+        'products_to_discounts.entity_id', 
+        'products.id'
+      )
+      .select(
+        (eb) => eb.fn.countAll().as('count')
+      )
+      .where(
+        (eb) => eb.and(
+          [
+            query_to_eb(eb, query, 'products'),
+            eb.or(
+              [
+                eb('products_to_discounts.reporter', '=', handle_or_id),
+                eb('products_to_discounts.value', '=', handle_or_id)
+              ]
+            )
+          ].filter(Boolean)        
+        )
+      )
+      .executeTakeFirst();
+
+    return Number(result.count);
+  }
+}
+
+
 /** 
  * @param {SQL} driver
  * @return {db_col}}
@@ -265,6 +398,8 @@ export const impl = (driver) => {
     remove: remove(driver),
     list: list(driver),
     list_discount_products: list_discount_products(driver),
+    count_discount_products: count_discount_products(driver),
+    list_all_discount_products_tags: list_all_discount_products_tags(driver),
     count: count_regular(driver, table_name),
   }
 }

package/src/con.discounts.utils.js

@@ -25,25 +25,26 @@ const extract_abs_number = v => {
 /**
  * @param {ExpressionBuilder<Database, 'products'>} eb 
  * @param {keyof Pick<Database, 'entity_to_tags_projections' | 'products_to_collections'>} table 
- * @param {BinaryOperator} op 
  * @param {string[]} value 
  */
-const eb_in = (eb, table, op, value) => {
+const eb_in = (eb, table, value) => {
   return eb.exists(
     eb => eb
-      .selectFrom(table)
-      .select('id')
-      .where(
-        eb => eb.and([
+    .selectFrom(table)
+    .select('id')
+    .where(
+      eb => eb.and(
+        [
           eb.or(
             [
               eb(`${table}.entity_id`, '=', eb.ref('products.id')),
               eb(`${table}.entity_handle`, '=', eb.ref('products.handle')),
             ]
           ),
-          eb(`${table}.value`, op, value)
-        ])
+          eb(`${table}.value`, 'in', value)
+        ]
       )
+    )
   )
 }
 
@@ -111,7 +112,7 @@ export const discount_to_conjunctions = (eb, d) => {
           
           conjunctions.push(
             eb_in(
-              eb, 'entity_to_tags_projections', 'in', 
+              eb, 'entity_to_tags_projections',
               cast
             )
           );
@@ -126,7 +127,7 @@ export const discount_to_conjunctions = (eb, d) => {
           conjunctions.push(
             eb.not(
               eb_in(
-                eb, 'entity_to_tags_projections', 'in', 
+                eb, 'entity_to_tags_projections',
                 cast
               )
             )
@@ -142,7 +143,7 @@ export const discount_to_conjunctions = (eb, d) => {
           // PROBLEM: we only have ids, but use handles in the filters
           conjunctions.push(
             eb_in(
-              eb, 'products_to_collections', 'in', 
+              eb, 'products_to_collections',
               cast.map(c => c.id)
             )
           );
@@ -157,7 +158,7 @@ export const discount_to_conjunctions = (eb, d) => {
           conjunctions.push(
             eb.not(
               eb_in(
-                eb, 'products_to_collections', 'in', 
+                eb, 'products_to_collections',
                 cast.map(c => c.id)
               )
             )

package/src/con.helpers.json.js

@@ -1,14 +1,25 @@
+/**
+ * @import { AliasableExpression, Expression} from 'kysely'
+ * @import { SelectQueryBuilderExpression } from './con.helpers.json.js'
+ * @import { SqlDialectType } from '../types.public.js'
+ * @import { RawBuilder, Simplify } from 'kysely'
+ */
+
 import {
   AliasNode, ColumnNode, ExpressionWrapper, IdentifierNode, 
   ReferenceNode, SelectQueryNode, TableNode, ValueNode } from 'kysely'
-import { sqlite_jsonArrayFrom, sqlite_jsonObjectFrom, 
-  sqlite_stringArrayFrom } from './con.helpers.json.sqlite.js'
-import { pg_jsonArrayFrom, pg_jsonObjectFrom, 
-  pg_stringArrayFrom } from './con.helpers.json.postgres.js'
-import { mysql_jsonArrayFrom, mysql_jsonObjectFrom, 
-  mysql_stringArrayFrom } from './con.helpers.json.mysql.js'
-import { mssql_jsonArrayFrom, mssql_jsonObjectFrom, 
-  mssql_stringArrayFrom } from './con.helpers.json.mssql.js'
+import { 
+  sqlite_jsonArrayFrom, sqlite_jsonObjectFrom, 
+  sqlite_stringArrayFrom 
+} from './con.helpers.json.sqlite.js'
+import { 
+  pg_jsonArrayFrom, pg_jsonObjectFrom, 
+  pg_stringArrayFrom 
+} from './con.helpers.json.postgres.js'
+import { 
+  mysql_jsonArrayFrom, mysql_jsonObjectFrom, 
+  mysql_stringArrayFrom 
+} from './con.helpers.json.mysql.js'
 
   
 /**
@@ -20,7 +31,7 @@ import { mssql_jsonArrayFrom, mssql_jsonObjectFrom,
 
 /**
  * @template O
- * @typedef {import('kysely').AliasableExpression<O> & _SelectQueryBuilderExpression<O>} SelectQueryBuilderExpression
+ * @typedef {AliasableExpression<O> & _SelectQueryBuilderExpression<O>} SelectQueryBuilderExpression
  * @property {boolean} isSelectQueryBuilder
  * @property {(): SelectQueryNode} toOperationNode
  */
@@ -30,10 +41,10 @@ import { mssql_jsonArrayFrom, mssql_jsonObjectFrom,
  * 
  * @param {SelectQueryNode} node 
  * @param {string} table 
- * @returns {import('kysely').Expression<unknown>[] }
+ * @returns {Expression<unknown>[] }
  */
 export function getJsonObjectArgs(node, table) {
-  /** @type {import('kysely').Expression<unknown>[] } */
+  /** @type {Expression<unknown>[] } */
   const args = []
 
   for (const { selection: s } of node.selections ?? []) {
@@ -58,7 +69,7 @@ export function getJsonObjectArgs(node, table) {
 /**
  * 
  * @param {string} col 
- * @returns {import('kysely').Expression<unknown> }
+ * @returns {Expression<unknown> }
  */
 function colName(col) {
   return new ExpressionWrapper(ValueNode.createImmediate(col))
@@ -68,7 +79,7 @@ function colName(col) {
  * 
  * @param {string} table 
  * @param {string} col 
- * @returns {import('kysely').Expression<unknown> }
+ * @returns {Expression<unknown> }
  */
 function colRef(table, col) {
   return new ExpressionWrapper(
@@ -80,7 +91,7 @@ function colRef(table, col) {
  * @template O
  * @param {SelectQueryBuilderExpression<O>} expr 
  * @param {string} table 
- * @returns {import('kysely').Expression<unknown>}
+ * @returns {Expression<unknown>}
  */
 export const extract_first_selection = (expr, table) => {
   /** @type {any} */
@@ -88,7 +99,7 @@ export const extract_first_selection = (expr, table) => {
   /** @type {SelectQueryNode} */
   const s__ = s_;
   const s = s__.selections[0].selection;
-  /** @type {import('kysely').Expression<unknown>} */
+  /** @type {Expression<unknown>} */
   let arg;
   if (ReferenceNode.is(s) && ColumnNode.is(s.column)) {
     // console.log('arg ', s)
@@ -126,11 +137,10 @@ export const extract_first_selection = (expr, table) => {
  * result[0].pets[0].pet_id
  * result[0].pets[0].name
  * ```
- * 
  * @template O
- * @param {import('./con.helpers.json.js').SelectQueryBuilderExpression<O>} expr 
- * @param {import('../types.public.d.ts').SqlDialectType} sql_type 
- * @returns {import('kysely').RawBuilder<import('kysely').Simplify<O>[]>}
+ * @param {SelectQueryBuilderExpression<O>} expr 
+ * @param {SqlDialectType} sql_type 
+ * @returns {RawBuilder<Simplify<O>[]>}
  */
 export function jsonArrayFrom(expr, sql_type) {
   switch(sql_type) {
@@ -140,8 +150,6 @@ export function jsonArrayFrom(expr, sql_type) {
       return pg_jsonArrayFrom(expr);
     case 'MYSQL':
       return mysql_jsonArrayFrom(expr);
-    // case 'MSSQL':
-    //   return mssql_jsonArrayFrom(expr);
     default:
       throw new Error(`sql_type=${sql_type} NOT SUPPORTED !`);
   }  
@@ -169,8 +177,8 @@ export function jsonArrayFrom(expr, sql_type) {
  * result[0].pets = ['name1', 'name2', ....]
  * ```
  * @template O
- * @param {import('./con.helpers.json.js').SelectQueryBuilderExpression<O>} expr 
- * @param {import('../types.public.d.ts').SqlDialectType} sql_type 
+ * @param {SelectQueryBuilderExpression<O>} expr 
+ * @param {SqlDialectType} sql_type 
  */
 export function stringArrayFrom(expr, sql_type) {
   switch(sql_type) {
@@ -180,8 +188,6 @@ export function stringArrayFrom(expr, sql_type) {
       return pg_stringArrayFrom(expr);
     case 'MYSQL':
       return mysql_stringArrayFrom(expr);
-    // case 'MSSQL':
-    //   return mssql_stringArrayFrom(expr);
     default:
       throw new Error(`sql_type=${sql_type} NOT SUPPORTED !`);
   }  
@@ -211,9 +217,9 @@ export function stringArrayFrom(expr, sql_type) {
  * ```
  *   
  * @template O
- * @param {import('./con.helpers.json.js').SelectQueryBuilderExpression<O>} expr 
- * @param {import('../types.public.d.ts').SqlDialectType} sql_type 
- * @returns {import('kysely').RawBuilder<import('kysely').Simplify<O> | null>}
+ * @param {SelectQueryBuilderExpression<O>} expr 
+ * @param {SqlDialectType} sql_type 
+ * @returns {RawBuilder<Simplify<O> | null>}
  */
 export function jsonObjectFrom(expr, sql_type) {
   switch(sql_type) {
@@ -223,8 +229,6 @@ export function jsonObjectFrom(expr, sql_type) {
       return pg_jsonObjectFrom(expr);
     case 'MYSQL':
       return mysql_jsonObjectFrom(expr);
-    // case 'MSSQL':
-    //   return mssql_jsonObjectFrom(expr);
     default:
       throw new Error(`sql_type=${sql_type} NOT SUPPORTED !`);
   }

package/src/con.helpers.json.mysql.js

@@ -1,5 +1,13 @@
+/**
+ * @import { AliasableExpression, Expression} from 'kysely'
+ * @import { SelectQueryBuilderExpression } from './con.helpers.json.js'
+ * @import { SqlDialectType } from '../types.public.js'
+ * @import { RawBuilder, Simplify } from 'kysely'
+ */
 import { SelectQueryNode, sql } from "kysely"
-import { extract_first_selection, getJsonObjectArgs } from "./con.helpers.json.js"
+import { 
+  extract_first_selection, getJsonObjectArgs 
+} from "./con.helpers.json.js"
 
 /**
  * A MySQL helper for aggregating a subquery into a JSON array.
@@ -48,13 +56,18 @@ import { extract_first_selection, getJsonObjectArgs } from "./con.helpers.json.j
  * ```
  * 
  * @template O
- * @param {import("./con.helpers.json.js").SelectQueryBuilderExpression<O>} expr 
- * @returns {import("kysely").RawBuilder<import("kysely").Simplify<O>[]>}
+ * @param {SelectQueryBuilderExpression<O>} expr 
+ * @returns {RawBuilder<Simplify<O>[]>}
  */
 export function mysql_jsonArrayFrom(expr) {
-  return sql`(select cast(coalesce(json_arrayagg(json_object(${sql.join(
-    getMysqlJsonObjectArgs(expr.toOperationNode(), 'agg'),
-  )})), '[]') as json) from ${expr} as agg)`
+  return sql`(select cast(coalesce(json_arrayagg(json_object(${
+    sql.join(
+      getMysqlJsonObjectArgs(
+        /** @type {SelectQueryNode} */(expr.toOperationNode()), 
+        'agg'
+      ),
+    )
+  })), '[]') as json) from ${expr} as agg)`
 }
 
 /**
@@ -105,8 +118,8 @@ export function mysql_jsonArrayFrom(expr) {
  * from "person"
  * ```
  * @template O
- * @param {import('./con.helpers.json.js').SelectQueryBuilderExpression<O>} expr 
- * @returns {import('kysely').RawBuilder<string[]>}
+ * @param {SelectQueryBuilderExpression<O>} expr 
+ * @returns {RawBuilder<string[]>}
  */
 export function mysql_stringArrayFrom(expr) {
   const arg = extract_first_selection(expr, 'agg');
@@ -163,13 +176,18 @@ export function mysql_stringArrayFrom(expr) {
  * ```
  * 
  * @template O
- * @param {import("./con.helpers.json.js").SelectQueryBuilderExpression<O>} expr 
- * @returns {import("kysely").RawBuilder<import("kysely").Simplify<O> | null>}
+ * @param {SelectQueryBuilderExpression<O>} expr 
+ * @returns {RawBuilder<Simplify<O> | null>}
  */
 export function mysql_jsonObjectFrom(expr) {
-  return sql`(select json_object(${sql.join(
-    getMysqlJsonObjectArgs(expr.toOperationNode(), 'obj'),
-  )}) from ${expr} as obj)`
+  return sql`(select json_object(${
+    sql.join(
+      getMysqlJsonObjectArgs(
+        /** @type {SelectQueryNode} */(expr.toOperationNode()), 
+        'obj'
+      ),
+    )
+  }) from ${expr} as obj)`
 }
 
 /**
@@ -212,21 +230,23 @@ export function mysql_jsonObjectFrom(expr) {
  * from "person"
  * ```
  * 
- * @template {Record<string, import("kysely").Expression<unknown>>} O
+ * @template {Record<string, Expression<unknown>>} O
  * @param {O} obj 
- * @returns {import("kysely").RawBuilder<import("kysely").Simplify<{[K in keyof O]: O[K] extends Expression<infer V> ? V : never}>>}
+ * @returns {RawBuilder<Simplify<{[K in keyof O]: O[K] extends Expression<infer V> ? V : never}>>}
  */
 export function mysql_jsonBuildObject(obj) {
-  return sql`json_object(${sql.join(
-    Object.keys(obj).flatMap((k) => [sql.lit(k), obj[k]]),
-  )})`
+  return sql`json_object(${
+    sql.join(
+      Object.keys(obj).flatMap((k) => [sql.lit(k), obj[k]]),
+    )
+  })`
 }
 
 /**
  * 
  * @param {SelectQueryNode} node 
  * @param {string} table 
- * @returns {import("kysely").Expression<unknown>[]}
+ * @returns {Expression<unknown>[]}
  */
 function getMysqlJsonObjectArgs(node, table) {
   try {