@storecraft/database-sql-base 1.0.10 → 1.0.12

package/index.js

@@ -1,3 +1,10 @@
+/**
+ * @import { db_driver } from '@storecraft/core/database'
+ * @import { Database } from './types.sql.tables.js'
+ * @import { Config } from './types.public.js'
+ * @import { Dialect } from 'kysely'
+ */
+
 import { App } from '@storecraft/core';
 import { impl as auth_users } from './src/con.auth_users.js';
 import { impl as collections } from './src/con.collections.js';
@@ -25,15 +32,10 @@ const assert = (b, msg) => {
   if(!Boolean(b)) throw new Error(msg);
 }
 
-/**
- * @typedef {import('./types.public.d.ts').Config} Config
- * @typedef {import('./types.sql.tables.d.ts').Database} Database
- * @typedef {import('kysely').Dialect} Dialect
- * @typedef {import('@storecraft/core/database').db_driver} db_driver
-*/
 
 /**
- * @implements {db_driver}
+ * @template {Config} [ConfigType=Config]
+ * @implements {db_driver<ConfigType>}
  */
 export class SQL {
 
@@ -43,7 +45,7 @@ export class SQL {
   /** @type {App<any, any, any>} */ 
   #_app;
 
-  /** @type {Config} */ 
+  /** @type {ConfigType} */ 
   #_config;
 
   /** @type {Kysely<Database>} */ 
@@ -54,7 +56,7 @@ export class SQL {
 
   /**
    * 
-   * @param {Config} [config] config 
+   * @param {ConfigType} [config] config 
    */
   constructor(config) {
     this.#_is_ready = false;
@@ -69,16 +71,6 @@ export class SQL {
       this.#_config.dialect_type, 
       'No Dialect Type specified !'
     );
-
-    this.#_client = new Kysely(
-      {
-        dialect: this.#_config.dialect, 
-        plugins: [
-          new ParseJSONResultsPlugin(),
-          new SanitizePlugin()
-        ]
-      }
-    );
   }
 
   throwIfNotReady() {
@@ -89,13 +81,9 @@ export class SQL {
   }
 
   /**
-   * 
-   * @param {App<any, any, any>} app 
-   * 
-   * 
-   * @returns {Promise<this>}
+   * @type {db_driver["init"]}
    */
-  async init(app) {
+  init(app) {
     if(this.isReady)
       return this;
 
@@ -144,6 +132,16 @@ export class SQL {
   }
 
   get client() { 
+    this.#_client = this.#_client ?? new Kysely(
+      {
+        dialect: this.config.dialect, 
+        plugins: [
+          new ParseJSONResultsPlugin(),
+          new SanitizePlugin()
+        ]
+      }
+    );
+
     return this.#_client; 
   }
 

package/migrations.mysql/00002_seed_email_templates.js

@@ -0,0 +1 @@
+export * from '../migrations.shared/00002_seed_email_templates.js'

package/migrations.postgres/00002_seed_email_templates.js

@@ -0,0 +1 @@
+export * from '../migrations.shared/00002_seed_email_templates.js'

package/migrations.shared/00002_seed_email_templates.js

@@ -0,0 +1,27 @@
+import { Kysely } from 'kysely'
+import { upsert } from '../src/con.templates.js'
+import { templates } from '@storecraft/core/assets/seed-templates-v2.js';
+
+/**
+ * @typedef {import('../types.sql.tables.js').Database} Database
+ */
+
+/**
+ * 
+ * @param {Kysely<Database>} db 
+ */
+export async function up(db) {
+  
+  for (const template of templates.slice(0)) {
+    const result = await upsert(db)(template, template.search);
+    if(!result)
+      throw new Error('Failed to write a template object')
+  }
+}
+
+/**
+ * 
+ * @param {Kysely<Database>} db 
+ */
+export async function down(db) {
+}

package/migrations.sqlite/00002_seed_email_templates.js

@@ -0,0 +1 @@
+export * from '../migrations.shared/00002_seed_email_templates.js'

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@storecraft/database-sql-base",
-  "version": "1.0.10",
+  "version": "1.0.12",
   "description": "Official SQL Database driver for storecraft",
   "license": "MIT",
   "author": "Tomer Shalev (https://github.com/store-craft)",

package/src/con.auth_users.js

@@ -1,14 +1,14 @@
+/**
+ * @import { db_auth_users as db_col } from '@storecraft/core/database'
+ */
 import { SQL } from '../index.js'
-import { sanitize_array } from './utils.funcs.js'
-import { count_regular, delete_me, insert_search_of, insert_tags_of, regular_upsert_me, 
-  where_id_or_handle_table, 
-  with_media, 
-  with_tags} from './con.shared.js'
+import { sanitize, sanitize_array } from './utils.funcs.js'
+import { 
+  count_regular, delete_me, insert_search_of, insert_tags_of, 
+  regular_upsert_me, where_id_or_handle_table, with_media, with_tags
+} from './con.shared.js'
 import { query_to_eb, query_to_sort } from './utils.query.js';
 
-/**
- * @typedef {import('@storecraft/core/database').db_auth_users} db_col
- */
 
 export const table_name = 'auth_users';
 
@@ -60,7 +60,8 @@ const get = (driver) => {
       .selectFrom(table_name)
       .selectAll()
       .where(where_id_or_handle_table(id_or_email))
-      .executeTakeFirst();
+      .executeTakeFirst()
+      .then(sanitize);
   }
 }
 
@@ -70,11 +71,12 @@ const get = (driver) => {
  * @returns {db_col["getByEmail"]}
  */
 const getByEmail = (driver) => {
-  return (email) => {
+  return async (email) => {
     return driver.client
       .selectFrom('auth_users')
       .selectAll().where('email', '=', email)
-      .executeTakeFirst();
+      .executeTakeFirst()
+      .then(sanitize);
   }
 }
 
@@ -134,13 +136,13 @@ const list = (driver) => {
           return query_to_eb(eb, query, table_name);
         }
       )
-      .orderBy(query_to_sort(query))
+      .orderBy(query_to_sort(query, 'auth_users'))
       .limit(query.limitToLast ?? query.limit ?? 10)
       .execute();
 
     if(query.limitToLast) items.reverse();
 
-    return items;
+    return sanitize_array(items);
   }
 }
 

package/src/con.collections.js

@@ -1,3 +1,6 @@
+/**
+ * @import { db_collections as db_col } from '@storecraft/core/database'
+ */
 import { SQL } from '../index.js'
 import { report_document_media } from './con.images.js'
 import { delete_entity_values_by_value_or_reporter, delete_me, 
@@ -6,14 +9,12 @@ import { delete_entity_values_by_value_or_reporter, delete_me,
   select_entity_ids_by_value_or_reporter, 
   regular_upsert_me, where_id_or_handle_table, 
   with_media, with_tags, 
-  count_regular} from './con.shared.js'
-import { sanitize_array } from './utils.funcs.js'
+  count_regular,
+  with_search} from './con.shared.js'
+import { sanitize, sanitize_array } from './utils.funcs.js'
 import { query_to_eb, query_to_sort } from './utils.query.js'
 
 
-/**
- * @typedef {import('@storecraft/core/database').db_collections} db_col
- */
 export const table_name = 'collections'
 
 /**
@@ -61,17 +62,17 @@ const upsert = (driver) => {
  */
 const get = (driver) => {
   return (id_or_handle, options) => {
-
     return driver.client
       .selectFrom(table_name)
       .selectAll('collections')
       .select(eb => [
         with_tags(eb, eb.ref('collections.id'), driver.dialectType),
-        with_media(eb, eb.ref('collections.id'), driver.dialectType)
+        with_media(eb, eb.ref('collections.id'), driver.dialectType),
+        with_search(eb, eb.ref('collections.id'), driver.dialectType)
       ])
       .where(where_id_or_handle_table(id_or_handle))
-    //  .compile()
-      .executeTakeFirst();
+      .executeTakeFirst()
+      .then(sanitize);
   }
 }
 
@@ -124,13 +125,14 @@ const list = (driver) => {
       .select(eb => [
         with_tags(eb, eb.ref('collections.id'), driver.dialectType),
         with_media(eb, eb.ref('collections.id'), driver.dialectType),
+        with_search(eb, eb.ref('collections.id'), driver.dialectType),
       ])
       .where(
         (eb) => {
           return query_to_eb(eb, query, table_name);
         }
       )
-      .orderBy(query_to_sort(query))
+      .orderBy(query_to_sort(query, 'collections'))
       .limit(query.limitToLast ?? query.limit ?? 10)
       .execute();
 
@@ -166,7 +168,7 @@ const list_collection_products = (driver) => {
           ].filter(Boolean)
         )
       )
-      .orderBy(query_to_sort(query))
+      .orderBy(query_to_sort(query, 'products'))
       .limit(query.limitToLast ?? query.limit ?? 10)
       .execute();
 

package/src/con.customers.js

@@ -1,15 +1,15 @@
+/**
+ * @import { db_customers as db_col } from '@storecraft/core/database'
+ */
 import { SQL } from '../index.js'
 import { report_document_media } from './con.images.js'
 import { count_regular, delete_me, delete_media_of, delete_search_of, 
   delete_tags_of, insert_media_of, insert_search_of, 
   insert_tags_of, regular_upsert_me, where_id_or_handle_table, 
-  with_media, with_tags} from './con.shared.js'
-import { sanitize_array } from './utils.funcs.js'
+  with_media, with_search, with_tags} from './con.shared.js'
+import { sanitize, sanitize_array } from './utils.funcs.js'
 import { query_to_eb, query_to_sort } from './utils.query.js'
 
-/**
- * @typedef {import('@storecraft/core/database').db_customers} db_col
- */
 export const table_name = 'customers'
 
 /**
@@ -64,9 +64,11 @@ const get = (driver) => {
       .select(eb => [
         with_media(eb, id, driver.dialectType),
         with_tags(eb, id, driver.dialectType),
+        with_search(eb, id, driver.dialectType),
       ])
       .where(where_id_or_handle_table(id))
-      .executeTakeFirst();
+      .executeTakeFirst()
+      .then(sanitize);
   }
 }
 
@@ -129,13 +131,14 @@ const list = (driver) => {
       .select(eb => [
         with_media(eb, eb.ref('customers.id'), driver.dialectType),
         with_tags(eb, eb.ref('customers.id'), driver.dialectType),
+        with_search(eb, eb.ref('customers.id'), driver.dialectType),
       ].filter(Boolean))
       .where(
         (eb) => {
           return query_to_eb(eb, query, table_name);
         }
       )
-      .orderBy(query_to_sort(query))
+      .orderBy(query_to_sort(query, table_name))
       .limit(query.limitToLast ?? query.limit ?? 10)
       .execute();
 
@@ -174,7 +177,7 @@ const list_customer_orders = (driver) => {
           ].filter(Boolean)
         )
       )
-      .orderBy(query_to_sort(query))
+      .orderBy(query_to_sort(query, 'orders'))
       .limit(query.limitToLast ?? query.limit ?? 10)
       .execute();
 

package/src/con.discounts.js

@@ -1,3 +1,6 @@
+/**
+ * @import { db_discounts as db_col } from '@storecraft/core/database'
+ */
 import { enums } from '@storecraft/core/api'
 import { SQL } from '../index.js'
 import { discount_to_conjunctions } from './con.discounts.utils.js'
@@ -6,14 +9,12 @@ import { delete_entity_values_by_value_or_reporter,
   delete_tags_of, insert_media_of, insert_search_of, 
   insert_tags_of, select_entity_ids_by_value_or_reporter, regular_upsert_me, where_id_or_handle_table, 
   with_media, with_tags,
-  count_regular} from './con.shared.js'
-import { sanitize_array } from './utils.funcs.js'
+  count_regular,
+  with_search} from './con.shared.js'
+import { sanitize, sanitize_array } from './utils.funcs.js'
 import { query_to_eb, query_to_sort } from './utils.query.js'
 import { report_document_media } from './con.images.js'
 
-/**
- * @typedef {import('@storecraft/core/database').db_discounts} db_col
- */
 export const table_name = 'discounts'
 
 /**
@@ -37,6 +38,12 @@ const upsert = (driver) => {
           // remove all products relation to this discount
           await delete_entity_values_by_value_or_reporter('products_to_discounts')(
             trx, item.id, item.handle);
+
+          await delete_entity_values_by_value_or_reporter('entity_to_search_terms')(
+            trx, `discount:${item.id}`);
+          await delete_entity_values_by_value_or_reporter('entity_to_search_terms')(
+            trx, `discount:${item.handle}`);
+
           if(item.active && item.application.id===enums.DiscountApplicationEnum.Auto.id) {
             // make connections
             await trx
@@ -56,6 +63,37 @@ const upsert = (driver) => {
                 )
             ).execute();
 
+            await trx
+            .insertInto('entity_to_search_terms')
+            .columns(['entity_handle', 'entity_id', 'value'])
+            .expression(eb => 
+              eb.selectFrom('products')
+                .select(eb => [
+                    'handle as entity_handle',
+                    'id as entity_id',
+                    eb.val(`discount:${item.id}`).as('value'),
+                  ]
+                )
+                .where(
+                  eb => eb.and(discount_to_conjunctions(eb, item))
+                )
+            ).execute();      
+
+            await trx
+            .insertInto('entity_to_search_terms')
+            .columns(['entity_handle', 'entity_id', 'value'])
+            .expression(eb => 
+              eb.selectFrom('products')
+                .select(eb => [
+                    'handle as entity_handle',
+                    'id as entity_id',
+                    eb.val(`discount:${item.handle}`).as('value'),
+                  ]
+                )
+                .where(
+                  eb => eb.and(discount_to_conjunctions(eb, item))
+                )
+            ).execute();                     
           }
 
           ///
@@ -100,9 +138,11 @@ const get = (driver) => {
       .select(eb => [
         with_media(eb, id_or_handle, driver.dialectType),
         with_tags(eb, id_or_handle, driver.dialectType),
+        with_search(eb, id_or_handle, driver.dialectType),
       ].filter(Boolean))
       .where(where_id_or_handle_table(id_or_handle))
-      .executeTakeFirst();
+      .executeTakeFirst()
+      .then(sanitize);
   }
 }
 
@@ -156,13 +196,14 @@ const list = (driver) => {
       .select(eb => [
         with_media(eb, eb.ref('discounts.id'), driver.dialectType),
         with_tags(eb, eb.ref('discounts.id'), driver.dialectType),
+        with_search(eb, eb.ref('discounts.id'), driver.dialectType),
       ].filter(Boolean))
       .where(
         (eb) => {
           return query_to_eb(eb, query, table_name);
         }
       )
-      .orderBy(query_to_sort(query))
+      .orderBy(query_to_sort(query, table_name))
       .limit(query.limitToLast ?? query.limit ?? 10)
       .execute();
 
@@ -179,6 +220,10 @@ const list = (driver) => {
 const list_discount_products = (driver) => {
   return async (handle_or_id, query={}) => {
 
+    // TODO: try to rewrite this with JOIN to products_to_discounts ON products.id=entity_id
+    // TODO: and then filter by value==handle_or_id_of_discount
+    // TODO: I think it will be better and more memory efficient for the database
+    // TODO: becausee right now it loads all the eligible products ids in advance
     const items = await driver.client
       .selectFrom('products')
       .selectAll()
@@ -198,7 +243,7 @@ const list_discount_products = (driver) => {
           ].filter(Boolean)
         )
       )
-      .orderBy(query_to_sort(query))
+      .orderBy(query_to_sort(query, 'products'))
       .limit(query.limitToLast ?? query.limit ?? 10)
       .execute();
 

package/src/con.discounts.utils.js

@@ -1,11 +1,20 @@
+/**
+ * @import { 
+ *  DiscountType, FilterValue_p_in_price_range, FilterValue_p_not_in_collections, 
+ *  FilterValue_p_in_collections, FilterValue_p_not_in_tags, FilterValue_p_in_tags, 
+ *  FilterValue_p_in_products, FilterValue_p_not_in_products 
+ * } from '@storecraft/core/api'
+ * @import { Database } from '../types.sql.tables.js'
+ * @import { ExpressionBuilder, BinaryOperator } from 'kysely'
+ */
 import { enums } from "@storecraft/core/api";
 
-/** @param {import("@storecraft/core/api").DiscountType} d */
+/** @param {DiscountType} d */
 const is_order_discount = d => {
   return (d.info.details.meta.id===enums.DiscountMetaEnum.order.id);
 }
 
-/** @param {import("@storecraft/core/api").DiscountType} d */
+/** @param {DiscountType} d */
 const is_automatic_discount = d => {
   return (d.application.id===enums.DiscountApplicationEnum.Auto.id);
 }
@@ -14,10 +23,9 @@ const extract_abs_number = v => {
   return v && !isNaN(v) && v!==Infinity && Math.abs(v);
 }
 /**
- * @typedef {import("../index.js").Database} Database
- * @param {import("kysely").ExpressionBuilder<Database, 'products'>} eb 
+ * @param {ExpressionBuilder<Database, 'products'>} eb 
  * @param {keyof Pick<Database, 'entity_to_tags_projections' | 'products_to_collections'>} table 
- * @param {import("kysely").BinaryOperator} op 
+ * @param {BinaryOperator} op 
  * @param {string[]} value 
  */
 const eb_in = (eb, table, op, value) => {
@@ -42,8 +50,8 @@ const eb_in = (eb, table, op, value) => {
 /**
  * create a mongodb conjunctions clauses from discount, intended
  * for filtering.
- * @param {import("kysely").ExpressionBuilder<Database, 'products'>} eb 
- * @param {import("@storecraft/core/api").DiscountType} d 
+ * @param {ExpressionBuilder<Database, 'products'>} eb 
+ * @param {DiscountType} d 
  */
 export const discount_to_conjunctions = (eb, d) => {
   // discount has to be product discount + automatic + active + has filters
@@ -66,8 +74,10 @@ export const discount_to_conjunctions = (eb, d) => {
         break;
       case enums.FilterMetaEnum.p_in_products.op:
         {
-          /** @type {import("@storecraft/core/api").FilterValue_p_in_products} */
-          const cast = Array.isArray(filter?.value) ? filter.value : [];
+          
+          const cast = /** @type {FilterValue_p_in_products} */ (
+            Array.isArray(filter?.value) ? filter.value : []
+          );
 
           conjunctions.push(
             eb(
@@ -79,8 +89,10 @@ export const discount_to_conjunctions = (eb, d) => {
         break;
       case enums.FilterMetaEnum.p_not_in_products.op:
         {
-          /** @type {import("@storecraft/core/api").FilterValue_p_not_in_products} */
-          const cast = Array.isArray(filter?.value) ? filter.value : [];
+          
+          const cast = /** @type {FilterValue_p_not_in_products} */ (
+            Array.isArray(filter?.value) ? filter.value : []
+          );
 
           conjunctions.push(
             eb(
@@ -92,8 +104,10 @@ export const discount_to_conjunctions = (eb, d) => {
         break;
       case enums.FilterMetaEnum.p_in_tags.op:
         {
-          /** @type {import("@storecraft/core/api").FilterValue_p_in_tags} */
-          const cast = Array.isArray(filter?.value) ? filter.value : [];
+          
+          const cast = /** @type {FilterValue_p_in_tags} */(
+            Array.isArray(filter?.value) ? filter.value : []
+          );
           
           conjunctions.push(
             eb_in(
@@ -105,8 +119,9 @@ export const discount_to_conjunctions = (eb, d) => {
         break;
       case enums.FilterMetaEnum.p_not_in_tags.op:
         {
-          /** @type {import("@storecraft/core/api").FilterValue_p_not_in_tags} */
-          const cast = Array.isArray(filter?.value) ? filter.value : [];
+          const cast = /** @type {FilterValue_p_not_in_tags} */ (
+            Array.isArray(filter?.value) ? filter.value : []
+          );
 
           conjunctions.push(
             eb.not(
@@ -120,8 +135,9 @@ export const discount_to_conjunctions = (eb, d) => {
         break;
       case enums.FilterMetaEnum.p_in_collections.op:
         {
-          /** @type {import("@storecraft/core/api").FilterValue_p_in_collections} */
-          const cast = Array.isArray(filter?.value) ? filter.value : [];
+          const cast = /** @type {FilterValue_p_in_collections} */ (
+            Array.isArray(filter?.value) ? filter.value : []
+          );
 
           // PROBLEM: we only have ids, but use handles in the filters
           conjunctions.push(
@@ -134,8 +150,9 @@ export const discount_to_conjunctions = (eb, d) => {
         break;
       case enums.FilterMetaEnum.p_not_in_collections.op:
         {
-          /** @type {import("@storecraft/core/api").FilterValue_p_not_in_collections} */
-          const cast = Array.isArray(filter?.value) ? filter.value : [];
+          const cast = /** @type {FilterValue_p_not_in_collections} */ (
+            Array.isArray(filter?.value) ? filter.value : []
+          );
 
           conjunctions.push(
             eb.not(
@@ -149,12 +166,13 @@ export const discount_to_conjunctions = (eb, d) => {
         break;
       case enums.FilterMetaEnum.p_in_price_range.op:
         {
-          /** @type {import("@storecraft/core/api").FilterValue_p_in_price_range} */
-          const cast = {
-            from: 0,
-            to: Number.POSITIVE_INFINITY,
-            ...(filter?.value ?? {}),
-          };
+          const cast = /** @type {FilterValue_p_in_price_range} */ (
+            {
+              from: 0,
+              to: Number.POSITIVE_INFINITY,
+              ...(filter?.value ?? {}),
+            }
+          );
 
           const from = extract_abs_number(cast.from);
           const to = extract_abs_number(cast.to);

package/src/con.helpers.json.js

@@ -140,8 +140,8 @@ export function jsonArrayFrom(expr, sql_type) {
       return pg_jsonArrayFrom(expr);
     case 'MYSQL':
       return mysql_jsonArrayFrom(expr);
-    case 'MSSQL':
-      return mssql_jsonArrayFrom(expr);
+    // case 'MSSQL':
+    //   return mssql_jsonArrayFrom(expr);
     default:
       throw new Error(`sql_type=${sql_type} NOT SUPPORTED !`);
   }  
@@ -171,7 +171,6 @@ export function jsonArrayFrom(expr, sql_type) {
  * @template O
  * @param {import('./con.helpers.json.js').SelectQueryBuilderExpression<O>} expr 
  * @param {import('../types.public.d.ts').SqlDialectType} sql_type 
- * @returns {import('kysely').RawBuilder<import('kysely').Simplify<O>[]>}
  */
 export function stringArrayFrom(expr, sql_type) {
   switch(sql_type) {
@@ -181,13 +180,14 @@ export function stringArrayFrom(expr, sql_type) {
       return pg_stringArrayFrom(expr);
     case 'MYSQL':
       return mysql_stringArrayFrom(expr);
-    case 'MSSQL':
-      return mssql_stringArrayFrom(expr);
+    // case 'MSSQL':
+    //   return mssql_stringArrayFrom(expr);
     default:
       throw new Error(`sql_type=${sql_type} NOT SUPPORTED !`);
   }  
 }
 
+
 /**
  * ### Examples
  *
@@ -223,8 +223,8 @@ export function jsonObjectFrom(expr, sql_type) {
       return pg_jsonObjectFrom(expr);
     case 'MYSQL':
       return mysql_jsonObjectFrom(expr);
-    case 'MSSQL':
-      return mssql_jsonObjectFrom(expr);
+    // case 'MSSQL':
+    //   return mssql_jsonObjectFrom(expr);
     default:
       throw new Error(`sql_type=${sql_type} NOT SUPPORTED !`);
   }

package/src/con.helpers.json.mysql.js

@@ -106,7 +106,7 @@ export function mysql_jsonArrayFrom(expr) {
  * ```
  * @template O
  * @param {import('./con.helpers.json.js').SelectQueryBuilderExpression<O>} expr 
- * @returns {import('kysely').RawBuilder<import('kysely').Simplify<O>[]>}
+ * @returns {import('kysely').RawBuilder<string[]>}
  */
 export function mysql_stringArrayFrom(expr) {
   const arg = extract_first_selection(expr, 'agg');

package/src/con.helpers.json.postgres.js

@@ -51,7 +51,7 @@ import { extract_first_selection } from './con.helpers.json.js';
  * ```
  * @template O
  * @param {import('./con.helpers.json.js').SelectQueryBuilderExpression<O>} expr 
- * @returns {import('kysely').RawBuilder<import('kysely').Simplify<O>[]>}
+ * @returns {import('kysely').RawBuilder<string[]>}
  */
 export function pg_stringArrayFrom(expr) {
   const arg = extract_first_selection(expr, 'agg');

package/src/con.helpers.json.sqlite.js

@@ -114,7 +114,7 @@ export function sqlite_jsonArrayFrom(expr) {
  * ```
  * @template O
  * @param {import('./con.helpers.json.js').SelectQueryBuilderExpression<O>} expr 
- * @returns {import('kysely').RawBuilder<import('kysely').Simplify<O>[]>}
+ * @returns {import('kysely').RawBuilder<string[]>}
  */
 export function sqlite_stringArrayFrom(expr) {
   const arg = extract_first_selection(expr, 'agg');