@stordata/vsphere-soapify 0.0.27 → 0.0.29

package/.gitlab-ci.yml

@@ -1,10 +1,17 @@
-image: docker.stordata.fr/stordata/docker-node:16
+image: docker.stordata.fr/stordata/docker-node:18
 
 stages:
-  - build
+  - test
 
-build:
-  stage: build
+include:
+  - template: Jobs/SAST.gitlab-ci.yml
+  - template: Jobs/Dependency-Scanning.gitlab-ci.yml
+
+variables:
+  SAST_EXCLUDED_PATHS: "*.spec.js, *.test.js"
+
+test:
+  stage: test
   tags:
     - docker
   script:

package/.nvmrc

@@ -1 +1 @@
-16.13.0
+18.12.1

package/lib/client.js

@@ -3,18 +3,18 @@
 const soap = require('soap'),
       _ = require('lodash'),
       Parser = require('./parser'),
-      request = require('./request'),
       { ServiceInstance, HostSystem, VirtualMachine, Datacenter, Datastore } = require('./sdk').managed,
       { PerfQuerySpec, PerfMetricId } = require('./sdk').data,
       DEFAULT_FEATURES = require('./features');
 
 module.exports = class Client {
+
   /**
    * Creates a new Client to access a vSphere server.
    *
    * @param {String} url The URL to the vSphere endpoint.
    *  Use the base URL only, the library manages the actual SDK endpoints automatically
-   * @param {Object} [requestOptions] Options given to request. See https://github.com/request/request#requestoptions-callback
+   * @param {Object} [options] The client options, passed to the `soap` library directly
    * @param {Object} [features] An optional list of feature flags to control advanced settings of the created Client
    * @param {boolean} [features.alwaysUseMaxSampleInQuerySpec=false] Whether to force the use of `maxSample` in QuerySpec objects,
    *  even though this might form invalid calls. Use with caution !
@@ -22,9 +22,9 @@ module.exports = class Client {
    *
    * @constructor
    */
-  constructor(url, requestOptions, features) {
+  constructor(url, options, features) {
     this.url = url;
-    this.requestOptions = requestOptions;
+    this.options = options;
     this.features = _.defaults(features, DEFAULT_FEATURES);
 
     this.parser = new Parser(this);
@@ -43,10 +43,7 @@ module.exports = class Client {
   getClient() {
     const wsdl = `${__dirname}/wsdl/5.5/vimService.wsdl`;
 
-    return this._cache('client', () => soap.createClientAsync(wsdl, {
-      endpoint: this.url,
-      request: request(this.url, this.requestOptions)
-    }));
+    return this._cache('client', () => soap.createClientAsync(wsdl, { endpoint: this.url, ...this.options }));
   }
 
   /**