@stoprocent/noble 2.3.4 → 2.3.6

package/lib/noble.js

@@ -167,6 +167,7 @@ class Noble extends EventEmitter {
         return;
       }
       const timeoutId = setTimeout(() => {
+        this.removeListener('stateChange', listener);
         reject(new Error('Timeout waiting for Noble to be powered on'));
       }, timeout);
 
@@ -187,10 +188,12 @@ class Noble extends EventEmitter {
     const self = this;
     const scan = (state) => {
       if (state !== 'poweredOn') {
-        self.once('stateChange', scan.bind(self));
+        const boundScan = scan.bind(self);
+        self.once('stateChange', boundScan);
         const error = new Error(`Could not start scanning, state is ${state} (not poweredOn)`);
 
         if (typeof callback === 'function') {
+          self.removeListener('stateChange', boundScan);
           callback(error);
         } else {
           throw error;

package/package.json

@@ -6,7 +6,7 @@
   "license": "MIT",
   "name": "@stoprocent/noble",
   "description": "A Node.js BLE (Bluetooth Low Energy) central library.",
-  "version": "2.3.4",
+  "version": "2.3.6",
   "repository": {
     "type": "git",
     "url": "https://github.com/stoprocent/noble.git"

package/test/noble.test.js

@@ -184,6 +184,24 @@ describe('noble', () => {
       );
       expect(mockBindings.startScanning).not.toHaveBeenCalled();
     });
+
+    test('should not cause MaxListenersExceededWarning warnings after repeated unauthorized errors', async () => {
+      noble._state = 'unauthorized';
+
+      const promise = noble.waitForPoweredOnAsync(0);
+
+      for (let i = 0; i < 10; i++) {
+        try {
+          await noble.startScanningAsync([]);
+        } catch (error) {
+        }
+      }
+
+      const finalListenerCount = noble.listenerCount('stateChange');
+
+      await expect(promise).rejects.toThrow('Timeout waiting for Noble to be powered on');
+      expect(finalListenerCount).toBeLessThanOrEqual(1);
+    });
   });
 
   describe('stopScanning', () => {
@@ -420,6 +438,19 @@ describe('noble', () => {
       // Promise should reject after timeout
       await expect(promise).rejects.toThrow('Timeout waiting for Noble to be powered on');
     });
+
+    test('should not cause MaxListenersExceededWarning warnings with multiple timeout calls', async () => {
+      noble._state = 'poweredOff';
+
+      const promises = [];
+      for (let i = 0; i < 11; i++) {
+        promises.push(noble.waitForPoweredOnAsync(0).catch(() => {}));
+      }
+      await Promise.all(promises);
+      const finalListenerCount = noble.listenerCount('stateChange');
+
+      expect(finalListenerCount).toBeLessThanOrEqual(1);
+    });
   });
 
   test('should change address', () => {