@stoprocent/noble 1.10.2 → 1.11.0

package/lib/hci-socket/gatt.js

@@ -199,9 +199,9 @@ Gatt.prototype.errorResponse = function (opcode, handle, status) {
 
 Gatt.prototype._queueCommand = function (buffer, callback, writeCallback) {
   this._commandQueue.push({
-    buffer: buffer,
-    callback: callback,
-    writeCallback: writeCallback
+    buffer,
+    callback,
+    writeCallback
   });
 
   if (this._currentCommand === null) {
@@ -375,7 +375,7 @@ Gatt.prototype.discoverServices = function (uuids) {
       }
     }
 
-    if ((opcode !== ATT_OP_READ_BY_GROUP_RESP && opcode !== ATT_OP_ERROR) || services[services.length - 1].endHandle === 0xffff) {
+    if (opcode !== ATT_OP_READ_BY_GROUP_RESP || services[services.length - 1].endHandle === 0xffff) {
       const serviceUuids = [];
       for (i = 0; i < services.length; i++) {
         const uuid = services[i].uuid.trim();

package/lib/hci-socket/hci.js

@@ -845,8 +845,8 @@ Hci.prototype.onSocketData = function (data) {
         this.emit('aclDataPkt', handle, cid, pktData);
       } else {
         this._handleBuffers[handle] = {
-          length: length,
-          cid: cid,
+          length,
+          cid,
           data: pktData
         };
       }

package/lib/noble.js

@@ -18,7 +18,7 @@ function Noble (bindings) {
   this._services = {};
   this._characteristics = {};
   this._descriptors = {};
-  this._discoveredPeripheralUUids = [];
+  this._discoveredPeripheralUUids = {};
 
   this._bindings.on('stateChange', this.onStateChange.bind(this));
   this._bindings.on('addressChange', this.onAddressChange.bind(this));
@@ -58,7 +58,11 @@ function Noble (bindings) {
       this.initialized = true;
 
       process.nextTick(() => {
-        this._bindings.init();
+        try {
+          this._bindings.init();
+        } catch (error) {
+          this.emit('warning', 'Initialization of USB device failed: ' + error.message);
+        }
       });
     }
   });
@@ -131,7 +135,7 @@ const startScanning = function (serviceUuids, allowDuplicates, callback) {
         });
       }
 
-      this._discoveredPeripheralUUids = [];
+      this._discoveredPeripheralUUids = {};
       this._allowDuplicates = allowDuplicates;
 
       this._bindings.startScanning(serviceUuids, allowDuplicates);
@@ -204,10 +208,10 @@ Noble.prototype.onDiscover = function (uuid, address, addressType, connectable,
     peripheral.rssi = rssi;
   }
 
-  const previouslyDiscoverd = (this._discoveredPeripheralUUids.indexOf(uuid) !== -1);
+  const previouslyDiscoverd = this._discoveredPeripheralUUids[uuid] === true;
 
   if (!previouslyDiscoverd) {
-    this._discoveredPeripheralUUids.push(uuid);
+    this._discoveredPeripheralUUids[uuid] = true;
   }
 
   if (this._allowDuplicates || !previouslyDiscoverd || (!scannable && !connectable)) {
@@ -587,7 +591,7 @@ Noble.prototype.onHandleNotify = function (peripheralUuid, handle, data) {
 
 Noble.prototype.onMtu = function (peripheralUuid, mtu) {
   const peripheral = this._peripherals[peripheralUuid];
-  if (peripheral && 'mtu' in peripheral && mtu) peripheral.mtu = mtu;
+  if (peripheral && mtu) peripheral.mtu = mtu;
 };
 
 module.exports = Noble;

package/lib/peripheral.js

@@ -1,8 +1,6 @@
 const events = require('events');
 const util = require('util');
 
-const Manufacturer = require('./manufacture');
-
 function Peripheral (noble, id, address, addressType, connectable, advertisement, rssi, scannable) {
   this._noble = noble;
 
@@ -17,11 +15,6 @@ function Peripheral (noble, id, address, addressType, connectable, advertisement
   this.services = null;
   this.mtu = null;
   this.state = 'disconnected';
-  this.manufacturer = null;
-
-  if (typeof this.advertisement !== 'undefined' && typeof this.advertisement.manufacturerData !== 'undefined') {
-    this.manufacturer = new Manufacturer(noble, this.advertisement.manufacturerData);
-  }
 }
 
 util.inherits(Peripheral, events.EventEmitter);

package/lib/resolve-bindings.js

@@ -1,7 +1,43 @@
+const os = require('os');
 
-module.exports = function (options) {
-  if (process.env.NOBLE_HCI_UART_PORT) {
-    return new (require('./hci-uart/bindings'))(options);
+function getWindowsBindings () {
+  const ver = os
+    .release()
+    .split('.')
+    .map((str) => parseInt(str, 10));
+  if (
+    !(
+      ver[0] > 10 ||
+      (ver[0] === 10 && ver[1] > 0) ||
+      (ver[0] === 10 && ver[1] === 0 && ver[2] >= 15063)
+    )
+  ) {
+    return require('./hci-socket/bindings');
+  } else {
+    return require('./win/bindings');
+  }
+}
+
+module.exports = function (options = {}) {
+  const platform = os.platform();
+
+  if (process.env.NOBLE_WEBSOCKET) {
+    return new (require('./websocket/bindings'))(options);
+  } else if (process.env.NOBLE_DISTRIBUTED) {
+    return new (require('./distributed/bindings'))(options);
+  } else if (
+    platform === 'linux' ||
+    platform === 'freebsd' ||
+    (process.env.BLUETOOTH_HCI_SOCKET_UART_PORT ||
+      process.env.BLUETOOTH_HCI_SOCKET_FORCE_UART) ||
+    (process.env.BLUETOOTH_HCI_SOCKET_USB_VID &&
+      process.env.BLUETOOTH_HCI_SOCKET_USB_PID)
+  ) {
+    return new (require('./hci-socket/bindings'))(options);
+  } else if (platform === 'darwin') {
+    return new (require('./mac/bindings'))(options);
+  } else if (platform === 'win32') {
+    return new (getWindowsBindings())(options);
   } else {
     throw new Error('Unsupported platform');
   }

package/lib/webbluetooth/bindings.js

@@ -109,9 +109,9 @@ NobleBindings.prototype.startScanning = function (options, allowDuplicates) {
 
         self._peripherals[address] = {
           uuid: address,
-          address: address,
+          address,
           advertisement: { localName: device.name }, // advertisement,
-          device: device,
+          device,
           cachedServices: {},
           localName: device.name,
           serviceUuids: options.services

package/lib/websocket/bindings.js

@@ -79,9 +79,9 @@ NobleBindings.prototype._onMessage = function (event) {
 
     this._peripherals[peripheralUuid] = {
       uuid: peripheralUuid,
-      address: address,
-      advertisement: advertisement,
-      rssi: rssi
+      address,
+      advertisement,
+      rssi
     };
 
     this.emit('discover', peripheralUuid, address, addressType, connectable, advertisement, rssi);
@@ -135,8 +135,8 @@ NobleBindings.prototype._sendCommand = function (command, errorCallback) {
 NobleBindings.prototype.startScanning = function (serviceUuids, allowDuplicates) {
   this._startScanCommand = {
     action: 'startScanning',
-    serviceUuids: serviceUuids,
-    allowDuplicates: allowDuplicates
+    serviceUuids,
+    allowDuplicates
   };
   this._sendCommand(this._startScanCommand);
 
@@ -186,7 +186,7 @@ NobleBindings.prototype.discoverServices = function (deviceUuid, uuids) {
   this._sendCommand({
     action: 'discoverServices',
     peripheralUuid: peripheral.uuid,
-    uuids: uuids
+    uuids
   });
 };
 
@@ -196,8 +196,8 @@ NobleBindings.prototype.discoverIncludedServices = function (deviceUuid, service
   this._sendCommand({
     action: 'discoverIncludedServices',
     peripheralUuid: peripheral.uuid,
-    serviceUuid: serviceUuid,
-    serviceUuids: serviceUuids
+    serviceUuid,
+    serviceUuids
   });
 };
 
@@ -207,8 +207,8 @@ NobleBindings.prototype.discoverCharacteristics = function (deviceUuid, serviceU
   this._sendCommand({
     action: 'discoverCharacteristics',
     peripheralUuid: peripheral.uuid,
-    serviceUuid: serviceUuid,
-    characteristicUuids: characteristicUuids
+    serviceUuid,
+    characteristicUuids
   });
 };
 
@@ -218,8 +218,8 @@ NobleBindings.prototype.read = function (deviceUuid, serviceUuid, characteristic
   this._sendCommand({
     action: 'read',
     peripheralUuid: peripheral.uuid,
-    serviceUuid: serviceUuid,
-    characteristicUuid: characteristicUuid
+    serviceUuid,
+    characteristicUuid
   });
 };
 
@@ -229,10 +229,10 @@ NobleBindings.prototype.write = function (deviceUuid, serviceUuid, characteristi
   this._sendCommand({
     action: 'write',
     peripheralUuid: peripheral.uuid,
-    serviceUuid: serviceUuid,
-    characteristicUuid: characteristicUuid,
+    serviceUuid,
+    characteristicUuid,
     data: data.toString('hex'),
-    withoutResponse: withoutResponse
+    withoutResponse
   });
 };
 
@@ -242,9 +242,9 @@ NobleBindings.prototype.broadcast = function (deviceUuid, serviceUuid, character
   this._sendCommand({
     action: 'broadcast',
     peripheralUuid: peripheral.uuid,
-    serviceUuid: serviceUuid,
-    characteristicUuid: characteristicUuid,
-    broadcast: broadcast
+    serviceUuid,
+    characteristicUuid,
+    broadcast
   });
 };
 
@@ -254,9 +254,9 @@ NobleBindings.prototype.notify = function (deviceUuid, serviceUuid, characterist
   this._sendCommand({
     action: 'notify',
     peripheralUuid: peripheral.uuid,
-    serviceUuid: serviceUuid,
-    characteristicUuid: characteristicUuid,
-    notify: notify
+    serviceUuid,
+    characteristicUuid,
+    notify
   });
 };
 
@@ -266,8 +266,8 @@ NobleBindings.prototype.discoverDescriptors = function (deviceUuid, serviceUuid,
   this._sendCommand({
     action: 'discoverDescriptors',
     peripheralUuid: peripheral.uuid,
-    serviceUuid: serviceUuid,
-    characteristicUuid: characteristicUuid
+    serviceUuid,
+    characteristicUuid
   });
 };
 
@@ -277,9 +277,9 @@ NobleBindings.prototype.readValue = function (deviceUuid, serviceUuid, character
   this._sendCommand({
     action: 'readValue',
     peripheralUuid: peripheral.uuid,
-    serviceUuid: serviceUuid,
-    characteristicUuid: characteristicUuid,
-    descriptorUuid: descriptorUuid
+    serviceUuid,
+    characteristicUuid,
+    descriptorUuid
   });
 };
 
@@ -289,9 +289,9 @@ NobleBindings.prototype.writeValue = function (deviceUuid, serviceUuid, characte
   this._sendCommand({
     action: 'writeValue',
     peripheralUuid: peripheral.uuid,
-    serviceUuid: serviceUuid,
-    characteristicUuid: characteristicUuid,
-    descriptorUuid: descriptorUuid,
+    serviceUuid,
+    characteristicUuid,
+    descriptorUuid,
     data: data.toString('hex')
   });
 };
@@ -302,7 +302,7 @@ NobleBindings.prototype.readHandle = function (deviceUuid, handle) {
   this._sendCommand({
     action: 'readHandle',
     peripheralUuid: peripheral.uuid,
-    handle: handle
+    handle
   });
 };
 
@@ -312,9 +312,9 @@ NobleBindings.prototype.writeHandle = function (deviceUuid, handle, data, withou
   this._sendCommand({
     action: 'writeHandle',
     peripheralUuid: peripheral.uuid,
-    handle: handle,
+    handle,
     data: data.toString('hex'),
-    withoutResponse: withoutResponse
+    withoutResponse
   });
 };
 

package/lib/win/src/ble_manager.cc

@@ -12,8 +12,10 @@
 #include <winrt/Windows.Storage.Streams.h>
 using winrt::Windows::Devices::Bluetooth::BluetoothCacheMode;
 using winrt::Windows::Devices::Bluetooth::BluetoothConnectionStatus;
+using winrt::Windows::Devices::Bluetooth::BluetoothLEDevice;
 using winrt::Windows::Storage::Streams::DataReader;
 using winrt::Windows::Storage::Streams::DataWriter;
+using winrt::Windows::Storage::Streams::IBuffer;
 
 template <typename T> auto inFilter(std::vector<T> filter, T object)
 {
@@ -190,7 +192,7 @@ bool BLEManager::Connect(const std::string& uuid)
     return true;
 }
 
-void BLEManager::OnConnected(IAsyncOperation<BluetoothLEDevice> asyncOp, AsyncStatus& status,
+void BLEManager::OnConnected(IAsyncOperation<BluetoothLEDevice> asyncOp, AsyncStatus status,
                              const std::string uuid)
 {
     if (status == AsyncStatus::Completed)
@@ -375,6 +377,7 @@ void BLEManager::OnCharacteristicsDiscovered(IAsyncOperation<GattCharacteristics
         auto result = asyncOp.GetResults();
         CHECK_RESULT(result);
         std::vector<std::pair<std::string, std::vector<std::string>>> characteristicsUuids;
+
         FOR(characteristic, result.Characteristics())
         {
             auto id = characteristic.Uuid();

package/lib/win/src/ble_manager.h

@@ -47,7 +47,7 @@ private:
     void OnRadio(Radio& radio);
     void OnScanResult(BluetoothLEAdvertisementWatcher watcher, const BluetoothLEAdvertisementReceivedEventArgs& args);
     void OnScanStopped(BluetoothLEAdvertisementWatcher watcher, const BluetoothLEAdvertisementWatcherStoppedEventArgs& args);
-    void OnConnected(IAsyncOperation<BluetoothLEDevice> asyncOp, AsyncStatus& status, std::string uuid);
+    void OnConnected(IAsyncOperation<BluetoothLEDevice> asyncOp, AsyncStatus status, std::string uuid);
     void OnConnectionStatusChanged(BluetoothLEDevice device, winrt::Windows::Foundation::IInspectable inspectable);
     void OnServicesDiscovered(IAsyncOperation<GattDeviceServicesResult> asyncOp, AsyncStatus status, std::string uuid, std::vector<winrt::guid> serviceUUIDs);
     void OnIncludedServicesDiscovered(IAsyncOperation<GattDeviceServicesResult> asyncOp, AsyncStatus status, std::string uuid, std::string serviceId, std::vector<winrt::guid> serviceUUIDs);

package/lib/win/src/peripheral_winrt.cc

@@ -2,6 +2,7 @@
 #include "winrt_cpp.h"
 
 #include <winrt/Windows.Storage.Streams.h>
+#include <winrt/Windows.Foundation.Collections.h>
 using namespace winrt::Windows::Storage::Streams;
 
 using winrt::Windows::Devices::Bluetooth::BluetoothCacheMode;
@@ -43,6 +44,7 @@ void PeripheralWinrt::Update(const int rssiValue, const BluetoothLEAdvertisement
         advertismentType == BluetoothLEAdvertisementType::ConnectableDirected;
 
     manufacturerData.clear();
+
     for (auto ds : advertisment.DataSections())
     {
         if (ds.DataType() == BluetoothLEAdvertisementDataTypes::TxPowerLevel())

package/lib/win/src/radio_watcher.cc

@@ -9,6 +9,7 @@
 
 #include "radio_watcher.h"
 #include "winrt_cpp.h"
+#include <winrt/Windows.Foundation.Collections.h>
 
 using winrt::Windows::Devices::Radios::RadioKind;
 using winrt::Windows::Foundation::AsyncStatus;

package/lib/win/src/winrt_cpp.cc

@@ -4,6 +4,7 @@
 #include <iomanip>
 
 #include <winrt\Windows.Devices.Bluetooth.h>
+#include <winrt/Windows.Foundation.Collections.h>
 
 std::string ws2s(const wchar_t* wstr)
 {

package/package.json

@@ -7,10 +7,10 @@
   "license": "MIT",
   "name": "@stoprocent/noble",
   "description": "A Node.js BLE (Bluetooth Low Energy) central library.",
-  "version": "1.10.2",
+  "version": "1.11.0",
   "repository": {
     "type": "git",
-    "url": "git+https://github.com/stoprocent/noble.git"
+    "url": "https://github.com/stoprocent/noble.git"
   },
   "bugs": {
     "url": "https://github.com/stoprocent/noble/issues"
@@ -35,35 +35,45 @@
     "win32"
   ],
   "dependencies": {
-    "debug": "^4.3.1"
+    "debug": "^4.3.4",
+    "napi-thread-safe-callback": "^0.0.6",
+    "node-addon-api": "^4.3.0",
+    "node-gyp-build": "^4.5.0"
   },
   "optionalDependencies": {
-    "async": "^3.2.4",
-    "serialport": "^10.4.0"
+    "@stoprocent/bluetooth-hci-socket": "^0.6.1"
   },
   "devDependencies": {
-    "async": "^3.2.0",
+    "async": "^3.2.4",
     "cross-env": "^7.0.3",
-    "eslint": "^7.32.0",
-    "eslint-config-semistandard": "^16.0.0",
-    "eslint-config-standard": "^16.0.3",
-    "eslint-plugin-import": "^2.25.3",
-    "eslint-plugin-node": "^11.1.0",
-    "eslint-plugin-promise": "^5.2.0",
-    "mocha": "^9.2.2",
-    "node-gyp": "^8.4.1",
+    "eslint": "^8.31.0",
+    "eslint-config-semistandard": "^17.0.0",
+    "eslint-config-standard": "^17.0.0",
+    "eslint-plugin-import": "^2.26.0",
+    "eslint-plugin-n": "^15.6.0",
+    "eslint-plugin-promise": "^6.1.1",
+    "mocha": "^10.2.0",
+    "node-gyp": "^9.3.1",
     "nyc": "^15.1.0",
-    "prebuildify": "^5.0.0",
+    "prebuildify": "^5.0.1",
     "prebuildify-ci": "^1.0.5",
-    "prettier": "^2.3.0",
+    "prettier": "^2.8.1",
     "proxyquire": "^2.1.3",
     "should": "~13.2.3",
-    "sinon": "^12.0.1",
-    "ws": "^8.3.0"
+    "sinon": "^15.0.1",
+    "ws": "^8.11.0"
   },
   "scripts": {
+    "install": "node-gyp-build",
     "lint": "eslint \"**/*.js\"",
     "lint-fix": "eslint \"**/*.js\" --fix",
+    "prebuild": "prebuildify --napi --strip",
+    "prebuild-darwin": "prebuildify --napi --strip --arch x64+arm64",
+    "prebuild-win32": "prebuildify --napi --strip",
+    "prebuild-linux": "prebuildify --napi --strip",
+    "prebuild-download": "prebuildify-ci download",
+    "pretest": "npm run rebuild",
+    "rebuild": "node-gyp rebuild",
     "coverage": "nyc npm test && nyc report --reporter=text-lcov > .nyc_output/lcov.info",
     "test": "cross-env NODE_ENV=test mocha --recursive \"test/*.test.js\" \"test/**/*.test.js\" --exit"
   },
@@ -74,11 +84,5 @@
     "napi_versions": [
       4
     ]
-  },
-  "homepage": "https://github.com/stoprocent/noble#readme",
-  "directories": {
-    "example": "examples",
-    "lib": "lib",
-    "test": "test"
   }
 }

package/test/lib/distributed/bindings.test.js

@@ -428,7 +428,7 @@ describe('distributed bindings', () => {
       assert.fail('Should throw an error');
     } catch (e) {
       should(e).instanceOf(Error);
-      should(e.message).eql('Cannot read property \'ws\' of undefined');
+      should(e.message.startsWith('Cannot read') && e.message.includes('\'ws\'') && e.message.includes('undefined')).eql(true);
     }
   });
 
@@ -459,7 +459,7 @@ describe('distributed bindings', () => {
       assert.fail('Should throw an error');
     } catch (e) {
       should(e).instanceOf(Error);
-      should(e.message).eql('Cannot read property \'ws\' of undefined');
+      should(e.message.startsWith('Cannot read') && e.message.includes('\'ws\'') && e.message.includes('undefined')).eql(true);
     }
   });
 
@@ -490,7 +490,7 @@ describe('distributed bindings', () => {
       assert.fail('Should throw an error');
     } catch (e) {
       should(e).instanceOf(Error);
-      should(e.message).eql('Cannot read property \'ws\' of undefined');
+      should(e.message.startsWith('Cannot read') && e.message.includes('\'ws\'') && e.message.includes('undefined')).eql(true);
     }
   });
 
@@ -521,7 +521,7 @@ describe('distributed bindings', () => {
       assert.fail('Should throw an error');
     } catch (e) {
       should(e).instanceOf(Error);
-      should(e.message).eql('Cannot read property \'ws\' of undefined');
+      should(e.message.startsWith('Cannot read') && e.message.includes('\'ws\'') && e.message.includes('undefined')).eql(true);
     }
   });
 
@@ -553,7 +553,7 @@ describe('distributed bindings', () => {
       assert.fail('Should throw an error');
     } catch (e) {
       should(e).instanceOf(Error);
-      should(e.message).eql('Cannot read property \'ws\' of undefined');
+      should(e.message.startsWith('Cannot read') && e.message.includes('\'ws\'') && e.message.includes('undefined')).eql(true);
     }
   });
 
@@ -586,7 +586,7 @@ describe('distributed bindings', () => {
       assert.fail('Should throw an error');
     } catch (e) {
       should(e).instanceOf(Error);
-      should(e.message).eql('Cannot read property \'ws\' of undefined');
+      should(e.message.startsWith('Cannot read') && e.message.includes('\'ws\'') && e.message.includes('undefined')).eql(true);
     }
   });
 
@@ -619,7 +619,7 @@ describe('distributed bindings', () => {
       assert.fail('Should throw an error');
     } catch (e) {
       should(e).instanceOf(Error);
-      should(e.message).eql('Cannot read property \'ws\' of undefined');
+      should(e.message.startsWith('Cannot read') && e.message.includes('\'ws\'') && e.message.includes('undefined')).eql(true);
     }
   });
 
@@ -652,7 +652,7 @@ describe('distributed bindings', () => {
       assert.fail('Should throw an error');
     } catch (e) {
       should(e).instanceOf(Error);
-      should(e.message).eql('Cannot read property \'ws\' of undefined');
+      should(e.message.startsWith('Cannot read') && e.message.includes('\'ws\'') && e.message.includes('undefined')).eql(true);
     }
   });
 
@@ -687,7 +687,7 @@ describe('distributed bindings', () => {
       assert.fail('Should throw an error');
     } catch (e) {
       should(e).instanceOf(Error);
-      should(e.message).eql('Cannot read property \'ws\' of undefined');
+      should(e.message.startsWith('Cannot read') && e.message.includes('\'ws\'') && e.message.includes('undefined')).eql(true);
     }
   });
 
@@ -721,7 +721,7 @@ describe('distributed bindings', () => {
       assert.fail('Should throw an error');
     } catch (e) {
       should(e).instanceOf(Error);
-      should(e.message).eql('Cannot read property \'ws\' of undefined');
+      should(e.message.startsWith('Cannot read') && e.message.includes('\'ws\'') && e.message.includes('undefined')).eql(true);
     }
   });
 
@@ -755,7 +755,7 @@ describe('distributed bindings', () => {
       assert.fail('Should throw an error');
     } catch (e) {
       should(e).instanceOf(Error);
-      should(e.message).eql('Cannot read property \'ws\' of undefined');
+      should(e.message.startsWith('Cannot read') && e.message.includes('\'ws\'') && e.message.includes('undefined')).eql(true);
     }
   });
 
@@ -788,7 +788,7 @@ describe('distributed bindings', () => {
       assert.fail('Should throw an error');
     } catch (e) {
       should(e).instanceOf(Error);
-      should(e.message).eql('Cannot read property \'ws\' of undefined');
+      should(e.message.startsWith('Cannot read') && e.message.includes('\'ws\'') && e.message.includes('undefined')).eql(true);
     }
   });
 
@@ -822,7 +822,7 @@ describe('distributed bindings', () => {
       assert.fail('Should throw an error');
     } catch (e) {
       should(e).instanceOf(Error);
-      should(e.message).eql('Cannot read property \'ws\' of undefined');
+      should(e.message.startsWith('Cannot read') && e.message.includes('\'ws\'') && e.message.includes('undefined')).eql(true);
     }
   });
 
@@ -857,7 +857,7 @@ describe('distributed bindings', () => {
       assert.fail('Should throw an error');
     } catch (e) {
       should(e).instanceOf(Error);
-      should(e.message).eql('Cannot read property \'ws\' of undefined');
+      should(e.message.startsWith('Cannot read') && e.message.includes('\'ws\'') && e.message.includes('undefined')).eql(true);
     }
   });
 
@@ -889,7 +889,7 @@ describe('distributed bindings', () => {
       assert.fail('Should throw an error');
     } catch (e) {
       should(e).instanceOf(Error);
-      should(e.message).eql('Cannot read property \'ws\' of undefined');
+      should(e.message.startsWith('Cannot read') && e.message.includes('\'ws\'') && e.message.includes('undefined')).eql(true);
     }
   });
 

package/test/lib/hci-socket/gap.test.js

@@ -1086,4 +1086,43 @@ describe('hci-socket gap', () => {
       assert.notCalled(discoverCallback);
     });
   });
+
+  it('should reset the service data on non scan responses', () => {
+    const hci = {
+      on: sinon.spy()
+    };
+
+    const status = 'status';
+    const address = 'a:d:d:r:e:s:s';
+    const addressType = 'addressType';
+    const rssi = 'rssi';
+
+    const eirType = 0x21;
+    const serviceUuid = Buffer.from([0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0a, 0x0b, 0x0c, 0x0d, 0x0e, 0x0f]);
+    const serviceData = Buffer.from([0x05, 0x06]);
+    const eirLength = serviceUuid.length + serviceData.length + 1;
+    const eirLengthAndType = Buffer.from([eirLength, eirType]);
+    const eir = Buffer.concat([eirLengthAndType, serviceUuid, serviceData]);
+
+    const discoverCallback = sinon.spy();
+
+    const gap = new Gap(hci);
+    gap.on('discover', discoverCallback);
+    gap.onHciLeAdvertisingReport(status, 0x04, address, addressType, eir, rssi);
+
+    const expectedServiceData = [
+      {
+        uuid: '0f0e0d0c0b0a09080706050403020100',
+        data: serviceData
+      }
+    ];
+
+    should(gap._discoveries[address].advertisement.serviceData).deepEqual(expectedServiceData);
+
+    gap.onHciLeAdvertisingReport(status, 0x01, address, addressType, eir, rssi);
+
+    should(gap._discoveries[address].advertisement.serviceData).deepEqual(expectedServiceData);
+
+    assert.calledOnce(discoverCallback);
+  });
 });