@stonyx/orm 0.3.2-beta.30 → 0.3.2-beta.301
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +328 -22
- package/config/{environment.ts → environment.js} +8 -0
- package/dist/column-conversion.d.ts +34 -0
- package/dist/column-conversion.js +34 -0
- package/dist/commands.js +34 -0
- package/dist/dynamodb/connection.d.ts +31 -0
- package/dist/dynamodb/connection.js +28 -0
- package/dist/dynamodb/dynamodb-db.d.ts +142 -0
- package/dist/dynamodb/dynamodb-db.js +596 -0
- package/dist/dynamodb/operation-builder.d.ts +76 -0
- package/dist/dynamodb/operation-builder.js +116 -0
- package/dist/dynamodb/type-map.d.ts +31 -0
- package/dist/dynamodb/type-map.js +48 -0
- package/dist/index.d.ts +2 -0
- package/dist/index.js +1 -0
- package/dist/main.js +29 -1
- package/dist/manage-record.js +34 -3
- package/dist/mysql/connection.d.ts +1 -0
- package/dist/mysql/mysql-db.d.ts +8 -0
- package/dist/mysql/mysql-db.js +44 -10
- package/dist/normalize-record-id.d.ts +67 -0
- package/dist/normalize-record-id.js +88 -0
- package/dist/orm-request.d.ts +17 -1
- package/dist/orm-request.js +77 -19
- package/dist/postgres/column-rules.d.ts +33 -0
- package/dist/postgres/column-rules.js +34 -0
- package/dist/postgres/connection.d.ts +1 -0
- package/dist/postgres/connection.js +8 -6
- package/dist/postgres/postgres-db.d.ts +12 -0
- package/dist/postgres/postgres-db.js +60 -19
- package/dist/record.js +7 -5
- package/dist/relationships.js +1 -1
- package/dist/serializer.js +38 -2
- package/dist/store.d.ts +13 -1
- package/dist/store.js +65 -6
- package/dist/types/orm-types.d.ts +11 -0
- package/package.json +19 -7
- package/src/column-conversion.ts +53 -0
- package/src/commands.ts +43 -0
- package/src/dynamodb/connection.ts +50 -0
- package/src/dynamodb/dynamodb-db.ts +811 -0
- package/src/dynamodb/operation-builder.ts +202 -0
- package/src/dynamodb/type-map.ts +54 -0
- package/src/index.ts +2 -0
- package/src/main.ts +29 -1
- package/src/manage-record.ts +41 -9
- package/src/mysql/connection.ts +1 -0
- package/src/mysql/mysql-db.ts +44 -12
- package/src/normalize-record-id.ts +88 -0
- package/src/orm-request.ts +109 -18
- package/src/postgres/column-rules.ts +37 -0
- package/src/postgres/connection.ts +10 -6
- package/src/postgres/postgres-db.ts +64 -21
- package/src/record.ts +8 -5
- package/src/relationships.ts +1 -1
- package/src/serializer.ts +39 -2
- package/src/store.ts +68 -6
- package/src/types/orm-types.ts +12 -0
- package/src/types/stonyx.d.ts +7 -1
package/dist/orm-request.js
CHANGED
|
@@ -5,6 +5,7 @@ import { getPluralName } from './plural-registry.js';
|
|
|
5
5
|
import { getBeforeHooks, getAfterHooks } from './hooks.js';
|
|
6
6
|
import config from 'stonyx/config';
|
|
7
7
|
import { isOrmRecord } from './utils.js';
|
|
8
|
+
import normalizeRecordId from './normalize-record-id.js';
|
|
8
9
|
const methodAccessMap = {
|
|
9
10
|
GET: 'read',
|
|
10
11
|
POST: 'create',
|
|
@@ -42,19 +43,46 @@ function getModelRelationships(modelName) {
|
|
|
42
43
|
}
|
|
43
44
|
return relationships;
|
|
44
45
|
}
|
|
45
|
-
|
|
46
|
-
|
|
46
|
+
/**
|
|
47
|
+
* Build the absolute base URL that every advertised link hangs off — origin
|
|
48
|
+
* plus the prefix the ORM's routes are actually mounted at.
|
|
49
|
+
*
|
|
50
|
+
* The prefix is derived from the *request*, not from
|
|
51
|
+
* `config.orm.restServer.route`. Express sets `request.baseUrl` to the real
|
|
52
|
+
* mountpath registered by `RestServer.mountRoute`, which for this module is
|
|
53
|
+
* always `<prefix>/<pluralizedModel>` (see setup-rest-server.ts). Stripping the
|
|
54
|
+
* trailing model segment therefore yields the prefix by construction, and the
|
|
55
|
+
* link builder cannot drift from the mount registrar the way a second,
|
|
56
|
+
* independent normalisation of `route` would.
|
|
57
|
+
*
|
|
58
|
+
* When `request.baseUrl` is absent or does not end in the model segment the
|
|
59
|
+
* prefix is empty, which reproduces the previous origin-only behaviour.
|
|
60
|
+
*/
|
|
61
|
+
function getBaseUrl(request, pluralizedModel) {
|
|
47
62
|
const protocol = request.protocol || 'http';
|
|
48
63
|
const host = request.get('host');
|
|
49
|
-
|
|
64
|
+
const modelSegment = `/${pluralizedModel}`;
|
|
65
|
+
const mountPath = request.baseUrl ?? '';
|
|
66
|
+
const prefix = mountPath.endsWith(modelSegment) ? mountPath.slice(0, -modelSegment.length) : '';
|
|
67
|
+
return `${protocol}://${host}${prefix}`;
|
|
50
68
|
}
|
|
69
|
+
// Kept as a name because twelve `getId(...)` call sites read it. It is now a
|
|
70
|
+
// thin delegate: there is exactly ONE normalisation of a URL id in the repo,
|
|
71
|
+
// and it is the exported one a consumer can import.
|
|
72
|
+
//
|
|
73
|
+
// "of a URL id" is the load-bearing qualifier, and it is the same one
|
|
74
|
+
// src/normalize-record-id.ts:18 carries. Three copies of the coercion survive
|
|
75
|
+
// at this head — src/orm-request.ts (the create-response path),
|
|
76
|
+
// src/postgres/postgres-db.ts and src/mysql/mysql-db.ts — but each normalises a
|
|
77
|
+
// RESPONSE id (`response?.data?.id`), not a URL id, and each omits this
|
|
78
|
+
// function's `if (!id) return ''` guard. They are tracked as
|
|
79
|
+
// abofs/stonyx-orm#282 and enumerated by name in AC-5's allowlist
|
|
80
|
+
// (test/integration/readme-sample-test.ts).
|
|
81
|
+
//
|
|
82
|
+
// A second implementation of the URL-id normalisation here is the defect
|
|
83
|
+
// abofs/stonyx-orm#270 exists to remove — see src/normalize-record-id.ts.
|
|
51
84
|
function getId(params) {
|
|
52
|
-
|
|
53
|
-
if (!id)
|
|
54
|
-
return '';
|
|
55
|
-
if (isNaN(id))
|
|
56
|
-
return id;
|
|
57
|
-
return parseInt(id);
|
|
85
|
+
return normalizeRecordId(params.id);
|
|
58
86
|
}
|
|
59
87
|
function buildResponse(data, includeParam, recordOrRecords, options = {}) {
|
|
60
88
|
const { links, baseUrl } = options;
|
|
@@ -209,7 +237,7 @@ export default class OrmRequest extends Request {
|
|
|
209
237
|
recordsToReturn = recordsToReturn.filter(accessFilter);
|
|
210
238
|
if (queryFilterPredicate)
|
|
211
239
|
recordsToReturn = recordsToReturn.filter(queryFilterPredicate);
|
|
212
|
-
const baseUrl = getBaseUrl(request);
|
|
240
|
+
const baseUrl = getBaseUrl(request, pluralizedModel);
|
|
213
241
|
const data = recordsToReturn.map(record => record.toJSON?.({ fields: modelFields, baseUrl }));
|
|
214
242
|
return buildResponse(data, request.query?.include, recordsToReturn, {
|
|
215
243
|
links: { self: `${baseUrl}/${pluralizedModel}` },
|
|
@@ -222,7 +250,7 @@ export default class OrmRequest extends Request {
|
|
|
222
250
|
return 404;
|
|
223
251
|
const fieldsMap = parseFields(request.query);
|
|
224
252
|
const modelFields = fieldsMap.get(pluralizedModel) || fieldsMap.get(model);
|
|
225
|
-
const baseUrl = getBaseUrl(request);
|
|
253
|
+
const baseUrl = getBaseUrl(request, pluralizedModel);
|
|
226
254
|
return buildResponse(record.toJSON?.({ fields: modelFields, baseUrl }), request.query?.include, record, {
|
|
227
255
|
links: { self: `${baseUrl}/${pluralizedModel}/${request.params.id}` },
|
|
228
256
|
baseUrl
|
|
@@ -289,7 +317,7 @@ export default class OrmRequest extends Request {
|
|
|
289
317
|
return { data: record.toJSON?.() };
|
|
290
318
|
};
|
|
291
319
|
const deleteHandler = ({ params }) => {
|
|
292
|
-
store.remove(model, getId(params));
|
|
320
|
+
store.remove(model, getId(params), { _skipAutoPersist: true });
|
|
293
321
|
return 204;
|
|
294
322
|
};
|
|
295
323
|
// Wrap handlers with hooks
|
|
@@ -348,9 +376,13 @@ export default class OrmRequest extends Request {
|
|
|
348
376
|
}
|
|
349
377
|
// Execute main handler
|
|
350
378
|
const response = await handler(request, state);
|
|
351
|
-
//
|
|
379
|
+
// Set context.record for update BEFORE persist so SQL drivers can read it
|
|
380
|
+
if (operation === 'update' && response?.data) {
|
|
381
|
+
context.record = store.get(this.model, getId(request.params));
|
|
382
|
+
}
|
|
383
|
+
// Persist to SQL database for all write operations (create/update/delete)
|
|
352
384
|
const sqlDb = Orm.instance.sqlDb;
|
|
353
|
-
if (sqlDb && (operation
|
|
385
|
+
if (sqlDb && WRITE_OPERATIONS.has(operation)) {
|
|
354
386
|
await sqlDb.persist(operation, this.model, context, response);
|
|
355
387
|
}
|
|
356
388
|
// Add response and relevant records to context
|
|
@@ -367,9 +399,6 @@ export default class OrmRequest extends Request {
|
|
|
367
399
|
const recordId = isNaN(responseData.id) ? responseData.id : parseInt(responseData.id);
|
|
368
400
|
context.record = store.get(this.model, recordId);
|
|
369
401
|
}
|
|
370
|
-
else if (operation === 'update' && response?.data) {
|
|
371
|
-
context.record = store.get(this.model, getId(request.params));
|
|
372
|
-
}
|
|
373
402
|
else if (operation === 'delete') {
|
|
374
403
|
// For delete, the record may no longer exist, but we have oldState
|
|
375
404
|
context.recordId = getId(request.params);
|
|
@@ -396,7 +425,7 @@ export default class OrmRequest extends Request {
|
|
|
396
425
|
if (!record)
|
|
397
426
|
return 404;
|
|
398
427
|
const relatedData = record.__relationships[relationshipName];
|
|
399
|
-
const baseUrl = getBaseUrl(request);
|
|
428
|
+
const baseUrl = getBaseUrl(request, pluralizedModel);
|
|
400
429
|
let data;
|
|
401
430
|
if (info.isArray) {
|
|
402
431
|
// hasMany - return array
|
|
@@ -418,7 +447,7 @@ export default class OrmRequest extends Request {
|
|
|
418
447
|
if (!record)
|
|
419
448
|
return 404;
|
|
420
449
|
const relatedData = record.__relationships[relationshipName];
|
|
421
|
-
const baseUrl = getBaseUrl(request);
|
|
450
|
+
const baseUrl = getBaseUrl(request, pluralizedModel);
|
|
422
451
|
let data;
|
|
423
452
|
if (info.isArray) {
|
|
424
453
|
// hasMany - return array of linkage objects
|
|
@@ -463,6 +492,35 @@ export default class OrmRequest extends Request {
|
|
|
463
492
|
return routes;
|
|
464
493
|
}
|
|
465
494
|
auth(request, state) {
|
|
495
|
+
// abofs/stonyx-orm#270 — hand the predicate the value the record is
|
|
496
|
+
// ACTUALLY resolved by, rather than the raw text it was parsed from.
|
|
497
|
+
//
|
|
498
|
+
// This is the default path precisely because it requires the consumer to
|
|
499
|
+
// remember nothing. Exporting `normalizeRecordId` alone would leave the
|
|
500
|
+
// framework owning resolution while asking every consumer to call one
|
|
501
|
+
// function, with no signal when they forget — the same silent fail-open,
|
|
502
|
+
// one step over. The export is the escape hatch for hooks and custom
|
|
503
|
+
// handlers; this line is the contract.
|
|
504
|
+
//
|
|
505
|
+
// `request.params` is deliberately NOT mutated. Twelve `getId(...)` call
|
|
506
|
+
// sites read it, and `_withHooks` assigns `params: request.params` onto the
|
|
507
|
+
// hook context, so every consumer hook reads the same object. Changing
|
|
508
|
+
// `params.id` from string to number underneath them is a silent behaviour
|
|
509
|
+
// change on paths this issue is not about.
|
|
510
|
+
//
|
|
511
|
+
// Synchronous by necessity: @stonyx/rest-server calls auth() without
|
|
512
|
+
// awaiting it.
|
|
513
|
+
//
|
|
514
|
+
// The `undefined` branch is a PRESENCE check, not a second normalisation:
|
|
515
|
+
// it answers "does this route carry an :id at all", which is how both
|
|
516
|
+
// documented samples tell a collection request from a record request. It
|
|
517
|
+
// cannot be folded into normalizeRecordId, because that function must keep
|
|
518
|
+
// returning '' for a falsy id — `store.get(key, undefined)` returns the
|
|
519
|
+
// whole model Map rather than a record (abofs/stonyx-orm#167, pinned by
|
|
520
|
+
// test/unit/store-get-falsy-id-test.ts), so the resolution path depends on
|
|
521
|
+
// the '' it returns today.
|
|
522
|
+
const rawId = request.params?.id;
|
|
523
|
+
request.recordId = rawId === undefined ? undefined : normalizeRecordId(rawId);
|
|
466
524
|
const access = this.access(request);
|
|
467
525
|
if (!access)
|
|
468
526
|
return 403;
|
|
@@ -0,0 +1,33 @@
|
|
|
1
|
+
import type { ColumnRule } from '../column-conversion.js';
|
|
2
|
+
/**
|
|
3
|
+
* PostgreSQL's write-path conversion rule (#292).
|
|
4
|
+
*
|
|
5
|
+
* JSONB columns must receive a JSON *string*. node-pg's `prepareValue`
|
|
6
|
+
* (`pg/lib/utils.js`) checks `Array.isArray` before its object fallback, so a
|
|
7
|
+
* raw array is rendered as a Postgres array literal (`{"1","2","3"}`) rather
|
|
8
|
+
* than JSON. `[]` becomes `{}`, which is valid JSON, so it lands silently
|
|
9
|
+
* corrupted with no error.
|
|
10
|
+
*
|
|
11
|
+
* Two behaviours this rule must keep:
|
|
12
|
+
*
|
|
13
|
+
* - `typeof value === 'string'` passes through untouched. A JSONB column
|
|
14
|
+
* already holding a JSON string (`'{"a":1}'`) must store the object it
|
|
15
|
+
* describes; an unconditional `JSON.stringify` would double-encode it.
|
|
16
|
+
* - An `undefined` column type is a no-op. `updated_at`, `id` and FK columns
|
|
17
|
+
* are added outside the attribute loop and are absent from
|
|
18
|
+
* `schema.columns`.
|
|
19
|
+
*
|
|
20
|
+
* The `'JSONB'` sentinel is the exact literal emitted by
|
|
21
|
+
* `src/postgres/type-map.ts`, the only module that produces the values in
|
|
22
|
+
* `schema.columns`. The two producing functions are `getPgType` and
|
|
23
|
+
* `getVectorType` (`src/postgres/schema-introspector.ts` writes `columns[key]`
|
|
24
|
+
* at exactly three sites, all routed through those two); `mysqlTypeToPg` is not
|
|
25
|
+
* exported and is reachable only from inside `getPgType`.
|
|
26
|
+
*
|
|
27
|
+
* One documented gap: `getPgType` returns a consumer transform's declared
|
|
28
|
+
* `pgType` verbatim, so a consumer writing `pgType: 'jsonb'` puts a value in
|
|
29
|
+
* `schema.columns` that type-map never authored and this exact-match sentinel
|
|
30
|
+
* misses. It misses identically on the create path, pre-fix and post-fix --
|
|
31
|
+
* pre-existing and symmetric, not introduced here.
|
|
32
|
+
*/
|
|
33
|
+
export declare const postgresJsonRule: ColumnRule;
|
|
@@ -0,0 +1,34 @@
|
|
|
1
|
+
/**
|
|
2
|
+
* PostgreSQL's write-path conversion rule (#292).
|
|
3
|
+
*
|
|
4
|
+
* JSONB columns must receive a JSON *string*. node-pg's `prepareValue`
|
|
5
|
+
* (`pg/lib/utils.js`) checks `Array.isArray` before its object fallback, so a
|
|
6
|
+
* raw array is rendered as a Postgres array literal (`{"1","2","3"}`) rather
|
|
7
|
+
* than JSON. `[]` becomes `{}`, which is valid JSON, so it lands silently
|
|
8
|
+
* corrupted with no error.
|
|
9
|
+
*
|
|
10
|
+
* Two behaviours this rule must keep:
|
|
11
|
+
*
|
|
12
|
+
* - `typeof value === 'string'` passes through untouched. A JSONB column
|
|
13
|
+
* already holding a JSON string (`'{"a":1}'`) must store the object it
|
|
14
|
+
* describes; an unconditional `JSON.stringify` would double-encode it.
|
|
15
|
+
* - An `undefined` column type is a no-op. `updated_at`, `id` and FK columns
|
|
16
|
+
* are added outside the attribute loop and are absent from
|
|
17
|
+
* `schema.columns`.
|
|
18
|
+
*
|
|
19
|
+
* The `'JSONB'` sentinel is the exact literal emitted by
|
|
20
|
+
* `src/postgres/type-map.ts`, the only module that produces the values in
|
|
21
|
+
* `schema.columns`. The two producing functions are `getPgType` and
|
|
22
|
+
* `getVectorType` (`src/postgres/schema-introspector.ts` writes `columns[key]`
|
|
23
|
+
* at exactly three sites, all routed through those two); `mysqlTypeToPg` is not
|
|
24
|
+
* exported and is reachable only from inside `getPgType`.
|
|
25
|
+
*
|
|
26
|
+
* One documented gap: `getPgType` returns a consumer transform's declared
|
|
27
|
+
* `pgType` verbatim, so a consumer writing `pgType: 'jsonb'` puts a value in
|
|
28
|
+
* `schema.columns` that type-map never authored and this exact-match sentinel
|
|
29
|
+
* misses. It misses identically on the create path, pre-fix and post-fix --
|
|
30
|
+
* pre-existing and symmetric, not introduced here.
|
|
31
|
+
*/
|
|
32
|
+
export const postgresJsonRule = (value, columnType) => columnType === 'JSONB' && typeof value !== 'string'
|
|
33
|
+
? JSON.stringify(value)
|
|
34
|
+
: value;
|
|
@@ -7,15 +7,17 @@ export async function getPool(pgConfig, extensions = ['vector']) {
|
|
|
7
7
|
if (pool)
|
|
8
8
|
return pool;
|
|
9
9
|
const { default: pg } = await import('pg');
|
|
10
|
+
const { host, port, user, password, database, connectionLimit, migrationsDir, migrationsTable, autoMigrate, ...poolOpts } = pgConfig;
|
|
10
11
|
pool = new pg.Pool({
|
|
11
|
-
host
|
|
12
|
-
port
|
|
13
|
-
user
|
|
14
|
-
password
|
|
15
|
-
database
|
|
16
|
-
max:
|
|
12
|
+
host,
|
|
13
|
+
port,
|
|
14
|
+
user,
|
|
15
|
+
password,
|
|
16
|
+
database,
|
|
17
|
+
max: connectionLimit,
|
|
17
18
|
idleTimeoutMillis: 30000,
|
|
18
19
|
connectionTimeoutMillis: 10000,
|
|
20
|
+
...poolOpts,
|
|
19
21
|
});
|
|
20
22
|
// Enable requested PostgreSQL extensions
|
|
21
23
|
for (const ext of extensions) {
|
|
@@ -8,6 +8,8 @@ import { createRecord } from '../manage-record.js';
|
|
|
8
8
|
import { confirm } from '@stonyx/utils/prompt';
|
|
9
9
|
import { readFile } from '@stonyx/utils/file';
|
|
10
10
|
import { getPluralName } from '../plural-registry.js';
|
|
11
|
+
import { convertRow } from '../column-conversion.js';
|
|
12
|
+
import { postgresJsonRule } from './column-rules.js';
|
|
11
13
|
import config from 'stonyx/config';
|
|
12
14
|
import log from 'stonyx/log';
|
|
13
15
|
import path from 'path';
|
|
@@ -57,6 +59,8 @@ interface PostgresDeps {
|
|
|
57
59
|
confirm: typeof confirm;
|
|
58
60
|
readFile: typeof readFile;
|
|
59
61
|
getPluralName: typeof getPluralName;
|
|
62
|
+
convertRow: typeof convertRow;
|
|
63
|
+
postgresJsonRule: typeof postgresJsonRule;
|
|
60
64
|
config: typeof config;
|
|
61
65
|
log: typeof log;
|
|
62
66
|
path: typeof path;
|
|
@@ -72,6 +76,14 @@ export default class PostgresDB {
|
|
|
72
76
|
deps: PostgresDeps;
|
|
73
77
|
pool: Pool | null;
|
|
74
78
|
pgConfig: Record<string, unknown>;
|
|
79
|
+
/**
|
|
80
|
+
* Promise-chain mutex for write serialization (#156).
|
|
81
|
+
* All persist() calls chain through this single queue so concurrent
|
|
82
|
+
* fire-and-forget writes never produce parallel transactions
|
|
83
|
+
* on FK-linked rows (which cause deadlocks).
|
|
84
|
+
* Reads are NOT affected — only persist() serializes.
|
|
85
|
+
*/
|
|
86
|
+
private _writeQueue;
|
|
75
87
|
constructor(deps?: Partial<PostgresDeps>);
|
|
76
88
|
protected requirePool(): Pool;
|
|
77
89
|
init(): Promise<void>;
|
|
@@ -8,6 +8,8 @@ import { createRecord } from '../manage-record.js';
|
|
|
8
8
|
import { confirm } from '@stonyx/utils/prompt';
|
|
9
9
|
import { readFile } from '@stonyx/utils/file';
|
|
10
10
|
import { getPluralName } from '../plural-registry.js';
|
|
11
|
+
import { convertRow } from '../column-conversion.js';
|
|
12
|
+
import { postgresJsonRule } from './column-rules.js';
|
|
11
13
|
import { isDbError } from '../utils.js';
|
|
12
14
|
import config from 'stonyx/config';
|
|
13
15
|
import log from 'stonyx/log';
|
|
@@ -18,7 +20,8 @@ const defaultDeps = {
|
|
|
18
20
|
introspectModels, introspectViews, getTopologicalOrder, schemasToSnapshot,
|
|
19
21
|
loadLatestSnapshot, detectSchemaDrift,
|
|
20
22
|
buildInsert, buildUpdate, buildDelete, buildSelect, buildVectorSearch, buildHybridSearch,
|
|
21
|
-
createRecord, store, confirm, readFile, getPluralName, config, log, path
|
|
23
|
+
createRecord, store, confirm, readFile, getPluralName, config, log, path,
|
|
24
|
+
convertRow, postgresJsonRule
|
|
22
25
|
};
|
|
23
26
|
export default class PostgresDB {
|
|
24
27
|
/** PostgreSQL extensions to enable on pool init. Subclasses can override. */
|
|
@@ -30,6 +33,14 @@ export default class PostgresDB {
|
|
|
30
33
|
deps;
|
|
31
34
|
pool;
|
|
32
35
|
pgConfig;
|
|
36
|
+
/**
|
|
37
|
+
* Promise-chain mutex for write serialization (#156).
|
|
38
|
+
* All persist() calls chain through this single queue so concurrent
|
|
39
|
+
* fire-and-forget writes never produce parallel transactions
|
|
40
|
+
* on FK-linked rows (which cause deadlocks).
|
|
41
|
+
* Reads are NOT affected — only persist() serializes.
|
|
42
|
+
*/
|
|
43
|
+
_writeQueue = Promise.resolve();
|
|
33
44
|
constructor(deps = {}) {
|
|
34
45
|
const Ctor = this.constructor;
|
|
35
46
|
if (Ctor.instance)
|
|
@@ -57,7 +68,17 @@ export default class PostgresDB {
|
|
|
57
68
|
const pending = files.filter(f => !applied.includes(f));
|
|
58
69
|
if (pending.length > 0) {
|
|
59
70
|
this.deps.log.db?.(`${pending.length} pending migration(s) found.`);
|
|
60
|
-
|
|
71
|
+
let shouldApply;
|
|
72
|
+
if (this.pgConfig.autoMigrate === true) {
|
|
73
|
+
shouldApply = true;
|
|
74
|
+
}
|
|
75
|
+
else if (this.pgConfig.autoMigrate === false) {
|
|
76
|
+
shouldApply = false;
|
|
77
|
+
this.deps.log.warn?.(`autoMigrate is false — skipping ${pending.length} pending migration(s).`);
|
|
78
|
+
}
|
|
79
|
+
else {
|
|
80
|
+
shouldApply = await this.deps.confirm(`${pending.length} pending migration(s) found. Apply now?`);
|
|
81
|
+
}
|
|
61
82
|
if (shouldApply) {
|
|
62
83
|
for (const filename of pending) {
|
|
63
84
|
const content = await this.deps.readFile(this.deps.path.join(migrationsPath, filename));
|
|
@@ -76,7 +97,17 @@ export default class PostgresDB {
|
|
|
76
97
|
const schemas = this.deps.introspectModels();
|
|
77
98
|
const modelCount = Object.keys(schemas).length;
|
|
78
99
|
if (modelCount > 0) {
|
|
79
|
-
|
|
100
|
+
let shouldGenerate;
|
|
101
|
+
if (this.pgConfig.autoMigrate === true) {
|
|
102
|
+
shouldGenerate = true;
|
|
103
|
+
}
|
|
104
|
+
else if (this.pgConfig.autoMigrate === false) {
|
|
105
|
+
shouldGenerate = false;
|
|
106
|
+
this.deps.log.warn?.(`autoMigrate is false — skipping initial migration generation for ${modelCount} model(s).`);
|
|
107
|
+
}
|
|
108
|
+
else {
|
|
109
|
+
shouldGenerate = await this.deps.confirm(`No migrations found but ${modelCount} model(s) detected. Generate and apply initial migration?`);
|
|
110
|
+
}
|
|
80
111
|
if (shouldGenerate) {
|
|
81
112
|
const { generateMigration } = await import('./migration-generator.js');
|
|
82
113
|
const result = await generateMigration('initial_setup');
|
|
@@ -356,14 +387,20 @@ export default class PostgresDB {
|
|
|
356
387
|
const Orm = (await import('@stonyx/orm')).default;
|
|
357
388
|
if (Orm.instance?.isView?.(modelName))
|
|
358
389
|
return;
|
|
359
|
-
|
|
360
|
-
|
|
361
|
-
|
|
362
|
-
|
|
363
|
-
|
|
364
|
-
|
|
365
|
-
|
|
366
|
-
|
|
390
|
+
const work = async () => {
|
|
391
|
+
switch (operation) {
|
|
392
|
+
case 'create':
|
|
393
|
+
return this._persistCreate(modelName, context, response);
|
|
394
|
+
case 'update':
|
|
395
|
+
return this._persistUpdate(modelName, context, response);
|
|
396
|
+
case 'delete':
|
|
397
|
+
return this._persistDelete(modelName, context);
|
|
398
|
+
}
|
|
399
|
+
};
|
|
400
|
+
// Chain through the write queue — .then(work, work) ensures the queue
|
|
401
|
+
// advances even when a previous persist rejects (#156).
|
|
402
|
+
this._writeQueue = this._writeQueue.then(work, work);
|
|
403
|
+
return this._writeQueue;
|
|
367
404
|
}
|
|
368
405
|
async _persistCreate(modelName, context, response) {
|
|
369
406
|
const schemas = this.deps.introspectModels();
|
|
@@ -383,7 +420,9 @@ export default class PostgresDB {
|
|
|
383
420
|
if (isPendingId) {
|
|
384
421
|
delete insertData.id;
|
|
385
422
|
}
|
|
386
|
-
|
|
423
|
+
// Convert the *complete* payload (attributes + id + FKs) in one place (#292).
|
|
424
|
+
const row = this.deps.convertRow(insertData, schema.columns, this.deps.postgresJsonRule);
|
|
425
|
+
const { sql, values } = this.deps.buildInsert(schema.table, row);
|
|
387
426
|
const result = await this.requirePool().query(sql, values);
|
|
388
427
|
// Re-key the record in the store if PostgreSQL generated the ID (via RETURNING)
|
|
389
428
|
if (isPendingId && result.rows.length > 0) {
|
|
@@ -435,7 +474,11 @@ export default class PostgresDB {
|
|
|
435
474
|
return;
|
|
436
475
|
// PostgreSQL doesn't have ON UPDATE CURRENT_TIMESTAMP -- set updated_at manually
|
|
437
476
|
changedData.updated_at = new Date();
|
|
438
|
-
|
|
477
|
+
// Same conversion, same choke point as the create path (#292). Columns
|
|
478
|
+
// appended after the attribute loop (FKs, updated_at) are absent from
|
|
479
|
+
// schema.columns and pass through untouched.
|
|
480
|
+
const row = this.deps.convertRow(changedData, schema.columns, this.deps.postgresJsonRule);
|
|
481
|
+
const { sql, values } = this.deps.buildUpdate(schema.table, id, row);
|
|
439
482
|
await this.requirePool().query(sql, values);
|
|
440
483
|
}
|
|
441
484
|
async _persistDelete(modelName, context) {
|
|
@@ -456,13 +499,11 @@ export default class PostgresDB {
|
|
|
456
499
|
if (data.id !== undefined) {
|
|
457
500
|
row.id = data.id;
|
|
458
501
|
}
|
|
459
|
-
// Attribute columns
|
|
460
|
-
|
|
502
|
+
// Attribute columns. Type conversion is NOT applied here -- it is applied
|
|
503
|
+
// once to the finished payload by the caller, via convertRow (#292).
|
|
504
|
+
for (const col of Object.keys(schema.columns)) {
|
|
461
505
|
if (data[col] !== undefined) {
|
|
462
|
-
|
|
463
|
-
row[col] = pgType === 'JSONB' && typeof data[col] !== 'string'
|
|
464
|
-
? JSON.stringify(data[col])
|
|
465
|
-
: data[col];
|
|
506
|
+
row[col] = data[col];
|
|
466
507
|
}
|
|
467
508
|
}
|
|
468
509
|
// FK columns from relationships
|
package/dist/record.js
CHANGED
|
@@ -40,11 +40,13 @@ export default class Record {
|
|
|
40
40
|
const records = {};
|
|
41
41
|
for (const [key, childRecord] of Object.entries(this.__relationships)) {
|
|
42
42
|
if (Array.isArray(childRecord)) {
|
|
43
|
+
// Filter out cleaned records (those with no __model)
|
|
44
|
+
const live = childRecord.filter((r) => r?.__model);
|
|
43
45
|
// Deduplicate by record ID — keep last occurrence (latest data wins)
|
|
44
46
|
const seen = new Set();
|
|
45
47
|
const unique = [];
|
|
46
|
-
for (let i =
|
|
47
|
-
const r =
|
|
48
|
+
for (let i = live.length - 1; i >= 0; i--) {
|
|
49
|
+
const r = live[i];
|
|
48
50
|
if (!seen.has(r.id)) {
|
|
49
51
|
seen.add(r.id);
|
|
50
52
|
unique.push(r);
|
|
@@ -54,7 +56,7 @@ export default class Record {
|
|
|
54
56
|
records[key] = unique.map((r) => r.serialize());
|
|
55
57
|
}
|
|
56
58
|
else {
|
|
57
|
-
records[key] = childRecord?.serialize()
|
|
59
|
+
records[key] = childRecord?.__model ? childRecord.serialize() : null;
|
|
58
60
|
}
|
|
59
61
|
}
|
|
60
62
|
return { ...data, ...records };
|
|
@@ -86,8 +88,8 @@ export default class Record {
|
|
|
86
88
|
if (fields && !fields.has(key))
|
|
87
89
|
continue;
|
|
88
90
|
const relationshipData = Array.isArray(childRecord)
|
|
89
|
-
? childRecord.map((r) => ({ type: r.__model.__name, id: r.id }))
|
|
90
|
-
: childRecord ? { type: childRecord.__model.__name, id: childRecord.id } : null;
|
|
91
|
+
? childRecord.filter((r) => r?.__model).map((r) => ({ type: r.__model.__name, id: r.id }))
|
|
92
|
+
: (childRecord && childRecord.__model) ? { type: childRecord.__model.__name, id: childRecord.id } : null;
|
|
91
93
|
// Dasherize the key for URL paths (e.g., accessLinks -> access-links)
|
|
92
94
|
const dasherizedKey = camelCaseToKebabCase(key);
|
|
93
95
|
relationships[dasherizedKey] = { data: relationshipData };
|
package/dist/relationships.js
CHANGED
|
@@ -38,4 +38,4 @@ export function getPendingRegistry() {
|
|
|
38
38
|
export function getPendingBelongsToRegistry() {
|
|
39
39
|
return relationships.get('pendingBelongsTo');
|
|
40
40
|
}
|
|
41
|
-
export const TYPES = ['global', 'hasMany', 'belongsTo', 'pending'];
|
|
41
|
+
export const TYPES = ['global', 'hasMany', 'belongsTo', 'pending', 'pendingBelongsTo'];
|
package/dist/serializer.js
CHANGED
|
@@ -79,8 +79,44 @@ export default class Serializer {
|
|
|
79
79
|
// Pass relationship key name to handler for pending fulfillment
|
|
80
80
|
const handlerOptions = { ...options, _relationshipKey: key };
|
|
81
81
|
const childRecord = handler(record, data, handlerOptions);
|
|
82
|
-
|
|
83
|
-
|
|
82
|
+
// hasMany relationships use a getter so format()/toJSON() always read
|
|
83
|
+
// the live registry array instead of a stale snapshot captured at
|
|
84
|
+
// serialization time. This is critical when child records are created
|
|
85
|
+
// in a later async frame — the belongsTo inverse wiring pushes into
|
|
86
|
+
// the shared registry array, and the getter ensures the parent sees it.
|
|
87
|
+
const isHasMany = handler.__relationshipType === 'hasMany';
|
|
88
|
+
if (isHasMany) {
|
|
89
|
+
// `childRecord` IS the shared registry array — define a getter that
|
|
90
|
+
// always dereferences through the same array reference.
|
|
91
|
+
const registryArray = childRecord;
|
|
92
|
+
Object.defineProperty(rec, key, {
|
|
93
|
+
enumerable: true,
|
|
94
|
+
configurable: true,
|
|
95
|
+
get: () => registryArray,
|
|
96
|
+
set(v) { relatedRecords[key] = v; }
|
|
97
|
+
});
|
|
98
|
+
Object.defineProperty(relatedRecords, key, {
|
|
99
|
+
enumerable: true,
|
|
100
|
+
configurable: true,
|
|
101
|
+
get: () => registryArray,
|
|
102
|
+
set(v) { Object.defineProperty(relatedRecords, key, { value: v, writable: true, enumerable: true, configurable: true }); }
|
|
103
|
+
});
|
|
104
|
+
}
|
|
105
|
+
else {
|
|
106
|
+
rec[key] = childRecord;
|
|
107
|
+
relatedRecords[key] = childRecord;
|
|
108
|
+
// Preserve the raw FK value in __data when the belongsTo handler
|
|
109
|
+
// couldn't resolve the target (e.g., memory:false model not loaded).
|
|
110
|
+
// This allows adapters to read the FK from __data as a fallback
|
|
111
|
+
// when __relationships[key] is null. Only store when `data` is a
|
|
112
|
+
// truthy non-object — i.e., a raw FK string/number that the handler
|
|
113
|
+
// attempted but failed to resolve. When `data` is null/undefined
|
|
114
|
+
// (optional empty relationship) we intentionally skip to preserve
|
|
115
|
+
// the existing behavior of not populating __data for empty FKs.
|
|
116
|
+
if (childRecord === null && data && typeof data !== 'object') {
|
|
117
|
+
parsedData[key] = data;
|
|
118
|
+
}
|
|
119
|
+
}
|
|
84
120
|
continue;
|
|
85
121
|
}
|
|
86
122
|
// Aggregate property handling — use the rawData value, not the aggregate descriptor
|
package/dist/store.d.ts
CHANGED
|
@@ -45,7 +45,19 @@ export default class Store {
|
|
|
45
45
|
*/
|
|
46
46
|
private _isMemoryModel;
|
|
47
47
|
set(key: string, value: Map<number | string, unknown>): void;
|
|
48
|
-
remove(key: string, id?: number | string
|
|
48
|
+
remove(key: string, id?: number | string, options?: {
|
|
49
|
+
_skipAutoPersist?: boolean;
|
|
50
|
+
}): void;
|
|
51
|
+
/**
|
|
52
|
+
* Evict a record from the store with full relationship registry cleanup.
|
|
53
|
+
* The caller retains its reference to the returned record, which is the
|
|
54
|
+
* contract memory:false post-persist eviction relies on.
|
|
55
|
+
*
|
|
56
|
+
* @param registryId - The ID used when the record's relationships were
|
|
57
|
+
* registered. For SQL models with pending IDs, this is the original
|
|
58
|
+
* negative pending ID (before the adapter re-keyed to the real DB ID).
|
|
59
|
+
*/
|
|
60
|
+
evictRecord(modelName: string, id: unknown, registryId?: unknown): void;
|
|
49
61
|
unloadRecord(model: string, id: unknown, options?: UnloadOptions): void;
|
|
50
62
|
unloadAllRecords(model: string, options?: UnloadOptions): void;
|
|
51
63
|
private _removeFromHasManyArrays;
|